<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[265349] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/265349">265349</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2020-08-06 15:11:04 -0700 (Thu, 06 Aug 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>Drop non-standard createBuffer(ArrayBuffer, boolean) overload from AudioContext
https://bugs.webkit.org/show_bug.cgi?id=215238

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that one more check is passing.

* web-platform-tests/webaudio/idlharness.https.window-expected.txt:

Source/WebCore:

Drop non-standard createBuffer(ArrayBuffer, boolean) overload from AudioContext:
- https://webaudio.github.io/web-audio-api/#BaseAudioContext

This overload is kept on WebKitAudioContext for backward-compatibility when the page
is still using the prefixed API.

No new tests, rebaselined existing test.

* Modules/webaudio/BaseAudioContext.cpp:
* Modules/webaudio/BaseAudioContext.h:
* Modules/webaudio/BaseAudioContext.idl:
* Modules/webaudio/WebKitAudioContext.cpp:
(WebCore::WebKitAudioContext::createLegacyBuffer):
* Modules/webaudio/WebKitAudioContext.h:
* Modules/webaudio/WebKitAudioContext.idl:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestswebaudioidlharnesshttpswindowexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioBaseAudioContextcpp">trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioBaseAudioContexth">trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioBaseAudioContextidl">trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.idl</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioWebKitAudioContextcpp">trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioWebKitAudioContexth">trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioWebKitAudioContextidl">trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.idl</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (265348 => 265349)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-06 21:49:57 UTC (rev 265348)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2020-08-06 22:11:04 UTC (rev 265349)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2020-08-06  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><ins>+        Drop non-standard createBuffer(ArrayBuffer, boolean) overload from AudioContext
+        https://bugs.webkit.org/show_bug.cgi?id=215238
+
+        Reviewed by Darin Adler.
+
+        Rebaseline WPT tests now that one more check is passing.
+
+        * web-platform-tests/webaudio/idlharness.https.window-expected.txt:
+
+2020-08-06  Chris Dumez  <cdumez@apple.com>
+
</ins><span class="cx">         MediaStreamAudioDestinationNode should have a constructor
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=215233
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestswebaudioidlharnesshttpswindowexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt (265348 => 265349)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt  2020-08-06 21:49:57 UTC (rev 265348)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt     2020-08-06 22:11:04 UTC (rev 265349)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx"> PASS BaseAudioContext interface: attribute onstatechange 
</span><span class="cx"> PASS BaseAudioContext interface: operation createAnalyser() 
</span><span class="cx"> PASS BaseAudioContext interface: operation createBiquadFilter() 
</span><del>-FAIL BaseAudioContext interface: operation createBuffer(unsigned long, unsigned long, float) assert_equals: property has wrong .length expected 3 but got 2
</del><ins>+PASS BaseAudioContext interface: operation createBuffer(unsigned long, unsigned long, float) 
</ins><span class="cx"> PASS BaseAudioContext interface: operation createBufferSource() 
</span><span class="cx"> PASS BaseAudioContext interface: operation createChannelMerger(optional unsigned long) 
</span><span class="cx"> PASS BaseAudioContext interface: operation createChannelSplitter(optional unsigned long) 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (265348 => 265349)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-08-06 21:49:57 UTC (rev 265348)
+++ trunk/Source/WebCore/ChangeLog      2020-08-06 22:11:04 UTC (rev 265349)
</span><span class="lines">@@ -1,5 +1,28 @@
</span><span class="cx"> 2020-08-06  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><ins>+        Drop non-standard createBuffer(ArrayBuffer, boolean) overload from AudioContext
+        https://bugs.webkit.org/show_bug.cgi?id=215238
+
+        Reviewed by Darin Adler.
+
+        Drop non-standard createBuffer(ArrayBuffer, boolean) overload from AudioContext:
+        - https://webaudio.github.io/web-audio-api/#BaseAudioContext
+
+        This overload is kept on WebKitAudioContext for backward-compatibility when the page
+        is still using the prefixed API.
+
+        No new tests, rebaselined existing test.
+
+        * Modules/webaudio/BaseAudioContext.cpp:
+        * Modules/webaudio/BaseAudioContext.h:
+        * Modules/webaudio/BaseAudioContext.idl:
+        * Modules/webaudio/WebKitAudioContext.cpp:
+        (WebCore::WebKitAudioContext::createLegacyBuffer):
+        * Modules/webaudio/WebKitAudioContext.h:
+        * Modules/webaudio/WebKitAudioContext.idl:
+
+2020-08-06  Chris Dumez  <cdumez@apple.com>
+
</ins><span class="cx">         MediaStreamAudioDestinationNode should have a constructor
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=215233
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioBaseAudioContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp (265348 => 265349)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp       2020-08-06 21:49:57 UTC (rev 265348)
+++ trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp  2020-08-06 22:11:04 UTC (rev 265349)
</span><span class="lines">@@ -391,14 +391,6 @@
</span><span class="cx">     return AudioBuffer::create(AudioBufferOptions {numberOfChannels, length, sampleRate});
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<AudioBuffer>> BaseAudioContext::createBuffer(ArrayBuffer& arrayBuffer, bool mixToMono)
-{
-    auto audioBuffer = AudioBuffer::createFromAudioFileData(arrayBuffer.data(), arrayBuffer.byteLength(), mixToMono, sampleRate());
-    if (!audioBuffer)
-        return Exception { SyntaxError };
-    return audioBuffer.releaseNonNull();
-}
-
</del><span class="cx"> void BaseAudioContext::decodeAudioData(Ref<ArrayBuffer>&& audioData, RefPtr<AudioBufferCallback>&& successCallback, RefPtr<AudioBufferCallback>&& errorCallback)
</span><span class="cx"> {
</span><span class="cx">     if (!m_audioDecoder)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioBaseAudioContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.h (265348 => 265349)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.h 2020-08-06 21:49:57 UTC (rev 265348)
+++ trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.h    2020-08-06 22:11:04 UTC (rev 265349)
</span><span class="lines">@@ -123,7 +123,6 @@
</span><span class="cx">     void decrementActiveSourceCount();
</span><span class="cx">     
</span><span class="cx">     ExceptionOr<Ref<AudioBuffer>> createBuffer(unsigned numberOfChannels, unsigned length, float sampleRate);
</span><del>-    ExceptionOr<Ref<AudioBuffer>> createBuffer(ArrayBuffer&, bool mixToMono);
</del><span class="cx"> 
</span><span class="cx">     // Asynchronous audio file data decoding.
</span><span class="cx">     void decodeAudioData(Ref<ArrayBuffer>&&, RefPtr<AudioBufferCallback>&&, RefPtr<AudioBufferCallback>&&);
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioBaseAudioContextidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.idl (265348 => 265349)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.idl       2020-08-06 21:49:57 UTC (rev 265348)
+++ trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.idl  2020-08-06 22:11:04 UTC (rev 265349)
</span><span class="lines">@@ -45,7 +45,6 @@
</span><span class="cx">     attribute EventHandler onstatechange;
</span><span class="cx">     
</span><span class="cx">     [MayThrowException] AudioBuffer createBuffer(unsigned long numberOfChannels, unsigned long numberOfFrames, float sampleRate);
</span><del>-    [MayThrowException] AudioBuffer createBuffer(ArrayBuffer buffer, boolean mixToMono);
</del><span class="cx"> 
</span><span class="cx">     // Asynchronous audio file data decoding.
</span><span class="cx">     // FIXME: successCallback should be optional and the callbacks should not be nullable. This should also return a Promise.
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioWebKitAudioContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.cpp (265348 => 265349)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.cpp     2020-08-06 21:49:57 UTC (rev 265348)
+++ trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.cpp        2020-08-06 22:11:04 UTC (rev 265349)
</span><span class="lines">@@ -199,6 +199,14 @@
</span><span class="cx">     return WebKitDynamicsCompressorNode::create(*this);
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+ExceptionOr<Ref<AudioBuffer>> WebKitAudioContext::createLegacyBuffer(ArrayBuffer& arrayBuffer, bool mixToMono)
+{
+    auto audioBuffer = AudioBuffer::createFromAudioFileData(arrayBuffer.data(), arrayBuffer.byteLength(), mixToMono, sampleRate());
+    if (!audioBuffer)
+        return Exception { SyntaxError };
+    return audioBuffer.releaseNonNull();
+}
+
</ins><span class="cx"> void WebKitAudioContext::close(DOMPromiseDeferred<void>&& promise)
</span><span class="cx"> {
</span><span class="cx">     if (isOfflineContext() || isStopped()) {
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioWebKitAudioContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.h (265348 => 265349)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.h       2020-08-06 21:49:57 UTC (rev 265348)
+++ trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.h  2020-08-06 22:11:04 UTC (rev 265349)
</span><span class="lines">@@ -71,6 +71,7 @@
</span><span class="cx">     ExceptionOr<Ref<PeriodicWave>> createPeriodicWave(Float32Array& real, Float32Array& imaginary);
</span><span class="cx">     ExceptionOr<Ref<WebKitAudioBufferSourceNode>> createWebKitBufferSource();
</span><span class="cx">     ExceptionOr<Ref<WebKitDynamicsCompressorNode>> createWebKitDynamicsCompressor();
</span><ins>+    ExceptionOr<Ref<AudioBuffer>> createLegacyBuffer(ArrayBuffer&, bool mixToMono);
</ins><span class="cx"> 
</span><span class="cx"> protected:
</span><span class="cx">     explicit WebKitAudioContext(Document&);
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioWebKitAudioContextidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.idl (265348 => 265349)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.idl     2020-08-06 21:49:57 UTC (rev 265348)
+++ trunk/Source/WebCore/Modules/webaudio/WebKitAudioContext.idl        2020-08-06 22:11:04 UTC (rev 265349)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx">     readonly attribute unsigned long activeSourceCount;
</span><span class="cx"> 
</span><span class="cx">     [MayThrowException] AudioBuffer createBuffer(unsigned long numberOfChannels, unsigned long numberOfFrames, unrestricted float sampleRate);
</span><del>-    [MayThrowException] AudioBuffer createBuffer(ArrayBuffer buffer, boolean mixToMono);
</del><ins>+    [MayThrowException, ImplementedAs=createLegacyBuffer] AudioBuffer createBuffer(ArrayBuffer buffer, boolean mixToMono);
</ins><span class="cx"> 
</span><span class="cx">     // Asynchronous audio file data decoding.
</span><span class="cx">     // FIXME: successCallback should be optional and the callbacks should not be nullable. This should also return a Promise.
</span></span></pre>
</div>
</div>

</body>
</html>