<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[260706] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/260706">260706</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2020-04-25 10:03:33 -0700 (Sat, 25 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>AX: Improve tracking of Element* pointers in AXObjectCache with WeakHashSet
https://bugs.webkit.org/show_bug.cgi?id=210879

Reviewed by Daniel Bates.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::filterListForRemoval):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
* accessibility/AXObjectCache.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAXObjectCachecpp">trunk/Source/WebCore/accessibility/AXObjectCache.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAXObjectCacheh">trunk/Source/WebCore/accessibility/AXObjectCache.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (260705 => 260706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-04-25 16:08:46 UTC (rev 260705)
+++ trunk/Source/WebCore/ChangeLog      2020-04-25 17:03:33 UTC (rev 260706)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2020-04-25  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Improve tracking of Element* pointers in AXObjectCache with WeakHashSet
+        https://bugs.webkit.org/show_bug.cgi?id=210879
+
+        Reviewed by Daniel Bates.
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::AXObjectCache::remove):
+        (WebCore::AXObjectCache::handleFocusedUIElementChanged):
+        (WebCore::filterListForRemoval):
+        (WebCore::AXObjectCache::performDeferredCacheUpdate):
+        * accessibility/AXObjectCache.h:
+
</ins><span class="cx"> 2020-04-25  Antoine Quint  <graouts@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [Web Animations] KeyframeEffect should ensure its target remains alive
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAXObjectCachecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (260705 => 260706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp     2020-04-25 16:08:46 UTC (rev 260705)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp        2020-04-25 17:03:33 UTC (rev 260706)
</span><span class="lines">@@ -859,8 +859,6 @@
</span><span class="cx"> void AXObjectCache::remove(Node& node)
</span><span class="cx"> {
</span><span class="cx">     if (is<Element>(node)) {
</span><del>-        m_deferredRecomputeIsIgnoredList.remove(downcast<Element>(&node));
-        m_deferredSelectedChildredChangedList.remove(downcast<Element>(&node));
</del><span class="cx">         m_deferredTextFormControlValue.remove(downcast<Element>(&node));
</span><span class="cx">         m_deferredAttributeChange.remove(downcast<Element>(&node));
</span><span class="cx">     }
</span><span class="lines">@@ -2997,9 +2995,7 @@
</span><span class="cx">     HashSet<Node*> nodesToRemove;
</span><span class="cx">     filterListForRemoval(m_textMarkerNodes, document, nodesToRemove);
</span><span class="cx">     filterListForRemoval(m_modalNodesSet, document, nodesToRemove);
</span><del>-    filterListForRemoval(m_deferredRecomputeIsIgnoredList, document, nodesToRemove);
</del><span class="cx">     filterListForRemoval(m_deferredTextChangedList, document, nodesToRemove);
</span><del>-    filterListForRemoval(m_deferredSelectedChildredChangedList, document, nodesToRemove);
</del><span class="cx">     filterListForRemoval(m_deferredChildrenChangedNodeList, document, nodesToRemove);
</span><span class="cx">     filterMapForRemoval(m_deferredTextFormControlValue, document, nodesToRemove);
</span><span class="cx">     filterMapForRemoval(m_deferredAttributeChange, document, nodesToRemove);
</span><span class="lines">@@ -3048,14 +3044,14 @@
</span><span class="cx">         textChanged(node);
</span><span class="cx">     m_deferredTextChangedList.clear();
</span><span class="cx"> 
</span><del>-    for (auto* element : m_deferredRecomputeIsIgnoredList) {
-        if (auto* renderer = element->renderer())
</del><ins>+    for (auto& element : m_deferredRecomputeIsIgnoredList) {
+        if (auto* renderer = element.renderer())
</ins><span class="cx">             recomputeIsIgnored(renderer);
</span><span class="cx">     }
</span><span class="cx">     m_deferredRecomputeIsIgnoredList.clear();
</span><span class="cx">     
</span><del>-    for (auto* selectElement : m_deferredSelectedChildredChangedList)
-        selectedChildrenChanged(selectElement);
</del><ins>+    for (auto& selectElement : m_deferredSelectedChildredChangedList)
+        selectedChildrenChanged(&selectElement);
</ins><span class="cx">     m_deferredSelectedChildredChangedList.clear();
</span><span class="cx"> 
</span><span class="cx">     for (auto& deferredFormControlContext : m_deferredTextFormControlValue) {
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAXObjectCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (260705 => 260706)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AXObjectCache.h       2020-04-25 16:08:46 UTC (rev 260705)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h  2020-04-25 17:03:33 UTC (rev 260706)
</span><span class="lines">@@ -487,9 +487,9 @@
</span><span class="cx">     Timer m_performCacheUpdateTimer;
</span><span class="cx"> 
</span><span class="cx">     AXTextStateChangeIntent m_textSelectionIntent;
</span><del>-    ListHashSet<Element*> m_deferredRecomputeIsIgnoredList;
</del><ins>+    WeakHashSet<Element> m_deferredRecomputeIsIgnoredList;
</ins><span class="cx">     ListHashSet<Node*> m_deferredTextChangedList;
</span><del>-    ListHashSet<Element*> m_deferredSelectedChildredChangedList;
</del><ins>+    WeakHashSet<Element> m_deferredSelectedChildredChangedList;
</ins><span class="cx">     ListHashSet<RefPtr<AXCoreObject>> m_deferredChildrenChangedList;
</span><span class="cx">     ListHashSet<Node*> m_deferredChildrenChangedNodeList;
</span><span class="cx">     HashMap<Element*, String> m_deferredTextFormControlValue;
</span></span></pre>
</div>
</div>

</body>
</html>