<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[260722] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/260722">260722</a></dd>
<dt>Author</dt> <dd>ross.kirsling@sony.com</dd>
<dt>Date</dt> <dd>2020-04-25 22:07:21 -0700 (Sat, 25 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[JSC] isCallable is redundant with isFunction
https://bugs.webkit.org/show_bug.cgi?id=211037

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

isCallable is only being used in two places and has the same definition as isFunction (aside from out params).
Where CallData is needed, getCallData should be used; where CallData is not needed, isFunction should be used.

* runtime/JSCJSValue.h:
* runtime/JSCJSValueInlines.h:
(JSC::JSValue::isCallable const): Deleted.
* runtime/JSCell.h:
* runtime/JSCellInlines.h:
(JSC::JSCell::isCallable): Deleted.
Remove isCallable.

* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
Use getCallData if you need CallData.

* runtime/ExceptionHelpers.cpp:
(JSC::errorDescriptionForValue):
* runtime/ObjectConstructor.cpp:
(JSC::toPropertyDescriptor):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
Don't use getCallData if you don't need CallData.

Source/WebCore:

* bindings/js/JSDOMConvertScheduledAction.h:
(WebCore::Converter<IDLScheduledAction>::convert):
* worklets/PaintWorkletGlobalScope.cpp:
(WebCore::PaintWorkletGlobalScope::registerPaint):
Don't use getCallData if you don't need CallData.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeExceptionHelperscpp">trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSCJSValueh">trunk/Source/JavaScriptCore/runtime/JSCJSValue.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSCJSValueInlinesh">trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSCellh">trunk/Source/JavaScriptCore/runtime/JSCell.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSCellInlinesh">trunk/Source/JavaScriptCore/runtime/JSCellInlines.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSONObjectcpp">trunk/Source/JavaScriptCore/runtime/JSONObject.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeObjectConstructorcpp">trunk/Source/JavaScriptCore/runtime/ObjectConstructor.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeObjectPrototypecpp">trunk/Source/JavaScriptCore/runtime/ObjectPrototype.cpp</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMConvertScheduledActionh">trunk/Source/WebCore/bindings/js/JSDOMConvertScheduledAction.h</a></li>
<li><a href="#trunkSourceWebCoreworkletsPaintWorkletGlobalScopecpp">trunk/Source/WebCore/worklets/PaintWorkletGlobalScope.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/JavaScriptCore/ChangeLog       2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2020-04-25  Ross Kirsling  <ross.kirsling@sony.com>
+
+        [JSC] isCallable is redundant with isFunction
+        https://bugs.webkit.org/show_bug.cgi?id=211037
+
+        Reviewed by Yusuke Suzuki.
+
+        isCallable is only being used in two places and has the same definition as isFunction (aside from out params).
+        Where CallData is needed, getCallData should be used; where CallData is not needed, isFunction should be used.
+
+        * runtime/JSCJSValue.h:
+        * runtime/JSCJSValueInlines.h:
+        (JSC::JSValue::isCallable const): Deleted.
+        * runtime/JSCell.h:
+        * runtime/JSCellInlines.h:
+        (JSC::JSCell::isCallable): Deleted.
+        Remove isCallable.
+
+        * runtime/JSONObject.cpp:
+        (JSC::Stringifier::Stringifier):
+        (JSC::Stringifier::toJSON):
+        Use getCallData if you need CallData.
+
+        * runtime/ExceptionHelpers.cpp:
+        (JSC::errorDescriptionForValue):
+        * runtime/ObjectConstructor.cpp:
+        (JSC::toPropertyDescriptor):
+        * runtime/ObjectPrototype.cpp:
+        (JSC::objectProtoFuncDefineGetter):
+        (JSC::objectProtoFuncDefineSetter):
+        Don't use getCallData if you don't need CallData. 
+
</ins><span class="cx"> 2020-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [JSC] Handle BigInt32 INT32_MIN shift amount
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeExceptionHelperscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp 2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp    2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -94,9 +94,8 @@
</span><span class="cx">         return asSymbol(v)->descriptiveString();
</span><span class="cx">     if (v.isObject()) {
</span><span class="cx">         VM& vm = globalObject->vm();
</span><del>-        CallData callData;
</del><span class="cx">         JSObject* object = asObject(v);
</span><del>-        if (object->methodTable(vm)->getCallData(object, callData) != CallType::None)
</del><ins>+        if (object->isFunction(vm))
</ins><span class="cx">             return vm.smallStrings.functionString()->value(globalObject);
</span><span class="cx">         return JSObject::calculatedClassName(object);
</span><span class="cx">     }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSCJSValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSCJSValue.h (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSCJSValue.h 2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/JavaScriptCore/runtime/JSCJSValue.h    2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -234,8 +234,6 @@
</span><span class="cx">     // Querying the type.
</span><span class="cx">     bool isEmpty() const;
</span><span class="cx">     bool isFunction(VM&) const;
</span><del>-    bool isCallable(VM&) const;
-    bool isCallable(VM&, CallType&, CallData&) const;
</del><span class="cx">     bool isConstructor(VM&) const;
</span><span class="cx">     bool isConstructor(VM&, ConstructType&, ConstructData&) const;
</span><span class="cx">     bool isUndefined() const;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSCJSValueInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h  2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h     2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -882,20 +882,6 @@
</span><span class="cx">     return asCell()->isFunction(vm);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-inline bool JSValue::isCallable(VM& vm) const
-{
-    CallType unusedType;
-    CallData unusedData;
-    return isCallable(vm, unusedType, unusedData);
-}
-
-inline bool JSValue::isCallable(VM& vm, CallType& callType, CallData& callData) const
-{
-    if (!isCell())
-        return false;
-    return asCell()->isCallable(vm, callType, callData);
-}
-
</del><span class="cx"> inline bool JSValue::isConstructor(VM& vm) const
</span><span class="cx"> {
</span><span class="cx">     if (!isCell())
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSCellh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSCell.h (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSCell.h     2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/JavaScriptCore/runtime/JSCell.h        2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -108,7 +108,6 @@
</span><span class="cx">     bool isCustomGetterSetter() const;
</span><span class="cx">     bool isProxy() const;
</span><span class="cx">     bool isFunction(VM&);
</span><del>-    bool isCallable(VM&, CallType&, CallData&);
</del><span class="cx">     bool isConstructor(VM&);
</span><span class="cx">     bool isConstructor(VM&, ConstructType&, ConstructData&);
</span><span class="cx">     bool inherits(VM&, const ClassInfo*) const;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSCellInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSCellInlines.h (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSCellInlines.h      2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/JavaScriptCore/runtime/JSCellInlines.h 2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -240,14 +240,6 @@
</span><span class="cx">     return false;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-inline bool JSCell::isCallable(VM& vm, CallType& callType, CallData& callData)
-{
-    if (type() != JSFunctionType && !(inlineTypeFlags() & OverridesGetCallData))
-        return false;
-    callType = methodTable(vm)->getCallData(this, callData);
-    return callType != CallType::None;
-}
-
</del><span class="cx"> inline bool JSCell::isConstructor(VM& vm)
</span><span class="cx"> {
</span><span class="cx">     ConstructType constructType;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSONObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSONObject.cpp (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSONObject.cpp       2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/JavaScriptCore/runtime/JSONObject.cpp  2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -231,8 +231,8 @@
</span><span class="cx">     if (m_replacer.isObject()) {
</span><span class="cx">         JSObject* replacerObject = asObject(m_replacer);
</span><span class="cx"> 
</span><del>-        m_replacerCallType = CallType::None;
-        if (!replacerObject->isCallable(vm, m_replacerCallType, m_replacerCallData)) {
</del><ins>+        m_replacerCallType = getCallData(vm, replacerObject, m_replacerCallData);
+        if (m_replacerCallType == CallType::None) {
</ins><span class="cx">             bool isArrayReplacer = JSC::isArray(globalObject, replacerObject);
</span><span class="cx">             RETURN_IF_EXCEPTION(scope, );
</span><span class="cx">             if (isArrayReplacer) {
</span><span class="lines">@@ -304,9 +304,9 @@
</span><span class="cx">     JSValue toJSONFunction = baseValue.get(m_globalObject, vm.propertyNames->toJSON);
</span><span class="cx">     RETURN_IF_EXCEPTION(scope, { });
</span><span class="cx"> 
</span><del>-    CallType callType;
</del><span class="cx">     CallData callData;
</span><del>-    if (!toJSONFunction.isCallable(vm, callType, callData))
</del><ins>+    CallType callType = getCallData(vm, toJSONFunction, callData);
+    if (callType == CallType::None)
</ins><span class="cx">         return baseValue;
</span><span class="cx"> 
</span><span class="cx">     MarkedArgumentBuffer args;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeObjectConstructorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ObjectConstructor.cpp (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ObjectConstructor.cpp        2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/JavaScriptCore/runtime/ObjectConstructor.cpp   2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -531,12 +531,9 @@
</span><span class="cx">     if (hasProperty) {
</span><span class="cx">         JSValue get = description->get(globalObject, vm.propertyNames->get);
</span><span class="cx">         RETURN_IF_EXCEPTION(scope, false);
</span><del>-        if (!get.isUndefined()) {
-            CallData callData;
-            if (getCallData(vm, get, callData) == CallType::None) {
-                throwTypeError(globalObject, scope, "Getter must be a function."_s);
-                return false;
-            }
</del><ins>+        if (!get.isUndefined() && !get.isFunction(vm)) {
+            throwTypeError(globalObject, scope, "Getter must be a function."_s);
+            return false;
</ins><span class="cx">         }
</span><span class="cx">         desc.setGetter(get);
</span><span class="cx">     } else
</span><span class="lines">@@ -547,12 +544,9 @@
</span><span class="cx">     if (hasProperty) {
</span><span class="cx">         JSValue set = description->get(globalObject, vm.propertyNames->set);
</span><span class="cx">         RETURN_IF_EXCEPTION(scope, false);
</span><del>-        if (!set.isUndefined()) {
-            CallData callData;
-            if (getCallData(vm, set, callData) == CallType::None) {
-                throwTypeError(globalObject, scope, "Setter must be a function."_s);
-                return false;
-            }
</del><ins>+        if (!set.isUndefined() && !set.isFunction(vm)) {
+            throwTypeError(globalObject, scope, "Setter must be a function."_s);
+            return false;
</ins><span class="cx">         }
</span><span class="cx">         desc.setSetter(set);
</span><span class="cx">     } else
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeObjectPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ObjectPrototype.cpp (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ObjectPrototype.cpp  2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/JavaScriptCore/runtime/ObjectPrototype.cpp     2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -154,8 +154,7 @@
</span><span class="cx">     RETURN_IF_EXCEPTION(scope, encodedJSValue());
</span><span class="cx"> 
</span><span class="cx">     JSValue get = callFrame->argument(1);
</span><del>-    CallData callData;
-    if (getCallData(vm, get, callData) == CallType::None)
</del><ins>+    if (!get.isFunction(vm))
</ins><span class="cx">         return throwVMTypeError(globalObject, scope, "invalid getter usage"_s);
</span><span class="cx"> 
</span><span class="cx">     auto propertyName = callFrame->argument(0).toPropertyKey(globalObject);
</span><span class="lines">@@ -182,8 +181,7 @@
</span><span class="cx">     RETURN_IF_EXCEPTION(scope, encodedJSValue());
</span><span class="cx"> 
</span><span class="cx">     JSValue set = callFrame->argument(1);
</span><del>-    CallData callData;
-    if (getCallData(vm, set, callData) == CallType::None)
</del><ins>+    if (!set.isFunction(vm))
</ins><span class="cx">         return throwVMTypeError(globalObject, scope, "invalid setter usage"_s);
</span><span class="cx"> 
</span><span class="cx">     auto propertyName = callFrame->argument(0).toPropertyKey(globalObject);
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/WebCore/ChangeLog      2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2020-04-25  Ross Kirsling  <ross.kirsling@sony.com>
+
+        [JSC] isCallable is redundant with isFunction
+        https://bugs.webkit.org/show_bug.cgi?id=211037
+
+        Reviewed by Yusuke Suzuki.
+
+        * bindings/js/JSDOMConvertScheduledAction.h:
+        (WebCore::Converter<IDLScheduledAction>::convert):
+        * worklets/PaintWorkletGlobalScope.cpp:
+        (WebCore::PaintWorkletGlobalScope::registerPaint):
+        Don't use getCallData if you don't need CallData. 
+
</ins><span class="cx"> 2020-04-25  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Build fix.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMConvertScheduledActionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMConvertScheduledAction.h (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMConvertScheduledAction.h   2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/WebCore/bindings/js/JSDOMConvertScheduledAction.h      2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -38,8 +38,7 @@
</span><span class="cx">         JSC::VM& vm = JSC::getVM(&lexicalGlobalObject);
</span><span class="cx">         auto scope = DECLARE_THROW_SCOPE(vm);
</span><span class="cx"> 
</span><del>-        JSC::CallData callData;
-        if (getCallData(vm, value, callData) == JSC::CallType::None) {
</del><ins>+        if (!value.isFunction(vm)) {
</ins><span class="cx">             auto code = Converter<IDLDOMString>::convert(lexicalGlobalObject, value);
</span><span class="cx">             RETURN_IF_EXCEPTION(scope, nullptr);
</span><span class="cx">             return ScheduledAction::create(globalObject.world(), WTFMove(code));
</span></span></pre></div>
<a id="trunkSourceWebCoreworkletsPaintWorkletGlobalScopecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/worklets/PaintWorkletGlobalScope.cpp (260721 => 260722)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/worklets/PaintWorkletGlobalScope.cpp        2020-04-26 04:57:48 UTC (rev 260721)
+++ trunk/Source/WebCore/worklets/PaintWorkletGlobalScope.cpp   2020-04-26 05:07:21 UTC (rev 260722)
</span><span class="lines">@@ -75,8 +75,7 @@
</span><span class="cx">     auto scope = DECLARE_THROW_SCOPE(vm);
</span><span class="cx"> 
</span><span class="cx">     // Validate that paintConstructor is a VoidFunction
</span><del>-    CallData callData;
-    if (JSC::getCallData(vm, paintConstructor.get(), callData) == JSC::CallType::None)
</del><ins>+    if (!paintConstructor->isFunction(vm))
</ins><span class="cx">         return Exception { TypeError, "paintConstructor must be callable" };
</span><span class="cx"> 
</span><span class="cx">     if (name.isEmpty())
</span></span></pre>
</div>
</div>

</body>
</html>