<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[260435] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/260435">260435</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2020-04-21 10:14:08 -0700 (Tue, 21 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/256808">r256808</a>): “A problem repeatedly occurred” when attempting to load https://bungalow.com/listings/bay-area
https://bugs.webkit.org/show_bug.cgi?id=210801
<rdar://problem/61658940>

Reviewed by Antti Koivisto.

Even though the page uses the 'async' attribute on the mapbox-gl.js script, deferring the execution of this
script gets the page into a bad state, causing it to use a lot of CPU & memory until the process crashes.
Since we don't have any other evidence of breakage from <a href="http://trac.webkit.org/projects/webkit/changeset/256808">r256808</a> yet and since <a href="http://trac.webkit.org/projects/webkit/changeset/256808">r256808</a> was a massive PLT
progression, I am opting to add a quirk to disable the async script optimization on bungalow.com for now.

* dom/Document.cpp:
(WebCore::Document::shouldDeferAsynchronousScriptsUntilParsingFinishes const):
* page/Quirks.cpp:
(WebCore::Quirks::shouldBypassAsyncScriptDeferring const):
* page/Quirks.h:
* platform/RegistrableDomain.h:
(WebCore::RegistrableDomain::operator== const):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCorepageQuirkscpp">trunk/Source/WebCore/page/Quirks.cpp</a></li>
<li><a href="#trunkSourceWebCorepageQuirksh">trunk/Source/WebCore/page/Quirks.h</a></li>
<li><a href="#trunkSourceWebCoreplatformRegistrableDomainh">trunk/Source/WebCore/platform/RegistrableDomain.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (260434 => 260435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2020-04-21 17:10:47 UTC (rev 260434)
+++ trunk/Source/WebCore/ChangeLog      2020-04-21 17:14:08 UTC (rev 260435)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2020-04-21  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r256808): “A problem repeatedly occurred” when attempting to load https://bungalow.com/listings/bay-area
+        https://bugs.webkit.org/show_bug.cgi?id=210801
+        <rdar://problem/61658940>
+
+        Reviewed by Antti Koivisto.
+
+        Even though the page uses the 'async' attribute on the mapbox-gl.js script, deferring the execution of this
+        script gets the page into a bad state, causing it to use a lot of CPU & memory until the process crashes.
+        Since we don't have any other evidence of breakage from r256808 yet and since r256808 was a massive PLT
+        progression, I am opting to add a quirk to disable the async script optimization on bungalow.com for now.
+
+        * dom/Document.cpp:
+        (WebCore::Document::shouldDeferAsynchronousScriptsUntilParsingFinishes const):
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldBypassAsyncScriptDeferring const):
+        * page/Quirks.h:
+        * platform/RegistrableDomain.h:
+        (WebCore::RegistrableDomain::operator== const):
+
</ins><span class="cx"> 2020-04-16  Sergio Villar Senin  <svillar@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [WebXR] Test IDLs and stubs
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (260434 => 260435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp    2020-04-21 17:10:47 UTC (rev 260434)
+++ trunk/Source/WebCore/dom/Document.cpp       2020-04-21 17:14:08 UTC (rev 260435)
</span><span class="lines">@@ -5557,6 +5557,9 @@
</span><span class="cx">     if (!settings().shouldDeferAsynchronousScriptsUntilAfterDocumentLoadOrFirstPaint())
</span><span class="cx">         return false;
</span><span class="cx"> 
</span><ins>+    if (quirks().shouldBypassAsyncScriptDeferring())
+        return false;
+
</ins><span class="cx">     return parsing() && !(view() && view()->hasEverPainted());
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorepageQuirkscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Quirks.cpp (260434 => 260435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Quirks.cpp     2020-04-21 17:10:47 UTC (rev 260434)
+++ trunk/Source/WebCore/page/Quirks.cpp        2020-04-21 17:14:08 UTC (rev 260435)
</span><span class="lines">@@ -678,6 +678,19 @@
</span><span class="cx">     return false;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+bool Quirks::shouldBypassAsyncScriptDeferring() const
+{
+    if (!needsQuirks())
+        return false;
+
+    if (!m_shouldBypassAsyncScriptDeferring) {
+        auto domain = RegistrableDomain { m_document->topDocument().url() };
+        // Deferring 'mapbox-gl.js' script on bungalow.com causes the script to get in a bad state (rdar://problem/61658940).
+        m_shouldBypassAsyncScriptDeferring = (domain == "bungalow.com");
+    }
+    return *m_shouldBypassAsyncScriptDeferring;
+}
+
</ins><span class="cx"> bool Quirks::shouldMakeEventListenerPassive(const EventTarget& eventTarget, const AtomString& eventType, const EventListener& eventListener)
</span><span class="cx"> {
</span><span class="cx">     if (eventNames().isTouchScrollBlockingEventType(eventType)) {
</span></span></pre></div>
<a id="trunkSourceWebCorepageQuirksh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Quirks.h (260434 => 260435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Quirks.h       2020-04-21 17:10:47 UTC (rev 260434)
+++ trunk/Source/WebCore/page/Quirks.h  2020-04-21 17:14:08 UTC (rev 260435)
</span><span class="lines">@@ -88,6 +88,7 @@
</span><span class="cx">     bool needsPreloadAutoQuirk() const;
</span><span class="cx"> 
</span><span class="cx">     bool shouldBypassBackForwardCache() const;
</span><ins>+    bool shouldBypassAsyncScriptDeferring() const;
</ins><span class="cx"> 
</span><span class="cx">     static bool shouldMakeEventListenerPassive(const EventTarget&, const AtomString& eventType, const EventListener&);
</span><span class="cx"> 
</span><span class="lines">@@ -121,6 +122,7 @@
</span><span class="cx">     mutable Optional<bool> m_shouldDispatchSimulatedMouseEventsQuirk;
</span><span class="cx"> #endif
</span><span class="cx">     mutable Optional<bool> m_needsCanPlayAfterSeekedQuirk;
</span><ins>+    mutable Optional<bool> m_shouldBypassAsyncScriptDeferring;
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformRegistrableDomainh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/RegistrableDomain.h (260434 => 260435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/RegistrableDomain.h        2020-04-21 17:10:47 UTC (rev 260434)
+++ trunk/Source/WebCore/platform/RegistrableDomain.h   2020-04-21 17:14:08 UTC (rev 260435)
</span><span class="lines">@@ -54,6 +54,7 @@
</span><span class="cx"> 
</span><span class="cx">     bool operator!=(const RegistrableDomain& other) const { return m_registrableDomain != other.m_registrableDomain; }
</span><span class="cx">     bool operator==(const RegistrableDomain& other) const { return m_registrableDomain == other.m_registrableDomain; }
</span><ins>+    bool operator==(const char* other) const { return m_registrableDomain == other; }
</ins><span class="cx"> 
</span><span class="cx">     bool matches(const URL& url) const
</span><span class="cx">     {
</span></span></pre>
</div>
</div>

</body>
</html>