<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[260265] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/260265">260265</a></dd>
<dt>Author</dt> <dd>ross.kirsling@sony.com</dd>
<dt>Date</dt> <dd>2020-04-17 10:57:11 -0700 (Fri, 17 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>Clean up some Intl classes following the ICU upgrade
https://bugs.webkit.org/show_bug.cgi?id=210637

Reviewed by Yusuke Suzuki.

In <a href="http://trac.webkit.org/projects/webkit/changeset/259606">r259606</a>, I removed the compile-time guards for {DateTimeFormat, NumberFormat}.prototype.formatToParts,
but I forgot to move the method setup back to the lookup table.

This patch addresses that and prunes various other unnecessary includes and forward declarations.

* runtime/IntlCollator.h:
* runtime/IntlCollatorConstructor.h:
* runtime/IntlDateTimeFormat.h:
* runtime/IntlDateTimeFormatConstructor.h:
* runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototype::create):
(JSC::IntlDateTimeFormatPrototype::finishCreation):
* runtime/IntlDateTimeFormatPrototype.h:
* runtime/IntlNumberFormat.h:
* runtime/IntlNumberFormatConstructor.h:
* runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototype::create):
(JSC::IntlNumberFormatPrototype::finishCreation):
* runtime/IntlNumberFormatPrototype.h:
* runtime/IntlObject.h:
* runtime/IntlPluralRules.h:
* runtime/IntlPluralRulesConstructor.h:
* runtime/IntlPluralRulesPrototype.cpp:
(JSC::IntlPluralRulesPrototype::create):
(JSC::IntlPluralRulesPrototype::finishCreation):
* runtime/IntlPluralRulesPrototype.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlCollatorh">trunk/Source/JavaScriptCore/runtime/IntlCollator.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlCollatorConstructorh">trunk/Source/JavaScriptCore/runtime/IntlCollatorConstructor.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlDateTimeFormath">trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlDateTimeFormatConstructorh">trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatConstructor.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlDateTimeFormatPrototypecpp">trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlDateTimeFormatPrototypeh">trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlNumberFormath">trunk/Source/JavaScriptCore/runtime/IntlNumberFormat.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlNumberFormatConstructorh">trunk/Source/JavaScriptCore/runtime/IntlNumberFormatConstructor.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlNumberFormatPrototypecpp">trunk/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlNumberFormatPrototypeh">trunk/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlObjecth">trunk/Source/JavaScriptCore/runtime/IntlObject.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlPluralRulesh">trunk/Source/JavaScriptCore/runtime/IntlPluralRules.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlPluralRulesConstructorh">trunk/Source/JavaScriptCore/runtime/IntlPluralRulesConstructor.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlPluralRulesPrototypecpp">trunk/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeIntlPluralRulesPrototypeh">trunk/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/ChangeLog       2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -1,3 +1,37 @@
</span><ins>+2020-04-17  Ross Kirsling  <ross.kirsling@sony.com>
+
+        Clean up some Intl classes following the ICU upgrade
+        https://bugs.webkit.org/show_bug.cgi?id=210637
+
+        Reviewed by Yusuke Suzuki.
+
+        In r259606, I removed the compile-time guards for {DateTimeFormat, NumberFormat}.prototype.formatToParts,
+        but I forgot to move the method setup back to the lookup table.
+
+        This patch addresses that and prunes various other unnecessary includes and forward declarations.
+
+        * runtime/IntlCollator.h:
+        * runtime/IntlCollatorConstructor.h:
+        * runtime/IntlDateTimeFormat.h:
+        * runtime/IntlDateTimeFormatConstructor.h:
+        * runtime/IntlDateTimeFormatPrototype.cpp:
+        (JSC::IntlDateTimeFormatPrototype::create):
+        (JSC::IntlDateTimeFormatPrototype::finishCreation):
+        * runtime/IntlDateTimeFormatPrototype.h:
+        * runtime/IntlNumberFormat.h:
+        * runtime/IntlNumberFormatConstructor.h:
+        * runtime/IntlNumberFormatPrototype.cpp:
+        (JSC::IntlNumberFormatPrototype::create):
+        (JSC::IntlNumberFormatPrototype::finishCreation):
+        * runtime/IntlNumberFormatPrototype.h:
+        * runtime/IntlObject.h:
+        * runtime/IntlPluralRules.h:
+        * runtime/IntlPluralRulesConstructor.h:
+        * runtime/IntlPluralRulesPrototype.cpp:
+        (JSC::IntlPluralRulesPrototype::create):
+        (JSC::IntlPluralRulesPrototype::finishCreation):
+        * runtime/IntlPluralRulesPrototype.h:
+
</ins><span class="cx"> 2020-04-17  Yusuke Suzuki  <ysuzuki@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [JSC] Map/Set iterator creation functions should fail with BadType etc. before executing insertChecks
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlCollatorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlCollator.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlCollator.h       2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlCollator.h  2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-class IntlCollatorConstructor;
</del><span class="cx"> class JSBoundFunction;
</span><span class="cx"> 
</span><span class="cx"> class IntlCollator final : public JSNonFinalObject {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlCollatorConstructorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlCollatorConstructor.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlCollatorConstructor.h    2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlCollatorConstructor.h       2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-class IntlCollator;
</del><span class="cx"> class IntlCollatorPrototype;
</span><span class="cx"> 
</span><span class="cx"> class IntlCollatorConstructor final : public InternalFunction {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlDateTimeFormath"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h 2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormat.h    2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -27,11 +27,9 @@
</span><span class="cx"> 
</span><span class="cx"> #include "JSObject.h"
</span><span class="cx"> #include <unicode/udat.h>
</span><del>-#include <unicode/uvernum.h>
</del><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-class IntlDateTimeFormatConstructor;
</del><span class="cx"> class JSBoundFunction;
</span><span class="cx"> 
</span><span class="cx"> class IntlDateTimeFormat final : public JSNonFinalObject {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlDateTimeFormatConstructorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatConstructor.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatConstructor.h      2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatConstructor.h 2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-class IntlDateTimeFormat;
</del><span class="cx"> class IntlDateTimeFormatPrototype;
</span><span class="cx"> 
</span><span class="cx"> class IntlDateTimeFormatConstructor final : public InternalFunction {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlDateTimeFormatPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp      2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp 2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -54,14 +54,15 @@
</span><span class="cx"> /* Source for IntlDateTimeFormatPrototype.lut.h
</span><span class="cx"> @begin dateTimeFormatPrototypeTable
</span><span class="cx">   format           IntlDateTimeFormatPrototypeGetterFormat         DontEnum|Accessor
</span><ins>+  formatToParts    IntlDateTimeFormatPrototypeFuncFormatToParts    DontEnum|Function 1
</ins><span class="cx">   resolvedOptions  IntlDateTimeFormatPrototypeFuncResolvedOptions  DontEnum|Function 0
</span><span class="cx"> @end
</span><span class="cx"> */
</span><span class="cx"> 
</span><del>-IntlDateTimeFormatPrototype* IntlDateTimeFormatPrototype::create(VM& vm, JSGlobalObject* globalObject, Structure* structure)
</del><ins>+IntlDateTimeFormatPrototype* IntlDateTimeFormatPrototype::create(VM& vm, JSGlobalObject*, Structure* structure)
</ins><span class="cx"> {
</span><span class="cx">     IntlDateTimeFormatPrototype* object = new (NotNull, allocateCell<IntlDateTimeFormatPrototype>(vm.heap)) IntlDateTimeFormatPrototype(vm, structure);
</span><del>-    object->finishCreation(vm, globalObject, structure);
</del><ins>+    object->finishCreation(vm);
</ins><span class="cx">     return object;
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -75,11 +76,9 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void IntlDateTimeFormatPrototype::finishCreation(VM& vm, JSGlobalObject* globalObject, Structure*)
</del><ins>+void IntlDateTimeFormatPrototype::finishCreation(VM& vm)
</ins><span class="cx"> {
</span><span class="cx">     Base::finishCreation(vm);
</span><del>-    JSFunction* formatToPartsFunction = JSFunction::create(vm, globalObject, 1, vm.propertyNames->formatToParts.string(), IntlDateTimeFormatPrototypeFuncFormatToParts);
-    putDirectWithoutTransition(vm, vm.propertyNames->formatToParts, formatToPartsFunction, static_cast<unsigned>(PropertyAttribute::DontEnum));
</del><span class="cx">     putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsNontrivialString(vm, "Object"_s), PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly);
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlDateTimeFormatPrototypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.h        2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.h   2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx">     DECLARE_INFO;
</span><span class="cx"> 
</span><span class="cx"> protected:
</span><del>-    void finishCreation(VM&, JSGlobalObject*, Structure*);
</del><ins>+    void finishCreation(VM&);
</ins><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     IntlDateTimeFormatPrototype(VM&, Structure*);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlNumberFormath"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlNumberFormat.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlNumberFormat.h   2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlNumberFormat.h      2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -27,11 +27,9 @@
</span><span class="cx"> 
</span><span class="cx"> #include "JSObject.h"
</span><span class="cx"> #include <unicode/unum.h>
</span><del>-#include <unicode/uvernum.h>
</del><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-class IntlNumberFormatConstructor;
</del><span class="cx"> class JSBoundFunction;
</span><span class="cx"> 
</span><span class="cx"> class IntlNumberFormat final : public JSNonFinalObject {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlNumberFormatConstructorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlNumberFormatConstructor.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlNumberFormatConstructor.h        2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlNumberFormatConstructor.h   2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-class IntlNumberFormat;
</del><span class="cx"> class IntlNumberFormatPrototype;
</span><span class="cx"> 
</span><span class="cx"> class IntlNumberFormatConstructor final : public InternalFunction {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlNumberFormatPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.cpp (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.cpp        2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.cpp   2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -52,14 +52,15 @@
</span><span class="cx"> /* Source for IntlNumberFormatPrototype.lut.h
</span><span class="cx"> @begin numberFormatPrototypeTable
</span><span class="cx">   format           IntlNumberFormatPrototypeGetterFormat         DontEnum|Accessor
</span><ins>+  formatToParts    IntlNumberFormatPrototypeFuncFormatToParts    DontEnum|Function 1
</ins><span class="cx">   resolvedOptions  IntlNumberFormatPrototypeFuncResolvedOptions  DontEnum|Function 0
</span><span class="cx"> @end
</span><span class="cx"> */
</span><span class="cx"> 
</span><del>-IntlNumberFormatPrototype* IntlNumberFormatPrototype::create(VM& vm, JSGlobalObject* globalObject, Structure* structure)
</del><ins>+IntlNumberFormatPrototype* IntlNumberFormatPrototype::create(VM& vm, JSGlobalObject*, Structure* structure)
</ins><span class="cx"> {
</span><span class="cx">     IntlNumberFormatPrototype* object = new (NotNull, allocateCell<IntlNumberFormatPrototype>(vm.heap)) IntlNumberFormatPrototype(vm, structure);
</span><del>-    object->finishCreation(vm, globalObject, structure);
</del><ins>+    object->finishCreation(vm);
</ins><span class="cx">     return object;
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -73,10 +74,9 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void IntlNumberFormatPrototype::finishCreation(VM& vm, JSGlobalObject* globalObject, Structure*)
</del><ins>+void IntlNumberFormatPrototype::finishCreation(VM& vm)
</ins><span class="cx"> {
</span><span class="cx">     Base::finishCreation(vm);
</span><del>-    JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->formatToParts, IntlNumberFormatPrototypeFuncFormatToParts, static_cast<unsigned>(PropertyAttribute::DontEnum), 1);
</del><span class="cx">     putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsNontrivialString(vm, "Object"_s), PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly);
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlNumberFormatPrototypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.h  2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.h     2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx">     DECLARE_INFO;
</span><span class="cx"> 
</span><span class="cx"> protected:
</span><del>-    void finishCreation(VM&, JSGlobalObject*, Structure*);
</del><ins>+    void finishCreation(VM&);
</ins><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     IntlNumberFormatPrototype(VM&, Structure*);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlObject.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlObject.h 2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlObject.h    2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -31,15 +31,6 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-class IntlCollatorConstructor;
-class IntlCollatorPrototype;
-class IntlDateTimeFormatConstructor;
-class IntlDateTimeFormatPrototype;
-class IntlNumberFormatConstructor;
-class IntlNumberFormatPrototype;
-class IntlPluralRulesConstructor;
-class IntlPluralRulesPrototype;
-
</del><span class="cx"> class IntlObject final : public JSNonFinalObject {
</span><span class="cx"> public:
</span><span class="cx">     using Base = JSNonFinalObject;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlPluralRulesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlPluralRules.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlPluralRules.h    2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlPluralRules.h       2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -28,13 +28,9 @@
</span><span class="cx"> #include "JSObject.h"
</span><span class="cx"> #include <unicode/unum.h>
</span><span class="cx"> #include <unicode/upluralrules.h>
</span><del>-#include <unicode/uvernum.h>
</del><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-class IntlPluralRulesConstructor;
-class JSBoundFunction;
-
</del><span class="cx"> class IntlPluralRules final : public JSNonFinalObject {
</span><span class="cx"> public:
</span><span class="cx">     using Base = JSNonFinalObject;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlPluralRulesConstructorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlPluralRulesConstructor.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlPluralRulesConstructor.h 2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlPluralRulesConstructor.h    2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -31,7 +31,6 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-class IntlPluralRules;
</del><span class="cx"> class IntlPluralRulesPrototype;
</span><span class="cx"> 
</span><span class="cx"> class IntlPluralRulesConstructor final : public InternalFunction {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlPluralRulesPrototypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp 2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp    2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> IntlPluralRulesPrototype* IntlPluralRulesPrototype::create(VM& vm, JSGlobalObject*, Structure* structure)
</span><span class="cx"> {
</span><span class="cx">     IntlPluralRulesPrototype* object = new (NotNull, allocateCell<IntlPluralRulesPrototype>(vm.heap)) IntlPluralRulesPrototype(vm, structure);
</span><del>-    object->finishCreation(vm, structure);
</del><ins>+    object->finishCreation(vm);
</ins><span class="cx">     return object;
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void IntlPluralRulesPrototype::finishCreation(VM& vm, Structure*)
</del><ins>+void IntlPluralRulesPrototype::finishCreation(VM& vm)
</ins><span class="cx"> {
</span><span class="cx">     Base::finishCreation(vm);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeIntlPluralRulesPrototypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.h (260264 => 260265)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.h   2020-04-17 17:56:07 UTC (rev 260264)
+++ trunk/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.h      2020-04-17 17:57:11 UTC (rev 260265)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx">     DECLARE_INFO;
</span><span class="cx"> 
</span><span class="cx"> protected:
</span><del>-    void finishCreation(VM&, Structure*);
</del><ins>+    void finishCreation(VM&);
</ins><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     IntlPluralRulesPrototype(VM&, Structure*);
</span></span></pre>
</div>
</div>

</body>
</html>