<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[260213] branches/safari-610.1.10-branch/Source/WebKit</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/260213">260213</a></dd>
<dt>Author</dt> <dd>repstein@apple.com</dd>
<dt>Date</dt> <dd>2020-04-16 12:44:10 -0700 (Thu, 16 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>Cherry-pick <a href="http://trac.webkit.org/projects/webkit/changeset/260120">r260120</a>. rdar://problem/61899305

    Unreviewed, reverting <a href="http://trac.webkit.org/projects/webkit/changeset/259891">r259891</a>.

    Causes significant iOS MotionMark regression

    Reverted changeset:

    "Switch unused IOKit classes from allow-with-report to deny-
    with-report"
    https://bugs.webkit.org/show_bug.cgi?id=210136
    https://trac.webkit.org/changeset/259891

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260120 268f45cc-cd09-0410-ab3c-d52691b4dbfc</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari610110branchSourceWebKitChangeLog">branches/safari-610.1.10-branch/Source/WebKit/ChangeLog</a></li>
<li><a href="#branchessafari610110branchSourceWebKitResourcesSandboxProfilesioscomappleWebKitWebContentsb">branches/safari-610.1.10-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb</a></li>
<li><a href="#branchessafari610110branchSourceWebKitWebProcesscomappleWebProcesssbin">branches/safari-610.1.10-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari610110branchSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-610.1.10-branch/Source/WebKit/ChangeLog (260212 => 260213)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-610.1.10-branch/Source/WebKit/ChangeLog  2020-04-16 19:31:13 UTC (rev 260212)
+++ branches/safari-610.1.10-branch/Source/WebKit/ChangeLog     2020-04-16 19:44:10 UTC (rev 260213)
</span><span class="lines">@@ -1,5 +1,36 @@
</span><span class="cx"> 2020-04-16  Alan Coon  <alancoon@apple.com>
</span><span class="cx"> 
</span><ins>+        Cherry-pick r260120. rdar://problem/61899305
+
+    Unreviewed, reverting r259891.
+    
+    Causes significant iOS MotionMark regression
+    
+    Reverted changeset:
+    
+    "Switch unused IOKit classes from allow-with-report to deny-
+    with-report"
+    https://bugs.webkit.org/show_bug.cgi?id=210136
+    https://trac.webkit.org/changeset/259891
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-04-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+            Unreviewed, reverting r259891.
+
+            Causes significant iOS MotionMark regression
+
+            Reverted changeset:
+
+            "Switch unused IOKit classes from allow-with-report to deny-
+            with-report"
+            https://bugs.webkit.org/show_bug.cgi?id=210136
+            https://trac.webkit.org/changeset/259891
+
+2020-04-16  Alan Coon  <alancoon@apple.com>
+
</ins><span class="cx">         Cherry-pick r260193. rdar://problem/61897737
</span><span class="cx"> 
</span><span class="cx">     REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable
</span></span></pre></div>
<a id="branchessafari610110branchSourceWebKitResourcesSandboxProfilesioscomappleWebKitWebContentsb"></a>
<div class="modfile"><h4>Modified: branches/safari-610.1.10-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (260212 => 260213)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-610.1.10-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb       2020-04-16 19:31:13 UTC (rev 260212)
+++ branches/safari-610.1.10-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb  2020-04-16 19:44:10 UTC (rev 260213)
</span><span class="lines">@@ -205,7 +205,7 @@
</span><span class="cx"> ;;;
</span><span class="cx"> (define-once (opengl)
</span><span class="cx">     ;; Items not seen in testing
</span><del>-    (deny iokit-open (with telemetry-backtrace)
</del><ins>+    (allow iokit-open (with report) (with telemetry)
</ins><span class="cx">            (iokit-connection "IOGPU")
</span><span class="cx">            (iokit-user-client-class
</span><span class="cx">                 "AGXCommandQueue"
</span><span class="lines">@@ -357,7 +357,9 @@
</span><span class="cx">     (allow mach-lookup
</span><span class="cx">         (global-name "com.apple.CARenderServer"))
</span><span class="cx"> 
</span><del>-    (deny iokit-open (with telemetry-backtrace)
</del><ins>+    ; UIKit-required IOKit nodes.
+    (allow iokit-open  (with report) (with telemetry)
+        (iokit-user-client-class "AppleJPEGDriverUserClient")
</ins><span class="cx">         (iokit-user-client-class "IOSurfaceSendRight")
</span><span class="cx">     )
</span><span class="cx"> 
</span></span></pre></div>
<a id="branchessafari610110branchSourceWebKitWebProcesscomappleWebProcesssbin"></a>
<div class="modfile"><h4>Modified: branches/safari-610.1.10-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (260212 => 260213)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-610.1.10-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in      2020-04-16 19:31:13 UTC (rev 260212)
+++ branches/safari-610.1.10-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-04-16 19:44:10 UTC (rev 260213)
</span><span class="lines">@@ -120,13 +120,17 @@
</span><span class="cx">         (iokit-registry-entry-class "IOAccelerationUserClient")
</span><span class="cx">         (iokit-registry-entry-class "IOSurfaceRootUserClient")
</span><span class="cx">         (iokit-registry-entry-class "IOSurfaceSendRight"))
</span><del>-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
</del><span class="cx">     ;; CoreVideo CVCGDisplayLink
</span><span class="cx">     (allow iokit-open
</span><ins>+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+        (with report) (with telemetry)
+#endif
</ins><span class="cx">         (iokit-registry-entry-class "IOFramebufferSharedUserClient"))
</span><del>-#endif
</del><span class="cx">     ;; H.264 Acceleration
</span><span class="cx">     (allow iokit-open
</span><ins>+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+        (with report) (with telemetry)
+#endif
</ins><span class="cx">         (iokit-registry-entry-class "AppleIntelMEUserClient")
</span><span class="cx">         (iokit-registry-entry-class "AppleSNBFBUserClient"))
</span><span class="cx">     ;; QuartzCore
</span><span class="lines">@@ -600,30 +604,20 @@
</span><span class="cx">     (allow-read-write-directory-and-issue-read-write-extensions (param "DARWIN_USER_TEMP_DIR")))
</span><span class="cx"> 
</span><span class="cx"> ;; IOKit user clients
</span><del>-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
</del><span class="cx"> (allow iokit-open
</span><del>-    (iokit-user-client-class "AppleMultitouchDeviceUserClient")
-    (iokit-user-client-class "IOHIDParamUserClient")
-    (iokit-user-client-class "IOAudioControlUserClient")
-    (iokit-user-client-class "IOAudioEngineUserClient")
-)
</del><ins>+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+    (with report) (with telemetry)
</ins><span class="cx"> #endif
</span><del>-
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
-(deny iokit-open
-    (with send-signal SIGKILL)
</del><span class="cx">     (iokit-user-client-class "AppleMultitouchDeviceUserClient")
</span><span class="cx">     (iokit-user-client-class "IOHIDParamUserClient")
</span><span class="cx">     (iokit-user-client-class "IOAudioControlUserClient")
</span><span class="cx">     (iokit-user-client-class "IOAudioEngineUserClient")
</span><del>-    (iokit-registry-entry-class "IOFramebufferSharedUserClient")
-)
-#endif
</del><ins>+    ;; Following is needed due to <rdar://problem/10427451> && <rdar://problem/10808817>
+    (iokit-user-client-class "AudioAUUC"))
</ins><span class="cx"> 
</span><span class="cx"> (allow iokit-open
</span><span class="cx">     (iokit-user-client-class "AppleUpstreamUserClient")
</span><span class="cx">     (iokit-user-client-class "RootDomainUserClient") ;; Needed by WebCore::PerformanceMonitor
</span><del>-    (iokit-user-client-class "AudioAUUC") ;; <rdar://problem/10427451> && <rdar://problem/10808817>
</del><span class="cx"> )
</span><span class="cx"> 
</span><span class="cx"> ;; cookied.
</span><span class="lines">@@ -723,9 +717,6 @@
</span><span class="cx"> 
</span><span class="cx"> ;; Needed to support encrypted media playback <rdar://problem/40038478>
</span><span class="cx"> (allow mach-lookup
</span><del>-#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101500
-    (with telemetry-backtrace)
-#endif
</del><span class="cx">     (global-name "com.apple.SecurityServer")
</span><span class="cx">     (global-name "com.apple.ocspd"))
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>