<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[259977] releases/WebKitGTK/webkit-2.28</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/259977">259977</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2020-04-12 06:27:28 -0700 (Sun, 12 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/258978">r258978</a> - [GTK] Add user agent quirk for auth.mayohr.com
https://bugs.webkit.org/show_bug.cgi?id=209378

Patch by Ting-Wei Lan <lantw44@gmail.com> on 2020-03-25
Reviewed by Michael Catanzaro.

Source/WebCore:

This site blocks the login page completely and asks the user to download
Google Chrome when using our standard user agent. It only blocks the
login page. After logging in, it works fine without user agent quirks.

Note that it is required to hide Version/X from the user agent string
for the site to recognize it as a valid Chrome user agent. Since Chrome
itself does not use Version/X, it should be safe to modify the existing
quirk instead of adding a new one to handle it.

* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):
(WebCore::urlRequiresNoSafariVersion):
(WebCore::UserAgentQuirks::quirksForURL):
(WebCore::UserAgentQuirks::stringForQuirk):
* platform/UserAgentQuirks.h:
* platform/glib/UserAgentGLib.cpp:
(WebCore::buildUserAgentString):

Tools:

* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::assertUserAgentForURLHasNoSafariVersionQuirk):
(TestWebKitAPI::TEST):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit228SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit228SourceWebCoreplatformUserAgentQuirkscpp">releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/UserAgentQuirks.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit228SourceWebCoreplatformglibUserAgentGLibcpp">releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/glib/UserAgentGLib.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit228ToolsChangeLog">releases/WebKitGTK/webkit-2.28/Tools/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit228ToolsTestWebKitAPITestsWebCoreUserAgentQuirkscpp">releases/WebKitGTK/webkit-2.28/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit228SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog (259976 => 259977)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog  2020-04-12 13:27:21 UTC (rev 259976)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/ChangeLog     2020-04-12 13:27:28 UTC (rev 259977)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2020-03-25  Ting-Wei Lan  <lantw44@gmail.com>
+
+        [GTK] Add user agent quirk for auth.mayohr.com
+        https://bugs.webkit.org/show_bug.cgi?id=209378
+
+        Reviewed by Michael Catanzaro.
+
+        This site blocks the login page completely and asks the user to download
+        Google Chrome when using our standard user agent. It only blocks the
+        login page. After logging in, it works fine without user agent quirks.
+
+        Note that it is required to hide Version/X from the user agent string
+        for the site to recognize it as a valid Chrome user agent. Since Chrome
+        itself does not use Version/X, it should be safe to modify the existing
+        quirk instead of adding a new one to handle it.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::urlRequiresChromeBrowser):
+        (WebCore::urlRequiresNoSafariVersion):
+        (WebCore::UserAgentQuirks::quirksForURL):
+        (WebCore::UserAgentQuirks::stringForQuirk):
+        * platform/UserAgentQuirks.h:
+        * platform/glib/UserAgentGLib.cpp:
+        (WebCore::buildUserAgentString):
+
</ins><span class="cx"> 2020-03-31  Zan Dobersek  <zdobersek@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [GTK][WPE] Jumpy rendering of fixed-element layers while scrolling
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit228SourceWebCoreplatformUserAgentQuirkscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/UserAgentQuirks.cpp (259976 => 259977)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/UserAgentQuirks.cpp       2020-04-12 13:27:21 UTC (rev 259976)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/UserAgentQuirks.cpp  2020-04-12 13:27:28 UTC (rev 259977)
</span><span class="lines">@@ -62,7 +62,8 @@
</span><span class="cx"> // that works in Chrome that WebKit cannot handle. Prefer other quirks instead.
</span><span class="cx"> static bool urlRequiresChromeBrowser(const URL& url)
</span><span class="cx"> {
</span><del>-    String baseDomain = topPrivatelyControlledDomain(url.host().toString());
</del><ins>+    String domain = url.host().toString();
+    String baseDomain = topPrivatelyControlledDomain(domain);
</ins><span class="cx"> 
</span><span class="cx">     // Needed for fonts on many sites to work with WebKit.
</span><span class="cx">     // https://bugs.webkit.org/show_bug.cgi?id=147296
</span><span class="lines">@@ -69,6 +70,11 @@
</span><span class="cx">     if (baseDomain == "typekit.net" || baseDomain == "typekit.com")
</span><span class="cx">         return true;
</span><span class="cx"> 
</span><ins>+    // This site completely blocks the login page with WebKitGTK's standard user
+    // agent and ask users to use Google Chrome or Microsoft Internet Explorer.
+    if (domain == "auth.mayohr.com")
+        return true;
+
</ins><span class="cx">     return false;
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit228SourceWebCoreplatformglibUserAgentGLibcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/glib/UserAgentGLib.cpp (259976 => 259977)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/glib/UserAgentGLib.cpp    2020-04-12 13:27:21 UTC (rev 259976)
+++ releases/WebKitGTK/webkit-2.28/Source/WebCore/platform/glib/UserAgentGLib.cpp       2020-04-12 13:27:28 UTC (rev 259977)
</span><span class="lines">@@ -101,15 +101,16 @@
</span><span class="cx">     uaString.append(versionForUAString());
</span><span class="cx">     uaString.appendLiteral(" (KHTML, like Gecko) ");
</span><span class="cx"> 
</span><del>-    // Note that Chrome UAs advertise *both* Chrome and Safari.
</del><ins>+    // Note that Chrome UAs advertise *both* Chrome/X and Safari/X, but it does
+    // not advertise Version/X.
</ins><span class="cx">     if (quirks.contains(UserAgentQuirks::NeedsChromeBrowser)) {
</span><span class="cx">         uaString.append(UserAgentQuirks::stringForQuirk(UserAgentQuirks::NeedsChromeBrowser));
</span><span class="cx">         uaString.appendLiteral(" ");
</span><del>-    }
-
</del><span class="cx">     // Version/X is mandatory *before* Safari/X to be a valid Safari UA. See
</span><span class="cx">     // https://bugs.webkit.org/show_bug.cgi?id=133403 for details.
</span><del>-    uaString.appendLiteral("Version/13.0 Safari/");
</del><ins>+    } else
+        uaString.appendLiteral("Version/13.0 ");
+    uaString.appendLiteral("Safari/");
</ins><span class="cx">     uaString.append(versionForUAString());
</span><span class="cx"> 
</span><span class="cx">     return uaString.toString();
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit228ToolsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.28/Tools/ChangeLog (259976 => 259977)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.28/Tools/ChangeLog   2020-04-12 13:27:21 UTC (rev 259976)
+++ releases/WebKitGTK/webkit-2.28/Tools/ChangeLog      2020-04-12 13:27:28 UTC (rev 259977)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2020-03-25  Ting-Wei Lan  <lantw44@gmail.com>
+
+        [GTK] Add user agent quirk for auth.mayohr.com
+        https://bugs.webkit.org/show_bug.cgi?id=209378
+
+        Reviewed by Michael Catanzaro.
+
+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+        (TestWebKitAPI::assertUserAgentForURLHasNoSafariVersionQuirk):
+        (TestWebKitAPI::TEST):
+
</ins><span class="cx"> 2020-04-01  Carlos Garcia Campos  <cgarcia@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [GTK] MiniBrowser: valgrind claims 'Invalid write of size 8' on close
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit228ToolsTestWebKitAPITestsWebCoreUserAgentQuirkscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.28/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (259976 => 259977)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.28/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp     2020-04-12 13:27:21 UTC (rev 259976)
+++ releases/WebKitGTK/webkit-2.28/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp        2020-04-12 13:27:28 UTC (rev 259977)
</span><span class="lines">@@ -40,6 +40,7 @@
</span><span class="cx">     EXPECT_TRUE(uaString.contains("Safari"));
</span><span class="cx">     EXPECT_FALSE(uaString.contains("Chromium"));
</span><span class="cx">     EXPECT_FALSE(uaString.contains("Firefox"));
</span><ins>+    EXPECT_FALSE(uaString.contains("Version"));
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> static void assertUserAgentForURLHasFirefoxBrowserQuirk(const char* url)
</span><span class="lines">@@ -50,6 +51,7 @@
</span><span class="cx">     EXPECT_FALSE(uaString.contains("Safari"));
</span><span class="cx">     EXPECT_FALSE(uaString.contains("Chromium"));
</span><span class="cx">     EXPECT_TRUE(uaString.contains("Firefox"));
</span><ins>+    EXPECT_FALSE(uaString.contains("Version"));
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> static void assertUserAgentForURLHasLinuxPlatformQuirk(const char* url)
</span><span class="lines">@@ -90,6 +92,7 @@
</span><span class="cx"> 
</span><span class="cx">     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.com/");
</span><span class="cx">     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
</span><ins>+    assertUserAgentForURLHasChromeBrowserQuirk("http://auth.mayohr.com/");
</ins><span class="cx"> 
</span><span class="cx">     assertUserAgentForURLHasFirefoxBrowserQuirk("http://accounts.youtube.com/");
</span><span class="cx">     assertUserAgentForURLHasFirefoxBrowserQuirk("http://docs.google.com/");
</span></span></pre>
</div>
</div>

</body>
</html>