<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[259917] trunk/Source/WTF</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/259917">259917</a></dd>
<dt>Author</dt> <dd>ddkilzer@apple.com</dd>
<dt>Date</dt> <dd>2020-04-10 18:57:12 -0700 (Fri, 10 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>Follow-up: Add WARN_UNUSED_RETURN to decode methods in Source/WTF
<https://webkit.org/b/210323>
<rdar://problem/61565764>

Changes based on feedback from Alex Christensen and Darin Adler:
- Remove WARN_UNUSED_RETURN from methods returning Optional<>.
- Place WARN_UNUSED_RETURN consistently before the return type.

* wtf/MediaTime.h:
* wtf/MonotonicTime.h:
* wtf/ObjectIdentifier.h:
(WTF::ObjectIdentifier::decode):
* wtf/Seconds.h:
* wtf/URL.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfMediaTimeh">trunk/Source/WTF/wtf/MediaTime.h</a></li>
<li><a href="#trunkSourceWTFwtfMonotonicTimeh">trunk/Source/WTF/wtf/MonotonicTime.h</a></li>
<li><a href="#trunkSourceWTFwtfObjectIdentifierh">trunk/Source/WTF/wtf/ObjectIdentifier.h</a></li>
<li><a href="#trunkSourceWTFwtfSecondsh">trunk/Source/WTF/wtf/Seconds.h</a></li>
<li><a href="#trunkSourceWTFwtfURLh">trunk/Source/WTF/wtf/URL.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (259916 => 259917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2020-04-11 01:23:17 UTC (rev 259916)
+++ trunk/Source/WTF/ChangeLog  2020-04-11 01:57:12 UTC (rev 259917)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2020-04-10  David Kilzer  <ddkilzer@apple.com>
+
+        Follow-up: Add WARN_UNUSED_RETURN to decode methods in Source/WTF
+        <https://webkit.org/b/210323>
+        <rdar://problem/61565764>
+
+        Changes based on feedback from Alex Christensen and Darin Adler:
+        - Remove WARN_UNUSED_RETURN from methods returning Optional<>.
+        - Place WARN_UNUSED_RETURN consistently before the return type.
+
+        * wtf/MediaTime.h:
+        * wtf/MonotonicTime.h:
+        * wtf/ObjectIdentifier.h:
+        (WTF::ObjectIdentifier::decode):
+        * wtf/Seconds.h:
+        * wtf/URL.h:
+
</ins><span class="cx"> 2020-04-10  Alicia Boya GarcĂ­a  <aboya@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [WTF] DataMutex: Add runUnlocked()
</span></span></pre></div>
<a id="trunkSourceWTFwtfMediaTimeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/MediaTime.h (259916 => 259917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/MediaTime.h 2020-04-11 01:23:17 UTC (rev 259916)
+++ trunk/Source/WTF/wtf/MediaTime.h    2020-04-11 01:57:12 UTC (rev 259917)
</span><span class="lines">@@ -135,7 +135,7 @@
</span><span class="cx">     MediaTime toTimeScale(uint32_t, RoundingFlags = RoundingFlags::HalfAwayFromZero) const;
</span><span class="cx"> 
</span><span class="cx">     template<class Encoder> void encode(Encoder&) const;
</span><del>-    template<class Decoder> static bool decode(Decoder&, MediaTime&) WARN_UNUSED_RETURN;
</del><ins>+    template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, MediaTime&);
</ins><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     void setTimeScale(uint32_t, RoundingFlags = RoundingFlags::HalfAwayFromZero);
</span></span></pre></div>
<a id="trunkSourceWTFwtfMonotonicTimeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/MonotonicTime.h (259916 => 259917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/MonotonicTime.h     2020-04-11 01:23:17 UTC (rev 259916)
+++ trunk/Source/WTF/wtf/MonotonicTime.h        2020-04-11 01:57:12 UTC (rev 259917)
</span><span class="lines">@@ -144,7 +144,7 @@
</span><span class="cx">         encoder << m_value;
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    template<class Decoder> WARN_UNUSED_RETURN
</del><ins>+    template<class Decoder>
</ins><span class="cx">     static Optional<MonotonicTime> decode(Decoder& decoder)
</span><span class="cx">     {
</span><span class="cx">         Optional<double> time;
</span><span class="lines">@@ -154,8 +154,8 @@
</span><span class="cx">         return MonotonicTime::fromRawSeconds(*time);
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    template<class Decoder> WARN_UNUSED_RETURN
-    static bool decode(Decoder& decoder, MonotonicTime& time)
</del><ins>+    template<class Decoder>
+    static WARN_UNUSED_RETURN bool decode(Decoder& decoder, MonotonicTime& time)
</ins><span class="cx">     {
</span><span class="cx">         double value;
</span><span class="cx">         if (!decoder.decode(value))
</span></span></pre></div>
<a id="trunkSourceWTFwtfObjectIdentifierh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/ObjectIdentifier.h (259916 => 259917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/ObjectIdentifier.h  2020-04-11 01:23:17 UTC (rev 259916)
+++ trunk/Source/WTF/wtf/ObjectIdentifier.h     2020-04-11 01:57:12 UTC (rev 259917)
</span><span class="lines">@@ -70,8 +70,7 @@
</span><span class="cx">         encoder << m_identifier;
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    template<typename Decoder> WARN_UNUSED_RETURN
-    static Optional<ObjectIdentifier> decode(Decoder& decoder)
</del><ins>+    template<typename Decoder> static Optional<ObjectIdentifier> decode(Decoder& decoder)
</ins><span class="cx">     {
</span><span class="cx">         Optional<uint64_t> identifier;
</span><span class="cx">         decoder >> identifier;
</span></span></pre></div>
<a id="trunkSourceWTFwtfSecondsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Seconds.h (259916 => 259917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Seconds.h   2020-04-11 01:23:17 UTC (rev 259916)
+++ trunk/Source/WTF/wtf/Seconds.h      2020-04-11 01:57:12 UTC (rev 259917)
</span><span class="lines">@@ -227,7 +227,7 @@
</span><span class="cx">         encoder << m_value;
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    template<class Decoder> WARN_UNUSED_RETURN
</del><ins>+    template<class Decoder>
</ins><span class="cx">     static Optional<Seconds> decode(Decoder& decoder)
</span><span class="cx">     {
</span><span class="cx">         Optional<double> seconds;
</span><span class="lines">@@ -237,8 +237,8 @@
</span><span class="cx">         return Seconds(*seconds);
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    template<class Decoder> WARN_UNUSED_RETURN
-    static bool decode(Decoder& decoder, Seconds& seconds)
</del><ins>+    template<class Decoder>
+    static WARN_UNUSED_RETURN bool decode(Decoder& decoder, Seconds& seconds)
</ins><span class="cx">     {
</span><span class="cx">         double value;
</span><span class="cx">         if (!decoder.decode(value))
</span></span></pre></div>
<a id="trunkSourceWTFwtfURLh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/URL.h (259916 => 259917)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/URL.h       2020-04-11 01:23:17 UTC (rev 259916)
+++ trunk/Source/WTF/wtf/URL.h  2020-04-11 01:57:12 UTC (rev 259917)
</span><span class="lines">@@ -192,8 +192,8 @@
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx">     template <class Encoder> void encode(Encoder&) const;
</span><del>-    template <class Decoder> static bool decode(Decoder&, URL&) WARN_UNUSED_RETURN;
-    template <class Decoder> static Optional<URL> decode(Decoder&) WARN_UNUSED_RETURN;
</del><ins>+    template <class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, URL&);
+    template <class Decoder> static Optional<URL> decode(Decoder&);
</ins><span class="cx"> 
</span><span class="cx"> private:
</span><span class="cx">     friend class URLParser;
</span></span></pre>
</div>
</div>

</body>
</html>