<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[259831] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/259831">259831</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2020-04-09 14:50:49 -0700 (Thu, 09 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[iOS]: New test landed for <a href="http://trac.webkit.org/projects/webkit/changeset/259762">r259762</a> landed broken: editing/editable-region/hit-test-overlap.html
https://bugs.webkit.org/show_bug.cgi?id=210305
<rdar://problem/61539886>

Fix up the test. All sub-tests are expected to find editable elements. This is a result
of a last minute realization that I need to iterate over all the hit views instead of just
the frontmost one because the search rect can overlap multiple layers: See "iterate over all
the hit views" in <https://bugs.webkit.org/show_bug.cgi?id=209888#c21>. It is because of this
requirement that WebKit::mayContainEditableElementsInRect() can return a false positive: return
true that the search rect contains an editable element even though that element may be occluded
by a higher z-order element (composited or not). False positives are acceptable. Thouhg false
negatives are not.

* editing/editable-region/hit-test-overlap-expected.txt:
* editing/editable-region/hit-test-overlap.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestseditingeditableregionhittestoverlapexpectedtxt">trunk/LayoutTests/editing/editable-region/hit-test-overlap-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingeditableregionhittestoverlaphtml">trunk/LayoutTests/editing/editable-region/hit-test-overlap.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (259830 => 259831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2020-04-09 21:45:57 UTC (rev 259830)
+++ trunk/LayoutTests/ChangeLog 2020-04-09 21:50:49 UTC (rev 259831)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2020-04-09  Daniel Bates  <dabates@apple.com>
+
+        [iOS]: New test landed for r259762 landed broken: editing/editable-region/hit-test-overlap.html
+        https://bugs.webkit.org/show_bug.cgi?id=210305
+        <rdar://problem/61539886>
+
+        Fix up the test. All sub-tests are expected to find editable elements. This is a result
+        of a last minute realization that I need to iterate over all the hit views instead of just
+        the frontmost one because the search rect can overlap multiple layers: See "iterate over all
+        the hit views" in <https://bugs.webkit.org/show_bug.cgi?id=209888#c21>. It is because of this
+        requirement that WebKit::mayContainEditableElementsInRect() can return a false positive: return
+        true that the search rect contains an editable element even though that element may be occluded
+        by a higher z-order element (composited or not). False positives are acceptable. Thouhg false
+        negatives are not.
+
+        * editing/editable-region/hit-test-overlap-expected.txt:
+        * editing/editable-region/hit-test-overlap.html:
+
</ins><span class="cx"> 2020-04-09  Said Abou-Hallawa  <sabouhallawa@apple.com>
</span><span class="cx"> 
</span><span class="cx">         REGRESSION: CSS animations inside an embedded SVG image do not animate
</span></span></pre></div>
<a id="trunkLayoutTestseditingeditableregionhittestoverlapexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/editable-region/hit-test-overlap-expected.txt (259830 => 259831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/editable-region/hit-test-overlap-expected.txt  2020-04-09 21:45:57 UTC (rev 259830)
+++ trunk/LayoutTests/editing/editable-region/hit-test-overlap-expected.txt     2020-04-09 21:50:49 UTC (rev 259831)
</span><span class="lines">@@ -9,8 +9,8 @@
</span><span class="cx"> PASS (x = 281, y = 69, width = 249, height = 201) contains editable elements.
</span><span class="cx"> 
</span><span class="cx"> Composited overlap:
</span><del>-PASS (x = 29, y = 343, width = 251, height = 201) does not contain editable elements.
-PASS (x = 270, y = 400, width = 10, height = 10) does not contain editable elements.
</del><ins>+PASS (x = 29, y = 343, width = 251, height = 201) contains editable elements.
+PASS (x = 270, y = 400, width = 10, height = 10) contains editable elements.
</ins><span class="cx"> PASS (x = 281, y = 343, width = 249, height = 201) contains editable elements.
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestseditingeditableregionhittestoverlaphtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/editing/editable-region/hit-test-overlap.html (259830 => 259831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/editable-region/hit-test-overlap.html  2020-04-09 21:45:57 UTC (rev 259830)
+++ trunk/LayoutTests/editing/editable-region/hit-test-overlap.html     2020-04-09 21:50:49 UTC (rev 259831)
</span><span class="lines">@@ -90,8 +90,8 @@
</span><span class="cx">     containerComputedStyle = window.getComputedStyle(container);
</span><span class="cx">     overlapper = container.querySelector(".overlapper");
</span><span class="cx">     borderLength = parseInt(containerComputedStyle.borderLeftWidth, 10); // Assumes uniform border width
</span><del>-    await shouldNotHaveEditableElementsInRect(container.offsetLeft + borderLength, container.offsetTop + borderLength, overlapper.offsetWidth - borderLength, container.offsetHeight - borderLength);
-    await shouldNotHaveEditableElementsInRectForElement(document.getElementById("second-tap-point"));
</del><ins>+    await shouldHaveEditableElementsInRect(container.offsetLeft + borderLength, container.offsetTop + borderLength, overlapper.offsetWidth - borderLength, container.offsetHeight - borderLength);
+    await shouldHaveEditableElementsInRectForElement(document.getElementById("second-tap-point"));
</ins><span class="cx">     await shouldHaveEditableElementsInRect(container.offsetLeft + overlapper.offsetWidth + borderLength, container.offsetTop + borderLength, container.offsetWidth - overlapper.offsetWidth - borderLength, container.offsetHeight - borderLength);
</span><span class="cx"> 
</span><span class="cx">     let testContainer = document.getElementById("test-container");
</span></span></pre>
</div>
</div>

</body>
</html>