<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[259694] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/259694">259694</a></dd>
<dt>Author</dt> <dd>aakash_jain@apple.com</dd>
<dt>Date</dt> <dd>2020-04-07 17:38:33 -0700 (Tue, 07 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[ews] Improve summary for CheckPatchRelevance build step
https://bugs.webkit.org/show_bug.cgi?id=210146

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(CheckPatchRelevance): Improved success message.
(CheckPatchRelevance.start):
(CheckPatchRelevance.getResultSummary): Improved failure message.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Updated accordingly.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportewsappewsviewsstatusbubblepy">trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py</a></li>
<li><a href="#trunkToolsBuildSlaveSupportewsbuildstepspy">trunk/Tools/BuildSlaveSupport/ews-build/steps.py</a></li>
<li><a href="#trunkToolsBuildSlaveSupportewsbuildsteps_unittestpy">trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportewsappewsviewsstatusbubblepy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (259693 => 259694)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py  2020-04-08 00:34:20 UTC (rev 259693)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py     2020-04-08 00:38:33 UTC (rev 259694)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx">                      '^Downloaded built product$', '^Extracted built product$',
</span><span class="cx">                      '^Cleaned and updated working directory$', '^Checked out required revision$', '^Updated working directory$',
</span><span class="cx">                      '^Validated patch$', '^Killed old processes$', '^Configured build$', '^OS:.*Xcode:', '(skipped)',
</span><del>-                     '^Printed configuration$', '^Checked patch relevance$', '^Deleted .git/index.lock$',
</del><ins>+                     '^Printed configuration$', '^Patch contains relevant changes$', '^Deleted .git/index.lock$',
</ins><span class="cx">                      '^triggered.*$', '^Found modified ChangeLogs$', '^Created local git commit$', '^Set build summary$',
</span><span class="cx">                      '^Validated commiter$', '^Validated commiter and reviewer$', '^Validated ChangeLog and Reviewer$',
</span><span class="cx">                      '^Removed flags on bugzilla patch$', '^Checked patch status on other queues$']
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportewsbuildstepspy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (259693 => 259694)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-04-08 00:34:20 UTC (rev 259693)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py    2020-04-08 00:38:33 UTC (rev 259694)
</span><span class="lines">@@ -243,7 +243,7 @@
</span><span class="cx"> class CheckPatchRelevance(buildstep.BuildStep):
</span><span class="cx">     name = 'check-patch-relevance'
</span><span class="cx">     description = ['check-patch-relevance running']
</span><del>-    descriptionDone = ['Checked patch relevance']
</del><ins>+    descriptionDone = ['Patch contains relevant changes']
</ins><span class="cx">     flunkOnFailure = True
</span><span class="cx">     haltOnFailure = True
</span><span class="cx"> 
</span><span class="lines">@@ -332,12 +332,16 @@
</span><span class="cx">             self.finished(SUCCESS)
</span><span class="cx">             return None
</span><span class="cx"> 
</span><del>-        self._addToLog('stdio', 'This patch does not have relevant changes.')
</del><ins>+        self._addToLog('stdio', 'This patch does not contain relevant changes.')
</ins><span class="cx">         self.finished(FAILURE)
</span><span class="cx">         self.build.results = SKIPPED
</span><del>-        self.build.buildFinished(['Patch {} doesn\'t have relevant changes'.format(self.getProperty('patch_id', ''))], SKIPPED)
</del><ins>+        self.build.buildFinished(['Patch {} doesn\'t contain relevant changes'.format(self.getProperty('patch_id', ''))], SKIPPED)
</ins><span class="cx">         return None
</span><span class="cx"> 
</span><ins>+    def getResultSummary(self):
+        if self.results == FAILURE:
+            return {u'step': u'Patch doesn\'t contain relevant changes'}
+        return super(CheckPatchRelevance, self).getResultSummary()
</ins><span class="cx"> 
</span><span class="cx"> class BugzillaMixin(object):
</span><span class="cx">     addURLs = False
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportewsbuildsteps_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (259693 => 259694)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py        2020-04-08 00:34:20 UTC (rev 259693)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py   2020-04-08 00:38:33 UTC (rev 259694)
</span><span class="lines">@@ -2165,7 +2165,7 @@
</span><span class="cx">         self.setProperty('buildername', 'JSC-Tests-EWS')
</span><span class="cx">         self.assertEqual(CheckPatchRelevance.haltOnFailure, True)
</span><span class="cx">         self.assertEqual(CheckPatchRelevance.flunkOnFailure, True)
</span><del>-        self.expectOutcome(result=SUCCESS, state_string='Checked patch relevance')
</del><ins>+        self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
</ins><span class="cx">         return self.runStep()
</span><span class="cx"> 
</span><span class="cx">     def test_queue_without_relevance_info(self):
</span><span class="lines">@@ -2173,7 +2173,7 @@
</span><span class="cx">         self.setupStep(CheckPatchRelevance())
</span><span class="cx">         self.setProperty('buildername', 'Commit-Queue')
</span><span class="cx">         CheckPatchStatusOnEWSQueues.get_patch_status = lambda cls, patch_id, queue: FAILURE
</span><del>-        self.expectOutcome(result=SUCCESS, state_string='Checked patch relevance')
</del><ins>+        self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
</ins><span class="cx">         return self.runStep()
</span><span class="cx"> 
</span><span class="cx">     def test_non_relevant_patch(self):
</span><span class="lines">@@ -2182,7 +2182,7 @@
</span><span class="cx">         self.setProperty('buildername', 'JSC-Tests-EWS')
</span><span class="cx">         self.setProperty('patch_id', '1234')
</span><span class="cx">         CheckPatchStatusOnEWSQueues.get_patch_status = lambda cls, patch_id, queue: FAILURE
</span><del>-        self.expectOutcome(result=FAILURE, state_string='Checked patch relevance (failure)')
</del><ins>+        self.expectOutcome(result=FAILURE, state_string='Patch doesn\'t contain relevant changes')
</ins><span class="cx">         return self.runStep()
</span><span class="cx"> 
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (259693 => 259694)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2020-04-08 00:34:20 UTC (rev 259693)
+++ trunk/Tools/ChangeLog       2020-04-08 00:38:33 UTC (rev 259694)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2020-04-07  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Improve summary for CheckPatchRelevance build step
+        https://bugs.webkit.org/show_bug.cgi?id=210146
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (CheckPatchRelevance): Improved success message.
+        (CheckPatchRelevance.start):
+        (CheckPatchRelevance.getResultSummary): Improved failure message.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Updated accordingly.
+
</ins><span class="cx"> 2020-04-07  Jiewen Tan  <jiewen_tan@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [WebAuthn] Cancel WebAuthn requests when users cancel LocalAuthentication prompts
</span></span></pre>
</div>
</div>

</body>
</html>