<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[259409] trunk/Source/WebKit</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/259409">259409</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2020-04-02 13:38:43 -0700 (Thu, 02 Apr 2020)</dd>
</dl>

<h3>Log Message</h3>
<pre>[iOS] Remove use of 'apple-signed-executable?' from Sandbox
https://bugs.webkit.org/show_bug.cgi?id=209914
<rdar://problem/45088481>

Reviewed by Per Arne Vollan.

Some of the rules imported from the system sandbox make decisions based on whether the software is
an apple-signed executable or not. This predicate is not relevant for the WebKit processes, and
should be removed (it is always apple-signed).

This patch makes the following changes:
1. Removes all uses of 'apple-signed-executable?' (since it is always true for WebKit).
2. Removed two iCloud preference reads that are not used in WebKit.
3. Switches from the deprecated 'com.apple.ReportCrash.SimulateCrash' XPC service to its
correct name 'com.apple.osanalytics.osanalyticshelper'.

Covered by existing regression tests.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitResourcesSandboxProfilesioscomappleWebKitGPUsb">trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb</a></li>
<li><a href="#trunkSourceWebKitResourcesSandboxProfilesioscomappleWebKitNetworkingsb">trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb</a></li>
<li><a href="#trunkSourceWebKitResourcesSandboxProfilesioscomappleWebKitWebContentsb">trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (259408 => 259409)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2020-04-02 20:33:32 UTC (rev 259408)
+++ trunk/Source/WebKit/ChangeLog       2020-04-02 20:38:43 UTC (rev 259409)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2020-04-02  Brent Fulgham  <bfulgham@apple.com>
+
+        [iOS] Remove use of 'apple-signed-executable?' from Sandbox
+        https://bugs.webkit.org/show_bug.cgi?id=209914
+        <rdar://problem/45088481>
+
+        Reviewed by Per Arne Vollan.
+
+        Some of the rules imported from the system sandbox make decisions based on whether the software is
+        an apple-signed executable or not. This predicate is not relevant for the WebKit processes, and
+        should be removed (it is always apple-signed).
+
+        This patch makes the following changes:
+        1. Removes all uses of 'apple-signed-executable?' (since it is always true for WebKit).
+        2. Removed two iCloud preference reads that are not used in WebKit.
+        3. Switches from the deprecated 'com.apple.ReportCrash.SimulateCrash' XPC service to its
+        correct name 'com.apple.osanalytics.osanalyticshelper'.
+
+        Covered by existing regression tests.
+
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
</ins><span class="cx"> 2020-04-01  Darin Adler  <darin@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Remove all uses of live ranges from TextIterator
</span></span></pre></div>
<a id="trunkSourceWebKitResourcesSandboxProfilesioscomappleWebKitGPUsb"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (259408 => 259409)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb        2020-04-02 20:33:32 UTC (rev 259408)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb   2020-04-02 20:38:43 UTC (rev 259409)
</span><span class="lines">@@ -436,16 +436,10 @@
</span><span class="cx"> 
</span><span class="cx"> (deny file-write-mount file-write-unmount)
</span><span class="cx"> 
</span><del>-(allow file-read-metadata (with no-times)
-       (vnode-type DIRECTORY))
-(with-filter (apple-signed-executable?)
-  (allow file-read-metadata
-         (vnode-type DIRECTORY)))
</del><ins>+(allow file-read-metadata
+    (vnode-type DIRECTORY))
</ins><span class="cx"> 
</span><del>-(with-filter (apple-signed-executable?)
-  (managed-configuration-read "CloudConfigurationDetails.plist")
-  (managed-configuration-read "CloudConfigurationSetAsideDetails.plist")
-  (mobile-preferences-read "com.apple.security"))
</del><ins>+(mobile-preferences-read "com.apple.security")
</ins><span class="cx"> 
</span><span class="cx"> (with-filter (system-attribute apple-internal)
</span><span class="cx">   (mobile-preferences-read "com.apple.PrototypeTools"))
</span><span class="lines">@@ -652,9 +646,6 @@
</span><span class="cx"> (allow process-info-rusage (target self))
</span><span class="cx"> (allow process-info-codesignature (target self))
</span><span class="cx"> 
</span><del>-(with-filter (apple-signed-executable?)
-    (mobile-preferences-read "com.apple.demo-settings"))
-
</del><span class="cx"> ;;;
</span><span class="cx"> ;;; End common.sb content
</span><span class="cx"> ;;;
</span></span></pre></div>
<a id="trunkSourceWebKitResourcesSandboxProfilesioscomappleWebKitNetworkingsb"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (259408 => 259409)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb 2020-04-02 20:33:32 UTC (rev 259408)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb    2020-04-02 20:38:43 UTC (rev 259409)
</span><span class="lines">@@ -125,8 +125,7 @@
</span><span class="cx">     (with-filter (entitlement-is-present "com.apple.private.networkextension.configuration")
</span><span class="cx">            (allow file-read* (literal "/private/var/preferences/com.apple.networkextension.plist")))
</span><span class="cx"> 
</span><del>-    (with-filter (apple-signed-executable?)
-        (allow file-read* (literal "/private/var/preferences/com.apple.networkextension.uuidcache.plist")))
</del><ins>+    (allow file-read* (literal "/private/var/preferences/com.apple.networkextension.uuidcache.plist"))
</ins><span class="cx"> 
</span><span class="cx">     (allow mach-lookup
</span><span class="cx">            (global-name "com.apple.AppSSO.service-xpc"))
</span><span class="lines">@@ -155,14 +154,9 @@
</span><span class="cx">                (global-name "com.apple.networkd_privileged")))
</span><span class="cx"> 
</span><span class="cx">     ;; <rdar://problem/20201593>
</span><del>-    (with-filter (require-any
-                   (apple-signed-executable?)
-                   (require-entitlement "com.apple.authkit.client")
-                   (require-entitlement "com.apple.authkit.client.private")
-                   (require-entitlement "com.apple.authkit.client.internal"))
-        (allow mach-lookup
-               (global-name "com.apple.ak.anisette.xpc")
-               (global-name "com.apple.ak.auth.xpc")))
</del><ins>+    (allow mach-lookup
+        (global-name "com.apple.ak.anisette.xpc")
+        (global-name "com.apple.ak.auth.xpc"))
</ins><span class="cx"> 
</span><span class="cx">     ;; <rdar://problem/15897781>
</span><span class="cx">     (allow mach-lookup
</span><span class="lines">@@ -281,9 +275,8 @@
</span><span class="cx">         (mobile-preferences-read "com.apple.hangtracer")
</span><span class="cx"> 
</span><span class="cx">         ;; <rdar://problem/9090627>
</span><del>-        (with-filter (apple-signed-executable?)
-          (allow mach-lookup
-                 (global-name "com.apple.ReportCrash.SimulateCrash"))))
</del><ins>+        (allow mach-lookup
+             (global-name "com.apple.osanalytics.osanalyticshelper")))
</ins><span class="cx"> 
</span><span class="cx"> (define-once (logd-diagnostic-paths)
</span><span class="cx">     (require-any
</span></span></pre></div>
<a id="trunkSourceWebKitResourcesSandboxProfilesioscomappleWebKitWebContentsb"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (259408 => 259409)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2020-04-02 20:33:32 UTC (rev 259408)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb    2020-04-02 20:38:43 UTC (rev 259409)
</span><span class="lines">@@ -394,16 +394,10 @@
</span><span class="cx"> 
</span><span class="cx"> (deny file-write-mount file-write-unmount)
</span><span class="cx"> 
</span><del>-(allow file-read-metadata (with no-times)
-       (vnode-type DIRECTORY))
-(with-filter (apple-signed-executable?)
-  (allow file-read-metadata
-         (vnode-type DIRECTORY)))
</del><ins>+(allow file-read-metadata
+    (vnode-type DIRECTORY))
</ins><span class="cx"> 
</span><del>-(with-filter (apple-signed-executable?)
-  (managed-configuration-read "CloudConfigurationDetails.plist")
-  (managed-configuration-read "CloudConfigurationSetAsideDetails.plist")
-  (mobile-preferences-read "com.apple.security"))
</del><ins>+(mobile-preferences-read "com.apple.security")
</ins><span class="cx"> 
</span><span class="cx"> (with-filter (system-attribute apple-internal)
</span><span class="cx">   (mobile-preferences-read "com.apple.PrototypeTools"))
</span><span class="lines">@@ -603,9 +597,6 @@
</span><span class="cx"> (allow process-info-rusage (target self))
</span><span class="cx"> (allow process-info-codesignature (target self))
</span><span class="cx"> 
</span><del>-(with-filter (apple-signed-executable?)
-    (mobile-preferences-read "com.apple.demo-settings"))
-
</del><span class="cx"> ;;;
</span><span class="cx"> ;;; End common.sb content
</span><span class="cx"> ;;;
</span></span></pre>
</div>
</div>

</body>
</html>