<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[248011] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/248011">248011</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2019-07-30 10:23:09 -0700 (Tue, 30 Jul 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>picture-in-picture.html fails because webkitpresentationmodechanged sometimes dispatched multiple times
using Apple Internal build
<rdar://problem/36455352>

Workaround by only listening for the first webkitpresentationmodechanged event dispatched. This test
is the canary in the coal mine that revealed that multiple webkitpresentationmodechanged events are
dispatched when one is expected. However this was not the primary purpose of the test and in absence
of a timeframe for a fix for <rdar://problem/36455352> work around this bug to avoid losing test coverage
when using an Apple Internal build.

* platform/ipad/media/controls/resources/picture-in-picture.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformipadmediacontrolsresourcespictureinpicturehtml">trunk/LayoutTests/platform/ipad/media/controls/resources/picture-in-picture.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (248010 => 248011)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-07-30 16:31:05 UTC (rev 248010)
+++ trunk/LayoutTests/ChangeLog 2019-07-30 17:23:09 UTC (rev 248011)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2019-07-30  Daniel Bates  <dabates@apple.com>
+
+        picture-in-picture.html fails because webkitpresentationmodechanged sometimes dispatched multiple times
+        using Apple Internal build
+        <rdar://problem/36455352>
+
+        Workaround by only listening for the first webkitpresentationmodechanged event dispatched. This test
+        is the canary in the coal mine that revealed that multiple webkitpresentationmodechanged events are
+        dispatched when one is expected. However this was not the primary purpose of the test and in absence
+        of a timeframe for a fix for <rdar://problem/36455352> work around this bug to avoid losing test coverage
+        when using an Apple Internal build.
+
+        * platform/ipad/media/controls/resources/picture-in-picture.html:
+
</ins><span class="cx"> 2019-07-30  Truitt Savell  <tsavell@apple.com>
</span><span class="cx"> 
</span><span class="cx">         (r247440) imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker.html is a flakey failure
</span></span></pre></div>
<a id="trunkLayoutTestsplatformipadmediacontrolsresourcespictureinpicturehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ipad/media/controls/resources/picture-in-picture.html (248010 => 248011)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ipad/media/controls/resources/picture-in-picture.html 2019-07-30 16:31:05 UTC (rev 248010)
+++ trunk/LayoutTests/platform/ipad/media/controls/resources/picture-in-picture.html    2019-07-30 17:23:09 UTC (rev 248011)
</span><span class="lines">@@ -17,7 +17,7 @@
</span><span class="cx"> var video = document.querySelector("video");
</span><span class="cx"> if (window.internals)
</span><span class="cx">     internals.setMediaElementRestrictions(video, "NoRestrictions");
</span><del>-video.addEventListener("webkitpresentationmodechanged", dispatchDidChangePresentationMode, false);
</del><ins>+video.addEventListener("webkitpresentationmodechanged", dispatchDidChangePresentationMode, { capture: false, once: true });
</ins><span class="cx"> video.addEventListener("canplaythrough", function () { video.webkitSetPresentationMode("picture-in-picture"); }, false);
</span><span class="cx"> video.src = findMediaFile("video", "../../../../../media/content/test");
</span><span class="cx"> </script>
</span></span></pre>
</div>
</div>

</body>
</html>