<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[247058] trunk/Source/WebKit</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/247058">247058</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2019-07-02 10:47:26 -0700 (Tue, 02 Jul 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>VisitedLinkStore does not need to subclass WebProcessLifetimeObserver
https://bugs.webkit.org/show_bug.cgi?id=199407

Reviewed by Sam Weinig.

VisitedLinkStore does not need to subclass WebProcessLifetimeObserver, it overrides
only 2 of WebProcessLifetimeObserver's functions and the implementation of those
overrides is empty. It also does not use WebProcessLifetimeObserver::processes()
since the VisitedLinkStore maintains its own list of processes.

* UIProcess/API/mac/WKView.mm:
* UIProcess/Automation/WebAutomationSession.cpp:
* UIProcess/VisitedLinkStore.cpp:
* UIProcess/VisitedLinkStore.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::m_resetRecentCrashCountTimer):
* UIProcess/WebProcessPool.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitUIProcessAPImacWKViewmm">trunk/Source/WebKit/UIProcess/API/mac/WKView.mm</a></li>
<li><a href="#trunkSourceWebKitUIProcessAutomationWebAutomationSessioncpp">trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessVisitedLinkStorecpp">trunk/Source/WebKit/UIProcess/VisitedLinkStore.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessVisitedLinkStoreh">trunk/Source/WebKit/UIProcess/VisitedLinkStore.h</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebPageProxycpp">trunk/Source/WebKit/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebProcessPoolh">trunk/Source/WebKit/UIProcess/WebProcessPool.h</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebsiteDataWebsiteDataStorecpp">trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp</a></li>
<li><a href="#trunkSourceWebKitUIProcessiosWKGeolocationProviderIOSmm">trunk/Source/WebKit/UIProcess/ios/WKGeolocationProviderIOS.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (247057 => 247058)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2019-07-02 17:37:18 UTC (rev 247057)
+++ trunk/Source/WebKit/ChangeLog       2019-07-02 17:47:26 UTC (rev 247058)
</span><span class="lines">@@ -1,5 +1,26 @@
</span><span class="cx"> 2019-07-02  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><ins>+        VisitedLinkStore does not need to subclass WebProcessLifetimeObserver
+        https://bugs.webkit.org/show_bug.cgi?id=199407
+
+        Reviewed by Sam Weinig.
+
+        VisitedLinkStore does not need to subclass WebProcessLifetimeObserver, it overrides
+        only 2 of WebProcessLifetimeObserver's functions and the implementation of those
+        overrides is empty. It also does not use WebProcessLifetimeObserver::processes()
+        since the VisitedLinkStore maintains its own list of processes.
+
+        * UIProcess/API/mac/WKView.mm:
+        * UIProcess/Automation/WebAutomationSession.cpp:
+        * UIProcess/VisitedLinkStore.cpp:
+        * UIProcess/VisitedLinkStore.h:
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::m_resetRecentCrashCountTimer):
+        * UIProcess/WebProcessPool.h:
+        * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+
+2019-07-02  Chris Dumez  <cdumez@apple.com>
+
</ins><span class="cx">         Null dereference under StorageManager::destroySessionStorageNamespace()
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=199388
</span><span class="cx">         <rdar://problem/52030641>
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessAPImacWKViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/API/mac/WKView.mm (247057 => 247058)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/API/mac/WKView.mm  2019-07-02 17:37:18 UTC (rev 247057)
+++ trunk/Source/WebKit/UIProcess/API/mac/WKView.mm     2019-07-02 17:47:26 UTC (rev 247058)
</span><span class="lines">@@ -38,6 +38,7 @@
</span><span class="cx"> #import "WebBackForwardListItem.h"
</span><span class="cx"> #import "WebKit2Initialize.h"
</span><span class="cx"> #import "WebPageGroup.h"
</span><ins>+#import "WebPageProxy.h"
</ins><span class="cx"> #import "WebPreferencesKeys.h"
</span><span class="cx"> #import "WebProcessPool.h"
</span><span class="cx"> #import "WebViewImpl.h"
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessAutomationWebAutomationSessioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (247057 => 247058)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp        2019-07-02 17:37:18 UTC (rev 247057)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp   2019-07-02 17:47:26 UTC (rev 247058)
</span><span class="lines">@@ -40,6 +40,7 @@
</span><span class="cx"> #include "WebFullScreenManagerProxy.h"
</span><span class="cx"> #include "WebInspectorProxy.h"
</span><span class="cx"> #include "WebOpenPanelResultListenerProxy.h"
</span><ins>+#include "WebPageProxy.h"
</ins><span class="cx"> #include "WebProcessPool.h"
</span><span class="cx"> #include <JavaScriptCore/InspectorBackendDispatcher.h>
</span><span class="cx"> #include <JavaScriptCore/InspectorFrontendRouter.h>
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessVisitedLinkStorecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/VisitedLinkStore.cpp (247057 => 247058)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/VisitedLinkStore.cpp       2019-07-02 17:37:18 UTC (rev 247057)
+++ trunk/Source/WebKit/UIProcess/VisitedLinkStore.cpp  2019-07-02 17:47:26 UTC (rev 247058)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx"> 
</span><span class="cx"> #include "VisitedLinkStoreMessages.h"
</span><span class="cx"> #include "VisitedLinkTableControllerMessages.h"
</span><ins>+#include "WebPageProxy.h"
</ins><span class="cx"> #include "WebProcessMessages.h"
</span><span class="cx"> #include "WebProcessPool.h"
</span><span class="cx"> #include "WebProcessProxy.h"
</span><span class="lines">@@ -99,16 +100,6 @@
</span><span class="cx">     }
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void VisitedLinkStore::webProcessWillOpenConnection(WebProcessProxy&, IPC::Connection&)
-{
-    // FIXME: Implement.
-}
-
-void VisitedLinkStore::webProcessDidCloseConnection(WebProcessProxy&, IPC::Connection&)
-{
-    // FIXME: Implement.
-}
-
</del><span class="cx"> void VisitedLinkStore::addVisitedLinkHashFromPage(PageIdentifier pageID, SharedStringHash linkHash)
</span><span class="cx"> {
</span><span class="cx">     if (auto* webPageProxy = WebProcessProxy::webPage(pageID)) {
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessVisitedLinkStoreh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/VisitedLinkStore.h (247057 => 247058)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/VisitedLinkStore.h 2019-07-02 17:37:18 UTC (rev 247057)
+++ trunk/Source/WebKit/UIProcess/VisitedLinkStore.h    2019-07-02 17:47:26 UTC (rev 247058)
</span><span class="lines">@@ -28,8 +28,7 @@
</span><span class="cx"> #include "APIObject.h"
</span><span class="cx"> #include "MessageReceiver.h"
</span><span class="cx"> #include "SharedStringHashStore.h"
</span><del>-#include "WebPageProxy.h"
-#include "WebProcessLifetimeObserver.h"
</del><ins>+#include <WebCore/PageIdentifier.h>
</ins><span class="cx"> #include <wtf/Forward.h>
</span><span class="cx"> #include <wtf/HashSet.h>
</span><span class="cx"> #include <wtf/Identified.h>
</span><span class="lines">@@ -37,14 +36,13 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebKit {
</span><span class="cx"> 
</span><del>-class WebPageProxy;
</del><span class="cx"> class WebProcessProxy;
</span><span class="cx">     
</span><del>-class VisitedLinkStore final : public API::ObjectImpl<API::Object::Type::VisitedLinkStore>, private IPC::MessageReceiver, public WebProcessLifetimeObserver, public Identified<VisitedLinkStore>, private SharedStringHashStore::Client {
</del><ins>+class VisitedLinkStore final : public API::ObjectImpl<API::Object::Type::VisitedLinkStore>, private IPC::MessageReceiver, public Identified<VisitedLinkStore>, private SharedStringHashStore::Client {
</ins><span class="cx"> public:
</span><span class="cx">     static Ref<VisitedLinkStore> create();
</span><ins>+    VisitedLinkStore();
</ins><span class="cx"> 
</span><del>-    explicit VisitedLinkStore();
</del><span class="cx">     virtual ~VisitedLinkStore();
</span><span class="cx"> 
</span><span class="cx">     void addProcess(WebProcessProxy&);
</span><span class="lines">@@ -59,10 +57,6 @@
</span><span class="cx">     // IPC::MessageReceiver
</span><span class="cx">     void didReceiveMessage(IPC::Connection&, IPC::Decoder&) final;
</span><span class="cx"> 
</span><del>-    // WebProcessLifetimeObserver
-    void webProcessWillOpenConnection(WebProcessProxy&, IPC::Connection&) final;
-    void webProcessDidCloseConnection(WebProcessProxy&, IPC::Connection&) final;
-
</del><span class="cx">     // SharedStringHashStore::Client
</span><span class="cx">     void didInvalidateSharedMemory() final;
</span><span class="cx">     void didUpdateSharedStringHashes(const Vector<WebCore::SharedStringHash>& addedHashes, const Vector<WebCore::SharedStringHash>& removedHashes) final;
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (247057 => 247058)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp   2019-07-02 17:37:18 UTC (rev 247057)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp      2019-07-02 17:47:26 UTC (rev 247058)
</span><span class="lines">@@ -445,7 +445,6 @@
</span><span class="cx">     if (!m_configuration->drawsBackground())
</span><span class="cx">         m_backgroundColor = Color(Color::transparent);
</span><span class="cx"> 
</span><del>-    m_webProcessLifetimeTracker.addObserver(m_visitedLinkStore);
</del><span class="cx">     m_webProcessLifetimeTracker.addObserver(m_websiteDataStore);
</span><span class="cx"> 
</span><span class="cx">     updateActivityState();
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebProcessPoolh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.h (247057 => 247058)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebProcessPool.h   2019-07-02 17:37:18 UTC (rev 247057)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.h      2019-07-02 17:47:26 UTC (rev 247058)
</span><span class="lines">@@ -43,6 +43,7 @@
</span><span class="cx"> #include "VisitedLinkStore.h"
</span><span class="cx"> #include "WebContextClient.h"
</span><span class="cx"> #include "WebContextConnectionClient.h"
</span><ins>+#include "WebPreferencesStore.h"
</ins><span class="cx"> #include "WebProcessProxy.h"
</span><span class="cx"> #include <WebCore/CrossSiteNavigationDataTransfer.h>
</span><span class="cx"> #include <WebCore/ProcessIdentifier.h>
</span><span class="lines">@@ -100,6 +101,7 @@
</span><span class="cx"> class UIGamepad;
</span><span class="cx"> class PerActivityStateCPUUsageSampler;
</span><span class="cx"> class ServiceWorkerProcessProxy;
</span><ins>+class SuspendedPageProxy;
</ins><span class="cx"> class WebAutomationSession;
</span><span class="cx"> class WebContextSupplement;
</span><span class="cx"> class WebPageGroup;
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebsiteDataWebsiteDataStorecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (247057 => 247058)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp   2019-07-02 17:37:18 UTC (rev 247057)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp      2019-07-02 17:47:26 UTC (rev 247058)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> #include "NetworkProcessMessages.h"
</span><span class="cx"> #include "ShouldGrandfatherStatistics.h"
</span><span class="cx"> #include "StorageAccessStatus.h"
</span><ins>+#include "WebPageProxy.h"
</ins><span class="cx"> #include "WebProcessCache.h"
</span><span class="cx"> #include "WebProcessMessages.h"
</span><span class="cx"> #include "WebProcessPool.h"
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessiosWKGeolocationProviderIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/ios/WKGeolocationProviderIOS.mm (247057 => 247058)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/ios/WKGeolocationProviderIOS.mm    2019-07-02 17:37:18 UTC (rev 247057)
+++ trunk/Source/WebKit/UIProcess/ios/WKGeolocationProviderIOS.mm       2019-07-02 17:47:26 UTC (rev 247058)
</span><span class="lines">@@ -36,6 +36,7 @@
</span><span class="cx"> #import "WKProcessPoolInternal.h"
</span><span class="cx"> #import "WKUIDelegatePrivate.h"
</span><span class="cx"> #import "WKWebView.h"
</span><ins>+#import "WebFrameProxy.h"
</ins><span class="cx"> #import "WebGeolocationManagerProxy.h"
</span><span class="cx"> #import "WebProcessPool.h"
</span><span class="cx"> #import "_WKGeolocationCoreLocationProvider.h"
</span></span></pre>
</div>
</div>

</body>
</html>