<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[246328] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/246328">246328</a></dd>
<dt>Author</dt> <dd>mcatanzaro@igalia.com</dd>
<dt>Date</dt> <dd>2019-06-11 12:33:57 -0700 (Tue, 11 Jun 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Unreviewed build warning fixes

Source/JavaScriptCore:

Silence -Wreturn-type warning

* wasm/WasmTable.cpp:
(JSC::Wasm::Table::tryCreate):

Source/WebCore:

Silence -Wunused-parameter warning

* testing/Internals.cpp:
(WebCore::Internals::storeRegistrationsOnDisk):

Source/WebKit:

Silence -Wunused-variable warning

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorewasmWasmTablecpp">trunk/Source/JavaScriptCore/wasm/WasmTable.cpp</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitUIProcessWebProcessPoolcpp">trunk/Source/WebKit/UIProcess/WebProcessPool.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (246327 => 246328)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/JavaScriptCore/ChangeLog       2019-06-11 19:33:57 UTC (rev 246328)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed build warning fixes
+
+        Silence -Wreturn-type warning
+
+        * wasm/WasmTable.cpp:
+        (JSC::Wasm::Table::tryCreate):
+
</ins><span class="cx"> 2019-06-11  Saam Barati  <sbarati@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Roll out PAC cage
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorewasmWasmTablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/wasm/WasmTable.cpp (246327 => 246328)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/wasm/WasmTable.cpp   2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/JavaScriptCore/wasm/WasmTable.cpp      2019-06-11 19:33:57 UTC (rev 246328)
</span><span class="lines">@@ -76,6 +76,8 @@
</span><span class="cx">     case TableElementType::Anyref:
</span><span class="cx">         return adoptRef(new Table(initial, maximum));
</span><span class="cx">     }
</span><ins>+
+    RELEASE_ASSERT_NOT_REACHED();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> Optional<uint32_t> Table::grow(uint32_t delta)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (246327 => 246328)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/WebCore/ChangeLog      2019-06-11 19:33:57 UTC (rev 246328)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed build warning fixes
+
+        Silence -Wunused-parameter warning
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::storeRegistrationsOnDisk):
+
</ins><span class="cx"> 2019-06-10  Simon Fraser  <simon.fraser@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Add logging for UI-side compositing hit-testing
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (246327 => 246328)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp       2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/WebCore/testing/Internals.cpp  2019-06-11 19:33:57 UTC (rev 246328)
</span><span class="lines">@@ -4806,6 +4806,8 @@
</span><span class="cx">     connection.storeRegistrationsOnDiskForTesting([promise = WTFMove(promise)]() mutable {
</span><span class="cx">         promise.resolve();
</span><span class="cx">     });
</span><ins>+#else
+    promise.resolve();
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (246327 => 246328)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/WebKit/ChangeLog       2019-06-11 19:33:57 UTC (rev 246328)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed build warning fixes
+
+        Silence -Wunused-variable warning
+
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):
+
</ins><span class="cx"> 2019-06-10  Simon Fraser  <simon.fraser@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Add logging for UI-side compositing hit-testing
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessWebProcessPoolcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (246327 => 246328)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2019-06-11 19:02:31 UTC (rev 246327)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp    2019-06-11 19:33:57 UTC (rev 246328)
</span><span class="lines">@@ -2597,7 +2597,8 @@
</span><span class="cx">     ASSERT_UNUSED(result, result);
</span><span class="cx"> 
</span><span class="cx">     auto* process = WebProcessProxy::processForIdentifier(processID);
</span><del>-    ASSERT(process);
</del><ins>+    ASSERT_UNUSED(process, process);
+
</ins><span class="cx">     RELEASE_LOG(ProcessSuspension, "Web process pid %u is no longer playing audible media", (unsigned)process->processIdentifier());
</span><span class="cx"> 
</span><span class="cx">     if (m_processesPlayingAudibleMedia.isEmpty()) {
</span></span></pre>
</div>
</div>

</body>
</html>