<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[245820] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/245820">245820</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2019-05-28 12:08:21 -0700 (Tue, 28 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>[Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
https://bugs.webkit.org/show_bug.cgi?id=197008

Patch by Antoine Quint <graouts@apple.com> on 2019-05-28
Reviewed by Jon Lee.

We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
the TestExpectations.

LayoutTests/imported/w3c:

* web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt:
* web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html:

LayoutTests:

* platform/mac/TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_suppress_compat_events_on_drag_mouseexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_suppress_compat_events_on_drag_mousehtml">trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (245819 => 245820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/ChangeLog 2019-05-28 19:08:21 UTC (rev 245820)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2019-05-28  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
+        https://bugs.webkit.org/show_bug.cgi?id=197008
+
+        Reviewed by Jon Lee.
+
+        We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
+        and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
+        the TestExpectations.
+
+        * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2019-05-28  Antti Koivisto  <antti@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [async scrolling] Fixed positioning inside stacking context overflow scroll is jumpy
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (245819 => 245820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2019-05-28 19:08:21 UTC (rev 245820)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2019-05-28  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
+        https://bugs.webkit.org/show_bug.cgi?id=197008
+
+        Reviewed by Jon Lee.
+
+        We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
+        and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
+        the TestExpectations.
+
+        * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt:
+        * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html:
+
</ins><span class="cx"> 2019-05-27  Oriol Brufau  <obrufau@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [css-grid] Preserve repeat() notation when serializing declared values
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_suppress_compat_events_on_drag_mouseexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt (245819 => 245820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt   2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt      2019-05-28 19:08:21 UTC (rev 245820)
</span><span class="lines">@@ -10,21 +10,11 @@
</span><span class="cx"> Done
</span><span class="cx"> The following pointer types were detected: mouse.
</span><span class="cx"> 
</span><del>-The following events were logged: mouseup@target0, mousedown@target1, mousemove@target1, mouseup@target1.
</del><ins>+The following events were logged: mousedown@target1, mousemove@target1, mouseup@target1.
</ins><span class="cx"> 
</span><span class="cx"> 
</span><del>-Harness Error (FAIL), message = 1 duplicate test name: "mouseup's time stamp should be the same as pointerup's time stamp."
-
</del><span class="cx"> PASS Suppress compat mouse events on drag 
</span><span class="cx"> PASS primary pointer pointerdown@target0 
</span><del>-PASS mouseup's time stamp should be the same as pointerup's time stamp. 
-PASS Pointer Event: Suppress compatibility mouse events on drag 
</del><span class="cx"> PASS primary pointer pointerdown@target1 
</span><del>-PASS mousedown's time stamp should be the same as pointerdown's time stamp. 
-PASS Pointer Event: Suppress compatibility mouse events on drag 1 
-PASS mousemove's time stamp should be the same as pointermove's time stamp. 
-FAIL Pointer Event: Suppress compatibility mouse events on drag 2 assert_equals: The time stamp of the compat mouse event should be the same as its pointerevent expected 100 but got 99
-PASS mouseup's time stamp should be the same as pointerup's time stamp. 
-PASS Pointer Event: Suppress compatibility mouse events on drag 3 
-FAIL Event log assert_equals: expected "mousedown@target1, mousemove@target1, mouseup@target1" but got "mouseup@target0, mousedown@target1, mousemove@target1, mouseup@target1"
</del><ins>+PASS Event log 
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_suppress_compat_events_on_drag_mousehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html (245819 => 245820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html   2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html      2019-05-28 19:08:21 UTC (rev 245820)
</span><span class="lines">@@ -46,7 +46,6 @@
</span><span class="cx">           var target_list = ["target0", "target1"];
</span><span class="cx">           var pointer_event_list = ["pointerdown" , "pointermove", "pointerup"];
</span><span class="cx">           var mouse_event_list = ["mousedown", "mouseup", "mousemove"];
</span><del>-          var last_pointer_event = null;
</del><span class="cx"> 
</span><span class="cx">           target_list.forEach(function(targetId) {
</span><span class="cx">               var target = document.getElementById(targetId);
</span><span class="lines">@@ -64,8 +63,6 @@
</span><span class="cx"> 
</span><span class="cx">                       if (label === "pointerdown@target0")
</span><span class="cx">                           event.preventDefault();
</span><del>-
-                      last_pointer_event = event;
</del><span class="cx">                   });
</span><span class="cx">               });
</span><span class="cx"> 
</span><span class="lines">@@ -77,11 +74,6 @@
</span><span class="cx">                       event_log.push(event.type + "@" + targetId);
</span><span class="cx"> 
</span><span class="cx">                       include_next_mousemove = (event.type == "mousedown");
</span><del>-                      test(function() {
-                          test(function () {
-                              assert_equals(event.timeStamp, last_pointer_event.timeStamp, "The time stamp of the compat mouse event should be the same as its pointerevent");
-                          });
-                      }, event.type + "'s time stamp should be the same as " + last_pointer_event.type + "'s time stamp.");
</del><span class="cx">                   });
</span><span class="cx">               });
</span><span class="cx">           });
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (245819 => 245820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations  2019-05-28 19:06:18 UTC (rev 245819)
+++ trunk/LayoutTests/platform/mac/TestExpectations     2019-05-28 19:08:21 UTC (rev 245820)
</span><span class="lines">@@ -1880,7 +1880,6 @@
</span><span class="cx"> imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-manual.html [ Skip ]
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/197005 imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_is_first.html [ Skip ]
</span><del>-webkit.org/b/197008 imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html [ Pass Failure ]
</del><span class="cx"> webkit.org/b/197007 imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_coordinates_when_locked.html [ Skip ]
</span><span class="cx"> webkit.org/b/197009 imported/w3c/web-platform-tests/pointerevents/pointerevent_setpointercapture_invalid_pointerid.html [ Failure Pass ]
</span><span class="cx"> webkit.org/b/197058 imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame.html [ Failure Pass ]
</span></span></pre>
</div>
</div>

</body>
</html>