<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[245584] trunk/LayoutTests/imported/w3c</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/245584">245584</a></dd>
<dt>Author</dt> <dd>graouts@webkit.org</dd>
<dt>Date</dt> <dd>2019-05-21 10:49:28 -0700 (Tue, 21 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>[Pointer Events] Do not dispatch pointermove events when the pointer is not down in WPT testdriver
https://bugs.webkit.org/show_bug.cgi?id=198071

Reviewed by Dean Jackson.

WPT actions sequences may move the pointer prior to pressing it down. In this case, we need to make sure we don't
end up queuing a "moved" touch and instead save the pointer position for when the pointer is pressed. It's important
to also generate a different touch id for each time we pause or end a touch sequence. This allows a few more WPT
touch tests to pass without any source change in our Pointer Events implementation.

* web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-expected.txt:
* web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch-expected.txt:
* web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch-expected.txt:
* web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-expected.txt:
* web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-expected.txt:
* web-platform-tests/resources/testdriver-vendor.js:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_pointerleave_after_pointercancel_touchexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_pointerout_after_pointercancel_touchexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_touchactionautocss_touchexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_touchactioninherit_highestparentnone_touchexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_touchactionpanxpany_touchexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsresourcestestdrivervendorjs">trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (245583 => 245584)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-21 17:30:41 UTC (rev 245583)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2019-05-21 17:49:28 UTC (rev 245584)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2019-05-21  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events] Do not dispatch pointermove events when the pointer is not down in WPT testdriver
+        https://bugs.webkit.org/show_bug.cgi?id=198071
+
+        Reviewed by Dean Jackson.
+
+        WPT actions sequences may move the pointer prior to pressing it down. In this case, we need to make sure we don't
+        end up queuing a "moved" touch and instead save the pointer position for when the pointer is pressed. It's important
+        to also generate a different touch id for each time we pause or end a touch sequence. This allows a few more WPT
+        touch tests to pass without any source change in our Pointer Events implementation.
+
+        * web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-expected.txt:
+        * web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch-expected.txt:
+        * web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch-expected.txt:
+        * web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-expected.txt:
+        * web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-expected.txt:
+        * web-platform-tests/resources/testdriver-vendor.js:
+
</ins><span class="cx"> 2019-05-17  Rob Buis  <rbuis@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Implement imagesrcset and imagesizes attributes on link rel=preload
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_pointerleave_after_pointercancel_touchexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-expected.txt (245583 => 245584)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-expected.txt 2019-05-21 17:30:41 UTC (rev 245583)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-expected.txt    2019-05-21 17:49:28 UTC (rev 245584)
</span><span class="lines">@@ -6,7 +6,7 @@
</span><span class="cx"> 
</span><span class="cx"> Pointer Events pointerleave tests
</span><span class="cx"> 
</span><del>-The following pointer types were detected: (none).
</del><ins>+The following pointer types were detected: touch.
</ins><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> FAIL pointerleave event received assert_true: pointerleave should be received before the test finishes expected true got false
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_pointerout_after_pointercancel_touchexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch-expected.txt (245583 => 245584)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch-expected.txt   2019-05-21 17:30:41 UTC (rev 245583)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch-expected.txt      2019-05-21 17:49:28 UTC (rev 245584)
</span><span class="lines">@@ -6,7 +6,7 @@
</span><span class="cx"> 
</span><span class="cx"> Pointer Events pointerout tests
</span><span class="cx"> 
</span><del>-The following pointer types were detected: (none).
</del><ins>+The following pointer types were detected: touch.
</ins><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> FAIL pointerout event received assert_true: pointerout should be received before the test finishes expected true got false
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_touchactionautocss_touchexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch-expected.txt (245583 => 245584)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch-expected.txt    2019-05-21 17:30:41 UTC (rev 245583)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch-expected.txt       2019-05-21 17:49:28 UTC (rev 245584)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> Pointer Events touch-action attribute support
</span><span class="cx"> 
</span><del>-Test Description: Try to scroll text RIGHT.
</del><ins>+Test Description: Test complete
</ins><span class="cx"> 
</span><span class="cx"> Note: this test is for touch-devices only
</span><span class="cx"> 
</span><span class="lines">@@ -73,5 +73,5 @@
</span><span class="cx"> The following pointer types were detected: touch.
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-FAIL touch-action attribute test assert_true: x-scroll and y-scroll should be received before the test finishes expected true got false
</del><ins>+PASS touch-action attribute test 
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_touchactioninherit_highestparentnone_touchexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-expected.txt (245583 => 245584)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-expected.txt 2019-05-21 17:30:41 UTC (rev 245583)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-expected.txt    2019-05-21 17:49:28 UTC (rev 245584)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> Pointer Events touch-action attribute support
</span><span class="cx"> 
</span><del>-Test Description: Try to scroll text RIGHT.
</del><ins>+Test Description: Test complete
</ins><span class="cx"> 
</span><span class="cx"> Note: this test is for touch-devices only
</span><span class="cx"> 
</span><span class="lines">@@ -73,5 +73,5 @@
</span><span class="cx"> The following pointer types were detected: touch.
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-FAIL touch-action attribute test assert_true: x-scroll and y-scroll should be received before the test finishes expected true got false
</del><ins>+PASS touch-action attribute test 
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestspointereventspointerevent_touchactionpanxpany_touchexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-expected.txt (245583 => 245584)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-expected.txt 2019-05-21 17:30:41 UTC (rev 245583)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-expected.txt    2019-05-21 17:49:28 UTC (rev 245584)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> Pointer Events touch-action attribute support
</span><span class="cx"> 
</span><del>-Test Description: Try to scroll text RIGHT.
</del><ins>+Test Description: Test complete
</ins><span class="cx"> 
</span><span class="cx"> Note: this test is for touch-devices only
</span><span class="cx"> 
</span><span class="lines">@@ -73,5 +73,5 @@
</span><span class="cx"> The following pointer types were detected: touch.
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-FAIL touch-action attribute test assert_true: x-scroll and y-scroll should be received before the test finishes expected true got false
</del><ins>+PASS touch-action attribute test 
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsresourcestestdrivervendorjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js (245583 => 245584)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2019-05-21 17:30:41 UTC (rev 245583)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js    2019-05-21 17:49:28 UTC (rev 245584)
</span><span class="lines">@@ -54,11 +54,14 @@
</span><span class="cx">     let x = 0;
</span><span class="cx">     let y = 0;
</span><span class="cx">     let timeOffset = 0;
</span><ins>+    let pointerDown = false;
+    let id = 1;
</ins><span class="cx"> 
</span><del>-    const events = actions.map(action => {
</del><ins>+    const events = [];
+    for (let action of actions) {
</ins><span class="cx">         const touch = {
</span><span class="cx">             inputType : "finger",
</span><del>-            id : 1,
</del><ins>+            id,
</ins><span class="cx">             x : action.x,
</span><span class="cx">             y : action.y,
</span><span class="cx">             pressure : 0
</span><span class="lines">@@ -83,16 +86,25 @@
</span><span class="cx">             }
</span><span class="cx">             break;
</span><span class="cx">         case "pointerDown":
</span><ins>+            pointerDown = true;
</ins><span class="cx">             touch.phase = "began";
</span><ins>+            if (action.x === undefined)
+                touch.x = x;
+            if (action.y === undefined)
+                touch.y = y;
</ins><span class="cx">             break;
</span><span class="cx">         case "pointerUp":
</span><ins>+            pointerDown = false;
</ins><span class="cx">             touch.phase = "ended";
</span><span class="cx">             touch.x = x;
</span><span class="cx">             touch.y = y;
</span><ins>+            id++;
</ins><span class="cx">             break;
</span><span class="cx">         case "pause":
</span><span class="cx">             timeOffsetIncrease = action.duration / 1000;
</span><span class="cx">             touch.phase = "stationary";
</span><ins>+            if (!pointerDown)
+                id++;
</ins><span class="cx">             break;
</span><span class="cx">         default:
</span><span class="cx">             return Promise.reject(new Error(`Unknown action type "${action.type}".`));
</span><span class="lines">@@ -100,10 +112,14 @@
</span><span class="cx"> 
</span><span class="cx">         x = touch.x;
</span><span class="cx">         y = touch.y;
</span><ins>+
+        if (!pointerDown && touch.phase == "moved")
+            continue;
+
</ins><span class="cx">         timeOffset += timeOffsetIncrease;
</span><span class="cx"> 
</span><del>-        return command;
-    });
</del><ins>+        events.push(command);
+    }
</ins><span class="cx"> 
</span><span class="cx">     const stream = JSON.stringify({ events });
</span><span class="cx">     logDebug(() => stream);
</span></span></pre>
</div>
</div>

</body>
</html>