<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[245518] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/245518">245518</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2019-05-20 10:24:20 -0700 (Mon, 20 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Hitpoint for link which spans two lines in web content is incorrect
https://bugs.webkit.org/show_bug.cgi?id=197511
<rdar://problem/49971483>

Patch by Andres Gonzalez <andresg_22@apple.com> on 2019-05-20
Reviewed by Chris Fleizach.

* accessibility/ios-simulator/links-activation.html:
* accessibility/links-activation-expected.txt:
* accessibility/links-activation.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilityiossimulatorlinksactivationhtml">trunk/LayoutTests/accessibility/ios-simulator/links-activation.html</a></li>
<li><a href="#trunkLayoutTestsaccessibilitylinksactivationexpectedtxt">trunk/LayoutTests/accessibility/links-activation-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitylinksactivationhtml">trunk/LayoutTests/accessibility/links-activation.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (245517 => 245518)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-05-20 17:14:33 UTC (rev 245517)
+++ trunk/LayoutTests/ChangeLog 2019-05-20 17:24:20 UTC (rev 245518)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2019-05-20  Andres Gonzalez  <andresg_22@apple.com>
+
+        Hitpoint for link which spans two lines in web content is incorrect
+        https://bugs.webkit.org/show_bug.cgi?id=197511
+        <rdar://problem/49971483>
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/ios-simulator/links-activation.html:
+        * accessibility/links-activation-expected.txt:
+        * accessibility/links-activation.html:
+
</ins><span class="cx"> 2019-05-20  Sihui Liu  <sihui_liu@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [ Mac WK2 iOS Sim] Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityiossimulatorlinksactivationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/ios-simulator/links-activation.html (245517 => 245518)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/ios-simulator/links-activation.html      2019-05-20 17:14:33 UTC (rev 245517)
+++ trunk/LayoutTests/accessibility/ios-simulator/links-activation.html 2019-05-20 17:24:20 UTC (rev 245518)
</span><span class="lines">@@ -37,8 +37,6 @@
</span><span class="cx">     };
</span><span class="cx"> 
</span><span class="cx">     if (window.accessibilityController) {
</span><del>-        window.jsTestIsAsync = true;
-
</del><span class="cx">         var link = accessibilityController.accessibleElementById("multiline-link");
</span><span class="cx">         shouldBeTrue("clickPointInsideFrame(link)");
</span><span class="cx">         link.press();
</span><span class="lines">@@ -46,11 +44,6 @@
</span><span class="cx">         link = accessibilityController.accessibleElementById("singleline-link");
</span><span class="cx">         shouldBeTrue("clickPointInsideFrame(link)");
</span><span class="cx">         link.press();
</span><del>-
-        setTimeout(
-            function() {
-                finishJSTest();
-            }, 10);
</del><span class="cx">     }
</span><span class="cx"> </script>
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitylinksactivationexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/links-activation-expected.txt (245517 => 245518)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/links-activation-expected.txt    2019-05-20 17:14:33 UTC (rev 245517)
+++ trunk/LayoutTests/accessibility/links-activation-expected.txt       2019-05-20 17:24:20 UTC (rev 245518)
</span><span class="lines">@@ -12,7 +12,9 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> click event [object MouseEvent] for element A with id multiline-link
</span><ins>+PASS clicked became true
</ins><span class="cx"> click event [object MouseEvent] for element A with id singleline-link
</span><ins>+PASS clicked became true
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx"> 
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitylinksactivationhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/links-activation.html (245517 => 245518)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/links-activation.html    2019-05-20 17:14:33 UTC (rev 245517)
+++ trunk/LayoutTests/accessibility/links-activation.html       2019-05-20 17:24:20 UTC (rev 245518)
</span><span class="lines">@@ -6,7 +6,9 @@
</span><span class="cx"> if (window.testRunner)
</span><span class="cx">     testRunner.dumpAsText();
</span><span class="cx"> 
</span><ins>+var clicked = false;
</ins><span class="cx"> function handleClick(event) {
</span><ins>+    clicked = true;
</ins><span class="cx">     debug("click event " + event
</span><span class="cx">           + " for element " + event.target.nodeName
</span><span class="cx">           + " with id " + event.target.id);
</span><span class="lines">@@ -35,14 +37,15 @@
</span><span class="cx"> 
</span><span class="cx">         var link = accessibilityController.accessibleElementById("multiline-link");
</span><span class="cx">         link.press();
</span><ins>+        shouldBecomeEqual("clicked", "true", function() {
+            clicked = false;
</ins><span class="cx"> 
</span><del>-        link = accessibilityController.accessibleElementById("singleline-link");
-        link.press();
-
-        setTimeout(
-            function() {
</del><ins>+            link = accessibilityController.accessibleElementById("singleline-link");
+            link.press();
+            shouldBecomeEqual("clicked", "true", function() {
</ins><span class="cx">                 finishJSTest();
</span><del>-            }, 10);
</del><ins>+            });
+        });
</ins><span class="cx">     }
</span><span class="cx"> </script>
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>