<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[245429] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/245429">245429</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2019-05-16 17:07:44 -0700 (Thu, 16 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
https://bugs.webkit.org/show_bug.cgi?id=197764
<rdar://problem/50649689>

Patch by Greg Doolittle <gr3g@apple.com> on 2019-05-16
Reviewed by Chris Fleizach.

Specifically these:
- ariaActiveDescendant
- ariaControls
- ariaDescribedBy
- ariaDetails
- ariaErrorMessage
- ariaFlowTo
- ariaLabelledBy
- ariaOwns

Source/WebCore:

Test: LayoutTests/accessibility/ARIA-reflections.html (updated)

* accessibility/AriaAttributes.idl:

LayoutTests:

* accessibility/ARIA-reflection-expected.txt: Updated.
* accessibility/ARIA-reflection.html: Updated.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilityARIAreflectionexpectedtxt">trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilityARIAreflectionhtml">trunk/LayoutTests/accessibility/ARIA-reflection.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAriaAttributesidl">trunk/Source/WebCore/accessibility/AriaAttributes.idl</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (245428 => 245429)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-05-17 00:01:31 UTC (rev 245428)
+++ trunk/LayoutTests/ChangeLog 2019-05-17 00:07:44 UTC (rev 245429)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2019-05-16  Greg Doolittle  <gr3g@apple.com>
+
+        AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
+        https://bugs.webkit.org/show_bug.cgi?id=197764
+        <rdar://problem/50649689>
+
+        Reviewed by Chris Fleizach.
+
+        Specifically these:
+        - ariaActiveDescendant
+        - ariaControls
+        - ariaDescribedBy
+        - ariaDetails
+        - ariaErrorMessage
+        - ariaFlowTo
+        - ariaLabelledBy
+        - ariaOwns
+
+        * accessibility/ARIA-reflection-expected.txt: Updated.
+        * accessibility/ARIA-reflection.html: Updated.
+
</ins><span class="cx"> 2019-05-16  John Wilander  <wilander@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Storage Access API: Call completion handlers in NetworkConnectionToWebProcess::hasStorageAccess() and NetworkConnectionToWebProcess::requestStorageAccess() when feature is off
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityARIAreflectionexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt (245428 => 245429)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt     2019-05-17 00:01:31 UTC (rev 245428)
+++ trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt        2019-05-17 00:07:44 UTC (rev 245429)
</span><span class="lines">@@ -12,14 +12,6 @@
</span><span class="cx"> element.setAttribute("role", otherData);
</span><span class="cx"> PASS element[currentProperty] is otherData
</span><span class="cx"> 
</span><del>-Test ariaActiveDescendant < - > aria-activedescendant
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaActiveDescendant"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-activedescendant", otherData);
-PASS element[currentProperty] is otherData
-
</del><span class="cx"> Test ariaAtomic < - > aria-atomic
</span><span class="cx"> PASS element[currentProperty] is null
</span><span class="cx"> PASS element.getAttribute(currentAttribute) is null
</span><span class="lines">@@ -76,14 +68,6 @@
</span><span class="cx"> element.setAttribute("aria-colspan", otherData);
</span><span class="cx"> PASS element[currentProperty] is otherData
</span><span class="cx"> 
</span><del>-Test ariaControls < - > aria-controls
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaControls"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-controls", otherData);
-PASS element[currentProperty] is otherData
-
</del><span class="cx"> Test ariaCurrent < - > aria-current
</span><span class="cx"> PASS element[currentProperty] is null
</span><span class="cx"> PASS element.getAttribute(currentAttribute) is null
</span><span class="lines">@@ -92,22 +76,6 @@
</span><span class="cx"> element.setAttribute("aria-current", otherData);
</span><span class="cx"> PASS element[currentProperty] is otherData
</span><span class="cx"> 
</span><del>-Test ariaDescribedBy < - > aria-describedby
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaDescribedBy"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-describedby", otherData);
-PASS element[currentProperty] is otherData
-
-Test ariaDetails < - > aria-details
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaDetails"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-details", otherData);
-PASS element[currentProperty] is otherData
-
</del><span class="cx"> Test ariaDisabled < - > aria-disabled
</span><span class="cx"> PASS element[currentProperty] is null
</span><span class="cx"> PASS element.getAttribute(currentAttribute) is null
</span><span class="lines">@@ -116,14 +84,6 @@
</span><span class="cx"> element.setAttribute("aria-disabled", otherData);
</span><span class="cx"> PASS element[currentProperty] is otherData
</span><span class="cx"> 
</span><del>-Test ariaErrorMessage < - > aria-errormessage
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaErrorMessage"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-errormessage", otherData);
-PASS element[currentProperty] is otherData
-
</del><span class="cx"> Test ariaExpanded < - > aria-expanded
</span><span class="cx"> PASS element[currentProperty] is null
</span><span class="cx"> PASS element.getAttribute(currentAttribute) is null
</span><span class="lines">@@ -132,14 +92,6 @@
</span><span class="cx"> element.setAttribute("aria-expanded", otherData);
</span><span class="cx"> PASS element[currentProperty] is otherData
</span><span class="cx"> 
</span><del>-Test ariaFlowTo < - > aria-flowto
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaFlowTo"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-flowto", otherData);
-PASS element[currentProperty] is otherData
-
</del><span class="cx"> Test ariaHasPopup < - > aria-haspopup
</span><span class="cx"> PASS element[currentProperty] is null
</span><span class="cx"> PASS element.getAttribute(currentAttribute) is null
</span><span class="lines">@@ -180,14 +132,6 @@
</span><span class="cx"> element.setAttribute("aria-label", otherData);
</span><span class="cx"> PASS element[currentProperty] is otherData
</span><span class="cx"> 
</span><del>-Test ariaLabelledBy < - > aria-labelledby
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaLabelledBy"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-labelledby", otherData);
-PASS element[currentProperty] is otherData
-
</del><span class="cx"> Test ariaLevel < - > aria-level
</span><span class="cx"> PASS element[currentProperty] is null
</span><span class="cx"> PASS element.getAttribute(currentAttribute) is null
</span><span class="lines">@@ -236,14 +180,6 @@
</span><span class="cx"> element.setAttribute("aria-orientation", otherData);
</span><span class="cx"> PASS element[currentProperty] is otherData
</span><span class="cx"> 
</span><del>-Test ariaOwns < - > aria-owns
-PASS element[currentProperty] is null
-PASS element.getAttribute(currentAttribute) is null
-element["ariaOwns"] = data;
-PASS element.getAttribute(currentAttribute) is data
-element.setAttribute("aria-owns", otherData);
-PASS element[currentProperty] is otherData
-
</del><span class="cx"> Test ariaPlaceholder < - > aria-placeholder
</span><span class="cx"> PASS element[currentProperty] is null
</span><span class="cx"> PASS element.getAttribute(currentAttribute) is null
</span><span class="lines">@@ -381,7 +317,7 @@
</span><span class="cx"> PASS element[currentProperty] is otherData
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-PASS count is 46
</del><ins>+PASS count is 38
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx"> 
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityARIAreflectionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/ARIA-reflection.html (245428 => 245429)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/ARIA-reflection.html     2019-05-17 00:01:31 UTC (rev 245428)
+++ trunk/LayoutTests/accessibility/ARIA-reflection.html        2019-05-17 00:07:44 UTC (rev 245429)
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         debug("\n");
</span><del>-        shouldBe("count", "46");
</del><ins>+        shouldBe("count", "38");
</ins><span class="cx"> 
</span><span class="cx">     } else {
</span><span class="cx">         testFailed("Could not load accessibility controller");
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (245428 => 245429)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-05-17 00:01:31 UTC (rev 245428)
+++ trunk/Source/WebCore/ChangeLog      2019-05-17 00:07:44 UTC (rev 245429)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2019-05-16  Greg Doolittle  <gr3g@apple.com>
+
+        AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
+        https://bugs.webkit.org/show_bug.cgi?id=197764
+        <rdar://problem/50649689>
+
+        Reviewed by Chris Fleizach.
+
+        Specifically these:
+        - ariaActiveDescendant
+        - ariaControls
+        - ariaDescribedBy
+        - ariaDetails
+        - ariaErrorMessage
+        - ariaFlowTo
+        - ariaLabelledBy
+        - ariaOwns
+
+        Test: LayoutTests/accessibility/ARIA-reflections.html (updated)
+
+        * accessibility/AriaAttributes.idl:
+
</ins><span class="cx"> 2019-05-16  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         CoreAudioCaptureSource should be marked as an audio capture track
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAriaAttributesidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AriaAttributes.idl (245428 => 245429)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AriaAttributes.idl    2019-05-17 00:01:31 UTC (rev 245428)
+++ trunk/Source/WebCore/accessibility/AriaAttributes.idl       2019-05-17 00:07:44 UTC (rev 245429)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx">     EnabledAtRuntime=AriaReflection,
</span><span class="cx">     NoInterfaceObject,
</span><span class="cx"> ] interface AriaAttributes {
</span><del>-    [Reflect=aria_activedescendant] attribute DOMString? ariaActiveDescendant;
</del><span class="cx">     [Reflect=aria_atomic]           attribute DOMString? ariaAtomic;
</span><span class="cx">     [Reflect=aria_autocomplete]     attribute DOMString? ariaAutoComplete;
</span><span class="cx">     [Reflect=aria_busy]             attribute DOMString? ariaBusy;
</span><span class="lines">@@ -35,20 +34,14 @@
</span><span class="cx">     [Reflect=aria_colcount]         attribute DOMString? ariaColCount;
</span><span class="cx">     [Reflect=aria_colindex]         attribute DOMString? ariaColIndex;
</span><span class="cx">     [Reflect=aria_colspan]          attribute DOMString? ariaColSpan;
</span><del>-    [Reflect=aria_controls]         attribute DOMString? ariaControls;
</del><span class="cx">     [Reflect=aria_current]          attribute DOMString? ariaCurrent;
</span><del>-    [Reflect=aria_describedby]      attribute DOMString? ariaDescribedBy;
-    [Reflect=aria_details]          attribute DOMString? ariaDetails;
</del><span class="cx">     [Reflect=aria_disabled]         attribute DOMString? ariaDisabled;
</span><del>-    [Reflect=aria_errormessage]     attribute DOMString? ariaErrorMessage;
</del><span class="cx">     [Reflect=aria_expanded]         attribute DOMString? ariaExpanded;
</span><del>-    [Reflect=aria_flowto]           attribute DOMString? ariaFlowTo;
</del><span class="cx">     [Reflect=aria_haspopup]         attribute DOMString? ariaHasPopup;
</span><span class="cx">     [Reflect=aria_hidden]           attribute DOMString? ariaHidden;
</span><span class="cx">     [Reflect=aria_invalid]          attribute DOMString? ariaInvalid;
</span><span class="cx">     [Reflect=aria_keyshortcuts]     attribute DOMString? ariaKeyShortcuts;
</span><span class="cx">     [Reflect=aria_label]            attribute DOMString? ariaLabel;
</span><del>-    [Reflect=aria_labelledby]       attribute DOMString? ariaLabelledBy;
</del><span class="cx">     [Reflect=aria_level]            attribute DOMString? ariaLevel;
</span><span class="cx">     [Reflect=aria_live]             attribute DOMString? ariaLive;
</span><span class="cx">     [Reflect=aria_modal]            attribute DOMString? ariaModal;
</span><span class="lines">@@ -55,7 +48,6 @@
</span><span class="cx">     [Reflect=aria_multiline]        attribute DOMString? ariaMultiLine;
</span><span class="cx">     [Reflect=aria_multiselectable]  attribute DOMString? ariaMultiSelectable;
</span><span class="cx">     [Reflect=aria_orientation]      attribute DOMString? ariaOrientation;
</span><del>-    [Reflect=aria_owns]             attribute DOMString? ariaOwns;
</del><span class="cx">     [Reflect=aria_placeholder]      attribute DOMString? ariaPlaceholder;
</span><span class="cx">     [Reflect=aria_posinset]         attribute DOMString? ariaPosInSet;
</span><span class="cx">     [Reflect=aria_pressed]          attribute DOMString? ariaPressed;
</span></span></pre>
</div>
</div>

</body>
</html>