<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[245362] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/245362">245362</a></dd>
<dt>Author</dt> <dd>drousso@apple.com</dd>
<dt>Date</dt> <dd>2019-05-15 15:36:34 -0700 (Wed, 15 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/242741">r242741</a>) [Mac WK1 Debug] Layout Test inspector/timeline/exception-in-injected-script-while-recording.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=197442
<rdar://problem/50354090>

Reviewed by Joseph Pecoraro.

Ever since <a href="http://trac.webkit.org/projects/webkit/changeset/198774">r198774</a>, we don't allow a timeline recording to be active at the same time as the
debugger being paused. As such, these tests are unnecessary.

* inspector/timeline/debugger-paused-while-recording.html: Removed.
* inspector/timeline/debugger-paused-while-recording-expected.txt: Removed.
* inspector/timeline/exception-in-injected-script-while-recording.html: Removed.
* inspector/timeline/exception-in-injected-script-while-recording-expected.txt: Removed.
* inspector/timeline/resources/timeline-helper.js: Removed.
* TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
</ul>

<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsinspectortimelinedebuggerpausedwhilerecordingexpectedtxt">trunk/LayoutTests/inspector/timeline/debugger-paused-while-recording-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectortimelinedebuggerpausedwhilerecordinghtml">trunk/LayoutTests/inspector/timeline/debugger-paused-while-recording.html</a></li>
<li><a href="#trunkLayoutTestsinspectortimelineexceptionininjectedscriptwhilerecordingexpectedtxt">trunk/LayoutTests/inspector/timeline/exception-in-injected-script-while-recording-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectortimelineexceptionininjectedscriptwhilerecordinghtml">trunk/LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html</a></li>
<li><a href="#trunkLayoutTestsinspectortimelineresourcestimelinehelperjs">trunk/LayoutTests/inspector/timeline/resources/timeline-helper.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (245361 => 245362)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-05-15 22:34:09 UTC (rev 245361)
+++ trunk/LayoutTests/ChangeLog 2019-05-15 22:36:34 UTC (rev 245362)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2019-05-15  Devin Rousso  <drousso@apple.com>
+
+        REGRESSION (r242741) [Mac WK1 Debug] Layout Test inspector/timeline/exception-in-injected-script-while-recording.html is a flaky crash
+        https://bugs.webkit.org/show_bug.cgi?id=197442
+        <rdar://problem/50354090>
+
+        Reviewed by Joseph Pecoraro.
+
+        Ever since r198774, we don't allow a timeline recording to be active at the same time as the
+        debugger being paused. As such, these tests are unnecessary.
+
+        * inspector/timeline/debugger-paused-while-recording.html: Removed.
+        * inspector/timeline/debugger-paused-while-recording-expected.txt: Removed.
+        * inspector/timeline/exception-in-injected-script-while-recording.html: Removed.
+        * inspector/timeline/exception-in-injected-script-while-recording-expected.txt: Removed.
+        * inspector/timeline/resources/timeline-helper.js: Removed.
+        * TestExpectations:
+
</ins><span class="cx"> 2019-05-15  Zalan Bujtas  <zalan@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Do not create a shape object outside of the layout context
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (245361 => 245362)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations       2019-05-15 22:34:09 UTC (rev 245361)
+++ trunk/LayoutTests/TestExpectations  2019-05-15 22:36:34 UTC (rev 245362)
</span><span class="lines">@@ -534,9 +534,6 @@
</span><span class="cx"> webkit.org/b/128736 inspector/debugger/setBreakpoint-dfg.html [ Failure Pass ]
</span><span class="cx"> webkit.org/b/134982 inspector/debugger/setBreakpoint-dfg-and-modify-local.html [ Failure Pass ]
</span><span class="cx"> 
</span><del>-webkit.org/b/142208 inspector/timeline/debugger-paused-while-recording.html [ Skip ]
-webkit.org/b/142208 inspector/timeline/exception-in-injected-script-while-recording.html [ Skip ]
-
</del><span class="cx"> # This test is fast enough in release but quite slow in debug builds.
</span><span class="cx"> [ Debug ] inspector/debugger/debugger-stack-overflow.html [ Skip ]
</span><span class="cx"> [ Debug ] inspector/canvas/recording-2d.html [ Slow ]
</span></span></pre></div>
<a id="trunkLayoutTestsinspectortimelinedebuggerpausedwhilerecordingexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector/timeline/debugger-paused-while-recording-expected.txt (245361 => 245362)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/timeline/debugger-paused-while-recording-expected.txt        2019-05-15 22:34:09 UTC (rev 245361)
+++ trunk/LayoutTests/inspector/timeline/debugger-paused-while-recording-expected.txt   2019-05-15 22:36:34 UTC (rev 245362)
</span><span class="lines">@@ -1,8 +0,0 @@
</span><del>-Testing that profiling data is correctly generated and attached to Timeline records when the debugger pauses and resumes while capturing timelines.
-
-Added a breakpoint inside hook().
-Debugger paused; resuming...
-Debugger resumed; stopping timeline capture.
-Timeline capturing stopped. Inspecting the active recording....
-TimerFired timeline record has profile attached: TRUE
-
</del></span></pre></div>
<a id="trunkLayoutTestsinspectortimelinedebuggerpausedwhilerecordinghtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector/timeline/debugger-paused-while-recording.html (245361 => 245362)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/timeline/debugger-paused-while-recording.html        2019-05-15 22:34:09 UTC (rev 245361)
+++ trunk/LayoutTests/inspector/timeline/debugger-paused-while-recording.html   2019-05-15 22:36:34 UTC (rev 245362)
</span><span class="lines">@@ -1,85 +0,0 @@
</span><del>-<!doctype html>
-<html>
-<head>
-<meta http-equiv="Content-Security-Policy" content="script-src 'self' 'unsafe-inline'">
-<script src="../../http/tests/inspector/resources/inspector-test.js"></script>
-<script src="./resources/timeline-helper.js"></script>
-<script>
-function installTimer()
-{
-    setTimeout(function() {
-        callFunction(mul, add(1, 3), 3);
-        hook();
-    });
-}
-
-function add(a, b)
-{
-    TestPage.addResult("Calling add(): " + a + " + " + b);
-    return a + b;
-}
-
-function mul(a, b)
-{
-    TestPage.addResult("Calling mul(): " + a + " * " + b);
-    return a * b;
-}
-
-function test()
-{
-    // First, set up the breakpoint, start timeline capturing, and trigger execution of installTimer().
-    WI.debuggerManager.addEventListener(WI.DebuggerManager.Event.ScriptAdded, function(event) {
-        var scriptObject = event.data.script;
-
-        if (!/timeline-helper\.js$/.test(scriptObject.url))
-            return;
-
-        var location = scriptObject.createSourceCodeLocation(17, 0);  // Inside timeline-helper.js:hook()
-        var breakpoint = new WI.Breakpoint(location);
-        WI.debuggerManager.addBreakpoint(breakpoint);
-        InspectorTest.addResult("Added a breakpoint inside hook().")
-
-        WI.timelineManager.startCapturing();
-        InspectorTest.evaluateInPage("installTimer()");
-    });
-
-    // Second, the debugger will pause during timeline capturing. Resume, then stop timeline capturing.
-    WI.debuggerManager.addEventListener(WI.DebuggerManager.Event.Paused, function(event) {
-            InspectorTest.addResult("Debugger paused; resuming...");
-
-            WI.debuggerManager.resume().then(function() {
-                InspectorTest.addResult("Debugger resumed; stopping timeline capture.");
-                WI.timelineManager.stopCapturing();
-            })
-    });
-
-    // When timeline capturing stops, inspect the resulting timeline records for a profile.
-    WI.timelineManager.addEventListener(WI.TimelineManager.Event.CapturingStateChanged, (event) => {
-        if (WI.timelineManager.capturingState !== WI.TimelineManager.CapturingState.Inactive)
-            return;
-
-        var recording = WI.timelineManager.activeRecording;
-        var scriptTimeline = recording.timelines.get(WI.TimelineRecord.Type.Script);
-        console.assert(scriptTimeline);
-
-        InspectorTest.addResult("Timeline capturing stopped. Inspecting the active recording....");
-
-        for (var record of scriptTimeline.records) {
-            if (record.eventType !== WI.ScriptTimelineRecord.EventType.TimerFired)
-                continue;
-
-            var result = record.profile ? "TRUE" : "FALSE";
-            InspectorTest.addResult("TimerFired timeline record has profile attached: " + result);
-        }
-
-        InspectorTest.completeTest();
-    });
-
-    InspectorTest.reloadPage();
-}
-</script>
-</head>
-<body onload="runTest()">
-    <p>Testing that profiling data is correctly generated and attached to Timeline records when the debugger pauses and resumes while capturing timelines.</p>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsinspectortimelineexceptionininjectedscriptwhilerecordingexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector/timeline/exception-in-injected-script-while-recording-expected.txt (245361 => 245362)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/timeline/exception-in-injected-script-while-recording-expected.txt   2019-05-15 22:34:09 UTC (rev 245361)
+++ trunk/LayoutTests/inspector/timeline/exception-in-injected-script-while-recording-expected.txt      2019-05-15 22:36:34 UTC (rev 245362)
</span><span class="lines">@@ -1,9 +0,0 @@
</span><del>-Testing that an injected script, run while the debugger is paused and the timeline profiler is enabled, should not loop forever if it has an exception thrown.
-
-Added a breakpoint inside hook().
-Debugger paused;
-An exception was thrown from the injected script.
-Debugger resumed; stopping timeline capture.
-Timeline capturing stopped. Inspecting the active recording....
-TimerFired timeline record has profile attached: TRUE
-
</del></span></pre></div>
<a id="trunkLayoutTestsinspectortimelineexceptionininjectedscriptwhilerecordinghtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html (245361 => 245362)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html   2019-05-15 22:34:09 UTC (rev 245361)
+++ trunk/LayoutTests/inspector/timeline/exception-in-injected-script-while-recording.html      2019-05-15 22:36:34 UTC (rev 245362)
</span><span class="lines">@@ -1,91 +0,0 @@
</span><del>-<!doctype html>
-<html>
-<head>
-<meta http-equiv="Content-Security-Policy" content="script-src 'self' 'unsafe-inline'">
-<script src="../../http/tests/inspector/resources/inspector-test.js"></script>
-<script src="./resources/timeline-helper.js"></script>
-<script>
-function installTimer()
-{
-    setTimeout(function() {
-        callFunction(mul, add(1, 3), 3);
-        hook();
-    });
-}
-
-function add(a, b)
-{
-    TestPage.addResult("Calling add(): " + a + " + " + b);
-    return a + b;
-}
-
-function mul(a, b)
-{
-    TestPage.addResult("Calling mul(): " + a + " * " + b);
-    return a * b;
-}
-
-function test()
-{
-    // First, set up the breakpoint, start timeline capturing, and trigger execution of installTimer().
-    WI.debuggerManager.addEventListener(WI.DebuggerManager.Event.ScriptAdded, function(event) {
-        var scriptObject = event.data.script;
-
-        if (!/timeline-helper\.js$/.test(scriptObject.url))
-            return;
-
-        var location = scriptObject.createSourceCodeLocation(17, 0);  // Inside timeline-helper.js:hook()
-        var breakpoint = new WI.Breakpoint(location);
-        WI.debuggerManager.addBreakpoint(breakpoint);
-        InspectorTest.addResult("Added a breakpoint inside hook().")
-
-        WI.timelineManager.startCapturing();
-        InspectorTest.evaluateInPage("installTimer()");
-    });
-
-    // Second, the debugger will pause during timeline capturing. Resume, then stop timeline capturing.
-    WI.debuggerManager.addEventListener(WI.DebuggerManager.Event.Paused, function(event) {
-        InspectorTest.addResult("Debugger paused;");
-        checkIfExceptionLoopsForever();
-    });
-
-    function checkIfExceptionLoopsForever() {
-        WI.runtimeManager.evaluateInInspectedWindow("({}).x.x", {objectGroup: "test", includeCommandLineAPI: true, doNotPauseOnExceptionsAndMuteConsole: true}, function(result, wasThrown) {
-            InspectorTest.addResult("An exception was " + (wasThrown ? "" : "not ") + "thrown from the injected script.");
-            WI.debuggerManager.resume().then(function() {
-                InspectorTest.addResult("Debugger resumed; stopping timeline capture.");
-                WI.timelineManager.stopCapturing();
-            });
-        });
-    }
-
-    // When timeline capturing stops, inspect the resulting timeline records for a profile.
-    WI.timelineManager.addEventListener(WI.TimelineManager.Event.CapturingStateChanged, (event) => {
-        if (WI.timelineManager.capturingState !== WI.TimelineManager.CapturingState.Inactive)
-            return;
-
-        var recording = WI.timelineManager.activeRecording;
-        var scriptTimeline = recording.timelines.get(WI.TimelineRecord.Type.Script);
-        console.assert(scriptTimeline);
-
-        InspectorTest.addResult("Timeline capturing stopped. Inspecting the active recording....");
-
-        for (var record of scriptTimeline.records) {
-            if (record.eventType !== WI.ScriptTimelineRecord.EventType.TimerFired)
-                continue;
-
-            var result = record.profile ? "TRUE" : "FALSE";
-            InspectorTest.addResult("TimerFired timeline record has profile attached: " + result);
-        }
-
-        InspectorTest.completeTest();
-    });
-
-    InspectorTest.reloadPage();
-}
-</script>
-</head>
-<body onload="runTest()">
-    <p>Testing that an injected script, run while the debugger is paused and the timeline profiler is enabled, should not loop forever if it has an exception thrown.</p>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsinspectortimelineresourcestimelinehelperjs"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector/timeline/resources/timeline-helper.js (245361 => 245362)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/timeline/resources/timeline-helper.js        2019-05-15 22:34:09 UTC (rev 245361)
+++ trunk/LayoutTests/inspector/timeline/resources/timeline-helper.js   2019-05-15 22:36:34 UTC (rev 245362)
</span><span class="lines">@@ -1,19 +0,0 @@
</span><del>-// WARNING: some tests blindly set breakpoints in this file by line number.
-// So, if you modify the code, make sure to adjust any createSourceCodeLocation
-// calls from tests in the ../ directory. Callsites should include a description
-// of the function/statement to set a breakpoint at, so that it's easy to fix them.
-
-function callFunction(fn)
-{
-    if (!(fn instanceof Function))
-        return;
-
-    var argsArray = Array.prototype.slice.call(arguments);
-    Array.prototype.splice.call(argsArray, 0, 1);
-    fn.call(this, argsArray);
-}
-
-function hook()
-{
-    return 42;
-}
</del></span></pre>
</div>
</div>

</body>
</html>