<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[245391] branches/safari-608.1.24-branch</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/245391">245391</a></dd>
<dt>Author</dt> <dd>kocsen_chung@apple.com</dd>
<dt>Date</dt> <dd>2019-05-15 23:02:03 -0700 (Wed, 15 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Cherry-pick <a href="http://trac.webkit.org/projects/webkit/changeset/245220">r245220</a>. rdar://problem/50686229

    When the set of backing-sharing layers changes, we need to issue a repaint
    https://bugs.webkit.org/show_bug.cgi?id=197825

    Reviewed by Zalan Bujtas.

    Source/WebCore:

    If the set of layers painting into a shared backing store changes, we need
    to repaint that backing store. This happens when scrolling as shared layers
    enter the visible area.

    Test: compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html

    * rendering/RenderLayerBacking.cpp:
    (WebCore::RenderLayerBacking::setBackingSharingLayers):

    LayoutTests:

    * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html: Added.
    * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html: Added.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245220 268f45cc-cd09-0410-ab3c-d52691b4dbfc</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari608124branchLayoutTestsChangeLog">branches/safari-608.1.24-branch/LayoutTests/ChangeLog</a></li>
<li><a href="#branchessafari608124branchSourceWebCoreChangeLog">branches/safari-608.1.24-branch/Source/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari608124branchSourceWebCorerenderingRenderLayerBackingcpp">branches/safari-608.1.24-branch/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#branchessafari608124branchLayoutTestscompositingsharedbackingoverflowscrollrepaintsharedonscrollexpectedhtml">branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html</a></li>
<li><a href="#branchessafari608124branchLayoutTestscompositingsharedbackingoverflowscrollrepaintsharedonscrollhtml">branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari608124branchLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-608.1.24-branch/LayoutTests/ChangeLog (245390 => 245391)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-608.1.24-branch/LayoutTests/ChangeLog    2019-05-16 06:01:59 UTC (rev 245390)
+++ branches/safari-608.1.24-branch/LayoutTests/ChangeLog       2019-05-16 06:02:03 UTC (rev 245391)
</span><span class="lines">@@ -1,5 +1,43 @@
</span><span class="cx"> 2019-05-15  Kocsen Chung  <kocsen_chung@apple.com>
</span><span class="cx"> 
</span><ins>+        Cherry-pick r245220. rdar://problem/50686229
+
+    When the set of backing-sharing layers changes, we need to issue a repaint
+    https://bugs.webkit.org/show_bug.cgi?id=197825
+    
+    Reviewed by Zalan Bujtas.
+    
+    Source/WebCore:
+    
+    If the set of layers painting into a shared backing store changes, we need
+    to repaint that backing store. This happens when scrolling as shared layers
+    enter the visible area.
+    
+    Test: compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html
+    
+    * rendering/RenderLayerBacking.cpp:
+    (WebCore::RenderLayerBacking::setBackingSharingLayers):
+    
+    LayoutTests:
+    
+    * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html: Added.
+    * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html: Added.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-05-12  Simon Fraser  <simon.fraser@apple.com>
+
+            When the set of backing-sharing layers changes, we need to issue a repaint
+            https://bugs.webkit.org/show_bug.cgi?id=197825
+
+            Reviewed by Zalan Bujtas.
+
+            * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html: Added.
+            * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html: Added.
+
+2019-05-15  Kocsen Chung  <kocsen_chung@apple.com>
+
</ins><span class="cx">         Cherry-pick r245205. rdar://problem/50652127
</span><span class="cx"> 
</span><span class="cx">     Backing-sharing layers with transforms render incorrectly
</span></span></pre></div>
<a id="branchessafari608124branchLayoutTestscompositingsharedbackingoverflowscrollrepaintsharedonscrollexpectedhtml"></a>
<div class="addfile"><h4>Added: branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html (0 => 245391)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html                            (rev 0)
+++ branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html       2019-05-16 06:02:03 UTC (rev 245391)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
+<html>
+<head>
+    <style>
+        .scrollable {
+            overflow-y: scroll;
+            height: 300px;
+            width: 300px;
+            margin: 10px;
+            border: 1px solid black;
+        }
+               
+               .box.sharing {
+            background-color: blue;
+               }
+               
+               .box {
+                       position: relative;
+                       top: 50px;
+                       left: 50px;
+            width: 180px;
+            height: 180px;
+            background-color: green;
+               }
+
+        .spacer {
+            height: 500px;
+        }
+    </style>
+</head>
+<body>
+    <div class="scrollable">
+        <div class="sharing box">
+                       <div class="inner box"></div>
+        </div>
+        <div class="spacer"></div>
+    </div>
+</body>
+</html>
+
</ins></span></pre></div>
<a id="branchessafari608124branchLayoutTestscompositingsharedbackingoverflowscrollrepaintsharedonscrollhtml"></a>
<div class="addfile"><h4>Added: branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html (0 => 245391)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html                             (rev 0)
+++ branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html        2019-05-16 06:02:03 UTC (rev 245391)
</span><span class="lines">@@ -0,0 +1,57 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
+<html>
+<head>
+    <title>Tests repaints of shared backing when the sharing layers change</title>
+    <style>
+        .scrollable {
+            overflow-y: scroll;
+            height: 300px;
+            width: 300px;
+            margin: 10px;
+            border: 1px solid black;
+        }
+               
+               .box.sharing {
+            background-color: blue;
+               }
+               
+               .box {
+                       position: relative;
+                       top: 50px;
+                       left: 50px;
+            width: 180px;
+            height: 180px;
+            background-color: green;
+               }
+
+        .spacer {
+            height: 500px;
+        }
+    </style>
+    <script>
+        if (window.testRunner)
+            testRunner.waitUntilDone();
+
+        window.addEventListener('load', () => {
+            let scroller = document.querySelector('.scrollable');
+            requestAnimationFrame(() => {
+                scroller.scrollTop = 250;
+                requestAnimationFrame(() => {
+                    scroller.scrollTop = 0;
+                    if (window.testRunner)
+                        testRunner.notifyDone();
+                });
+            });
+        }, false);
+    </script>
+</head>
+<body>
+    <div class="scrollable">
+        <div class="sharing box">
+                       <div class="inner box"></div>
+        </div>
+        <div class="spacer"></div>
+    </div>
+</body>
+</html>
+
</ins></span></pre></div>
<a id="branchessafari608124branchSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-608.1.24-branch/Source/WebCore/ChangeLog (245390 => 245391)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-608.1.24-branch/Source/WebCore/ChangeLog 2019-05-16 06:01:59 UTC (rev 245390)
+++ branches/safari-608.1.24-branch/Source/WebCore/ChangeLog    2019-05-16 06:02:03 UTC (rev 245391)
</span><span class="lines">@@ -1,5 +1,49 @@
</span><span class="cx"> 2019-05-15  Kocsen Chung  <kocsen_chung@apple.com>
</span><span class="cx"> 
</span><ins>+        Cherry-pick r245220. rdar://problem/50686229
+
+    When the set of backing-sharing layers changes, we need to issue a repaint
+    https://bugs.webkit.org/show_bug.cgi?id=197825
+    
+    Reviewed by Zalan Bujtas.
+    
+    Source/WebCore:
+    
+    If the set of layers painting into a shared backing store changes, we need
+    to repaint that backing store. This happens when scrolling as shared layers
+    enter the visible area.
+    
+    Test: compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html
+    
+    * rendering/RenderLayerBacking.cpp:
+    (WebCore::RenderLayerBacking::setBackingSharingLayers):
+    
+    LayoutTests:
+    
+    * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html: Added.
+    * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html: Added.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-05-12  Simon Fraser  <simon.fraser@apple.com>
+
+            When the set of backing-sharing layers changes, we need to issue a repaint
+            https://bugs.webkit.org/show_bug.cgi?id=197825
+
+            Reviewed by Zalan Bujtas.
+
+            If the set of layers painting into a shared backing store changes, we need
+            to repaint that backing store. This happens when scrolling as shared layers
+            enter the visible area.
+
+            Test: compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html
+
+            * rendering/RenderLayerBacking.cpp:
+            (WebCore::RenderLayerBacking::setBackingSharingLayers):
+
+2019-05-15  Kocsen Chung  <kocsen_chung@apple.com>
+
</ins><span class="cx">         Cherry-pick r245218. rdar://problem/50705506
</span><span class="cx"> 
</span><span class="cx">     Refactor composited backing-sharing code
</span></span></pre></div>
<a id="branchessafari608124branchSourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: branches/safari-608.1.24-branch/Source/WebCore/rendering/RenderLayerBacking.cpp (245390 => 245391)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-608.1.24-branch/Source/WebCore/rendering/RenderLayerBacking.cpp  2019-05-16 06:01:59 UTC (rev 245390)
+++ branches/safari-608.1.24-branch/Source/WebCore/rendering/RenderLayerBacking.cpp     2019-05-16 06:02:03 UTC (rev 245391)
</span><span class="lines">@@ -281,6 +281,10 @@
</span><span class="cx"> void RenderLayerBacking::setBackingSharingLayers(Vector<WeakPtr<RenderLayer>>&& sharingLayers)
</span><span class="cx"> {
</span><span class="cx">     clearBackingSharingLayerProviders(m_backingSharingLayers);
</span><ins>+
+    if (sharingLayers != m_backingSharingLayers)
+        setContentsNeedDisplay(); // This could be optimize to only repaint rects for changed layers.
+
</ins><span class="cx">     m_backingSharingLayers = WTFMove(sharingLayers);
</span><span class="cx"> 
</span><span class="cx">     for (auto& layerWeakPtr : m_backingSharingLayers)
</span></span></pre>
</div>
</div>

</body>
</html>