<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[245288] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/245288">245288</a></dd>
<dt>Author</dt> <dd>ysuzuki@apple.com</dd>
<dt>Date</dt> <dd>2019-05-14 10:31:53 -0700 (Tue, 14 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>[JSC] Shrink sizeof(UnlinkedFunctionExecutable) more
https://bugs.webkit.org/show_bug.cgi?id=197833

Reviewed by Darin Adler.

JSTests:

* stress/generator-name.js: Added.
(shouldBe):
(gen):
(catch):

Source/JavaScriptCore:

It turns out that Gmail creates so many JSFunctions, FunctionExecutables, and UnlinkedFunctionExecutables.
So we should shrink size of them to save memory. As a first step, this patch reduces the sizeof(UnlinkedFunctionExecutable) more by 16 bytes.

1. We reorder some fields to get 8 bytes. And we use 31 bits for xxx offset things since their maximum size should be within 31 bits due to
   String's length & int32_t representation in our parser.

2. We drop m_inferredName and prefer m_ecmaName. The inferred name is used to offer better function name when the function expression lacks
   the name, but now ECMAScript has a specified semantics to name those functions with intuitive names. We should use ecmaName consistently,
   and should not eat 8 bytes for inferred names in UnlinkedFunctionExecutable.

We also fix generator ecma name.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::inferredName const):
* bytecode/InlineCallFrame.cpp:
(JSC::InlineCallFrame::inferredName const):
* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
* bytecode/UnlinkedFunctionExecutable.h:
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createGeneratorFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::tryInferNameInPatternWithIdentifier):
(JSC::ASTBuilder::makeAssignNode):
* parser/Nodes.cpp:
(JSC::FunctionMetadataNode::operator== const):
(JSC::FunctionMetadataNode::dump const):
* parser/Nodes.h:
* runtime/CachedTypes.cpp:
(JSC::CachedFunctionExecutable::ecmaName const):
(JSC::CachedFunctionExecutable::encode):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::CachedFunctionExecutable::inferredName const): Deleted.
* runtime/FunctionExecutable.h:
* runtime/FunctionExecutableDump.cpp:
(JSC::FunctionExecutableDump::dump const):
* runtime/JSFunction.cpp:
(JSC::JSFunction::calculatedDisplayName):
(JSC::getCalculatedDisplayName):
* runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):

Source/WebCore:

* testing/Internals.cpp:
(WebCore::Internals::parserMetaData):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJSTestsChangeLog">trunk/JSTests/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeCodeBlockcpp">trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeInlineCallFramecpp">trunk/Source/JavaScriptCore/bytecode/InlineCallFrame.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeUnlinkedFunctionExecutablecpp">trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeUnlinkedFunctionExecutableh">trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserASTBuilderh">trunk/Source/JavaScriptCore/parser/ASTBuilder.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserNodescpp">trunk/Source/JavaScriptCore/parser/Nodes.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserNodesh">trunk/Source/JavaScriptCore/parser/Nodes.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeCachedTypescpp">trunk/Source/JavaScriptCore/runtime/CachedTypes.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeFunctionExecutableh">trunk/Source/JavaScriptCore/runtime/FunctionExecutable.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeFunctionExecutableDumpcpp">trunk/Source/JavaScriptCore/runtime/FunctionExecutableDump.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSFunctioncpp">trunk/Source/JavaScriptCore/runtime/JSFunction.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeSamplingProfilercpp">trunk/Source/JavaScriptCore/runtime/SamplingProfiler.cpp</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoretestingInternalscpp">trunk/Source/WebCore/testing/Internals.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkJSTestsstressgeneratornamejs">trunk/JSTests/stress/generator-name.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJSTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JSTests/ChangeLog (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/ChangeLog  2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/JSTests/ChangeLog     2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2019-05-14  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Shrink sizeof(UnlinkedFunctionExecutable) more
+        https://bugs.webkit.org/show_bug.cgi?id=197833
+
+        Reviewed by Darin Adler.
+
+        * stress/generator-name.js: Added.
+        (shouldBe):
+        (gen):
+        (catch):
+
</ins><span class="cx"> 2019-05-13  Tadeu Zagallo  <tzagallo@apple.com>
</span><span class="cx"> 
</span><span class="cx">         JSObject::getOwnPropertyDescriptor is missing an exception check
</span></span></pre></div>
<a id="trunkJSTestsstressgeneratornamejs"></a>
<div class="addfile"><h4>Added: trunk/JSTests/stress/generator-name.js (0 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JSTests/stress/generator-name.js                           (rev 0)
+++ trunk/JSTests/stress/generator-name.js      2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+function shouldBe(actual, expected) {
+    if (actual !== expected)
+        throw new Error('bad value: ' + actual);
+}
+
+function*gen() { throw new Error(); }
+
+var flag = true;
+var g = gen();
+try {
+    g.next();
+    flag = false;
+} catch (error) {
+    shouldBe(error.stack.startsWith("gen@"), true);
+}
+shouldBe(flag, true);
</ins></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/ChangeLog       2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -1,3 +1,55 @@
</span><ins>+2019-05-14  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Shrink sizeof(UnlinkedFunctionExecutable) more
+        https://bugs.webkit.org/show_bug.cgi?id=197833
+
+        Reviewed by Darin Adler.
+
+        It turns out that Gmail creates so many JSFunctions, FunctionExecutables, and UnlinkedFunctionExecutables.
+        So we should shrink size of them to save memory. As a first step, this patch reduces the sizeof(UnlinkedFunctionExecutable) more by 16 bytes.
+
+        1. We reorder some fields to get 8 bytes. And we use 31 bits for xxx offset things since their maximum size should be within 31 bits due to
+           String's length & int32_t representation in our parser.
+
+        2. We drop m_inferredName and prefer m_ecmaName. The inferred name is used to offer better function name when the function expression lacks
+           the name, but now ECMAScript has a specified semantics to name those functions with intuitive names. We should use ecmaName consistently,
+           and should not eat 8 bytes for inferred names in UnlinkedFunctionExecutable.
+
+        We also fix generator ecma name.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::inferredName const):
+        * bytecode/InlineCallFrame.cpp:
+        (JSC::InlineCallFrame::inferredName const):
+        * bytecode/UnlinkedFunctionExecutable.cpp:
+        (JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
+        * bytecode/UnlinkedFunctionExecutable.h:
+        * parser/ASTBuilder.h:
+        (JSC::ASTBuilder::createAssignResolve):
+        (JSC::ASTBuilder::createGeneratorFunctionBody):
+        (JSC::ASTBuilder::createGetterOrSetterProperty):
+        (JSC::ASTBuilder::createProperty):
+        (JSC::ASTBuilder::tryInferNameInPatternWithIdentifier):
+        (JSC::ASTBuilder::makeAssignNode):
+        * parser/Nodes.cpp:
+        (JSC::FunctionMetadataNode::operator== const):
+        (JSC::FunctionMetadataNode::dump const):
+        * parser/Nodes.h:
+        * runtime/CachedTypes.cpp:
+        (JSC::CachedFunctionExecutable::ecmaName const):
+        (JSC::CachedFunctionExecutable::encode):
+        (JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
+        (JSC::CachedFunctionExecutable::inferredName const): Deleted.
+        * runtime/FunctionExecutable.h:
+        * runtime/FunctionExecutableDump.cpp:
+        (JSC::FunctionExecutableDump::dump const):
+        * runtime/JSFunction.cpp:
+        (JSC::JSFunction::calculatedDisplayName):
+        (JSC::getCalculatedDisplayName):
+        * runtime/SamplingProfiler.cpp:
+        (JSC::SamplingProfiler::StackFrame::displayName):
+        (JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
+
</ins><span class="cx"> 2019-05-13  Yusuke Suzuki  <ysuzuki@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [JSC] Compress JIT related data more by using Packed<>
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeCodeBlockcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp       2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp  2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -122,7 +122,7 @@
</span><span class="cx">     case EvalCode:
</span><span class="cx">         return "<eval>";
</span><span class="cx">     case FunctionCode:
</span><del>-        return jsCast<FunctionExecutable*>(ownerExecutable())->inferredName().utf8();
</del><ins>+        return jsCast<FunctionExecutable*>(ownerExecutable())->ecmaName().utf8();
</ins><span class="cx">     case ModuleCode:
</span><span class="cx">         return "<module>";
</span><span class="cx">     default:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeInlineCallFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/InlineCallFrame.cpp (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/InlineCallFrame.cpp 2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/bytecode/InlineCallFrame.cpp    2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> 
</span><span class="cx"> CString InlineCallFrame::inferredName() const
</span><span class="cx"> {
</span><del>-    return jsCast<FunctionExecutable*>(baselineCodeBlock->ownerExecutable())->inferredName().utf8();
</del><ins>+    return jsCast<FunctionExecutable*>(baselineCodeBlock->ownerExecutable())->ecmaName().utf8();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void InlineCallFrame::dumpBriefFunctionInformation(PrintStream& out) const
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeUnlinkedFunctionExecutablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp      2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp 2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -84,34 +84,33 @@
</span><span class="cx"> UnlinkedFunctionExecutable::UnlinkedFunctionExecutable(VM* vm, Structure* structure, const SourceCode& parentSource, FunctionMetadataNode* node, UnlinkedFunctionKind kind, ConstructAbility constructAbility, JSParserScriptMode scriptMode, Optional<CompactVariableMap::Handle> parentScopeTDZVariables, DerivedContextType derivedContextType, bool isBuiltinDefaultClassConstructor)
</span><span class="cx">     : Base(*vm, structure)
</span><span class="cx">     , m_firstLineOffset(node->firstLine() - parentSource.firstLine().oneBasedInt())
</span><ins>+    , m_isInStrictContext(node->isInStrictContext())
</ins><span class="cx">     , m_lineCount(node->lastLine() - node->firstLine())
</span><ins>+    , m_hasCapturedVariables(false)
</ins><span class="cx">     , m_unlinkedFunctionNameStart(node->functionNameStart() - parentSource.startOffset())
</span><ins>+    , m_isBuiltinFunction(kind == UnlinkedBuiltinFunction)
</ins><span class="cx">     , m_unlinkedBodyStartColumn(node->startColumn())
</span><ins>+    , m_isBuiltinDefaultClassConstructor(isBuiltinDefaultClassConstructor)
</ins><span class="cx">     , m_unlinkedBodyEndColumn(m_lineCount ? node->endColumn() : node->endColumn() - node->startColumn())
</span><ins>+    , m_constructAbility(static_cast<unsigned>(constructAbility))
</ins><span class="cx">     , m_startOffset(node->source().startOffset() - parentSource.startOffset())
</span><ins>+    , m_scriptMode(static_cast<unsigned>(scriptMode))
</ins><span class="cx">     , m_sourceLength(node->source().length())
</span><ins>+    , m_superBinding(static_cast<unsigned>(node->superBinding()))
</ins><span class="cx">     , m_parametersStartOffset(node->parametersStart())
</span><ins>+    , m_isCached(false)
</ins><span class="cx">     , m_typeProfilingStartOffset(node->functionKeywordStart())
</span><span class="cx">     , m_typeProfilingEndOffset(node->startStartOffset() + node->source().length() - 1)
</span><span class="cx">     , m_parameterCount(node->parameterCount())
</span><span class="cx">     , m_features(0)
</span><span class="cx">     , m_sourceParseMode(node->parseMode())
</span><del>-    , m_isInStrictContext(node->isInStrictContext())
-    , m_hasCapturedVariables(false)
-    , m_isBuiltinFunction(kind == UnlinkedBuiltinFunction)
-    , m_isBuiltinDefaultClassConstructor(isBuiltinDefaultClassConstructor)
-    , m_constructAbility(static_cast<unsigned>(constructAbility))
</del><span class="cx">     , m_constructorKind(static_cast<unsigned>(node->constructorKind()))
</span><span class="cx">     , m_functionMode(static_cast<unsigned>(node->functionMode()))
</span><del>-    , m_scriptMode(static_cast<unsigned>(scriptMode))
-    , m_superBinding(static_cast<unsigned>(node->superBinding()))
</del><span class="cx">     , m_derivedContextType(static_cast<unsigned>(derivedContextType))
</span><del>-    , m_isCached(false)
</del><span class="cx">     , m_unlinkedCodeBlockForCall()
</span><span class="cx">     , m_unlinkedCodeBlockForConstruct()
</span><span class="cx">     , m_name(node->ident())
</span><span class="cx">     , m_ecmaName(node->ecmaName())
</span><del>-    , m_inferredName(node->inferredName())
</del><span class="cx"> {
</span><span class="cx">     // Make sure these bitfields are adequately wide.
</span><span class="cx">     ASSERT(m_constructAbility == static_cast<unsigned>(constructAbility));
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeUnlinkedFunctionExecutableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h        2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h   2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -81,7 +81,6 @@
</span><span class="cx">     const Identifier& name() const { return m_name; }
</span><span class="cx">     const Identifier& ecmaName() const { return m_ecmaName; }
</span><span class="cx">     void setEcmaName(const Identifier& name) { m_ecmaName = name; }
</span><del>-    const Identifier& inferredName() const { return m_inferredName; }
</del><span class="cx">     unsigned parameterCount() const { return m_parameterCount; }; // Excluding 'this'!
</span><span class="cx">     SourceParseMode parseMode() const { return static_cast<SourceParseMode>(m_sourceParseMode); };
</span><span class="cx"> 
</span><span class="lines">@@ -205,30 +204,30 @@
</span><span class="cx"> 
</span><span class="cx">     void decodeCachedCodeBlocks();
</span><span class="cx"> 
</span><del>-    unsigned m_firstLineOffset;
-    unsigned m_lineCount;
-    unsigned m_unlinkedFunctionNameStart;
-    unsigned m_unlinkedBodyStartColumn;
-    unsigned m_unlinkedBodyEndColumn;
-    unsigned m_startOffset;
-    unsigned m_sourceLength;
-    unsigned m_parametersStartOffset;
</del><ins>+    unsigned m_firstLineOffset : 31;
+    unsigned m_isInStrictContext : 1;
+    unsigned m_lineCount : 31;
+    unsigned m_hasCapturedVariables : 1;
+    unsigned m_unlinkedFunctionNameStart : 31;
+    unsigned m_isBuiltinFunction : 1;
+    unsigned m_unlinkedBodyStartColumn : 31;
+    unsigned m_isBuiltinDefaultClassConstructor : 1;
+    unsigned m_unlinkedBodyEndColumn : 31;
+    unsigned m_constructAbility: 1;
+    unsigned m_startOffset : 31;
+    unsigned m_scriptMode: 1; // JSParserScriptMode
+    unsigned m_sourceLength : 31;
+    unsigned m_superBinding : 1;
+    unsigned m_parametersStartOffset : 31;
+    unsigned m_isCached : 1;
</ins><span class="cx">     unsigned m_typeProfilingStartOffset;
</span><span class="cx">     unsigned m_typeProfilingEndOffset;
</span><span class="cx">     unsigned m_parameterCount;
</span><span class="cx">     CodeFeatures m_features;
</span><span class="cx">     SourceParseMode m_sourceParseMode;
</span><del>-    unsigned m_isInStrictContext : 1;
-    unsigned m_hasCapturedVariables : 1;
-    unsigned m_isBuiltinFunction : 1;
-    unsigned m_isBuiltinDefaultClassConstructor : 1;
-    unsigned m_constructAbility: 1;
</del><span class="cx">     unsigned m_constructorKind : 2;
</span><span class="cx">     unsigned m_functionMode : 2; // FunctionMode
</span><del>-    unsigned m_scriptMode: 1; // JSParserScriptMode
-    unsigned m_superBinding : 1;
</del><span class="cx">     unsigned m_derivedContextType: 2;
</span><del>-    bool m_isCached : 1;
</del><span class="cx"> 
</span><span class="cx">     union {
</span><span class="cx">         WriteBarrier<UnlinkedFunctionCodeBlock> m_unlinkedCodeBlockForCall;
</span><span class="lines">@@ -245,7 +244,6 @@
</span><span class="cx"> 
</span><span class="cx">     Identifier m_name;
</span><span class="cx">     Identifier m_ecmaName;
</span><del>-    Identifier m_inferredName;
</del><span class="cx"> 
</span><span class="cx">     RareData& ensureRareData()
</span><span class="cx">     {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserASTBuilderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/ASTBuilder.h (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/ASTBuilder.h  2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/parser/ASTBuilder.h     2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -370,7 +370,6 @@
</span><span class="cx">         if (rhs->isBaseFuncExprNode()) {
</span><span class="cx">             auto metadata = static_cast<BaseFuncExprNode*>(rhs)->metadata();
</span><span class="cx">             metadata->setEcmaName(ident);
</span><del>-            metadata->setInferredName(ident);
</del><span class="cx">         } else if (rhs->isClassExprNode())
</span><span class="cx">             static_cast<ClassExprNode*>(rhs)->setEcmaName(ident);
</span><span class="cx">         AssignResolveNode* node = new (m_parserArena) AssignResolveNode(location, ident, rhs, assignmentContext);
</span><span class="lines">@@ -417,7 +416,7 @@
</span><span class="cx">     {
</span><span class="cx">         FuncExprNode* result = static_cast<FuncExprNode*>(createFunctionExpr(location, functionInfo));
</span><span class="cx">         if (!name.isNull())
</span><del>-            result->metadata()->setInferredName(name);
</del><ins>+            result->metadata()->setEcmaName(name);
</ins><span class="cx">         return result;
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="lines">@@ -475,7 +474,6 @@
</span><span class="cx">         ASSERT(name);
</span><span class="cx">         functionInfo.body->setLoc(functionInfo.startLine, functionInfo.endLine, location.startOffset, location.lineStartOffset);
</span><span class="cx">         functionInfo.body->setEcmaName(*name);
</span><del>-        functionInfo.body->setInferredName(*name);
</del><span class="cx">         SourceCode source = m_sourceCode->subExpression(functionInfo.startOffset, functionInfo.endOffset, functionInfo.startLine, functionInfo.parametersStartColumn);
</span><span class="cx">         MethodDefinitionNode* methodDef = new (m_parserArena) MethodDefinitionNode(location, m_vm->propertyNames->nullIdentifier, functionInfo.body, source);
</span><span class="cx">         return new (m_parserArena) PropertyNode(*name, methodDef, type, PropertyNode::Unknown, SuperBinding::Needed, tag);
</span><span class="lines">@@ -507,7 +505,6 @@
</span><span class="cx">             if (node->isBaseFuncExprNode()) {
</span><span class="cx">                 auto metadata = static_cast<BaseFuncExprNode*>(node)->metadata();
</span><span class="cx">                 metadata->setEcmaName(*propertyName);
</span><del>-                metadata->setInferredName(*propertyName);
</del><span class="cx">             } else if (node->isClassExprNode())
</span><span class="cx">                 static_cast<ClassExprNode*>(node)->setEcmaName(*propertyName);
</span><span class="cx">         }
</span><span class="lines">@@ -1115,7 +1112,6 @@
</span><span class="cx">         if (defaultValue->isBaseFuncExprNode()) {
</span><span class="cx">             auto metadata = static_cast<BaseFuncExprNode*>(defaultValue)->metadata();
</span><span class="cx">             metadata->setEcmaName(ident);
</span><del>-            metadata->setInferredName(ident);
</del><span class="cx">         } else if (defaultValue->isClassExprNode())
</span><span class="cx">             static_cast<ClassExprNode*>(defaultValue)->setEcmaName(ident);
</span><span class="cx">     }
</span><span class="lines">@@ -1480,7 +1476,6 @@
</span><span class="cx">             if (expr->isBaseFuncExprNode()) {
</span><span class="cx">                 auto metadata = static_cast<BaseFuncExprNode*>(expr)->metadata();
</span><span class="cx">                 metadata->setEcmaName(resolve->identifier());
</span><del>-                metadata->setInferredName(resolve->identifier());
</del><span class="cx">             } else if (expr->isClassExprNode())
</span><span class="cx">                 static_cast<ClassExprNode*>(expr)->setEcmaName(resolve->identifier());
</span><span class="cx">             AssignResolveNode* node = new (m_parserArena) AssignResolveNode(location, resolve->identifier(), expr, AssignmentContext::AssignmentExpression);
</span><span class="lines">@@ -1499,14 +1494,8 @@
</span><span class="cx">     }
</span><span class="cx">     ASSERT(loc->isDotAccessorNode());
</span><span class="cx">     DotAccessorNode* dot = static_cast<DotAccessorNode*>(loc);
</span><del>-    if (op == OpEqual) {
-        if (expr->isBaseFuncExprNode()) {
-            // We don't also set the ecma name here because ES6 specifies that the
-            // function should not pick up the name of the dot->identifier().
-            static_cast<BaseFuncExprNode*>(expr)->metadata()->setInferredName(dot->identifier());
-        }
</del><ins>+    if (op == OpEqual)
</ins><span class="cx">         return new (m_parserArena) AssignDotNode(location, dot->base(), dot->identifier(), expr, exprHasAssignments, dot->divot(), start, end);
</span><del>-    }
</del><span class="cx"> 
</span><span class="cx">     ReadModifyDotNode* node = new (m_parserArena) ReadModifyDotNode(location, dot->base(), dot->identifier(), op, expr, exprHasAssignments, divot, start, end);
</span><span class="cx">     node->setSubexpressionInfo(dot->divot(), dot->divotEnd().offset);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserNodescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Nodes.cpp (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Nodes.cpp     2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/parser/Nodes.cpp        2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -257,7 +257,6 @@
</span><span class="cx">         && m_isArrowFunctionBodyExpression == other.m_isArrowFunctionBodyExpression
</span><span class="cx">         && m_ident == other.m_ident
</span><span class="cx">         && m_ecmaName == other.m_ecmaName
</span><del>-        && m_inferredName == other.m_inferredName
</del><span class="cx">         && m_functionMode== other.m_functionMode
</span><span class="cx">         && m_startColumn== other.m_startColumn
</span><span class="cx">         && m_endColumn== other.m_endColumn
</span><span class="lines">@@ -281,7 +280,6 @@
</span><span class="cx">     stream.println("m_isArrowFunctionBodyExpression ", m_isArrowFunctionBodyExpression);
</span><span class="cx">     stream.println("m_ident ", m_ident);
</span><span class="cx">     stream.println("m_ecmaName ", m_ecmaName);
</span><del>-    stream.println("m_inferredName ", m_inferredName);
</del><span class="cx">     stream.println("m_functionMode ", static_cast<uint32_t>(m_functionMode));
</span><span class="cx">     stream.println("m_startColumn ", m_startColumn);
</span><span class="cx">     stream.println("m_endColumn ", m_endColumn);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserNodesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Nodes.h (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Nodes.h       2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/parser/Nodes.h  2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -1994,8 +1994,6 @@
</span><span class="cx">         const Identifier& ident() { return m_ident; }
</span><span class="cx">         void setEcmaName(const Identifier& ecmaName) { m_ecmaName = ecmaName; }
</span><span class="cx">         const Identifier& ecmaName() { return m_ident.isEmpty() ? m_ecmaName : m_ident; }
</span><del>-        void setInferredName(const Identifier& inferredName) { ASSERT(!inferredName.isNull()); m_inferredName = inferredName; }
-        const Identifier& inferredName() { return m_inferredName.isEmpty() ? m_ident : m_inferredName; }
</del><span class="cx"> 
</span><span class="cx">         FunctionMode functionMode() { return m_functionMode; }
</span><span class="cx"> 
</span><span class="lines">@@ -2042,7 +2040,6 @@
</span><span class="cx">         FunctionMode m_functionMode;
</span><span class="cx">         Identifier m_ident;
</span><span class="cx">         Identifier m_ecmaName;
</span><del>-        Identifier m_inferredName;
</del><span class="cx">         unsigned m_startColumn;
</span><span class="cx">         unsigned m_endColumn;
</span><span class="cx">         int m_functionKeywordStart;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeCachedTypescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/CachedTypes.cpp (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/CachedTypes.cpp      2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/runtime/CachedTypes.cpp 2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -1641,7 +1641,6 @@
</span><span class="cx"> 
</span><span class="cx">     Identifier name(Decoder& decoder) const { return m_name.decode(decoder); }
</span><span class="cx">     Identifier ecmaName(Decoder& decoder) const { return m_ecmaName.decode(decoder); }
</span><del>-    Identifier inferredName(Decoder& decoder) const { return m_inferredName.decode(decoder); }
</del><span class="cx"> 
</span><span class="cx">     UnlinkedFunctionExecutable::RareData* rareData(Decoder& decoder) const { return m_rareData.decode(decoder); }
</span><span class="cx"> 
</span><span class="lines">@@ -1651,26 +1650,26 @@
</span><span class="cx"> private:
</span><span class="cx">     CachedFunctionExecutableMetadata m_mutableMetadata;
</span><span class="cx"> 
</span><del>-    unsigned m_firstLineOffset;
-    unsigned m_lineCount;
-    unsigned m_unlinkedFunctionNameStart;
-    unsigned m_unlinkedBodyStartColumn;
-    unsigned m_unlinkedBodyEndColumn;
-    unsigned m_startOffset;
-    unsigned m_sourceLength;
-    unsigned m_parametersStartOffset;
</del><ins>+    unsigned m_firstLineOffset : 31;
+    unsigned m_isInStrictContext : 1;
+    unsigned m_lineCount : 31;
+    unsigned m_isBuiltinFunction : 1;
+    unsigned m_unlinkedFunctionNameStart : 31;
+    unsigned m_isBuiltinDefaultClassConstructor : 1;
+    unsigned m_unlinkedBodyStartColumn : 31;
+    unsigned m_constructAbility: 1;
+    unsigned m_unlinkedBodyEndColumn : 31;
+    unsigned m_startOffset : 31;
+    unsigned m_scriptMode: 1; // JSParserScriptMode
+    unsigned m_sourceLength : 31;
+    unsigned m_superBinding : 1;
+    unsigned m_parametersStartOffset : 31;
</ins><span class="cx">     unsigned m_typeProfilingStartOffset;
</span><span class="cx">     unsigned m_typeProfilingEndOffset;
</span><span class="cx">     unsigned m_parameterCount;
</span><span class="cx">     SourceParseMode m_sourceParseMode;
</span><del>-    unsigned m_isInStrictContext : 1;
-    unsigned m_isBuiltinFunction : 1;
-    unsigned m_isBuiltinDefaultClassConstructor : 1;
-    unsigned m_constructAbility: 1;
</del><span class="cx">     unsigned m_constructorKind : 2;
</span><span class="cx">     unsigned m_functionMode : 2; // FunctionMode
</span><del>-    unsigned m_scriptMode: 1; // JSParserScriptMode
-    unsigned m_superBinding : 1;
</del><span class="cx">     unsigned m_derivedContextType: 2;
</span><span class="cx"> 
</span><span class="cx">     CachedPtr<CachedFunctionExecutableRareData> m_rareData;
</span><span class="lines">@@ -1677,7 +1676,6 @@
</span><span class="cx"> 
</span><span class="cx">     CachedIdentifier m_name;
</span><span class="cx">     CachedIdentifier m_ecmaName;
</span><del>-    CachedIdentifier m_inferredName;
</del><span class="cx"> 
</span><span class="cx">     CachedWriteBarrier<CachedFunctionCodeBlock, UnlinkedFunctionCodeBlock> m_unlinkedCodeBlockForCall;
</span><span class="cx">     CachedWriteBarrier<CachedFunctionCodeBlock, UnlinkedFunctionCodeBlock> m_unlinkedCodeBlockForConstruct;
</span><span class="lines">@@ -2044,7 +2042,6 @@
</span><span class="cx"> 
</span><span class="cx">     m_name.encode(encoder, executable.name());
</span><span class="cx">     m_ecmaName.encode(encoder, executable.ecmaName());
</span><del>-    m_inferredName.encode(encoder, executable.inferredName());
</del><span class="cx"> 
</span><span class="cx">     m_unlinkedCodeBlockForCall.encode(encoder, executable.m_unlinkedCodeBlockForCall);
</span><span class="cx">     m_unlinkedCodeBlockForConstruct.encode(encoder, executable.m_unlinkedCodeBlockForConstruct);
</span><span class="lines">@@ -2063,35 +2060,34 @@
</span><span class="cx"> ALWAYS_INLINE UnlinkedFunctionExecutable::UnlinkedFunctionExecutable(Decoder& decoder, const CachedFunctionExecutable& cachedExecutable)
</span><span class="cx">     : Base(decoder.vm(), decoder.vm().unlinkedFunctionExecutableStructure.get())
</span><span class="cx">     , m_firstLineOffset(cachedExecutable.firstLineOffset())
</span><ins>+    , m_isInStrictContext(cachedExecutable.isInStrictContext())
</ins><span class="cx">     , m_lineCount(cachedExecutable.lineCount())
</span><ins>+    , m_hasCapturedVariables(cachedExecutable.hasCapturedVariables())
</ins><span class="cx">     , m_unlinkedFunctionNameStart(cachedExecutable.unlinkedFunctionNameStart())
</span><ins>+    , m_isBuiltinFunction(cachedExecutable.isBuiltinFunction())
</ins><span class="cx">     , m_unlinkedBodyStartColumn(cachedExecutable.unlinkedBodyStartColumn())
</span><ins>+    , m_isBuiltinDefaultClassConstructor(cachedExecutable.isBuiltinDefaultClassConstructor())
</ins><span class="cx">     , m_unlinkedBodyEndColumn(cachedExecutable.unlinkedBodyEndColumn())
</span><ins>+    , m_constructAbility(cachedExecutable.constructAbility())
</ins><span class="cx">     , m_startOffset(cachedExecutable.startOffset())
</span><ins>+    , m_scriptMode(cachedExecutable.scriptMode())
</ins><span class="cx">     , m_sourceLength(cachedExecutable.sourceLength())
</span><ins>+    , m_superBinding(cachedExecutable.superBinding())
</ins><span class="cx">     , m_parametersStartOffset(cachedExecutable.parametersStartOffset())
</span><ins>+    , m_isCached(false)
</ins><span class="cx">     , m_typeProfilingStartOffset(cachedExecutable.typeProfilingStartOffset())
</span><span class="cx">     , m_typeProfilingEndOffset(cachedExecutable.typeProfilingEndOffset())
</span><span class="cx">     , m_parameterCount(cachedExecutable.parameterCount())
</span><span class="cx">     , m_features(cachedExecutable.features())
</span><span class="cx">     , m_sourceParseMode(cachedExecutable.sourceParseMode())
</span><del>-    , m_isInStrictContext(cachedExecutable.isInStrictContext())
-    , m_hasCapturedVariables(cachedExecutable.hasCapturedVariables())
-    , m_isBuiltinFunction(cachedExecutable.isBuiltinFunction())
-    , m_isBuiltinDefaultClassConstructor(cachedExecutable.isBuiltinDefaultClassConstructor())
-    , m_constructAbility(cachedExecutable.constructAbility())
</del><span class="cx">     , m_constructorKind(cachedExecutable.constructorKind())
</span><span class="cx">     , m_functionMode(cachedExecutable.functionMode())
</span><del>-    , m_scriptMode(cachedExecutable.scriptMode())
-    , m_superBinding(cachedExecutable.superBinding())
</del><span class="cx">     , m_derivedContextType(cachedExecutable.derivedContextType())
</span><del>-    , m_isCached(false)
</del><span class="cx">     , m_unlinkedCodeBlockForCall()
</span><span class="cx">     , m_unlinkedCodeBlockForConstruct()
</span><span class="cx"> 
</span><span class="cx">     , m_name(cachedExecutable.name(decoder))
</span><span class="cx">     , m_ecmaName(cachedExecutable.ecmaName(decoder))
</span><del>-    , m_inferredName(cachedExecutable.inferredName(decoder))
</del><span class="cx"> 
</span><span class="cx">     , m_rareData(cachedExecutable.rareData(decoder))
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeFunctionExecutableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/FunctionExecutable.h (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/FunctionExecutable.h 2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/runtime/FunctionExecutable.h    2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -161,7 +161,6 @@
</span><span class="cx">     bool isClassConstructorFunction() const { return m_unlinkedExecutable->isClassConstructorFunction(); }
</span><span class="cx">     const Identifier& name() { return m_unlinkedExecutable->name(); }
</span><span class="cx">     const Identifier& ecmaName() { return m_unlinkedExecutable->ecmaName(); }
</span><del>-    const Identifier& inferredName() { return m_unlinkedExecutable->inferredName(); }
</del><span class="cx">     unsigned parameterCount() const { return m_unlinkedExecutable->parameterCount(); } // Excluding 'this'!
</span><span class="cx">     SourceParseMode parseMode() const { return m_unlinkedExecutable->parseMode(); }
</span><span class="cx">     JSParserScriptMode scriptMode() const { return m_unlinkedExecutable->scriptMode(); }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeFunctionExecutableDumpcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/FunctionExecutableDump.cpp (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/FunctionExecutableDump.cpp   2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/runtime/FunctionExecutableDump.cpp      2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> 
</span><span class="cx"> void FunctionExecutableDump::dump(PrintStream& out) const
</span><span class="cx"> {
</span><del>-    out.print(m_executable->inferredName().string(), "#");
</del><ins>+    out.print(m_executable->ecmaName().string(), "#");
</ins><span class="cx">     if (m_executable->isGeneratedForCall())
</span><span class="cx">         out.print(m_executable->codeBlockForCall()->hashAsStringIfPossible());
</span><span class="cx">     else
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSFunctioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSFunction.cpp (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSFunction.cpp       2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/runtime/JSFunction.cpp  2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -227,7 +227,7 @@
</span><span class="cx">     if (!actualName.isEmpty() || isHostOrBuiltinFunction())
</span><span class="cx">         return actualName;
</span><span class="cx"> 
</span><del>-    return jsExecutable()->inferredName().string();
</del><ins>+    return jsExecutable()->ecmaName().string();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> const SourceCode* JSFunction::sourceCode() const
</span><span class="lines">@@ -651,7 +651,7 @@
</span><span class="cx">         if (!actualName.isEmpty() || function->isHostOrBuiltinFunction())
</span><span class="cx">             return actualName;
</span><span class="cx"> 
</span><del>-        return function->jsExecutable()->inferredName().string();
</del><ins>+        return function->jsExecutable()->ecmaName().string();
</ins><span class="cx">     }
</span><span class="cx">     if (auto* function = jsDynamicCast<InternalFunction*>(vm, object))
</span><span class="cx">         return function->name();
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeSamplingProfilercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/SamplingProfiler.cpp (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/SamplingProfiler.cpp 2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/JavaScriptCore/runtime/SamplingProfiler.cpp    2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -779,7 +779,7 @@
</span><span class="cx">         return static_cast<NativeExecutable*>(executable)->name();
</span><span class="cx"> 
</span><span class="cx">     if (executable->isFunctionExecutable())
</span><del>-        return static_cast<FunctionExecutable*>(executable)->inferredName().string();
</del><ins>+        return static_cast<FunctionExecutable*>(executable)->ecmaName().string();
</ins><span class="cx">     if (executable->isProgramExecutable() || executable->isEvalExecutable())
</span><span class="cx">         return "(program)"_s;
</span><span class="cx">     if (executable->isModuleProgramExecutable())
</span><span class="lines">@@ -806,7 +806,7 @@
</span><span class="cx">         return static_cast<NativeExecutable*>(executable)->name();
</span><span class="cx"> 
</span><span class="cx">     if (executable->isFunctionExecutable()) {
</span><del>-        String result = static_cast<FunctionExecutable*>(executable)->inferredName().string();
</del><ins>+        String result = static_cast<FunctionExecutable*>(executable)->ecmaName().string();
</ins><span class="cx">         if (result.isEmpty())
</span><span class="cx">             return "(anonymous function)"_s;
</span><span class="cx">         return result;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/WebCore/ChangeLog      2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2019-05-14  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Shrink sizeof(UnlinkedFunctionExecutable) more
+        https://bugs.webkit.org/show_bug.cgi?id=197833
+
+        Reviewed by Darin Adler.
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::parserMetaData):
+
</ins><span class="cx"> 2019-05-14  Antoine Quint  <graouts@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [Pointer Events] The pointerenter and pointerleave events target the wrong element on iOS
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/Internals.cpp (245287 => 245288)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/Internals.cpp       2019-05-14 17:03:18 UTC (rev 245287)
+++ trunk/Source/WebCore/testing/Internals.cpp  2019-05-14 17:31:53 UTC (rev 245288)
</span><span class="lines">@@ -2159,7 +2159,7 @@
</span><span class="cx"> 
</span><span class="cx">     if (executable->isFunctionExecutable()) {
</span><span class="cx">         FunctionExecutable* funcExecutable = reinterpret_cast<FunctionExecutable*>(executable);
</span><del>-        String inferredName = funcExecutable->inferredName().string();
</del><ins>+        String inferredName = funcExecutable->ecmaName().string();
</ins><span class="cx">         result.appendLiteral("function \"");
</span><span class="cx">         result.append(inferredName);
</span><span class="cx">         result.append('"');
</span></span></pre>
</div>
</div>

</body>
</html>