<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[245019] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/245019">245019</a></dd>
<dt>Author</dt> <dd>ryanhaddad@apple.com</dd>
<dt>Date</dt> <dd>2019-05-07 11:42:16 -0700 (Tue, 07 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/244900">r244900</a>.

Caused media/track/track-cue-missing.html to fail on debug
queues

Reverted changeset:

"Add logging for RenderLayer clip rects"
https://bugs.webkit.org/show_bug.cgi?id=197547
https://trac.webkit.org/changeset/244900</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformLoggingh">trunk/Source/WebCore/platform/Logging.h</a></li>
<li><a href="#trunkSourceWebCorerenderingClipRectcpp">trunk/Source/WebCore/rendering/ClipRect.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingClipRecth">trunk/Source/WebCore/rendering/ClipRect.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerh">trunk/Source/WebCore/rendering/RenderLayer.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (245018 => 245019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-05-07 18:39:27 UTC (rev 245018)
+++ trunk/Source/WebCore/ChangeLog      2019-05-07 18:42:16 UTC (rev 245019)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r244900.
+
+        Caused media/track/track-cue-missing.html to fail on debug
+        queues
+
+        Reverted changeset:
+
+        "Add logging for RenderLayer clip rects"
+        https://bugs.webkit.org/show_bug.cgi?id=197547
+        https://trac.webkit.org/changeset/244900
+
</ins><span class="cx"> 2019-05-07  Antti Koivisto  <antti@apple.com>
</span><span class="cx"> 
</span><span class="cx">         <body> with overflow:hidden CSS is scrollable on iOS
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformLoggingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/Logging.h (245018 => 245019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/Logging.h  2019-05-07 18:39:27 UTC (rev 245018)
+++ trunk/Source/WebCore/platform/Logging.h     2019-05-07 18:42:16 UTC (rev 245019)
</span><span class="lines">@@ -42,7 +42,6 @@
</span><span class="cx">     M(Animations) \
</span><span class="cx">     M(ApplePay) \
</span><span class="cx">     M(Archives) \
</span><del>-    M(ClipRects) \
</del><span class="cx">     M(Compositing) \
</span><span class="cx">     M(ContentFiltering) \
</span><span class="cx">     M(ContentObservation) \
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingClipRectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/ClipRect.cpp (245018 => 245019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/ClipRect.cpp      2019-05-07 18:39:27 UTC (rev 245018)
+++ trunk/Source/WebCore/rendering/ClipRect.cpp 2019-05-07 18:42:16 UTC (rev 245019)
</span><span class="lines">@@ -38,17 +38,4 @@
</span><span class="cx">     return hitTestLocation.intersects(m_rect);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TextStream& operator<<(TextStream& ts, const ClipRect& clipRect)
-{
-    ts << "rect ";
-    if (clipRect.isInfinite())
-        ts << "infinite";
-    else
-        ts << clipRect.rect();
-
-    if (clipRect.affectedByRadius())
-        ts << " affected by radius";
-    return ts;
</del><span class="cx"> }
</span><del>-
-}
</del></span></pre></div>
<a id="trunkSourceWebCorerenderingClipRecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/ClipRect.h (245018 => 245019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/ClipRect.h        2019-05-07 18:39:27 UTC (rev 245018)
+++ trunk/Source/WebCore/rendering/ClipRect.h   2019-05-07 18:42:16 UTC (rev 245019)
</span><span class="lines">@@ -27,10 +27,6 @@
</span><span class="cx"> 
</span><span class="cx"> #include "LayoutRect.h"
</span><span class="cx"> 
</span><del>-namespace WTF {
-class TextStream;
-}
-
</del><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><span class="cx"> class HitTestLocation;
</span><span class="lines">@@ -107,6 +103,4 @@
</span><span class="cx">     return c;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-WTF::TextStream& operator<<(WTF::TextStream&, const ClipRect&);
-
</del><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (245018 => 245019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp   2019-05-07 18:39:27 UTC (rev 245018)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp      2019-05-07 18:42:16 UTC (rev 245019)
</span><span class="lines">@@ -268,19 +268,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-#if !LOG_DISABLED
-static TextStream& operator<<(TextStream& ts, const ClipRects& clipRects)
-{
-    TextStream::GroupScope scope(ts);
-    ts << indent << "ClipRects\n";
-    ts << indent << "  overflow  : " << clipRects.overflowClipRect() << "\n";
-    ts << indent << "  fixed     : " << clipRects.fixedClipRect() << "\n";
-    ts << indent << "  positioned: " << clipRects.posClipRect() << "\n";
-
-    return ts;
-}
-#endif
-
</del><span class="cx"> RenderLayer::RenderLayer(RenderLayerModelObject& rendererLayerModelObject)
</span><span class="cx">     : m_isRenderViewLayer(rendererLayerModelObject.isRenderView())
</span><span class="cx">     , m_forcedStackingContext(rendererLayerModelObject.isMedia())
</span><span class="lines">@@ -5541,8 +5528,6 @@
</span><span class="cx">             clipRects.setFixedClipRect(intersection(newPosClip, clipRects.fixedClipRect()));
</span><span class="cx">         }
</span><span class="cx">     }
</span><del>-    
-    LOG_WITH_STREAM(ClipRects, stream << "RenderLayer " << this << " calculateClipRects " << clipRects);
</del><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> Ref<ClipRects> RenderLayer::parentClipRects(const ClipRectsContext& clipRectsContext) const
</span><span class="lines">@@ -5592,8 +5577,6 @@
</span><span class="cx">     // Note: infinite clipRects should not be scrolled here, otherwise they will accidentally no longer be considered infinite.
</span><span class="cx">     if (parentRects->fixed() && &clipRectsContext.rootLayer->renderer() == &view && !backgroundClipRect.isInfinite())
</span><span class="cx">         backgroundClipRect.moveBy(view.frameView().scrollPositionForFixedPosition());
</span><del>-
-    LOG_WITH_STREAM(ClipRects, stream << "RenderLayer " << this << " backgroundClipRect with context " << clipRectsContext << " returning " << backgroundClipRect);
</del><span class="cx">     return backgroundClipRect;
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -6756,21 +6739,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TextStream& operator<<(WTF::TextStream& ts, ClipRectsType clipRectsType)
-{
-    switch (clipRectsType) {
-    case PaintingClipRects: ts << "painting"; break;
-    case RootRelativeClipRects: ts << "root-relative"; break;
-    case AbsoluteClipRects: ts << "absolute"; break;
-    case TemporaryClipRects: ts << "temporary"; break;
-    case NumCachedClipRectsTypes:
-    case AllClipRectTypes:
-        ts << "?";
-        break;
-    }
-    return ts;
-}
-
</del><span class="cx"> TextStream& operator<<(TextStream& ts, const RenderLayer& layer)
</span><span class="cx"> {
</span><span class="cx">     ts << "RenderLayer " << &layer << " " << layer.size();
</span><span class="lines">@@ -6789,15 +6757,6 @@
</span><span class="cx">     return ts;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-TextStream& operator<<(TextStream& ts, const RenderLayer::ClipRectsContext& context)
-{
-    ts.dumpProperty("root layer:", context.rootLayer);
-    ts.dumpProperty("type:", context.clipRectsType);
-    ts.dumpProperty("overflow-clip:", context.respectOverflowClip == IgnoreOverflowClip ? "ignore" : "respect");
-    
-    return ts;
-}
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(TREE_DEBUGGING)
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.h (245018 => 245019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.h     2019-05-07 18:39:27 UTC (rev 245018)
+++ trunk/Source/WebCore/rendering/RenderLayer.h        2019-05-07 18:42:16 UTC (rev 245019)
</span><span class="lines">@@ -1369,9 +1369,7 @@
</span><span class="cx"> 
</span><span class="cx"> bool compositedWithOwnBackingStore(const RenderLayer&);
</span><span class="cx"> 
</span><del>-WTF::TextStream& operator<<(WTF::TextStream&, ClipRectsType);
</del><span class="cx"> WTF::TextStream& operator<<(WTF::TextStream&, const RenderLayer&);
</span><del>-WTF::TextStream& operator<<(WTF::TextStream&, const RenderLayer::ClipRectsContext&);
</del><span class="cx"> 
</span><span class="cx"> } // namespace WebCore
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>