<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[244907] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/244907">244907</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2019-05-03 07:32:23 -0700 (Fri, 03 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/244881">r244881</a>.
https://bugs.webkit.org/show_bug.cgi?id=197559

Breaks compilation of jsconly on linux, breaking compilation
for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
guijemont on #webkit).

Reverted changeset:

"[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
WEBKIT_COPY_FILES"
https://bugs.webkit.org/show_bug.cgi?id=197174
https://trac.webkit.org/changeset/244881</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreCMakeListstxt">trunk/Source/JavaScriptCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfCMakeListstxt">trunk/Source/WTF/wtf/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreCMakeListstxt">trunk/Source/WebCore/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorePALChangeLog">trunk/Source/WebCore/PAL/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorePALpalCMakeListstxt">trunk/Source/WebCore/PAL/pal/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebKitCMakeListstxt">trunk/Source/WebKit/CMakeLists.txt</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitPlatformWincmake">trunk/Source/WebKit/PlatformWin.cmake</a></li>
<li><a href="#trunkSourceWebKitLegacyChangeLog">trunk/Source/WebKitLegacy/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitLegacyPlatformWincmake">trunk/Source/WebKitLegacy/PlatformWin.cmake</a></li>
<li><a href="#trunkSourcecmakeWebKitMacroscmake">trunk/Source/cmake/WebKitMacros.cmake</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPIPlatformGTKcmake">trunk/Tools/TestWebKitAPI/PlatformGTK.cmake</a></li>
<li><a href="#trunkToolsTestWebKitAPIPlatformWPEcmake">trunk/Tools/TestWebKitAPI/PlatformWPE.cmake</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog  2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/ChangeLog     2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244881.
+        https://bugs.webkit.org/show_bug.cgi?id=197559
+
+        Breaks compilation of jsconly on linux, breaking compilation
+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
+        guijemont on #webkit).
+
+        Reverted changeset:
+
+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
+        WEBKIT_COPY_FILES"
+        https://bugs.webkit.org/show_bug.cgi?id=197174
+        https://trac.webkit.org/changeset/244881
+
</ins><span class="cx"> 2019-05-02  Christopher Reid  <chris.reid@sony.com>
</span><span class="cx"> 
</span><span class="cx">         [CMake] Add support for LTO builds
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/CMakeLists.txt (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/CMakeLists.txt       2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/JavaScriptCore/CMakeLists.txt  2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -296,9 +296,9 @@
</span><span class="cx"> )
</span><span class="cx"> 
</span><span class="cx"> target_link_libraries(LLIntSettingsExtractor WTF)
</span><del>-add_dependencies(LLIntSettingsExtractor JavaScriptCoreFrameworkHeaders WTFFrameworkHeaders)
</del><ins>+add_dependencies(LLIntSettingsExtractor JavaScriptCoreFrameworkHeaders)
</ins><span class="cx"> target_link_libraries(LLIntOffsetsExtractor WTF)
</span><del>-add_dependencies(LLIntOffsetsExtractor JavaScriptCoreFrameworkHeaders WTFFrameworkHeaders)
</del><ins>+add_dependencies(LLIntOffsetsExtractor JavaScriptCoreFrameworkHeaders)
</ins><span class="cx"> 
</span><span class="cx"> # The build system will execute asm.rb every time LLIntOffsetsExtractor's mtime is newer than
</span><span class="cx"> # LLIntAssembly.h's mtime. The problem we have here is: asm.rb has some built-in optimization
</span><span class="lines">@@ -1274,6 +1274,20 @@
</span><span class="cx">     WEBKIT_ADD_TARGET_CXX_FLAGS(JavaScriptCore -ffp-contract=off)
</span><span class="cx"> endif ()
</span><span class="cx"> 
</span><ins>+WEBKIT_MAKE_FORWARDING_HEADERS(JavaScriptCore
+    TARGET_NAME JavaScriptCoreFrameworkHeaders
+    DESTINATION ${JavaScriptCore_FRAMEWORK_HEADERS_DIR}/JavaScriptCore
+    FILES ${JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS}
+    FLATTENED
+)
+
+WEBKIT_MAKE_FORWARDING_HEADERS(JavaScriptCore
+    TARGET_NAME JavaScriptCorePrivateFrameworkHeaders
+    DESTINATION ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS_DIR}/JavaScriptCore
+    FILES ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS}
+    FLATTENED
+)
+
</ins><span class="cx"> target_include_directories(LLIntSettingsExtractor PRIVATE
</span><span class="cx">     ${JavaScriptCore_INCLUDE_DIRECTORIES}
</span><span class="cx">     ${JavaScriptCore_PRIVATE_INCLUDE_DIRECTORIES}
</span><span class="lines">@@ -1292,21 +1306,6 @@
</span><span class="cx"> WEBKIT_WRAP_SOURCELIST(${JavaScriptCore_SOURCES})
</span><span class="cx"> WEBKIT_FRAMEWORK(JavaScriptCore)
</span><span class="cx"> 
</span><del>-WEBKIT_COPY_FILES(JavaScriptCoreFrameworkHeaders
-    DESTINATION ${JavaScriptCore_FRAMEWORK_HEADERS_DIR}/JavaScriptCore
-    FILES ${JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS}
-    FLATTENED
-)
-
-WEBKIT_COPY_FILES(JavaScriptCorePrivateFrameworkHeaders
-    DESTINATION ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS_DIR}/JavaScriptCore
-    FILES ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS}
-    FLATTENED
-)
-
-add_dependencies(JavaScriptCore JavaScriptCoreFrameworkHeaders)
-add_dependencies(JavaScriptCorePrivateFrameworkHeaders JavaScriptCore)
-
</del><span class="cx"> if (NOT "${PORT}" STREQUAL "Mac")
</span><span class="cx">     if (${JavaScriptCore_LIBRARY_TYPE} STREQUAL "SHARED")
</span><span class="cx">         WEBKIT_POPULATE_LIBRARY_VERSION(JAVASCRIPTCORE)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/JavaScriptCore/ChangeLog       2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244881.
+        https://bugs.webkit.org/show_bug.cgi?id=197559
+
+        Breaks compilation of jsconly on linux, breaking compilation
+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
+        guijemont on #webkit).
+
+        Reverted changeset:
+
+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
+        WEBKIT_COPY_FILES"
+        https://bugs.webkit.org/show_bug.cgi?id=197174
+        https://trac.webkit.org/changeset/244881
+
</ins><span class="cx"> 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
</span><span class="cx"> 
</span><span class="cx">         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WTF/ChangeLog  2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244881.
+        https://bugs.webkit.org/show_bug.cgi?id=197559
+
+        Breaks compilation of jsconly on linux, breaking compilation
+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
+        guijemont on #webkit).
+
+        Reverted changeset:
+
+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
+        WEBKIT_COPY_FILES"
+        https://bugs.webkit.org/show_bug.cgi?id=197174
+        https://trac.webkit.org/changeset/244881
+
</ins><span class="cx"> 2019-05-02  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Mark U+01C0 as a homograph of U+006C
</span></span></pre></div>
<a id="trunkSourceWTFwtfCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/CMakeLists.txt (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/CMakeLists.txt      2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WTF/wtf/CMakeLists.txt 2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -503,7 +503,8 @@
</span><span class="cx"> WEBKIT_WRAP_SOURCELIST(${WTF_SOURCES})
</span><span class="cx"> WEBKIT_FRAMEWORK(WTF)
</span><span class="cx"> 
</span><del>-WEBKIT_COPY_FILES(WTFFrameworkHeaders
</del><ins>+WEBKIT_MAKE_FORWARDING_HEADERS(WTF
+    TARGET_NAME WTFFrameworkHeaders
</ins><span class="cx">     DESTINATION ${WTF_FRAMEWORK_HEADERS_DIR}/wtf
</span><span class="cx">     FILES ${WTF_PUBLIC_HEADERS}
</span><span class="cx"> )
</span></span></pre></div>
<a id="trunkSourceWebCoreCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/CMakeLists.txt (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/CMakeLists.txt      2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WebCore/CMakeLists.txt 2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -1763,6 +1763,13 @@
</span><span class="cx"> WEBKIT_FRAMEWORK_DECLARE(WebCore)
</span><span class="cx"> WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
</span><span class="cx"> 
</span><ins>+WEBKIT_MAKE_FORWARDING_HEADERS(WebCore
+    TARGET_NAME WebCorePrivateFrameworkHeaders
+    DESTINATION ${WebCore_PRIVATE_FRAMEWORK_HEADERS_DIR}/WebCore
+    FILES ${WebCore_PRIVATE_FRAMEWORK_HEADERS}
+    FLATTENED
+)
+
</ins><span class="cx"> # Generate CommandLineAPIModuleSource.h
</span><span class="cx"> add_custom_command(
</span><span class="cx">     OUTPUT ${WebCore_DERIVED_SOURCES_DIR}/CommandLineAPIModuleSource.h ${WebCore_DERIVED_SOURCES_DIR}/CommandLineAPIModuleSource.min.js
</span><span class="lines">@@ -2072,17 +2079,7 @@
</span><span class="cx"> 
</span><span class="cx"> WEBKIT_FRAMEWORK(WebCore)
</span><span class="cx"> 
</span><del>-WEBKIT_COPY_FILES(WebCorePrivateFrameworkHeaders
-    DESTINATION ${WebCore_PRIVATE_FRAMEWORK_HEADERS_DIR}/WebCore
-    FILES ${WebCore_PRIVATE_FRAMEWORK_HEADERS}
-    FLATTENED
-)
-
-add_dependencies(WebCore
-    PALFrameworkHeaders
-    JavaScriptCorePrivateFrameworkHeaders
-    WebCoreBindings
-)
</del><ins>+add_dependencies(WebCore WebCoreBindings)
</ins><span class="cx"> add_dependencies(WebCorePrivateFrameworkHeaders WebCoreBindings)
</span><span class="cx"> 
</span><span class="cx"> if (APPLE)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WebCore/ChangeLog      2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244881.
+        https://bugs.webkit.org/show_bug.cgi?id=197559
+
+        Breaks compilation of jsconly on linux, breaking compilation
+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
+        guijemont on #webkit).
+
+        Reverted changeset:
+
+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
+        WEBKIT_COPY_FILES"
+        https://bugs.webkit.org/show_bug.cgi?id=197174
+        https://trac.webkit.org/changeset/244881
+
</ins><span class="cx"> 2019-05-03  Joonghun Park  <jh718.park@samsung.com>
</span><span class="cx"> 
</span><span class="cx">         Resolve the percentage values of inset properties against proper box.
</span></span></pre></div>
<a id="trunkSourceWebCorePALChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/PAL/ChangeLog (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/PAL/ChangeLog       2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WebCore/PAL/ChangeLog  2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244881.
+        https://bugs.webkit.org/show_bug.cgi?id=197559
+
+        Breaks compilation of jsconly on linux, breaking compilation
+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
+        guijemont on #webkit).
+
+        Reverted changeset:
+
+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
+        WEBKIT_COPY_FILES"
+        https://bugs.webkit.org/show_bug.cgi?id=197174
+        https://trac.webkit.org/changeset/244881
+
</ins><span class="cx"> 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
</span><span class="cx"> 
</span><span class="cx">         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
</span></span></pre></div>
<a id="trunkSourceWebCorePALpalCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/PAL/pal/CMakeLists.txt (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/PAL/pal/CMakeLists.txt      2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WebCore/PAL/pal/CMakeLists.txt 2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -51,7 +51,8 @@
</span><span class="cx"> WEBKIT_WRAP_SOURCELIST(${PAL_SOURCES})
</span><span class="cx"> WEBKIT_FRAMEWORK(PAL)
</span><span class="cx"> 
</span><del>-WEBKIT_COPY_FILES(PALFrameworkHeaders
</del><ins>+WEBKIT_MAKE_FORWARDING_HEADERS(PAL
+    TARGET_NAME PALFrameworkHeaders
</ins><span class="cx">     DESTINATION ${PAL_FRAMEWORK_HEADERS_DIR}/pal
</span><span class="cx">     FILES ${PAL_PUBLIC_HEADERS}
</span><span class="cx"> )
</span></span></pre></div>
<a id="trunkSourceWebKitCMakeListstxt"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/CMakeLists.txt (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/CMakeLists.txt       2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WebKit/CMakeLists.txt  2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -421,7 +421,7 @@
</span><span class="cx"> WEBKIT_COMPUTE_SOURCES(WebKit)
</span><span class="cx"> 
</span><span class="cx"> WEBKIT_FRAMEWORK(WebKit)
</span><del>-add_dependencies(WebKit WebCore WebCorePrivateFrameworkHeaders ${WEBKIT_EXTRA_DEPENDENCIES})
</del><ins>+add_dependencies(WebKit WebCore ${WEBKIT_EXTRA_DEPENDENCIES})
</ins><span class="cx"> ADD_WEBKIT_PREFIX_HEADER(WebKit)
</span><span class="cx"> 
</span><span class="cx"> add_executable(WebProcess ${WebProcess_SOURCES})
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WebKit/ChangeLog       2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244881.
+        https://bugs.webkit.org/show_bug.cgi?id=197559
+
+        Breaks compilation of jsconly on linux, breaking compilation
+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
+        guijemont on #webkit).
+
+        Reverted changeset:
+
+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
+        WEBKIT_COPY_FILES"
+        https://bugs.webkit.org/show_bug.cgi?id=197174
+        https://trac.webkit.org/changeset/244881
+
</ins><span class="cx"> 2019-05-02  Wenson Hsieh  <wenson_hsieh@apple.com>
</span><span class="cx"> 
</span><span class="cx">         REGRESSION: Layout test editing/selection/ios/selection-after-changing-text-with-callout-menu.html is failing
</span></span></pre></div>
<a id="trunkSourceWebKitPlatformWincmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/PlatformWin.cmake (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/PlatformWin.cmake    2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WebKit/PlatformWin.cmake       2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -370,7 +370,8 @@
</span><span class="cx">     )
</span><span class="cx"> endif ()
</span><span class="cx"> 
</span><del>-WEBKIT_COPY_FILES(WebKitFrameworkHeaders
</del><ins>+WEBKIT_MAKE_FORWARDING_HEADERS(WebKit
+    TARGET_NAME WebKitFrameworkHeaders
</ins><span class="cx">     DESTINATION ${WebKit_FRAMEWORK_HEADERS_DIR}/WebKit
</span><span class="cx">     FILES ${WebKit_PUBLIC_FRAMEWORK_HEADERS}
</span><span class="cx">     FLATTENED
</span></span></pre></div>
<a id="trunkSourceWebKitLegacyChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/ChangeLog (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/ChangeLog      2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WebKitLegacy/ChangeLog 2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244881.
+        https://bugs.webkit.org/show_bug.cgi?id=197559
+
+        Breaks compilation of jsconly on linux, breaking compilation
+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
+        guijemont on #webkit).
+
+        Reverted changeset:
+
+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
+        WEBKIT_COPY_FILES"
+        https://bugs.webkit.org/show_bug.cgi?id=197174
+        https://trac.webkit.org/changeset/244881
+
</ins><span class="cx"> 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
</span><span class="cx"> 
</span><span class="cx">         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
</span></span></pre></div>
<a id="trunkSourceWebKitLegacyPlatformWincmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKitLegacy/PlatformWin.cmake (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKitLegacy/PlatformWin.cmake      2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/WebKitLegacy/PlatformWin.cmake 2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -496,12 +496,13 @@
</span><span class="cx">     win/WebKitCOMAPI.h
</span><span class="cx"> )
</span><span class="cx"> 
</span><del>-WEBKIT_COPY_FILES(WebKitLegacyFrameworkHeaders
</del><ins>+WEBKIT_MAKE_FORWARDING_HEADERS(WebKitLegacyGUID
+    TARGET_NAME WebKitLegacyFrameworkHeaders
</ins><span class="cx">     DESTINATION ${WebKitLegacy_FRAMEWORK_HEADERS_DIR}/WebKitLegacy
</span><span class="cx">     FILES ${WebKitLegacy_PUBLIC_FRAMEWORK_HEADERS}
</span><span class="cx">     FLATTENED
</span><span class="cx"> )
</span><del>-add_dependencies(WebKitLegacyFrameworkHeaders WebKitLegacyGUID)
</del><ins>+add_dependencies(WebKitLegacyFrameworkHeaders WebCorePrivateFrameworkHeaders)
</ins><span class="cx"> 
</span><span class="cx"> set(WebKitLegacy_OUTPUT_NAME
</span><span class="cx">     WebKit${DEBUG_SUFFIX}
</span></span></pre></div>
<a id="trunkSourcecmakeWebKitMacroscmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/WebKitMacros.cmake (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/WebKitMacros.cmake    2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Source/cmake/WebKitMacros.cmake       2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -291,35 +291,46 @@
</span><span class="cx">     endif ()
</span><span class="cx"> endmacro()
</span><span class="cx"> 
</span><del>-function(WEBKIT_COPY_FILES target_name)
</del><ins>+function(WEBKIT_MAKE_FORWARDING_HEADERS framework)
</ins><span class="cx">     set(options FLATTENED)
</span><del>-    set(oneValueArgs DESTINATION)
-    set(multiValueArgs FILES)
</del><ins>+    set(oneValueArgs DESTINATION TARGET_NAME)
+    set(multiValueArgs DIRECTORIES FILES)
</ins><span class="cx">     cmake_parse_arguments(opt "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
</span><del>-    set(files ${opt_FILES})
-    set(dst_files)
-    foreach (file IN LISTS files)
-        if (IS_ABSOLUTE ${file})
-            set(src_file ${file})
</del><ins>+    set(headers ${opt_FILES})
+    file(MAKE_DIRECTORY ${opt_DESTINATION})
+    foreach (dir IN LISTS opt_DIRECTORIES)
+        file(GLOB files RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} ${dir}/*.h)
+        list(APPEND headers ${files})
+    endforeach ()
+    set(fwd_headers)
+    foreach (header IN LISTS headers)
+        if (IS_ABSOLUTE ${header})
+            set(src_header ${header})
</ins><span class="cx">         else ()
</span><del>-            set(src_file ${CMAKE_CURRENT_SOURCE_DIR}/${file})
</del><ins>+            set(src_header ${CMAKE_CURRENT_SOURCE_DIR}/${header})
</ins><span class="cx">         endif ()
</span><span class="cx">         if (opt_FLATTENED)
</span><del>-            get_filename_component(filename ${file} NAME)
-            set(dst_file ${opt_DESTINATION}/${filename})
</del><ins>+            get_filename_component(header_filename ${header} NAME)
+            set(fwd_header ${opt_DESTINATION}/${header_filename})
</ins><span class="cx">         else ()
</span><del>-            get_filename_component(file_dir ${file} DIRECTORY)
-            file(MAKE_DIRECTORY ${opt_DESTINATION}/${file_dir})
-            set(dst_file ${opt_DESTINATION}/${file})
</del><ins>+            get_filename_component(header_dir ${header} DIRECTORY)
+            file(MAKE_DIRECTORY ${opt_DESTINATION}/${header_dir})
+            set(fwd_header ${opt_DESTINATION}/${header})
</ins><span class="cx">         endif ()
</span><del>-        add_custom_command(OUTPUT ${dst_file}
-            COMMAND ${CMAKE_COMMAND} -E copy ${src_file} ${dst_file}
-            MAIN_DEPENDENCY ${file}
</del><ins>+        add_custom_command(OUTPUT ${fwd_header}
+            COMMAND ${CMAKE_COMMAND} -E copy ${src_header} ${fwd_header}
+            MAIN_DEPENDENCY ${header}
</ins><span class="cx">             VERBATIM
</span><span class="cx">         )
</span><del>-        list(APPEND dst_files ${dst_file})
</del><ins>+        list(APPEND fwd_headers ${fwd_header})
</ins><span class="cx">     endforeach ()
</span><del>-    add_custom_target(${target_name} DEPENDS ${dst_files})
</del><ins>+    if (opt_TARGET_NAME)
+        set(target_name ${opt_TARGET_NAME})
+    else ()
+        set(target_name ${framework}ForwardingHeaders)
+    endif ()
+    add_custom_target(${target_name} DEPENDS ${fwd_headers})
+    add_dependencies(${framework} ${target_name})
</ins><span class="cx"> endfunction()
</span><span class="cx"> 
</span><span class="cx"> # Helper macros for debugging CMake problems.
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Tools/ChangeLog       2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244881.
+        https://bugs.webkit.org/show_bug.cgi?id=197559
+
+        Breaks compilation of jsconly on linux, breaking compilation
+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
+        guijemont on #webkit).
+
+        Reverted changeset:
+
+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
+        WEBKIT_COPY_FILES"
+        https://bugs.webkit.org/show_bug.cgi?id=197174
+        https://trac.webkit.org/changeset/244881
+
</ins><span class="cx"> 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Unreviewed WPE build fix after r244898.
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPIPlatformGTKcmake"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/PlatformGTK.cmake (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/PlatformGTK.cmake      2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Tools/TestWebKitAPI/PlatformGTK.cmake 2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -119,10 +119,6 @@
</span><span class="cx">     JavaScriptCore
</span><span class="cx"> )
</span><span class="cx"> 
</span><del>-set(TestJSC_DEPENDENCIES
-    JavaScriptCorePrivateFrameworkHeaders
-)
-
</del><span class="cx"> set(TestJSC_DEFINITIONS
</span><span class="cx">     WEBKIT_SRC_DIR="${CMAKE_SOURCE_DIR}"
</span><span class="cx"> )
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPIPlatformWPEcmake"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/PlatformWPE.cmake (244906 => 244907)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/PlatformWPE.cmake      2019-05-03 13:19:57 UTC (rev 244906)
+++ trunk/Tools/TestWebKitAPI/PlatformWPE.cmake 2019-05-03 14:32:23 UTC (rev 244907)
</span><span class="lines">@@ -117,10 +117,6 @@
</span><span class="cx">     JavaScriptCore
</span><span class="cx"> )
</span><span class="cx"> 
</span><del>-set(TestJSC_DEPENDENCIES
-    JavaScriptCorePrivateFrameworkHeaders
-)
-
</del><span class="cx"> set(TestJSC_DEFINITIONS
</span><span class="cx">     WEBKIT_SRC_DIR="${CMAKE_SOURCE_DIR}"
</span><span class="cx"> )
</span></span></pre>
</div>
</div>

</body>
</html>