<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[244894] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/244894">244894</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2019-05-02 16:31:42 -0700 (Thu, 02 May 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Disable software keyboard for a math field textarea on desmos.com
https://bugs.webkit.org/show_bug.cgi?id=197488

Reviewed by Wenson Hsieh.

Treat a textarea inside a math field span as if it had inputmode content attribute set to none to suppress
the software keyboard on desmos.com as it interferes with website's own UI.

* html/HTMLElement.cpp:
(WebCore::HTMLElement::canonicalInputMode const):
* page/Quirks.cpp:
(WebCore::Quirks::needsInputModeNoneImplicitly const):
* page/Quirks.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementcpp">trunk/Source/WebCore/html/HTMLElement.cpp</a></li>
<li><a href="#trunkSourceWebCorepageQuirkscpp">trunk/Source/WebCore/page/Quirks.cpp</a></li>
<li><a href="#trunkSourceWebCorepageQuirksh">trunk/Source/WebCore/page/Quirks.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (244893 => 244894)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-05-02 23:22:40 UTC (rev 244893)
+++ trunk/Source/WebCore/ChangeLog      2019-05-02 23:31:42 UTC (rev 244894)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-05-02  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Disable software keyboard for a math field textarea on desmos.com
+        https://bugs.webkit.org/show_bug.cgi?id=197488
+
+        Reviewed by Wenson Hsieh.
+
+        Treat a textarea inside a math field span as if it had inputmode content attribute set to none to suppress
+        the software keyboard on desmos.com as it interferes with website's own UI.
+
+        * html/HTMLElement.cpp:
+        (WebCore::HTMLElement::canonicalInputMode const):
+        * page/Quirks.cpp:
+        (WebCore::Quirks::needsInputModeNoneImplicitly const):
+        * page/Quirks.h:
+
</ins><span class="cx"> 2019-05-02  Timothy Hatcher  <timothy@apple.com>
</span><span class="cx"> 
</span><span class="cx">         NSAttributedString conversion in a loop returns nil and WKUnknownError every other time.
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.cpp (244893 => 244894)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.cpp        2019-05-02 23:22:40 UTC (rev 244893)
+++ trunk/Source/WebCore/html/HTMLElement.cpp   2019-05-02 23:31:42 UTC (rev 244894)
</span><span class="lines">@@ -1108,7 +1108,12 @@
</span><span class="cx"> 
</span><span class="cx"> InputMode HTMLElement::canonicalInputMode() const
</span><span class="cx"> {
</span><del>-    return inputModeForAttributeValue(attributeWithoutSynchronization(inputmodeAttr));
</del><ins>+    auto mode = inputModeForAttributeValue(attributeWithoutSynchronization(inputmodeAttr));
+    if (mode == InputMode::Unspecified) {
+        if (document().quirks().needsInputModeNoneImplicitly(*this))
+            return InputMode::None;
+    }
+    return mode;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> const AtomicString& HTMLElement::inputMode() const
</span></span></pre></div>
<a id="trunkSourceWebCorepageQuirkscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Quirks.cpp (244893 => 244894)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Quirks.cpp     2019-05-02 23:22:40 UTC (rev 244893)
+++ trunk/Source/WebCore/page/Quirks.cpp        2019-05-02 23:31:42 UTC (rev 244894)
</span><span class="lines">@@ -265,4 +265,26 @@
</span><span class="cx">     return false;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+// FIXME(<rdar://problem/50394969>): Remove after desmos.com adopts inputmode="none".
+bool Quirks::needsInputModeNoneImplicitly(const HTMLElement& element) const
+{
+#if PLATFORM(IOS_FAMILY)
+    if (!needsQuirks())
+        return false;
+
+    if (!element.hasTagName(HTMLNames::textareaTag))
+        return false;
+
+    auto& url = m_document->url();
+    auto host = url.host();
+    if (!host.endsWithIgnoringASCIICase(".desmos.com"))
+        return false;
+
+    return element.parentElement() && element.parentElement()->classNames().contains("dcg-mq-textarea");
+#else
+    UNUSED_PARAM(element);
+    return false;
+#endif
</ins><span class="cx"> }
</span><ins>+
+}
</ins></span></pre></div>
<a id="trunkSourceWebCorepageQuirksh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Quirks.h (244893 => 244894)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Quirks.h       2019-05-02 23:22:40 UTC (rev 244893)
+++ trunk/Source/WebCore/page/Quirks.h  2019-05-02 23:31:42 UTC (rev 244894)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><span class="cx"> class Document;
</span><ins>+class HTMLElement;
</ins><span class="cx"> 
</span><span class="cx"> class Quirks {
</span><span class="cx">     WTF_MAKE_NONCOPYABLE(Quirks); WTF_MAKE_FAST_ALLOCATED;
</span><span class="lines">@@ -47,6 +48,7 @@
</span><span class="cx">     bool hasWebSQLSupportQuirk() const;
</span><span class="cx">     bool shouldDispatchSimulatedMouseEvents() const;
</span><span class="cx">     bool shouldDisablePointerEventsQuirk() const;
</span><ins>+    bool needsInputModeNoneImplicitly(const HTMLElement&) const;
</ins><span class="cx"> 
</span><span class="cx">     WEBCORE_EXPORT bool shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreas() const;
</span><span class="cx">     WEBCORE_EXPORT bool isTouchBarUpdateSupressedForHiddenContentEditable() const;
</span></span></pre>
</div>
</div>

</body>
</html>