<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[244797] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/244797">244797</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2019-04-30 13:09:44 -0700 (Tue, 30 Apr 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/244774">r244774</a>.
https://bugs.webkit.org/show_bug.cgi?id=197431

Causing assertion failures on debug queues (Requested by
ShawnRoberts on #webkit).

Reverted changeset:

"Reject/throw when calling AudioContext methods on a stopped
AudioContext"
https://bugs.webkit.org/show_bug.cgi?id=197391
https://trac.webkit.org/changeset/244774</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioAudioContextcpp">trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioAudioContexth">trunk/Source/WebCore/Modules/webaudio/AudioContext.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebaudioAudioContextidl">trunk/Source/WebCore/Modules/webaudio/AudioContext.idl</a></li>
</ul>

<h3>Removed Paths</h3>
<ul>
<li>trunk/LayoutTests/http/wpt/webaudio/</li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (244796 => 244797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-04-30 20:08:01 UTC (rev 244796)
+++ trunk/LayoutTests/ChangeLog 2019-04-30 20:09:44 UTC (rev 244797)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2019-04-30  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244774.
+        https://bugs.webkit.org/show_bug.cgi?id=197431
+
+        Causing assertion failures on debug queues (Requested by
+        ShawnRoberts on #webkit).
+
+        Reverted changeset:
+
+        "Reject/throw when calling AudioContext methods on a stopped
+        AudioContext"
+        https://bugs.webkit.org/show_bug.cgi?id=197391
+        https://trac.webkit.org/changeset/244774
+
</ins><span class="cx"> 2019-04-30  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Add WKContentRuleList ping resource-type
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (244796 => 244797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations  2019-04-30 20:08:01 UTC (rev 244796)
+++ trunk/LayoutTests/platform/win/TestExpectations     2019-04-30 20:09:44 UTC (rev 244797)
</span><span class="lines">@@ -494,7 +494,6 @@
</span><span class="cx"> 
</span><span class="cx"> # TODO For now, Web Audio tests are disabled
</span><span class="cx"> webkit.org/b/86914 webaudio/ [ Skip ]
</span><del>-webkit.org/b/86914 http/wpt/webaudio/ [ Skip ]
</del><span class="cx"> webkit.org/b/86914 fast/history/page-cache-closed-audiocontext.html [ Skip ]
</span><span class="cx"> webkit.org/b/86914 fast/history/page-cache-running-audiocontext.html [ Skip ]
</span><span class="cx"> webkit.org/b/86914 fast/history/page-cache-suspended-audiocontext.html [ Skip ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (244796 => 244797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-04-30 20:08:01 UTC (rev 244796)
+++ trunk/Source/WebCore/ChangeLog      2019-04-30 20:09:44 UTC (rev 244797)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2019-04-30  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244774.
+        https://bugs.webkit.org/show_bug.cgi?id=197431
+
+        Causing assertion failures on debug queues (Requested by
+        ShawnRoberts on #webkit).
+
+        Reverted changeset:
+
+        "Reject/throw when calling AudioContext methods on a stopped
+        AudioContext"
+        https://bugs.webkit.org/show_bug.cgi?id=197391
+        https://trac.webkit.org/changeset/244774
+
</ins><span class="cx"> 2019-04-30  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Add WKContentRuleList ping resource-type
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioAudioContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp (244796 => 244797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp   2019-04-30 20:08:01 UTC (rev 244796)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp      2019-04-30 20:09:44 UTC (rev 244797)
</span><span class="lines">@@ -216,8 +216,6 @@
</span><span class="cx"> 
</span><span class="cx"> void AudioContext::lazyInitialize()
</span><span class="cx"> {
</span><del>-    ASSERT(!m_isStopScheduled);
-
</del><span class="cx">     if (m_isInitialized)
</span><span class="cx">         return;
</span><span class="cx"> 
</span><span class="lines">@@ -432,15 +430,11 @@
</span><span class="cx">     m_audioDecoder.decodeAsync(WTFMove(audioData), sampleRate(), WTFMove(successCallback), WTFMove(errorCallback));
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<AudioBufferSourceNode>> AudioContext::createBufferSource()
</del><ins>+Ref<AudioBufferSourceNode> AudioContext::createBufferSource()
</ins><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><del>-
</del><ins>+    
</ins><span class="cx">     ASSERT(isMainThread());
</span><del>-
-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     Ref<AudioBufferSourceNode> node = AudioBufferSourceNode::create(*this, m_destinationNode->sampleRate());
</span><span class="cx"> 
</span><span class="lines">@@ -456,14 +450,13 @@
</span><span class="cx"> ExceptionOr<Ref<MediaElementAudioSourceNode>> AudioContext::createMediaElementSource(HTMLMediaElement& mediaElement)
</span><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><del>-
</del><ins>+    
</ins><span class="cx">     ASSERT(isMainThread());
</span><del>-
-    if (m_isStopScheduled || mediaElement.audioSourceNode())
</del><ins>+    lazyInitialize();
+    
+    if (mediaElement.audioSourceNode())
</ins><span class="cx">         return Exception { InvalidStateError };
</span><span class="cx"> 
</span><del>-    lazyInitialize();
-    
</del><span class="cx">     auto node = MediaElementAudioSourceNode::create(*this, mediaElement);
</span><span class="cx"> 
</span><span class="cx">     mediaElement.setAudioSourceNode(node.ptr());
</span><span class="lines">@@ -482,9 +475,6 @@
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><span class="cx"> 
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     auto audioTracks = mediaStream.getAudioTracks();
</span><span class="cx">     if (audioTracks.isEmpty())
</span><span class="cx">         return Exception { InvalidStateError };
</span><span class="lines">@@ -508,11 +498,8 @@
</span><span class="cx">     return node;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<MediaStreamAudioDestinationNode>> AudioContext::createMediaStreamDestination()
</del><ins>+Ref<MediaStreamAudioDestinationNode> AudioContext::createMediaStreamDestination()
</ins><span class="cx"> {
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     // FIXME: Add support for an optional argument which specifies the number of channels.
</span><span class="cx">     // FIXME: The default should probably be stereo instead of mono.
</span><span class="cx">     return MediaStreamAudioDestinationNode::create(*this, 1);
</span><span class="lines">@@ -525,10 +512,6 @@
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-
-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx"> 
</span><span class="cx">     // W3C Editor's Draft 06 June 2017
</span><span class="lines">@@ -584,87 +567,65 @@
</span><span class="cx">     return node;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<BiquadFilterNode>> AudioContext::createBiquadFilter()
</del><ins>+Ref<BiquadFilterNode> AudioContext::createBiquadFilter()
</ins><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><del>-
</del><span class="cx">     return BiquadFilterNode::create(*this, m_destinationNode->sampleRate());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<WaveShaperNode>> AudioContext::createWaveShaper()
</del><ins>+Ref<WaveShaperNode> AudioContext::createWaveShaper()
</ins><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     return WaveShaperNode::create(*this);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<PannerNode>> AudioContext::createPanner()
</del><ins>+Ref<PannerNode> AudioContext::createPanner()
</ins><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     return PannerNode::create(*this, m_destinationNode->sampleRate());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<ConvolverNode>> AudioContext::createConvolver()
</del><ins>+Ref<ConvolverNode> AudioContext::createConvolver()
</ins><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     return ConvolverNode::create(*this, m_destinationNode->sampleRate());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<DynamicsCompressorNode>> AudioContext::createDynamicsCompressor()
</del><ins>+Ref<DynamicsCompressorNode> AudioContext::createDynamicsCompressor()
</ins><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     return DynamicsCompressorNode::create(*this, m_destinationNode->sampleRate());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<AnalyserNode>> AudioContext::createAnalyser()
</del><ins>+Ref<AnalyserNode> AudioContext::createAnalyser()
</ins><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     return AnalyserNode::create(*this, m_destinationNode->sampleRate());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<GainNode>> AudioContext::createGain()
</del><ins>+Ref<GainNode> AudioContext::createGain()
</ins><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     return GainNode::create(*this, m_destinationNode->sampleRate());
</span><span class="cx"> }
</span><span class="lines">@@ -674,9 +635,6 @@
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     return DelayNode::create(*this, m_destinationNode->sampleRate(), maxDelayTime);
</span><span class="cx"> }
</span><span class="lines">@@ -686,9 +644,6 @@
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     auto node = ChannelSplitterNode::create(*this, m_destinationNode->sampleRate(), numberOfOutputs);
</span><span class="cx">     if (!node)
</span><span class="lines">@@ -701,9 +656,6 @@
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx">     auto node = ChannelMergerNode::create(*this, m_destinationNode->sampleRate(), numberOfInputs);
</span><span class="cx">     if (!node)
</span><span class="lines">@@ -711,14 +663,11 @@
</span><span class="cx">     return node.releaseNonNull();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-ExceptionOr<Ref<OscillatorNode>> AudioContext::createOscillator()
</del><ins>+Ref<OscillatorNode> AudioContext::createOscillator()
</ins><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     lazyInitialize();
</span><span class="cx"> 
</span><span class="cx">     Ref<OscillatorNode> node = OscillatorNode::create(*this, m_destinationNode->sampleRate());
</span><span class="lines">@@ -735,9 +684,6 @@
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><span class="cx">     
</span><span class="cx">     ASSERT(isMainThread());
</span><del>-    if (m_isStopScheduled)
-        return Exception { InvalidStateError };
-
</del><span class="cx">     if (real.length() != imaginary.length() || (real.length() > MaxPeriodicWaveLength) || !real.length())
</span><span class="cx">         return Exception { IndexSizeError };
</span><span class="cx">     lazyInitialize();
</span><span class="lines">@@ -1132,7 +1078,7 @@
</span><span class="cx"> void AudioContext::startRendering()
</span><span class="cx"> {
</span><span class="cx">     ALWAYS_LOG(LOGIDENTIFIER);
</span><del>-    if (m_isStopScheduled || !willBeginPlayback())
</del><ins>+    if (!willBeginPlayback())
</ins><span class="cx">         return;
</span><span class="cx"> 
</span><span class="cx">     destination()->startRendering();
</span><span class="lines">@@ -1204,7 +1150,7 @@
</span><span class="cx"> 
</span><span class="cx"> void AudioContext::suspend(DOMPromiseDeferred<void>&& promise)
</span><span class="cx"> {
</span><del>-    if (isOfflineContext() || m_isStopScheduled) {
</del><ins>+    if (isOfflineContext()) {
</ins><span class="cx">         promise.reject(InvalidStateError);
</span><span class="cx">         return;
</span><span class="cx">     }
</span><span class="lines">@@ -1233,7 +1179,7 @@
</span><span class="cx"> 
</span><span class="cx"> void AudioContext::resume(DOMPromiseDeferred<void>&& promise)
</span><span class="cx"> {
</span><del>-    if (isOfflineContext() || m_isStopScheduled) {
</del><ins>+    if (isOfflineContext()) {
</ins><span class="cx">         promise.reject(InvalidStateError);
</span><span class="cx">         return;
</span><span class="cx">     }
</span><span class="lines">@@ -1262,7 +1208,7 @@
</span><span class="cx"> 
</span><span class="cx"> void AudioContext::close(DOMPromiseDeferred<void>&& promise)
</span><span class="cx"> {
</span><del>-    if (isOfflineContext() || m_isStopScheduled) {
</del><ins>+    if (isOfflineContext()) {
</ins><span class="cx">         promise.reject(InvalidStateError);
</span><span class="cx">         return;
</span><span class="cx">     }
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioAudioContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.h (244796 => 244797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/AudioContext.h     2019-04-30 20:08:01 UTC (rev 244796)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.h        2019-04-30 20:09:44 UTC (rev 244797)
</span><span class="lines">@@ -134,26 +134,26 @@
</span><span class="cx">     bool wouldTaintOrigin(const URL&) const;
</span><span class="cx"> 
</span><span class="cx">     // The AudioNode create methods are called on the main thread (from JavaScript).
</span><del>-    ExceptionOr<Ref<AudioBufferSourceNode>> createBufferSource();
</del><ins>+    Ref<AudioBufferSourceNode> createBufferSource();
</ins><span class="cx"> #if ENABLE(VIDEO)
</span><span class="cx">     ExceptionOr<Ref<MediaElementAudioSourceNode>> createMediaElementSource(HTMLMediaElement&);
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(MEDIA_STREAM)
</span><span class="cx">     ExceptionOr<Ref<MediaStreamAudioSourceNode>> createMediaStreamSource(MediaStream&);
</span><del>-    ExceptionOr<Ref<MediaStreamAudioDestinationNode>> createMediaStreamDestination();
</del><ins>+    Ref<MediaStreamAudioDestinationNode> createMediaStreamDestination();
</ins><span class="cx"> #endif
</span><del>-    ExceptionOr<Ref<GainNode>> createGain();
-    ExceptionOr<Ref<BiquadFilterNode>> createBiquadFilter();
-    ExceptionOr<Ref<WaveShaperNode>> createWaveShaper();
</del><ins>+    Ref<GainNode> createGain();
+    Ref<BiquadFilterNode> createBiquadFilter();
+    Ref<WaveShaperNode> createWaveShaper();
</ins><span class="cx">     ExceptionOr<Ref<DelayNode>> createDelay(double maxDelayTime);
</span><del>-    ExceptionOr<Ref<PannerNode>> createPanner();
-    ExceptionOr<Ref<ConvolverNode>> createConvolver();
-    ExceptionOr<Ref<DynamicsCompressorNode>> createDynamicsCompressor();
-    ExceptionOr<Ref<AnalyserNode>> createAnalyser();
</del><ins>+    Ref<PannerNode> createPanner();
+    Ref<ConvolverNode> createConvolver();
+    Ref<DynamicsCompressorNode> createDynamicsCompressor();
+    Ref<AnalyserNode> createAnalyser();
</ins><span class="cx">     ExceptionOr<Ref<ScriptProcessorNode>> createScriptProcessor(size_t bufferSize, size_t numberOfInputChannels, size_t numberOfOutputChannels);
</span><span class="cx">     ExceptionOr<Ref<ChannelSplitterNode>> createChannelSplitter(size_t numberOfOutputs);
</span><span class="cx">     ExceptionOr<Ref<ChannelMergerNode>> createChannelMerger(size_t numberOfInputs);
</span><del>-    ExceptionOr<Ref<OscillatorNode>> createOscillator();
</del><ins>+    Ref<OscillatorNode> createOscillator();
</ins><span class="cx">     ExceptionOr<Ref<PeriodicWave>> createPeriodicWave(Float32Array& real, Float32Array& imaginary);
</span><span class="cx"> 
</span><span class="cx">     // When a source node has no more processing to do (has finished playing), then it tells the context to dereference it.
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebaudioAudioContextidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.idl (244796 => 244797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webaudio/AudioContext.idl   2019-04-30 20:08:01 UTC (rev 244796)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.idl      2019-04-30 20:09:44 UTC (rev 244797)
</span><span class="lines">@@ -69,24 +69,24 @@
</span><span class="cx">     void decodeAudioData(ArrayBuffer audioData, AudioBufferCallback? successCallback, optional AudioBufferCallback? errorCallback);
</span><span class="cx"> 
</span><span class="cx">     // Sources
</span><del>-    [MayThrowException] AudioBufferSourceNode createBufferSource();
</del><ins>+    AudioBufferSourceNode createBufferSource();
</ins><span class="cx"> 
</span><span class="cx">     [Conditional=VIDEO, MayThrowException] MediaElementAudioSourceNode createMediaElementSource(HTMLMediaElement mediaElement);
</span><span class="cx"> 
</span><span class="cx">     [Conditional=MEDIA_STREAM, MayThrowException] MediaStreamAudioSourceNode createMediaStreamSource(MediaStream mediaStream);
</span><del>-    [Conditional=MEDIA_STREAM, MayThrowException] MediaStreamAudioDestinationNode createMediaStreamDestination();
</del><ins>+    [Conditional=MEDIA_STREAM] MediaStreamAudioDestinationNode createMediaStreamDestination();
</ins><span class="cx"> 
</span><span class="cx">     // Processing nodes
</span><del>-    [MayThrowException] GainNode createGain();
</del><ins>+    GainNode createGain();
</ins><span class="cx">     [MayThrowException] DelayNode createDelay(optional unrestricted double maxDelayTime = 1);
</span><del>-    [MayThrowException] BiquadFilterNode createBiquadFilter();
-    [MayThrowException] WaveShaperNode createWaveShaper();
-    [MayThrowException] PannerNode createPanner();
-    [MayThrowException] ConvolverNode createConvolver();
-    [MayThrowException] DynamicsCompressorNode createDynamicsCompressor();
-    [MayThrowException] AnalyserNode createAnalyser();
</del><ins>+    BiquadFilterNode createBiquadFilter();
+    WaveShaperNode createWaveShaper();
+    PannerNode createPanner();
+    ConvolverNode createConvolver();
+    DynamicsCompressorNode createDynamicsCompressor();
+    AnalyserNode createAnalyser();
</ins><span class="cx">     [MayThrowException] ScriptProcessorNode createScriptProcessor(optional unsigned long bufferSize = 0, optional unsigned long numberOfInputChannels = 2, optional unsigned long numberOfOutputChannels = 2);
</span><del>-    [MayThrowException] OscillatorNode createOscillator();
</del><ins>+    OscillatorNode createOscillator();
</ins><span class="cx">     [MayThrowException] PeriodicWave createPeriodicWave(Float32Array real, Float32Array imag);
</span><span class="cx"> 
</span><span class="cx">     // Channel splitting and merging
</span></span></pre>
</div>
</div>

</body>
</html>