<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[244752] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/244752">244752</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2019-04-29 13:45:26 -0700 (Mon, 29 Apr 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/238090">r238090</a>): animation on https://www.robotodyssey.online gets stuck; site broken
https://bugs.webkit.org/show_bug.cgi?id=197381
Source/WebCore:

Reviewed by Zalan Bujtas.

When -webkit-clip-path changes on a composited layer, we need to trigger a backing geometry update
to push the changes to GraphicsLayers.

Test: compositing/style-change/clip-path-change.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::recompositeChangeRequiresGeometryUpdate):

LayoutTests:

<rdar://problem/50308128>

Reviewed by Zalan Bujtas.

* compositing/style-change/clip-path-change-expected.html: Added.
* compositing/style-change/clip-path-change.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerCompositorcpp">trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscompositingstylechangeclippathchangeexpectedhtml">trunk/LayoutTests/compositing/style-change/clip-path-change-expected.html</a></li>
<li><a href="#trunkLayoutTestscompositingstylechangeclippathchangehtml">trunk/LayoutTests/compositing/style-change/clip-path-change.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (244751 => 244752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-04-29 20:34:16 UTC (rev 244751)
+++ trunk/LayoutTests/ChangeLog 2019-04-29 20:45:26 UTC (rev 244752)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2019-04-29  Javier Fernandez  <jfernandez@igalia.com>
+
+        line should not be broken before the first space after a word
+        https://bugs.webkit.org/show_bug.cgi?id=197278
+
+        Reviewed by Myles C. Maxfield.
+
+        Added a few Skip (due to unimplemented features) and Failure (break-all related
+        issues) entries for some of the tests added by this patch.
+
+        * TestExpectations:
+
</ins><span class="cx"> 2019-04-29  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         getDisplayMedia should be called on user gesture
</span><span class="lines">@@ -15,18 +27,17 @@
</span><span class="cx"> 
</span><span class="cx">         * resources/testharnessreport.js:
</span><span class="cx"> 
</span><del>-2019-04-29  Javier Fernandez  <jfernandez@igalia.com>
</del><ins>+2019-04-29  Simon Fraser  <simon.fraser@apple.com>
</ins><span class="cx"> 
</span><del>-        line should not be broken before the first space after a word
-        https://bugs.webkit.org/show_bug.cgi?id=197278
</del><ins>+        REGRESSION (r238090): animation on https://www.robotodyssey.online gets stuck; site broken
+        https://bugs.webkit.org/show_bug.cgi?id=197381
+        <rdar://problem/50308128>
</ins><span class="cx"> 
</span><del>-        Reviewed by Myles C. Maxfield.
</del><ins>+        Reviewed by Zalan Bujtas.
</ins><span class="cx"> 
</span><del>-        Added a few Skip (due to unimplemented features) and Failure (break-all related
-        issues) entries for some of the tests added by this patch.
</del><ins>+        * compositing/style-change/clip-path-change-expected.html: Added.
+        * compositing/style-change/clip-path-change.html: Added.
</ins><span class="cx"> 
</span><del>-        * TestExpectations:
-
</del><span class="cx"> 2019-04-29  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         RTCTrackEvent should be delayed until the whole remote description is set
</span></span></pre></div>
<a id="trunkLayoutTestscompositingstylechangeclippathchangeexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/style-change/clip-path-change-expected.html (0 => 244752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/style-change/clip-path-change-expected.html                                (rev 0)
+++ trunk/LayoutTests/compositing/style-change/clip-path-change-expected.html   2019-04-29 20:45:26 UTC (rev 244752)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+    <style>
+        .container {
+            margin: 50px;
+            height: 300px;
+            width: 300px;
+            border: 1px solid black;
+        }
+        
+        .clipped {
+            width: 100%;
+            height: 100%;
+            background-color: blue;
+            transform: translateZ(0);
+            -webkit-clip-path: circle(50% at center);
+        }
+    </style>
+</head>
+<body>
+    <div class="container">
+        <div class="clipped"></div>
+    </div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestscompositingstylechangeclippathchangehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/style-change/clip-path-change.html (0 => 244752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/style-change/clip-path-change.html                         (rev 0)
+++ trunk/LayoutTests/compositing/style-change/clip-path-change.html    2019-04-29 20:45:26 UTC (rev 244752)
</span><span class="lines">@@ -0,0 +1,42 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+    <style>
+        .container {
+            margin: 50px;
+            height: 300px;
+            width: 300px;
+            border: 1px solid black;
+        }
+        
+        .clipped {
+            width: 100%;
+            height: 100%;
+            background-color: blue;
+            transform: translateZ(0);
+            -webkit-clip-path: circle(10% at center);
+        }
+        
+        .clipped.changed {
+            -webkit-clip-path: circle(50% at center);
+        }
+    </style>
+    <script>
+        if (window.testRunner)
+            testRunner.waitUntilDone();
+
+        window.addEventListener('load', () => {
+            setTimeout(() => {
+                document.querySelector('.clipped').classList.add('changed');
+                if (window.testRunner)
+                    testRunner.notifyDone();
+            }, 0);
+        }, false);
+    </script>
+</head>
+<body>
+    <div class="container">
+        <div class="clipped"></div>
+    </div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (244751 => 244752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-04-29 20:34:16 UTC (rev 244751)
+++ trunk/Source/WebCore/ChangeLog      2019-04-29 20:45:26 UTC (rev 244752)
</span><span class="lines">@@ -73,6 +73,21 @@
</span><span class="cx">         (WebCore::BreakingContext::handleText):
</span><span class="cx">         (WebCore::BreakingContext::trailingSpacesHang):
</span><span class="cx"> 
</span><ins>+2019-04-29  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r238090): animation on https://www.robotodyssey.online gets stuck; site broken
+        https://bugs.webkit.org/show_bug.cgi?id=197381
+
+        Reviewed by Zalan Bujtas.
+
+        When -webkit-clip-path changes on a composited layer, we need to trigger a backing geometry update
+        to push the changes to GraphicsLayers.
+
+        Test: compositing/style-change/clip-path-change.html
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::recompositeChangeRequiresGeometryUpdate):
+
</ins><span class="cx"> 2019-04-29  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><span class="cx">         User-facing strings should use curly quotes instead of straight
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerCompositorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (244751 => 244752)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2019-04-29 20:34:16 UTC (rev 244751)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp    2019-04-29 20:45:26 UTC (rev 244752)
</span><span class="lines">@@ -1434,7 +1434,8 @@
</span><span class="cx">         || oldStyle.perspective() != newStyle.perspective()
</span><span class="cx">         || oldStyle.perspectiveOriginX() != newStyle.perspectiveOriginX()
</span><span class="cx">         || oldStyle.perspectiveOriginY() != newStyle.perspectiveOriginY()
</span><del>-        || oldStyle.backfaceVisibility() != newStyle.backfaceVisibility();
</del><ins>+        || oldStyle.backfaceVisibility() != newStyle.backfaceVisibility()
+        || !arePointingToEqualData(oldStyle.clipPath(), newStyle.clipPath());
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void RenderLayerCompositor::layerStyleChanged(StyleDifference diff, RenderLayer& layer, const RenderStyle* oldStyle)
</span></span></pre>
</div>
</div>

</body>
</html>