<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[244674] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/244674">244674</a></dd>
<dt>Author</dt> <dd>sihui_liu@apple.com</dd>
<dt>Date</dt> <dd>2019-04-25 18:58:33 -0700 (Thu, 25 Apr 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>[ iOS Sim ] REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/242986">r242986</a>) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196357
<rdar://problem/49386836>

Reviewed by Geoffrey Garen.

Source/WebCore:

Dispatch IDBRequest event to IDBTransaction if event of IDBTransaction has not been dispatched.

Covered by existing tests.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::dispatchEvent):
* Modules/indexeddb/IDBTransaction.h:

LayoutTests:

* platform/ios-simulator-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorwk2TestExpectations">trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBRequestcpp">trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBTransactioncpp">trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBTransactionh">trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (244673 => 244674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-04-26 01:28:39 UTC (rev 244673)
+++ trunk/LayoutTests/ChangeLog 2019-04-26 01:58:33 UTC (rev 244674)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2019-04-25  Sihui Liu  <sihui_liu@apple.com>
+
+        [ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=196357
+        <rdar://problem/49386836>
+
+        Reviewed by Geoffrey Garen.
+
+        * platform/ios-simulator-wk2/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+        * platform/mac/TestExpectations:
+
</ins><span class="cx"> 2019-04-25  Shawn Roberts  <sroberts@apple.com>
</span><span class="cx"> 
</span><span class="cx">         fast/harness/render-tree-as-text-options.html Rebaselined test for windows
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (244673 => 244674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations    2019-04-26 01:28:39 UTC (rev 244673)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations       2019-04-26 01:58:33 UTC (rev 244674)
</span><span class="lines">@@ -75,8 +75,6 @@
</span><span class="cx"> webkit.org/b/196112 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html [ Pass ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/196112 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html [ Pass ImageOnlyFailure ]
</span><span class="cx"> 
</span><del>-webkit.org/b/196357 storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html [ Pass Failure ]
-
</del><span class="cx"> http/wpt/cache-storage/quota-third-party.https.html [ Slow ]
</span><span class="cx"> http/wpt/fetch/response-opaque-clone.html [ Slow ]
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (244673 => 244674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations  2019-04-26 01:28:39 UTC (rev 244673)
+++ trunk/LayoutTests/platform/mac/TestExpectations     2019-04-26 01:58:33 UTC (rev 244674)
</span><span class="lines">@@ -1593,8 +1593,6 @@
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/165311 [ Sierra+ ] media/modern-media-controls/pip-support/pip-support-click.html [ Pass Failure ]
</span><span class="cx"> 
</span><del>-webkit.org/b/176693 storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html [ Pass Failure ]
-
</del><span class="cx"> # User-installed font infrastructure is ony present on certain OSes.
</span><span class="cx"> webkit.org/b/180062 [ Sierra HighSierra ] fast/text/user-installed-fonts/disable.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/180062 fast/text/user-installed-fonts/shadow-postscript.html [ ImageOnlyFailure ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (244673 => 244674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations      2019-04-26 01:28:39 UTC (rev 244673)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-04-26 01:58:33 UTC (rev 244674)
</span><span class="lines">@@ -673,8 +673,6 @@
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/171837 [ Debug ] http/tests/security/storage-blocking-loosened-plugin.html [ Pass Failure ]
</span><span class="cx"> 
</span><del>-webkit.org/b/171862  storage/indexeddb/modern/idbtransaction-objectstore-failures.html [ Pass Failure ]
-
</del><span class="cx"> webkit.org/b/171935 [ Sierra ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html [ Pass Failure ]
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/171939 [ Sierra Release ] media/track/track-cue-rendering-on-resize.html [ Pass Timeout ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (244673 => 244674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-04-26 01:28:39 UTC (rev 244673)
+++ trunk/Source/WebCore/ChangeLog      2019-04-26 01:58:33 UTC (rev 244674)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2019-04-25  Sihui Liu  <sihui_liu@apple.com>
+
+        [ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=196357
+        <rdar://problem/49386836>
+
+        Reviewed by Geoffrey Garen.
+
+        Dispatch IDBRequest event to IDBTransaction if event of IDBTransaction has not been dispatched.
+
+        Covered by existing tests.
+
+        * Modules/indexeddb/IDBRequest.cpp:
+        (WebCore::IDBRequest::dispatchEvent):
+        * Modules/indexeddb/IDBTransaction.cpp:
+        (WebCore::IDBTransaction::dispatchEvent):
+        * Modules/indexeddb/IDBTransaction.h:
+
</ins><span class="cx"> 2019-04-25  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><span class="cx">         ASSERT(scriptExecutionContext()) in Performance::resourceTimingBufferFullTimerFired()
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBRequestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (244673 => 244674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp    2019-04-26 01:28:39 UTC (rev 244673)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp       2019-04-26 01:58:33 UTC (rev 244674)
</span><span class="lines">@@ -318,7 +318,7 @@
</span><span class="cx"> 
</span><span class="cx">     if (&event == m_openDatabaseSuccessEvent)
</span><span class="cx">         m_openDatabaseSuccessEvent = nullptr;
</span><del>-    else if (m_transaction && !m_transaction->isFinished())
</del><ins>+    else if (m_transaction && !m_transaction->didDispatchAbortOrCommit())
</ins><span class="cx">         targets = { this, m_transaction.get(), &m_transaction->database() };
</span><span class="cx"> 
</span><span class="cx">     m_hasPendingActivity = false;
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBTransactioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp (244673 => 244674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp        2019-04-26 01:28:39 UTC (rev 244673)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp   2019-04-26 01:58:33 UTC (rev 244674)
</span><span class="lines">@@ -641,6 +641,7 @@
</span><span class="cx">     auto protectedThis = makeRef(*this);
</span><span class="cx"> 
</span><span class="cx">     EventDispatcher::dispatchEvent({ this, m_database.ptr() }, event);
</span><ins>+    m_didDispatchAbortOrCommit = true;
</ins><span class="cx"> 
</span><span class="cx">     if (isVersionChange()) {
</span><span class="cx">         ASSERT(m_openDBRequest);
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBTransactionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h (244673 => 244674)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h  2019-04-26 01:28:39 UTC (rev 244673)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h     2019-04-26 01:58:33 UTC (rev 244674)
</span><span class="lines">@@ -146,6 +146,7 @@
</span><span class="cx"> 
</span><span class="cx">     bool isFinishedOrFinishing() const;
</span><span class="cx">     bool isFinished() const { return m_state == IndexedDB::TransactionState::Finished; }
</span><ins>+    bool didDispatchAbortOrCommit() const { return m_didDispatchAbortOrCommit; }
</ins><span class="cx"> 
</span><span class="cx">     IDBClient::IDBConnectionProxy& connectionProxy();
</span><span class="cx"> 
</span><span class="lines">@@ -261,6 +262,7 @@
</span><span class="cx">     RefPtr<IDBRequest> m_currentlyCompletingRequest;
</span><span class="cx"> 
</span><span class="cx">     bool m_contextStopped { false };
</span><ins>+    bool m_didDispatchAbortOrCommit { false };
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> class TransactionActivator {
</span></span></pre>
</div>
</div>

</body>
</html>