<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[244019] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/244019">244019</a></dd>
<dt>Author</dt> <dd>csaavedra@igalia.com</dd>
<dt>Date</dt> <dd>2019-04-08 07:45:08 -0700 (Mon, 08 Apr 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>[JSC] Partially fix the build with unified builds disabled
https://bugs.webkit.org/show_bug.cgi?id=196647

Reviewed by Konstantin Tokarev.

If you disable unified builds you find all kind of build
errors. This partially tries to fix them but there's a lot
more.

* API/JSBaseInternal.h:
* b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
* b3/air/AirHandleCalleeSaves.h:
* bytecode/ExecutableToCodeBlockEdge.cpp:
* bytecode/ExitFlag.h:
* bytecode/ICStatusUtils.h:
* bytecode/UnlinkedMetadataTable.h:
* dfg/DFGPureValue.h:
* heap/IsoAlignedMemoryAllocator.cpp:
* heap/IsoAlignedMemoryAllocator.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreAPIJSBaseInternalh">trunk/Source/JavaScriptCore/API/JSBaseInternal.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3airAirAllocateRegistersAndStackAndGenerateCodecpp">trunk/Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreb3airAirHandleCalleeSavesh">trunk/Source/JavaScriptCore/b3/air/AirHandleCalleeSaves.h</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeExecutableToCodeBlockEdgecpp">trunk/Source/JavaScriptCore/bytecode/ExecutableToCodeBlockEdge.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeExitFlagh">trunk/Source/JavaScriptCore/bytecode/ExitFlag.h</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeICStatusUtilsh">trunk/Source/JavaScriptCore/bytecode/ICStatusUtils.h</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeUnlinkedMetadataTableh">trunk/Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGPureValueh">trunk/Source/JavaScriptCore/dfg/DFGPureValue.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreheapIsoAlignedMemoryAllocatorcpp">trunk/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreheapIsoAlignedMemoryAllocatorh">trunk/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreAPIJSBaseInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/API/JSBaseInternal.h (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/API/JSBaseInternal.h 2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/API/JSBaseInternal.h    2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx"> namespace JSC {
</span><span class="cx"> class JSLockHolder;
</span><span class="cx"> class ExecState;
</span><ins>+class SourceCode;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> extern "C" JSValueRef JSEvaluateScriptInternal(const JSC::JSLockHolder&, JSC::ExecState*, JSContextRef, JSObjectRef thisObject, const JSC::SourceCode&, JSValueRef* exception);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/ChangeLog       2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2019-04-08  Claudio Saavedra  <csaavedra@igalia.com>
+
+        [JSC] Partially fix the build with unified builds disabled
+        https://bugs.webkit.org/show_bug.cgi?id=196647
+
+        Reviewed by Konstantin Tokarev.
+
+        If you disable unified builds you find all kind of build
+        errors. This partially tries to fix them but there's a lot
+        more.
+
+        * API/JSBaseInternal.h:
+        * b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
+        * b3/air/AirHandleCalleeSaves.h:
+        * bytecode/ExecutableToCodeBlockEdge.cpp:
+        * bytecode/ExitFlag.h:
+        * bytecode/ICStatusUtils.h:
+        * bytecode/UnlinkedMetadataTable.h:
+        * dfg/DFGPureValue.h:
+        * heap/IsoAlignedMemoryAllocator.cpp:
+        * heap/IsoAlignedMemoryAllocator.h:
+
</ins><span class="cx"> 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Enable DFG on MIPS
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3airAirAllocateRegistersAndStackAndGenerateCodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp       2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp  2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(B3_JIT)
</span><span class="cx"> 
</span><ins>+#include "AirArgInlines.h"
</ins><span class="cx"> #include "AirBlockInsertionSet.h"
</span><span class="cx"> #include "AirCode.h"
</span><span class="cx"> #include "AirHandleCalleeSaves.h"
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreb3airAirHandleCalleeSavesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/b3/air/AirHandleCalleeSaves.h (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/b3/air/AirHandleCalleeSaves.h        2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/b3/air/AirHandleCalleeSaves.h   2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -27,8 +27,12 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(B3_JIT)
</span><span class="cx"> 
</span><del>-namespace JSC { namespace B3 { namespace Air {
</del><ins>+namespace JSC {
</ins><span class="cx"> 
</span><ins>+class RegisterSet;
+
+namespace B3 { namespace Air {
+
</ins><span class="cx"> class Code;
</span><span class="cx"> 
</span><span class="cx"> // This utility identifies callee-save registers and tells Code. It's called from phases that
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeExecutableToCodeBlockEdgecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/ExecutableToCodeBlockEdge.cpp (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/ExecutableToCodeBlockEdge.cpp       2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/bytecode/ExecutableToCodeBlockEdge.cpp  2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -26,6 +26,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "ExecutableToCodeBlockEdge.h"
</span><span class="cx"> 
</span><ins>+#include "CodeBlock.h"
</ins><span class="cx"> #include "IsoCellSetInlines.h"
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeExitFlagh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/ExitFlag.h (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/ExitFlag.h  2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/bytecode/ExitFlag.h     2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -27,6 +27,10 @@
</span><span class="cx"> 
</span><span class="cx"> #include "ExitingInlineKind.h"
</span><span class="cx"> 
</span><ins>+namespace WTF {
+class PrintStream;
+} // namespace WTF
+
</ins><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><span class="cx"> class ExitFlag {
</span><span class="lines">@@ -87,7 +91,7 @@
</span><span class="cx">         return !!(*this & ExitFlag(true, inlineKind));
</span><span class="cx">     }
</span><span class="cx">     
</span><del>-    void dump(PrintStream&) const;
</del><ins>+    void dump(WTF::PrintStream&) const;
</ins><span class="cx">     
</span><span class="cx"> private:
</span><span class="cx">     static constexpr uint8_t trueNotInlined = 1;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeICStatusUtilsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/ICStatusUtils.h (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/ICStatusUtils.h     2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/bytecode/ICStatusUtils.h        2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -29,6 +29,9 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><ins>+class CodeBlock;
+class StructureSet;
+
</ins><span class="cx"> template<typename VariantVectorType, typename VariantType>
</span><span class="cx"> bool appendICStatusVariant(VariantVectorType& variants, const VariantType& variant)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeUnlinkedMetadataTableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h     2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h        2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> 
</span><span class="cx"> #include "Opcode.h"
</span><span class="cx"> #include <wtf/Ref.h>
</span><ins>+#include <wtf/RefCounted.h>
</ins><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGPureValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGPureValue.h (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGPureValue.h   2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/dfg/DFGPureValue.h      2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(DFG_JIT)
</span><span class="cx"> 
</span><ins>+#include "DFGGraph.h"
</ins><span class="cx"> #include "DFGNode.h"
</span><span class="cx"> 
</span><span class="cx"> namespace JSC { namespace DFG {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreheapIsoAlignedMemoryAllocatorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp   2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.cpp      2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -25,6 +25,7 @@
</span><span class="cx"> 
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "IsoAlignedMemoryAllocator.h"
</span><ins>+#include "MarkedBlock.h"
</ins><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreheapIsoAlignedMemoryAllocatorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.h (244018 => 244019)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.h     2019-04-08 12:40:04 UTC (rev 244018)
+++ trunk/Source/JavaScriptCore/heap/IsoAlignedMemoryAllocator.h        2019-04-08 14:45:08 UTC (rev 244019)
</span><span class="lines">@@ -26,6 +26,9 @@
</span><span class="cx"> #pragma once
</span><span class="cx"> 
</span><span class="cx"> #include "AlignedMemoryAllocator.h"
</span><ins>+#include <wtf/FastBitVector.h>
+#include <wtf/HashMap.h>
+#include <wtf/Vector.h>
</ins><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>