<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[243757] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/243757">243757</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2019-04-02 13:48:19 -0700 (Tue, 02 Apr 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>[Fetch API] Allow used body replacement in Request constructor
https://bugs.webkit.org/show_bug.cgi?id=183703
<rdar://problem/49425609>

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test now that one more check is passing.

* web-platform-tests/fetch/api/request/request-disturbed-expected.txt:

Source/WebCore:

Allow used body replacement in Request constructor as per:
- https://github.com/whatwg/fetch/pull/675

No new tests, rebaseline existing test.

* Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::initializeWith):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequestdisturbedexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-disturbed-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesfetchFetchRequestcpp">trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (243756 => 243757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-04-02 20:30:02 UTC (rev 243756)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2019-04-02 20:48:19 UTC (rev 243757)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2019-04-02  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><ins>+        [Fetch API] Allow used body replacement in Request constructor
+        https://bugs.webkit.org/show_bug.cgi?id=183703
+        <rdar://problem/49425609>
+
+        Reviewed by Youenn Fablet.
+
+        Rebaseline WPT test now that one more check is passing.
+
+        * web-platform-tests/fetch/api/request/request-disturbed-expected.txt:
+
+2019-04-02  Chris Dumez  <cdumez@apple.com>
+
</ins><span class="cx">         Unreviewed, rolling out r243551.
</span><span class="cx"> 
</span><span class="cx">         Seems to have broken file uploads to SoundCloud
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsfetchapirequestrequestdisturbedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-disturbed-expected.txt (243756 => 243757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-disturbed-expected.txt       2019-04-02 20:30:02 UTC (rev 243756)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-disturbed-expected.txt  2019-04-02 20:48:19 UTC (rev 243757)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> PASS Request without body cannot be disturbed 
</span><span class="cx"> PASS Check cloning a disturbed request 
</span><span class="cx"> PASS Check creating a new request from a disturbed request 
</span><del>-FAIL Check creating a new request with a new body from a disturbed request Request input is disturbed or locked.
</del><ins>+PASS Check creating a new request with a new body from a disturbed request 
</ins><span class="cx"> FAIL Input request used for creating new request became disturbed assert_equals: body should not change expected object "[object ReadableStream]" but got object "[object ReadableStream]"
</span><span class="cx"> FAIL Input request used for creating new request became disturbed even if body is not used assert_true: bodyUsed is true when request is disturbed expected true got false
</span><span class="cx"> PASS Check consuming a disturbed request 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (243756 => 243757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-04-02 20:30:02 UTC (rev 243756)
+++ trunk/Source/WebCore/ChangeLog      2019-04-02 20:48:19 UTC (rev 243757)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2019-04-02  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><ins>+        [Fetch API] Allow used body replacement in Request constructor
+        https://bugs.webkit.org/show_bug.cgi?id=183703
+        <rdar://problem/49425609>
+
+        Reviewed by Youenn Fablet.
+
+        Allow used body replacement in Request constructor as per:
+        - https://github.com/whatwg/fetch/pull/675
+
+        No new tests, rebaseline existing test.
+
+        * Modules/fetch/FetchRequest.cpp:
+        (WebCore::FetchRequest::initializeWith):
+
+2019-04-02  Chris Dumez  <cdumez@apple.com>
+
</ins><span class="cx">         Unreviewed, rolling out r243551.
</span><span class="cx"> 
</span><span class="cx">         Seems to have broken file uploads to SoundCloud
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesfetchFetchRequestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp (243756 => 243757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp      2019-04-02 20:30:02 UTC (rev 243756)
+++ trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp 2019-04-02 20:48:19 UTC (rev 243757)
</span><span class="lines">@@ -203,9 +203,6 @@
</span><span class="cx"> 
</span><span class="cx"> ExceptionOr<void> FetchRequest::initializeWith(FetchRequest& input, Init&& init)
</span><span class="cx"> {
</span><del>-    if (input.isDisturbedOrLocked())
-        return Exception {TypeError, "Request input is disturbed or locked."_s };
-
</del><span class="cx">     m_request = input.m_request;
</span><span class="cx">     m_options = input.m_options;
</span><span class="cx">     m_referrer = input.m_referrer;
</span><span class="lines">@@ -240,6 +237,9 @@
</span><span class="cx">         if (setBodyResult.hasException())
</span><span class="cx">             return setBodyResult.releaseException();
</span><span class="cx">     } else {
</span><ins>+        if (input.isDisturbedOrLocked())
+            return Exception { TypeError, "Request input is disturbed or locked."_s };
+
</ins><span class="cx">         auto setBodyResult = setBody(input);
</span><span class="cx">         if (setBodyResult.hasException())
</span><span class="cx">             return setBodyResult.releaseException();
</span></span></pre>
</div>
</div>

</body>
</html>