<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[243435] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/243435">243435</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2019-03-25 03:30:55 -0700 (Mon, 25 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Reflect HTMLLinkElement.as according to the spec
https://bugs.webkit.org/show_bug.cgi?id=196189

Patch by Rob Buis <rbuis@igalia.com> on 2019-03-25
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update improved test result and import reflected-as-value.html.

* web-platform-tests/html/dom/reflection-metadata-expected.txt:
* web-platform-tests/preload/reflected-as-value-expected.txt: Added.
* web-platform-tests/preload/reflected-as-value.html: Added.

Source/WebCore:

The 'as' attribute is an enumerated attribute [1] and should
reflect using a finite set of keywords, so lowercase the as getter
to match the defined set of destinations [2].

Test: imported/w3c/web-platform-tests/preload/reflected-as-value.html

[1] https://html.spec.whatwg.org/#enumerated-attribute
[2] https://fetch.spec.whatwg.org/#concept-request-destination

* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::as const):

LayoutTests:

Update improved test result.

* platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectionmetadataexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformioswk2importedw3cwebplatformtestshtmldomreflectionmetadataexpectedtxt">trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLLinkElementcpp">trunk/Source/WebCore/html/HTMLLinkElement.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li>trunk/LayoutTests/imported/w3c/web-platform-tests/preload/</li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestspreloadreflectedasvalueexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/preload/reflected-as-value-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestspreloadreflectedasvaluehtml">trunk/LayoutTests/imported/w3c/web-platform-tests/preload/reflected-as-value.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (243434 => 243435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-03-25 09:11:58 UTC (rev 243434)
+++ trunk/LayoutTests/ChangeLog 2019-03-25 10:30:55 UTC (rev 243435)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2019-03-25  Rob Buis  <rbuis@igalia.com>
+
+        Reflect HTMLLinkElement.as according to the spec
+        https://bugs.webkit.org/show_bug.cgi?id=196189
+
+        Reviewed by Youenn Fablet.
+
+        Update improved test result.
+
+        * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt:
+
</ins><span class="cx"> 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Remove NavigatorContentUtils in WebCore/Modules
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (243434 => 243435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-03-25 09:11:58 UTC (rev 243434)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2019-03-25 10:30:55 UTC (rev 243435)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2019-03-25  Rob Buis  <rbuis@igalia.com>
+
+        Reflect HTMLLinkElement.as according to the spec
+        https://bugs.webkit.org/show_bug.cgi?id=196189
+
+        Reviewed by Youenn Fablet.
+
+        Update improved test result and import reflected-as-value.html.
+
+        * web-platform-tests/html/dom/reflection-metadata-expected.txt:
+        * web-platform-tests/preload/reflected-as-value-expected.txt: Added.
+        * web-platform-tests/preload/reflected-as-value.html: Added.
+
</ins><span class="cx"> 2019-03-25  Manuel Rego Casasnovas  <rego@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [css-grid] Fix grid container baseline alignment for orthogonal items
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestshtmldomreflectionmetadataexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt (243434 => 243435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt      2019-03-25 09:11:58 UTC (rev 243434)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt 2019-03-25 10:30:55 UTC (rev 243435)
</span><span class="lines">@@ -1184,12 +1184,12 @@
</span><span class="cx"> PASS link.as: setAttribute() to "xfetch" 
</span><span class="cx"> PASS link.as: setAttribute() to "fetch\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "etch" 
</span><del>-FAIL link.as: setAttribute() to "FETCH" assert_equals: IDL get expected "fetch" but got "FETCH"
</del><ins>+PASS link.as: setAttribute() to "FETCH" 
</ins><span class="cx"> PASS link.as: setAttribute() to "audio" 
</span><span class="cx"> PASS link.as: setAttribute() to "xaudio" 
</span><span class="cx"> PASS link.as: setAttribute() to "audio\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "udio" 
</span><del>-FAIL link.as: setAttribute() to "AUDIO" assert_equals: IDL get expected "audio" but got "AUDIO"
</del><ins>+PASS link.as: setAttribute() to "AUDIO" 
</ins><span class="cx"> FAIL link.as: setAttribute() to "document" assert_equals: IDL get expected "document" but got ""
</span><span class="cx"> PASS link.as: setAttribute() to "xdocument" 
</span><span class="cx"> PASS link.as: setAttribute() to "document\0" 
</span><span class="lines">@@ -1204,12 +1204,12 @@
</span><span class="cx"> PASS link.as: setAttribute() to "xfont" 
</span><span class="cx"> PASS link.as: setAttribute() to "font\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "ont" 
</span><del>-FAIL link.as: setAttribute() to "FONT" assert_equals: IDL get expected "font" but got "FONT"
</del><ins>+PASS link.as: setAttribute() to "FONT" 
</ins><span class="cx"> PASS link.as: setAttribute() to "image" 
</span><span class="cx"> PASS link.as: setAttribute() to "ximage" 
</span><span class="cx"> PASS link.as: setAttribute() to "image\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "mage" 
</span><del>-FAIL link.as: setAttribute() to "IMAGE" assert_equals: IDL get expected "image" but got "IMAGE"
</del><ins>+PASS link.as: setAttribute() to "IMAGE" 
</ins><span class="cx"> FAIL link.as: setAttribute() to "manifest" assert_equals: IDL get expected "manifest" but got ""
</span><span class="cx"> PASS link.as: setAttribute() to "xmanifest" 
</span><span class="cx"> PASS link.as: setAttribute() to "manifest\0" 
</span><span class="lines">@@ -1229,7 +1229,7 @@
</span><span class="cx"> PASS link.as: setAttribute() to "xscript" 
</span><span class="cx"> PASS link.as: setAttribute() to "script\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "cript" 
</span><del>-FAIL link.as: setAttribute() to "SCRIPT" assert_equals: IDL get expected "script" but got "SCRIPT"
</del><ins>+PASS link.as: setAttribute() to "SCRIPT" 
</ins><span class="cx"> FAIL link.as: setAttribute() to "sharedworker" assert_equals: IDL get expected "sharedworker" but got ""
</span><span class="cx"> PASS link.as: setAttribute() to "xsharedworker" 
</span><span class="cx"> PASS link.as: setAttribute() to "sharedworker\0" 
</span><span class="lines">@@ -1240,18 +1240,18 @@
</span><span class="cx"> PASS link.as: setAttribute() to "xstyle" 
</span><span class="cx"> PASS link.as: setAttribute() to "style\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "tyle" 
</span><del>-FAIL link.as: setAttribute() to "STYLE" assert_equals: IDL get expected "style" but got "STYLE"
</del><ins>+PASS link.as: setAttribute() to "STYLE" 
</ins><span class="cx"> PASS link.as: setAttribute() to "track" 
</span><span class="cx"> PASS link.as: setAttribute() to "xtrack" 
</span><span class="cx"> PASS link.as: setAttribute() to "track\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "rack" 
</span><del>-FAIL link.as: setAttribute() to "TRACK" assert_equals: IDL get expected "track" but got "TRACK"
</del><ins>+PASS link.as: setAttribute() to "TRACK" 
</ins><span class="cx"> PASS link.as: setAttribute() to "tracK" 
</span><span class="cx"> PASS link.as: setAttribute() to "video" 
</span><span class="cx"> PASS link.as: setAttribute() to "xvideo" 
</span><span class="cx"> PASS link.as: setAttribute() to "video\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "ideo" 
</span><del>-FAIL link.as: setAttribute() to "VIDEO" assert_equals: IDL get expected "video" but got "VIDEO"
</del><ins>+PASS link.as: setAttribute() to "VIDEO" 
</ins><span class="cx"> FAIL link.as: setAttribute() to "worker" assert_equals: IDL get expected "worker" but got ""
</span><span class="cx"> PASS link.as: setAttribute() to "xworker" 
</span><span class="cx"> PASS link.as: setAttribute() to "worker\0" 
</span><span class="lines">@@ -1282,12 +1282,12 @@
</span><span class="cx"> PASS link.as: IDL set to "xfetch" 
</span><span class="cx"> PASS link.as: IDL set to "fetch\0" 
</span><span class="cx"> PASS link.as: IDL set to "etch" 
</span><del>-FAIL link.as: IDL set to "FETCH" assert_equals: IDL get expected "fetch" but got "FETCH"
</del><ins>+PASS link.as: IDL set to "FETCH" 
</ins><span class="cx"> PASS link.as: IDL set to "audio" 
</span><span class="cx"> PASS link.as: IDL set to "xaudio" 
</span><span class="cx"> PASS link.as: IDL set to "audio\0" 
</span><span class="cx"> PASS link.as: IDL set to "udio" 
</span><del>-FAIL link.as: IDL set to "AUDIO" assert_equals: IDL get expected "audio" but got "AUDIO"
</del><ins>+PASS link.as: IDL set to "AUDIO" 
</ins><span class="cx"> FAIL link.as: IDL set to "document" assert_equals: IDL get expected "document" but got ""
</span><span class="cx"> PASS link.as: IDL set to "xdocument" 
</span><span class="cx"> PASS link.as: IDL set to "document\0" 
</span><span class="lines">@@ -1302,12 +1302,12 @@
</span><span class="cx"> PASS link.as: IDL set to "xfont" 
</span><span class="cx"> PASS link.as: IDL set to "font\0" 
</span><span class="cx"> PASS link.as: IDL set to "ont" 
</span><del>-FAIL link.as: IDL set to "FONT" assert_equals: IDL get expected "font" but got "FONT"
</del><ins>+PASS link.as: IDL set to "FONT" 
</ins><span class="cx"> PASS link.as: IDL set to "image" 
</span><span class="cx"> PASS link.as: IDL set to "ximage" 
</span><span class="cx"> PASS link.as: IDL set to "image\0" 
</span><span class="cx"> PASS link.as: IDL set to "mage" 
</span><del>-FAIL link.as: IDL set to "IMAGE" assert_equals: IDL get expected "image" but got "IMAGE"
</del><ins>+PASS link.as: IDL set to "IMAGE" 
</ins><span class="cx"> FAIL link.as: IDL set to "manifest" assert_equals: IDL get expected "manifest" but got ""
</span><span class="cx"> PASS link.as: IDL set to "xmanifest" 
</span><span class="cx"> PASS link.as: IDL set to "manifest\0" 
</span><span class="lines">@@ -1327,7 +1327,7 @@
</span><span class="cx"> PASS link.as: IDL set to "xscript" 
</span><span class="cx"> PASS link.as: IDL set to "script\0" 
</span><span class="cx"> PASS link.as: IDL set to "cript" 
</span><del>-FAIL link.as: IDL set to "SCRIPT" assert_equals: IDL get expected "script" but got "SCRIPT"
</del><ins>+PASS link.as: IDL set to "SCRIPT" 
</ins><span class="cx"> FAIL link.as: IDL set to "sharedworker" assert_equals: IDL get expected "sharedworker" but got ""
</span><span class="cx"> PASS link.as: IDL set to "xsharedworker" 
</span><span class="cx"> PASS link.as: IDL set to "sharedworker\0" 
</span><span class="lines">@@ -1338,18 +1338,18 @@
</span><span class="cx"> PASS link.as: IDL set to "xstyle" 
</span><span class="cx"> PASS link.as: IDL set to "style\0" 
</span><span class="cx"> PASS link.as: IDL set to "tyle" 
</span><del>-FAIL link.as: IDL set to "STYLE" assert_equals: IDL get expected "style" but got "STYLE"
</del><ins>+PASS link.as: IDL set to "STYLE" 
</ins><span class="cx"> PASS link.as: IDL set to "track" 
</span><span class="cx"> PASS link.as: IDL set to "xtrack" 
</span><span class="cx"> PASS link.as: IDL set to "track\0" 
</span><span class="cx"> PASS link.as: IDL set to "rack" 
</span><del>-FAIL link.as: IDL set to "TRACK" assert_equals: IDL get expected "track" but got "TRACK"
</del><ins>+PASS link.as: IDL set to "TRACK" 
</ins><span class="cx"> PASS link.as: IDL set to "tracK" 
</span><span class="cx"> PASS link.as: IDL set to "video" 
</span><span class="cx"> PASS link.as: IDL set to "xvideo" 
</span><span class="cx"> PASS link.as: IDL set to "video\0" 
</span><span class="cx"> PASS link.as: IDL set to "ideo" 
</span><del>-FAIL link.as: IDL set to "VIDEO" assert_equals: IDL get expected "video" but got "VIDEO"
</del><ins>+PASS link.as: IDL set to "VIDEO" 
</ins><span class="cx"> FAIL link.as: IDL set to "worker" assert_equals: IDL get expected "worker" but got ""
</span><span class="cx"> PASS link.as: IDL set to "xworker" 
</span><span class="cx"> PASS link.as: IDL set to "worker\0" 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestspreloadreflectedasvalueexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/imported/w3c/web-platform-tests/preload/reflected-as-value-expected.txt (0 => 243435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/preload/reflected-as-value-expected.txt                                (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/preload/reflected-as-value-expected.txt   2019-03-25 10:30:55 UTC (rev 243435)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+
+PASS Make sure that the `as` value reflects only known values 
+
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestspreloadreflectedasvaluehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/imported/w3c/web-platform-tests/preload/reflected-as-value.html (0 => 243435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/preload/reflected-as-value.html                                (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/preload/reflected-as-value.html   2019-03-25 10:30:55 UTC (rev 243435)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+<!DOCTYPE html>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script>
+test(function() {
+  var link = document.createElement("link");
+  var values = {
+    "Image": "image",
+    "images": "",
+    "scripT": "script",
+    "style": "style",
+    "": "",
+    "foNt": "font",
+    "foobar": "",
+    "video": "video",
+    "audio": "audio",
+    "track": "track",
+    "fetch": "fetch",
+  };
+  var keys = Object.keys(values);
+  for (var i = 0; i < keys.length; ++i) {
+    link.as = keys[i];
+    assert_true(link.as == values[keys[i]]);
+  }
+}, "Make sure that the `as` value reflects only known values");
+</script>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformioswk2importedw3cwebplatformtestshtmldomreflectionmetadataexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt (243434 => 243435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt     2019-03-25 09:11:58 UTC (rev 243434)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt        2019-03-25 10:30:55 UTC (rev 243435)
</span><span class="lines">@@ -1184,12 +1184,12 @@
</span><span class="cx"> PASS link.as: setAttribute() to "xfetch" 
</span><span class="cx"> PASS link.as: setAttribute() to "fetch\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "etch" 
</span><del>-FAIL link.as: setAttribute() to "FETCH" assert_equals: IDL get expected "fetch" but got "FETCH"
</del><ins>+PASS link.as: setAttribute() to "FETCH" 
</ins><span class="cx"> PASS link.as: setAttribute() to "audio" 
</span><span class="cx"> PASS link.as: setAttribute() to "xaudio" 
</span><span class="cx"> PASS link.as: setAttribute() to "audio\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "udio" 
</span><del>-FAIL link.as: setAttribute() to "AUDIO" assert_equals: IDL get expected "audio" but got "AUDIO"
</del><ins>+PASS link.as: setAttribute() to "AUDIO" 
</ins><span class="cx"> FAIL link.as: setAttribute() to "document" assert_equals: IDL get expected "document" but got ""
</span><span class="cx"> PASS link.as: setAttribute() to "xdocument" 
</span><span class="cx"> PASS link.as: setAttribute() to "document\0" 
</span><span class="lines">@@ -1204,12 +1204,12 @@
</span><span class="cx"> PASS link.as: setAttribute() to "xfont" 
</span><span class="cx"> PASS link.as: setAttribute() to "font\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "ont" 
</span><del>-FAIL link.as: setAttribute() to "FONT" assert_equals: IDL get expected "font" but got "FONT"
</del><ins>+PASS link.as: setAttribute() to "FONT" 
</ins><span class="cx"> PASS link.as: setAttribute() to "image" 
</span><span class="cx"> PASS link.as: setAttribute() to "ximage" 
</span><span class="cx"> PASS link.as: setAttribute() to "image\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "mage" 
</span><del>-FAIL link.as: setAttribute() to "IMAGE" assert_equals: IDL get expected "image" but got "IMAGE"
</del><ins>+PASS link.as: setAttribute() to "IMAGE" 
</ins><span class="cx"> FAIL link.as: setAttribute() to "manifest" assert_equals: IDL get expected "manifest" but got ""
</span><span class="cx"> PASS link.as: setAttribute() to "xmanifest" 
</span><span class="cx"> PASS link.as: setAttribute() to "manifest\0" 
</span><span class="lines">@@ -1229,7 +1229,7 @@
</span><span class="cx"> PASS link.as: setAttribute() to "xscript" 
</span><span class="cx"> PASS link.as: setAttribute() to "script\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "cript" 
</span><del>-FAIL link.as: setAttribute() to "SCRIPT" assert_equals: IDL get expected "script" but got "SCRIPT"
</del><ins>+PASS link.as: setAttribute() to "SCRIPT" 
</ins><span class="cx"> FAIL link.as: setAttribute() to "sharedworker" assert_equals: IDL get expected "sharedworker" but got ""
</span><span class="cx"> PASS link.as: setAttribute() to "xsharedworker" 
</span><span class="cx"> PASS link.as: setAttribute() to "sharedworker\0" 
</span><span class="lines">@@ -1240,18 +1240,18 @@
</span><span class="cx"> PASS link.as: setAttribute() to "xstyle" 
</span><span class="cx"> PASS link.as: setAttribute() to "style\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "tyle" 
</span><del>-FAIL link.as: setAttribute() to "STYLE" assert_equals: IDL get expected "style" but got "STYLE"
</del><ins>+PASS link.as: setAttribute() to "STYLE" 
</ins><span class="cx"> PASS link.as: setAttribute() to "track" 
</span><span class="cx"> PASS link.as: setAttribute() to "xtrack" 
</span><span class="cx"> PASS link.as: setAttribute() to "track\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "rack" 
</span><del>-FAIL link.as: setAttribute() to "TRACK" assert_equals: IDL get expected "track" but got "TRACK"
</del><ins>+PASS link.as: setAttribute() to "TRACK" 
</ins><span class="cx"> PASS link.as: setAttribute() to "tracK" 
</span><span class="cx"> PASS link.as: setAttribute() to "video" 
</span><span class="cx"> PASS link.as: setAttribute() to "xvideo" 
</span><span class="cx"> PASS link.as: setAttribute() to "video\0" 
</span><span class="cx"> PASS link.as: setAttribute() to "ideo" 
</span><del>-FAIL link.as: setAttribute() to "VIDEO" assert_equals: IDL get expected "video" but got "VIDEO"
</del><ins>+PASS link.as: setAttribute() to "VIDEO" 
</ins><span class="cx"> FAIL link.as: setAttribute() to "worker" assert_equals: IDL get expected "worker" but got ""
</span><span class="cx"> PASS link.as: setAttribute() to "xworker" 
</span><span class="cx"> PASS link.as: setAttribute() to "worker\0" 
</span><span class="lines">@@ -1282,12 +1282,12 @@
</span><span class="cx"> PASS link.as: IDL set to "xfetch" 
</span><span class="cx"> PASS link.as: IDL set to "fetch\0" 
</span><span class="cx"> PASS link.as: IDL set to "etch" 
</span><del>-FAIL link.as: IDL set to "FETCH" assert_equals: IDL get expected "fetch" but got "FETCH"
</del><ins>+PASS link.as: IDL set to "FETCH" 
</ins><span class="cx"> PASS link.as: IDL set to "audio" 
</span><span class="cx"> PASS link.as: IDL set to "xaudio" 
</span><span class="cx"> PASS link.as: IDL set to "audio\0" 
</span><span class="cx"> PASS link.as: IDL set to "udio" 
</span><del>-FAIL link.as: IDL set to "AUDIO" assert_equals: IDL get expected "audio" but got "AUDIO"
</del><ins>+PASS link.as: IDL set to "AUDIO" 
</ins><span class="cx"> FAIL link.as: IDL set to "document" assert_equals: IDL get expected "document" but got ""
</span><span class="cx"> PASS link.as: IDL set to "xdocument" 
</span><span class="cx"> PASS link.as: IDL set to "document\0" 
</span><span class="lines">@@ -1302,12 +1302,12 @@
</span><span class="cx"> PASS link.as: IDL set to "xfont" 
</span><span class="cx"> PASS link.as: IDL set to "font\0" 
</span><span class="cx"> PASS link.as: IDL set to "ont" 
</span><del>-FAIL link.as: IDL set to "FONT" assert_equals: IDL get expected "font" but got "FONT"
</del><ins>+PASS link.as: IDL set to "FONT" 
</ins><span class="cx"> PASS link.as: IDL set to "image" 
</span><span class="cx"> PASS link.as: IDL set to "ximage" 
</span><span class="cx"> PASS link.as: IDL set to "image\0" 
</span><span class="cx"> PASS link.as: IDL set to "mage" 
</span><del>-FAIL link.as: IDL set to "IMAGE" assert_equals: IDL get expected "image" but got "IMAGE"
</del><ins>+PASS link.as: IDL set to "IMAGE" 
</ins><span class="cx"> FAIL link.as: IDL set to "manifest" assert_equals: IDL get expected "manifest" but got ""
</span><span class="cx"> PASS link.as: IDL set to "xmanifest" 
</span><span class="cx"> PASS link.as: IDL set to "manifest\0" 
</span><span class="lines">@@ -1327,7 +1327,7 @@
</span><span class="cx"> PASS link.as: IDL set to "xscript" 
</span><span class="cx"> PASS link.as: IDL set to "script\0" 
</span><span class="cx"> PASS link.as: IDL set to "cript" 
</span><del>-FAIL link.as: IDL set to "SCRIPT" assert_equals: IDL get expected "script" but got "SCRIPT"
</del><ins>+PASS link.as: IDL set to "SCRIPT" 
</ins><span class="cx"> FAIL link.as: IDL set to "sharedworker" assert_equals: IDL get expected "sharedworker" but got ""
</span><span class="cx"> PASS link.as: IDL set to "xsharedworker" 
</span><span class="cx"> PASS link.as: IDL set to "sharedworker\0" 
</span><span class="lines">@@ -1338,18 +1338,18 @@
</span><span class="cx"> PASS link.as: IDL set to "xstyle" 
</span><span class="cx"> PASS link.as: IDL set to "style\0" 
</span><span class="cx"> PASS link.as: IDL set to "tyle" 
</span><del>-FAIL link.as: IDL set to "STYLE" assert_equals: IDL get expected "style" but got "STYLE"
</del><ins>+PASS link.as: IDL set to "STYLE" 
</ins><span class="cx"> PASS link.as: IDL set to "track" 
</span><span class="cx"> PASS link.as: IDL set to "xtrack" 
</span><span class="cx"> PASS link.as: IDL set to "track\0" 
</span><span class="cx"> PASS link.as: IDL set to "rack" 
</span><del>-FAIL link.as: IDL set to "TRACK" assert_equals: IDL get expected "track" but got "TRACK"
</del><ins>+PASS link.as: IDL set to "TRACK" 
</ins><span class="cx"> PASS link.as: IDL set to "tracK" 
</span><span class="cx"> PASS link.as: IDL set to "video" 
</span><span class="cx"> PASS link.as: IDL set to "xvideo" 
</span><span class="cx"> PASS link.as: IDL set to "video\0" 
</span><span class="cx"> PASS link.as: IDL set to "ideo" 
</span><del>-FAIL link.as: IDL set to "VIDEO" assert_equals: IDL get expected "video" but got "VIDEO"
</del><ins>+PASS link.as: IDL set to "VIDEO" 
</ins><span class="cx"> FAIL link.as: IDL set to "worker" assert_equals: IDL get expected "worker" but got ""
</span><span class="cx"> PASS link.as: IDL set to "xworker" 
</span><span class="cx"> PASS link.as: IDL set to "worker\0" 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (243434 => 243435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-03-25 09:11:58 UTC (rev 243434)
+++ trunk/Source/WebCore/ChangeLog      2019-03-25 10:30:55 UTC (rev 243435)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2019-03-25  Rob Buis  <rbuis@igalia.com>
+
+        Reflect HTMLLinkElement.as according to the spec
+        https://bugs.webkit.org/show_bug.cgi?id=196189
+
+        Reviewed by Youenn Fablet.
+
+        The 'as' attribute is an enumerated attribute [1] and should
+        reflect using a finite set of keywords, so lowercase the as getter
+        to match the defined set of destinations [2].
+
+        Test: imported/w3c/web-platform-tests/preload/reflected-as-value.html
+
+        [1] https://html.spec.whatwg.org/#enumerated-attribute
+        [2] https://fetch.spec.whatwg.org/#concept-request-destination
+
+        * html/HTMLLinkElement.cpp:
+        (WebCore::HTMLLinkElement::as const):
+
</ins><span class="cx"> 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Remove NavigatorContentUtils in WebCore/Modules
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLLinkElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLLinkElement.cpp (243434 => 243435)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLLinkElement.cpp    2019-03-25 09:11:58 UTC (rev 243434)
+++ trunk/Source/WebCore/html/HTMLLinkElement.cpp       2019-03-25 10:30:55 UTC (rev 243435)
</span><span class="lines">@@ -245,7 +245,7 @@
</span><span class="cx">         || equalLettersIgnoringASCIICase(as, "track")
</span><span class="cx"> #endif
</span><span class="cx">         || equalLettersIgnoringASCIICase(as, "font"))
</span><del>-        return as;
</del><ins>+        return as.convertToASCIILowercase();
</ins><span class="cx">     return String();
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>