<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[243089] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/243089">243089</a></dd>
<dt>Author</dt> <dd>justin_fan@apple.com</dd>
<dt>Date</dt> <dd>2019-03-18 12:07:56 -0700 (Mon, 18 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>[Web GPU] API updates: GPUTexture.createDefaultView and type-safe GPURenderPassEncoder.setPipeline
https://bugs.webkit.org/show_bug.cgi?id=195896

Reviewed by Jon Lee.

Source/WebCore:

Rename createDefaultTextureView -> createDefaultView and move setPipeline from GPUProgrammablePassEncoder to GPURenderPassEncoder.

Existing tests updated for createDefaultView name.

* Modules/webgpu/WebGPUProgrammablePassEncoder.cpp:
(WebCore::WebGPUProgrammablePassEncoder::setPipeline): Deleted.
* Modules/webgpu/WebGPUProgrammablePassEncoder.h:
* Modules/webgpu/WebGPUProgrammablePassEncoder.idl:
* Modules/webgpu/WebGPURenderPassEncoder.cpp:
(WebCore::WebGPURenderPassEncoder::setPipeline):
* Modules/webgpu/WebGPURenderPassEncoder.h:
* Modules/webgpu/WebGPURenderPassEncoder.idl:
* Modules/webgpu/WebGPUTexture.cpp:
(WebCore::WebGPUTexture::createDefaultView):
(WebCore::WebGPUTexture::createDefaultTextureView): Deleted.
* Modules/webgpu/WebGPUTexture.h:
* Modules/webgpu/WebGPUTexture.idl:
* platform/graphics/gpu/GPUProgrammablePassEncoder.h:
* platform/graphics/gpu/GPURenderPassEncoder.h:

LayoutTests:

Rename createDefaultTextureView -> createDefaultView.

* webgpu/buffer-command-buffer-races.html:
* webgpu/depth-enabled-triangle-strip.html:
* webgpu/js/webgpu-functions.js:
(beginBasicRenderPass):
* webgpu/texture-triangle-strip.html:
* webgpu/textures-textureviews.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestswebgpubuffercommandbufferraceshtml">trunk/LayoutTests/webgpu/buffer-command-buffer-races.html</a></li>
<li><a href="#trunkLayoutTestswebgpudepthenabledtrianglestriphtml">trunk/LayoutTests/webgpu/depth-enabled-triangle-strip.html</a></li>
<li><a href="#trunkLayoutTestswebgpujswebgpufunctionsjs">trunk/LayoutTests/webgpu/js/webgpu-functions.js</a></li>
<li><a href="#trunkLayoutTestswebgputexturetrianglestriphtml">trunk/LayoutTests/webgpu/texture-triangle-strip.html</a></li>
<li><a href="#trunkLayoutTestswebgputexturestextureviewshtml">trunk/LayoutTests/webgpu/textures-textureviews.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebgpuWebGPUProgrammablePassEncodercpp">trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebgpuWebGPUProgrammablePassEncoderh">trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebgpuWebGPUProgrammablePassEncoderidl">trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.idl</a></li>
<li><a href="#trunkSourceWebCoreModuleswebgpuWebGPURenderPassEncodercpp">trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebgpuWebGPURenderPassEncoderh">trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebgpuWebGPURenderPassEncoderidl">trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.idl</a></li>
<li><a href="#trunkSourceWebCoreModuleswebgpuWebGPUTexturecpp">trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebgpuWebGPUTextureh">trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebgpuWebGPUTextureidl">trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.idl</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsgpuGPUProgrammablePassEncoderh">trunk/Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsgpuGPURenderPassEncoderh">trunk/Source/WebCore/platform/graphics/gpu/GPURenderPassEncoder.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/LayoutTests/ChangeLog 2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2019-03-18  Justin Fan  <justin_fan@apple.com>
+
+        [Web GPU] API updates: GPUTexture.createDefaultView and type-safe GPURenderPassEncoder.setPipeline
+        https://bugs.webkit.org/show_bug.cgi?id=195896
+
+        Reviewed by Jon Lee.
+
+        Rename createDefaultTextureView -> createDefaultView.
+
+        * webgpu/buffer-command-buffer-races.html:
+        * webgpu/depth-enabled-triangle-strip.html:
+        * webgpu/js/webgpu-functions.js:
+        (beginBasicRenderPass):
+        * webgpu/texture-triangle-strip.html:
+        * webgpu/textures-textureviews.html:
+
</ins><span class="cx"> 2019-03-18  Joseph Pecoraro  <pecoraro@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: HAR Extension for `serverIPAddress` port number
</span></span></pre></div>
<a id="trunkLayoutTestswebgpubuffercommandbufferraceshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/webgpu/buffer-command-buffer-races.html (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webgpu/buffer-command-buffer-races.html        2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/LayoutTests/webgpu/buffer-command-buffer-races.html   2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx">     colorBuffer.setSubData(0, greenArray.buffer);
</span><span class="cx"> 
</span><span class="cx">     const attachment = {
</span><del>-        attachment: swapChain.getCurrentTexture().createDefaultTextureView(),
</del><ins>+        attachment: swapChain.getCurrentTexture().createDefaultView(),
</ins><span class="cx">         loadOp: "load",
</span><span class="cx">         storeOp: "store",
</span><span class="cx">         clearColor: { r: 1, g: 0, b: 0, a: 1 }
</span></span></pre></div>
<a id="trunkLayoutTestswebgpudepthenabledtrianglestriphtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/webgpu/depth-enabled-triangle-strip.html (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webgpu/depth-enabled-triangle-strip.html       2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/LayoutTests/webgpu/depth-enabled-triangle-strip.html  2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx">     const commandEncoder = device.createCommandEncoder();
</span><span class="cx"> 
</span><span class="cx">     const basicAttachment = {
</span><del>-        attachment: swapChain.getCurrentTexture().createDefaultTextureView(),
</del><ins>+        attachment: swapChain.getCurrentTexture().createDefaultView(),
</ins><span class="cx">         loadOp: "clear",
</span><span class="cx">         storeOp: "store",
</span><span class="cx">         clearColor: { r: 1.0, g: 0, b: 0, a: 1.0 }
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx">     };
</span><span class="cx"> 
</span><span class="cx">     const depthAttachment = {
</span><del>-        attachment: createBasicDepthTexture(canvas, device).createDefaultTextureView(),
</del><ins>+        attachment: createBasicDepthTexture(canvas, device).createDefaultView(),
</ins><span class="cx">         depthLoadOp: "clear",
</span><span class="cx">         depthStoreOp: "store",
</span><span class="cx">         clearDepth: 1.0
</span></span></pre></div>
<a id="trunkLayoutTestswebgpujswebgpufunctionsjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/webgpu/js/webgpu-functions.js (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webgpu/js/webgpu-functions.js  2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/LayoutTests/webgpu/js/webgpu-functions.js     2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> 
</span><span class="cx"> function beginBasicRenderPass(swapChain, commandEncoder) {
</span><span class="cx">     const basicAttachment = {
</span><del>-        attachment: swapChain.getCurrentTexture().createDefaultTextureView(),
</del><ins>+        attachment: swapChain.getCurrentTexture().createDefaultView(),
</ins><span class="cx">         loadOp: "clear",
</span><span class="cx">         storeOp: "store",
</span><span class="cx">         clearColor: { r: 1.0, g: 0, b: 0, a: 1.0 }
</span></span></pre></div>
<a id="trunkLayoutTestswebgputexturetrianglestriphtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/webgpu/texture-triangle-strip.html (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webgpu/texture-triangle-strip.html     2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/LayoutTests/webgpu/texture-triangle-strip.html        2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -171,7 +171,7 @@
</span><span class="cx"> 
</span><span class="cx">     const textureBinding = { 
</span><span class="cx">         binding: textureBindingNum, 
</span><del>-        resource: texture.createDefaultTextureView() 
</del><ins>+        resource: texture.createDefaultView() 
</ins><span class="cx">     };
</span><span class="cx">     const samplerBinding = {
</span><span class="cx">         binding: samplerBindingNum,
</span></span></pre></div>
<a id="trunkLayoutTestswebgputexturestextureviewshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/webgpu/textures-textureviews.html (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/webgpu/textures-textureviews.html      2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/LayoutTests/webgpu/textures-textureviews.html 2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx">     const texture = swapChain.getCurrentTexture();
</span><span class="cx">     assert_true(texture instanceof WebGPUTexture, "Successfully acquired next texture.");
</span><span class="cx"> 
</span><del>-    const textureView = texture.createDefaultTextureView();
</del><ins>+    const textureView = texture.createDefaultView();
</ins><span class="cx">     assert_true(textureView instanceof WebGPUTextureView, "Successfully created texture view from next texture.");
</span><span class="cx"> }, "Create texture view from swap chain.");
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/ChangeLog      2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -1,3 +1,30 @@
</span><ins>+2019-03-18  Justin Fan  <justin_fan@apple.com>
+
+        [Web GPU] API updates: GPUTexture.createDefaultView and type-safe GPURenderPassEncoder.setPipeline
+        https://bugs.webkit.org/show_bug.cgi?id=195896
+
+        Reviewed by Jon Lee.
+
+        Rename createDefaultTextureView -> createDefaultView and move setPipeline from GPUProgrammablePassEncoder to GPURenderPassEncoder.
+
+        Existing tests updated for createDefaultView name.
+
+        * Modules/webgpu/WebGPUProgrammablePassEncoder.cpp:
+        (WebCore::WebGPUProgrammablePassEncoder::setPipeline): Deleted.
+        * Modules/webgpu/WebGPUProgrammablePassEncoder.h:
+        * Modules/webgpu/WebGPUProgrammablePassEncoder.idl:
+        * Modules/webgpu/WebGPURenderPassEncoder.cpp:
+        (WebCore::WebGPURenderPassEncoder::setPipeline):
+        * Modules/webgpu/WebGPURenderPassEncoder.h:
+        * Modules/webgpu/WebGPURenderPassEncoder.idl:
+        * Modules/webgpu/WebGPUTexture.cpp:
+        (WebCore::WebGPUTexture::createDefaultView):
+        (WebCore::WebGPUTexture::createDefaultTextureView): Deleted.
+        * Modules/webgpu/WebGPUTexture.h:
+        * Modules/webgpu/WebGPUTexture.idl:
+        * platform/graphics/gpu/GPUProgrammablePassEncoder.h:
+        * platform/graphics/gpu/GPURenderPassEncoder.h:
+
</ins><span class="cx"> 2019-03-18  Chris Dumez  <cdumez@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [iOS] The network process sometimes gets killed for trying to suspend while holding locked files
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebgpuWebGPUProgrammablePassEncodercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.cpp (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.cpp    2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.cpp       2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -68,19 +68,6 @@
</span><span class="cx">     passEncoder()->setBindGroup(index, *bindGroup.bindGroup());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void WebGPUProgrammablePassEncoder::setPipeline(const WebGPURenderPipeline& pipeline)
-{
-    if (!passEncoder()) {
-        LOG(WebGPU, "GPUProgrammablePassEncoder::setPipeline(): Invalid operation!");
-        return;
-    }
-    if (!pipeline.renderPipeline()) {
-        LOG(WebGPU, "GPUProgrammablePassEncoder::setPipeline(): Invalid pipeline!");
-        return;
-    }
-    passEncoder()->setPipeline(makeRef(*pipeline.renderPipeline()));
-}
-
</del><span class="cx"> } // namespace WebCore
</span><span class="cx"> 
</span><span class="cx"> #endif // ENABLE(WEBGPU)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebgpuWebGPUProgrammablePassEncoderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.h (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.h      2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.h 2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -42,7 +42,6 @@
</span><span class="cx"> 
</span><span class="cx">     void endPass();
</span><span class="cx">     void setBindGroup(unsigned, WebGPUBindGroup&) const;
</span><del>-    void setPipeline(const WebGPURenderPipeline&);
</del><span class="cx"> 
</span><span class="cx"> protected:
</span><span class="cx">     WebGPUProgrammablePassEncoder(Ref<WebGPUCommandEncoder>&&);
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebgpuWebGPUProgrammablePassEncoderidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.idl (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.idl    2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPUProgrammablePassEncoder.idl       2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -33,5 +33,4 @@
</span><span class="cx"> ] interface WebGPUProgrammablePassEncoder {
</span><span class="cx">     void endPass();
</span><span class="cx">     void setBindGroup(u32 index, WebGPUBindGroup bindGroup/*, optional sequence<u32> dynamicOffsets*/);
</span><del>-    void setPipeline(WebGPURenderPipeline pipeline); // FIXME: Support WebGPUComputePipelines.
</del><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebgpuWebGPURenderPassEncodercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.cpp (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.cpp  2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.cpp     2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -47,6 +47,19 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void WebGPURenderPassEncoder::setPipeline(const WebGPURenderPipeline& pipeline)
+{
+    if (!m_passEncoder) {
+        LOG(WebGPU, "GPUProgrammablePassEncoder::setPipeline(): Invalid operation!");
+        return;
+    }
+    if (!pipeline.renderPipeline()) {
+        LOG(WebGPU, "GPUProgrammablePassEncoder::setPipeline(): Invalid pipeline!");
+        return;
+    }
+    m_passEncoder->setPipeline(makeRef(*pipeline.renderPipeline()));
+}
+
</ins><span class="cx"> void WebGPURenderPassEncoder::setVertexBuffers(unsigned long startSlot, Vector<RefPtr<WebGPUBuffer>>&& buffers, Vector<unsigned long long>&& offsets)
</span><span class="cx"> {
</span><span class="cx"> #if !LOG_DISABLED
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebgpuWebGPURenderPassEncoderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.h (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.h    2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.h       2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -42,6 +42,7 @@
</span><span class="cx"> public:
</span><span class="cx">     static Ref<WebGPURenderPassEncoder> create(Ref<WebGPUCommandEncoder>&&, RefPtr<GPURenderPassEncoder>&&);
</span><span class="cx"> 
</span><ins>+    void setPipeline(const WebGPURenderPipeline&);
</ins><span class="cx">     void setVertexBuffers(unsigned long, Vector<RefPtr<WebGPUBuffer>>&&, Vector<unsigned long long>&&);
</span><span class="cx">     void draw(unsigned long vertexCount, unsigned long instanceCount, unsigned long firstVertex, unsigned long firstInstance);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebgpuWebGPURenderPassEncoderidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.idl (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.idl  2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPURenderPassEncoder.idl     2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -32,6 +32,8 @@
</span><span class="cx">     EnabledAtRuntime=WebGPU,
</span><span class="cx">     JSGenerateToJSObject
</span><span class="cx"> ] interface WebGPURenderPassEncoder : WebGPUProgrammablePassEncoder {
</span><ins>+    void setPipeline(WebGPURenderPipeline pipeline);
+
</ins><span class="cx">     void setVertexBuffers(u32 startSlot, sequence<WebGPUBuffer> buffers, sequence<u64> offsets);
</span><span class="cx"> 
</span><span class="cx">     void draw(u32 vertexCount, u32 instanceCount, u32 firstVertex, u32 firstInstance);
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebgpuWebGPUTexturecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.cpp (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.cpp    2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.cpp       2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -42,10 +42,10 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-Ref<WebGPUTextureView> WebGPUTexture::createDefaultTextureView()
</del><ins>+Ref<WebGPUTextureView> WebGPUTexture::createDefaultView()
</ins><span class="cx"> {
</span><span class="cx">     if (!m_texture) {
</span><del>-        LOG(WebGPU, "GPUTexture::createDefaultTextureView(): Invalid operation!");
</del><ins>+        LOG(WebGPU, "GPUTexture::createDefaultView(): Invalid operation!");
</ins><span class="cx">         return WebGPUTextureView::create(nullptr);
</span><span class="cx">     }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebgpuWebGPUTextureh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.h (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.h      2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.h 2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx"> 
</span><span class="cx">     RefPtr<GPUTexture> texture() const { return m_texture; }
</span><span class="cx"> 
</span><del>-    Ref<WebGPUTextureView> createDefaultTextureView();
</del><ins>+    Ref<WebGPUTextureView> createDefaultView();
</ins><span class="cx">     void destroy();
</span><span class="cx"> 
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebgpuWebGPUTextureidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.idl (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.idl    2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/Modules/webgpu/WebGPUTexture.idl       2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -29,7 +29,7 @@
</span><span class="cx">     EnabledAtRuntime=WebGPU,
</span><span class="cx">     ImplementationLacksVTable
</span><span class="cx"> ] interface WebGPUTexture {
</span><del>-    WebGPUTextureView createDefaultTextureView();
</del><ins>+    WebGPUTextureView createDefaultView();
</ins><span class="cx">     void destroy();
</span><span class="cx"> 
</span><span class="cx">     // Not Yet Implemented:
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsgpuGPUProgrammablePassEncoderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h  2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/platform/graphics/gpu/GPUProgrammablePassEncoder.h     2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -50,7 +50,6 @@
</span><span class="cx"> 
</span><span class="cx">     virtual void endPass();
</span><span class="cx">     void setBindGroup(unsigned, GPUBindGroup&);
</span><del>-    virtual void setPipeline(Ref<const GPURenderPipeline>&&) = 0;
</del><span class="cx"> 
</span><span class="cx"> protected:
</span><span class="cx">     GPUProgrammablePassEncoder(Ref<GPUCommandBuffer>&&);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsgpuGPURenderPassEncoderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/gpu/GPURenderPassEncoder.h (243088 => 243089)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/gpu/GPURenderPassEncoder.h        2019-03-18 19:03:32 UTC (rev 243088)
+++ trunk/Source/WebCore/platform/graphics/gpu/GPURenderPassEncoder.h   2019-03-18 19:07:56 UTC (rev 243089)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx">     static RefPtr<GPURenderPassEncoder> tryCreate(Ref<GPUCommandBuffer>&&, GPURenderPassDescriptor&&);
</span><span class="cx"> 
</span><span class="cx">     void endPass() final;
</span><del>-    void setPipeline(Ref<const GPURenderPipeline>&&) final;
</del><ins>+    void setPipeline(Ref<const GPURenderPipeline>&&);
</ins><span class="cx"> 
</span><span class="cx">     void setVertexBuffers(unsigned long, Vector<Ref<GPUBuffer>>&&, Vector<unsigned long long>&&);
</span><span class="cx">     void draw(unsigned long vertexCount, unsigned long instanceCount, unsigned long firstVertex, unsigned long firstInstance);
</span></span></pre>
</div>
</div>

</body>
</html>