<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[243123] trunk/Websites/perf.webkit.org</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/243123">243123</a></dd>
<dt>Author</dt> <dd>dewei_zhu@apple.com</dd>
<dt>Date</dt> <dd>2019-03-18 18:55:13 -0700 (Mon, 18 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fix a bug from <a href="http://trac.webkit.org/projects/webkit/changeset/226303">r226303</a> that latest build time is not correctly calculated.
https://bugs.webkit.org/show_bug.cgi?id=195912

Reviewed by Ryosuke Niwa.

Time series is ordered by revision time which does not grantee the build time is
monotonically increasing.

* public/v3/pages/test-freshness-page.js: Use the latest build time instead of the build time of
last point on the chart.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pagestestfreshnesspagejs">trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (243122 => 243123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2019-03-19 01:32:04 UTC (rev 243122)
+++ trunk/Websites/perf.webkit.org/ChangeLog    2019-03-19 01:55:13 UTC (rev 243123)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2019-03-18  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Fix a bug from r226303 that latest build time is not correctly calculated.
+        https://bugs.webkit.org/show_bug.cgi?id=195912
+
+        Reviewed by Ryosuke Niwa.
+
+        Time series is ordered by revision time which does not grantee the build time is
+        monotonically increasing.
+
+        * public/v3/pages/test-freshness-page.js: Use the latest build time instead of the build time of
+        last point on the chart.
+
</ins><span class="cx"> 2019-03-13  Dewei Zhu  <dewei_zhu@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Test freshness page should improve the ability to correlating issues from same builder.
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pagestestfreshnesspagejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js (243122 => 243123)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js    2019-03-19 01:32:04 UTC (rev 243122)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js       2019-03-19 01:55:13 UTC (rev 243123)
</span><span class="lines">@@ -88,17 +88,26 @@
</span><span class="cx">                 measurementSet.fetchBetween(startTime, this._measurementSetFetchTime).then(() => {
</span><span class="cx">                     const currentTimeSeries = measurementSet.fetchedTimeSeries('current', false, false);
</span><span class="cx"> 
</span><del>-                    let timeForLastDataPoint = startTime;
</del><ins>+                    let timeForLatestBuild = startTime;
</ins><span class="cx">                     let lastBuildLink = null;
</span><span class="cx">                     let builder = null;
</span><span class="cx">                     const lastPoint = currentTimeSeries.lastPoint();
</span><span class="cx">                     if (lastPoint) {
</span><del>-                        timeForLastDataPoint = lastPoint.build().buildTime();
-                        lastBuildLink = lastPoint.build().url();
-                        builder = lastPoint.build().builder();
</del><ins>+                        timeForLatestBuild = lastPoint.build().buildTime().getTime();
+                        const view = currentTimeSeries.viewBetweenPoints(currentTimeSeries.firstPoint(), lastPoint);
+                        for (const point of view) {
+                            const build = point.build();
+                            if (!build)
+                                continue;
+                            if (build.buildTime().getTime() >= timeForLatestBuild) {
+                                timeForLatestBuild = build.buildTime().getTime();
+                                lastBuildLink = build.url();
+                                builder = build.builder();
+                            }
+                        }
</ins><span class="cx">                     }
</span><span class="cx"> 
</span><del>-                    lastDataPointByMetric.set(metric, {time: timeForLastDataPoint, hasCurrentDataPoint: !!currentTimeSeries.lastPoint(),
</del><ins>+                    lastDataPointByMetric.set(metric, {time: timeForLatestBuild, hasCurrentDataPoint: !!lastPoint,
</ins><span class="cx">                         lastBuildLink, builder});
</span><span class="cx">                     this.enqueueToRender();
</span><span class="cx">                 });
</span></span></pre>
</div>
</div>

</body>
</html>