<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[242944] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/242944">242944</a></dd>
<dt>Author</dt> <dd>rmorisset@apple.com</dd>
<dt>Date</dt> <dd>2019-03-14 09:41:50 -0700 (Thu, 14 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>DFG::Worklist can be shrunk by 16 bytes
https://bugs.webkit.org/show_bug.cgi?id=195490

Reviewed by Darin Adler.

* dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::Worklist):
* dfg/DFGWorklist.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGWorklistcpp">trunk/Source/JavaScriptCore/dfg/DFGWorklist.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoredfgDFGWorklisth">trunk/Source/JavaScriptCore/dfg/DFGWorklist.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (242943 => 242944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2019-03-14 16:21:34 UTC (rev 242943)
+++ trunk/Source/JavaScriptCore/ChangeLog       2019-03-14 16:41:50 UTC (rev 242944)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2019-03-14  Robin Morisset  <rmorisset@apple.com>
+
+        DFG::Worklist can be shrunk by 16 bytes
+        https://bugs.webkit.org/show_bug.cgi?id=195490
+
+        Reviewed by Darin Adler.
+
+        * dfg/DFGWorklist.cpp:
+        (JSC::DFG::Worklist::Worklist):
+        * dfg/DFGWorklist.h:
+
</ins><span class="cx"> 2019-03-14  Devin Rousso  <drousso@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: Audit: provide a way to get the contents of resources
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGWorklistcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGWorklist.cpp (242943 => 242944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGWorklist.cpp  2019-03-14 16:21:34 UTC (rev 242943)
+++ trunk/Source/JavaScriptCore/dfg/DFGWorklist.cpp     2019-03-14 16:41:50 UTC (rev 242944)
</span><span class="lines">@@ -185,9 +185,8 @@
</span><span class="cx"> 
</span><span class="cx"> Worklist::Worklist(CString&& tierName)
</span><span class="cx">     : m_threadName(createWorklistName(WTFMove(tierName)))
</span><ins>+    , m_planEnqueued(AutomaticThreadCondition::create())
</ins><span class="cx">     , m_lock(Box<Lock>::create())
</span><del>-    , m_planEnqueued(AutomaticThreadCondition::create())
-    , m_numberOfActiveThreads(0)
</del><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredfgDFGWorklisth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/dfg/DFGWorklist.h (242943 => 242944)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/dfg/DFGWorklist.h    2019-03-14 16:21:34 UTC (rev 242943)
+++ trunk/Source/JavaScriptCore/dfg/DFGWorklist.h       2019-03-14 16:41:50 UTC (rev 242944)
</span><span class="lines">@@ -96,7 +96,9 @@
</span><span class="cx"> 
</span><span class="cx">     void dump(const AbstractLocker&, PrintStream&) const;
</span><span class="cx">     
</span><ins>+    unsigned m_numberOfActiveThreads { 0 };
</ins><span class="cx">     CString m_threadName;
</span><ins>+    Vector<std::unique_ptr<ThreadData>> m_threads;
</ins><span class="cx">     
</span><span class="cx">     // Used to inform the thread about what work there is left to do.
</span><span class="cx">     Deque<RefPtr<Plan>> m_queue;
</span><span class="lines">@@ -111,15 +113,11 @@
</span><span class="cx">     // Used to quickly find which plans have been compiled and are ready to
</span><span class="cx">     // be completed.
</span><span class="cx">     Vector<RefPtr<Plan>, 16> m_readyPlans;
</span><ins>+    Ref<AutomaticThreadCondition> m_planEnqueued;
+    Condition m_planCompiled;
</ins><span class="cx"> 
</span><span class="cx">     Lock m_suspensionLock;
</span><del>-    
</del><span class="cx">     Box<Lock> m_lock;
</span><del>-    Ref<AutomaticThreadCondition> m_planEnqueued;
-    Condition m_planCompiled;
-    
-    Vector<std::unique_ptr<ThreadData>> m_threads;
-    unsigned m_numberOfActiveThreads;
</del><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> JS_EXPORT_PRIVATE unsigned setNumberOfDFGCompilerThreads(unsigned);
</span></span></pre>
</div>
</div>

</body>
</html>