<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[242886] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/242886">242886</a></dd>
<dt>Author</dt> <dd>youenn@apple.com</dd>
<dt>Date</dt> <dd>2019-03-13 10:14:18 -0700 (Wed, 13 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Enable libwebrtc logging control through WebCore
https://bugs.webkit.org/show_bug.cgi?id=195658

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Add a callback to get access to libwebrtc log messages.

* Configurations/libwebrtc.iOS.exp:
* Configurations/libwebrtc.iOSsim.exp:
* Configurations/libwebrtc.mac.exp:
* Source/webrtc/rtc_base/logging.cc:
* Source/webrtc/rtc_base/logging.h:

Source/WebCore:

Add support for WebCore logging of libwebrtc messages.
This is controlled by WebRTC log channel state and level.
In case of private browsing mode, any logging is disabled.
This will stay for the lifetime of the process.
No change of behavior.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::create):
* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::doReleaseLogging):
(WebCore::setLogging):
(WebCore::computeLogLevel):
(WebCore::initializePeerConnectionFactoryAndThreads):
(WebCore::LibWebRTCProvider::setEnableLogging):
* platform/mediastream/libwebrtc/LibWebRTCProvider.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceThirdPartylibwebrtcChangeLog">trunk/Source/ThirdParty/libwebrtc/ChangeLog</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcConfigurationslibwebrtciOSexp">trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcConfigurationslibwebrtciOSsimexp">trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcConfigurationslibwebrtcmacexp">trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcSourcewebrtcrtc_baseloggingcc">trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc</a></li>
<li><a href="#trunkSourceThirdPartylibwebrtcSourcewebrtcrtc_baseloggingh">trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediastreamRTCPeerConnectioncpp">trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformmediastreamlibwebrtcLibWebRTCProvidercpp">trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformmediastreamlibwebrtcLibWebRTCProviderh">trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceThirdPartylibwebrtcChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/ChangeLog      2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2019-03-13  Youenn Fablet  <youenn@apple.com>
+
+        Enable libwebrtc logging control through WebCore
+        https://bugs.webkit.org/show_bug.cgi?id=195658
+
+        Reviewed by Eric Carlson.
+
+        Add a callback to get access to libwebrtc log messages.
+
+        * Configurations/libwebrtc.iOS.exp:
+        * Configurations/libwebrtc.iOSsim.exp:
+        * Configurations/libwebrtc.mac.exp:
+        * Source/webrtc/rtc_base/logging.cc:
+        * Source/webrtc/rtc_base/logging.h:
+
</ins><span class="cx"> 2019-03-07  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Skip compilation of unused audio device files for Mac and iOS
</span></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcConfigurationslibwebrtciOSexp"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp       2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp  2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -246,3 +246,4 @@
</span><span class="cx"> __ZN6webrtc16RtpFecParametersD1Ev
</span><span class="cx"> __ZN6webrtc16RtpRtxParametersC1ERKS0_
</span><span class="cx"> __ZN6webrtc16RtpRtxParametersD1Ev
</span><ins>+__ZN3rtc10LogMessage12SetLogOutputENS_15LoggingSeverityEPFvS1_PKcE
</ins></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcConfigurationslibwebrtciOSsimexp"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp    2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp       2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -247,3 +247,4 @@
</span><span class="cx"> __ZN6webrtc16RtpFecParametersD1Ev
</span><span class="cx"> __ZN6webrtc16RtpRtxParametersC1ERKS0_
</span><span class="cx"> __ZN6webrtc16RtpRtxParametersD1Ev
</span><ins>+__ZN3rtc10LogMessage12SetLogOutputENS_15LoggingSeverityEPFvS1_PKcE
</ins></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcConfigurationslibwebrtcmacexp"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp       2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp  2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -247,3 +247,4 @@
</span><span class="cx"> __ZN6webrtc16RtpFecParametersD1Ev
</span><span class="cx"> __ZN6webrtc16RtpRtxParametersC1ERKS0_
</span><span class="cx"> __ZN6webrtc16RtpRtxParametersD1Ev
</span><ins>+__ZN3rtc10LogMessage12SetLogOutputENS_15LoggingSeverityEPFvS1_PKcE
</ins></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcSourcewebrtcrtc_baseloggingcc"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc      2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc 2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -52,7 +52,9 @@
</span><span class="cx"> static LoggingSeverity g_min_sev = LS_NONE;
</span><span class="cx"> static LoggingSeverity g_dbg_sev = LS_NONE;
</span><span class="cx"> #endif
</span><ins>+static LogMessage::LogOutputCallback g_log_output_callback = nullptr;
</ins><span class="cx"> 
</span><ins>+
</ins><span class="cx"> // Return the filename portion of the string (that following the last slash).
</span><span class="cx"> const char* FilenameFromPath(const char* file) {
</span><span class="cx">   const char* end1 = ::strrchr(file, '/');
</span><span class="lines">@@ -269,6 +271,14 @@
</span><span class="cx">   UpdateMinLogSeverity();
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void LogMessage::SetLogOutput(LoggingSeverity min_sev, LogOutputCallback callback)
+{
+  g_dbg_sev = min_sev;
+  CritScope cs(&logCriticalScope());
+  UpdateMinLogSeverity();
+  g_log_output_callback = callback;
+}
+
</ins><span class="cx"> void LogMessage::SetLogToStderr(bool log_to_stderr) {
</span><span class="cx">   log_to_stderr_ = log_to_stderr;
</span><span class="cx"> }
</span><span class="lines">@@ -456,6 +466,8 @@
</span><span class="cx">   }
</span><span class="cx"> #endif  // WEBRTC_ANDROID
</span><span class="cx">   if (log_to_stderr) {
</span><ins>+    if (g_log_output_callback)
+      g_log_output_callback(severity, str.c_str());
</ins><span class="cx">     fprintf(stderr, "%s", str.c_str());
</span><span class="cx">     fflush(stderr);
</span><span class="cx">   }
</span></span></pre></div>
<a id="trunkSourceThirdPartylibwebrtcSourcewebrtcrtc_baseloggingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h       2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h  2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -430,6 +430,9 @@
</span><span class="cx">   // These are the available logging channels
</span><span class="cx">   //  Debug: Debug console on Windows, otherwise stderr
</span><span class="cx">   static void LogToDebug(LoggingSeverity min_sev);
</span><ins>+
+  typedef void (*LogOutputCallback)(LoggingSeverity severity, const char*);
+  static void SetLogOutput(LoggingSeverity min_sev, LogOutputCallback);
</ins><span class="cx">   static LoggingSeverity GetLogToDebug();
</span><span class="cx"> 
</span><span class="cx">   // Sets whether logs will be directed to stderr in debug mode.
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/WebCore/ChangeLog      2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2019-03-13  Youenn Fablet  <youenn@apple.com>
+
+        Enable libwebrtc logging control through WebCore
+        https://bugs.webkit.org/show_bug.cgi?id=195658
+
+        Reviewed by Eric Carlson.
+
+        Add support for WebCore logging of libwebrtc messages.
+        This is controlled by WebRTC log channel state and level.
+        In case of private browsing mode, any logging is disabled.
+        This will stay for the lifetime of the process.
+        No change of behavior.
+
+        * Modules/mediastream/RTCPeerConnection.cpp:
+        (WebCore::RTCPeerConnection::create):
+        * platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
+        (WebCore::doReleaseLogging):
+        (WebCore::setLogging):
+        (WebCore::computeLogLevel):
+        (WebCore::initializePeerConnectionFactoryAndThreads):
+        (WebCore::LibWebRTCProvider::setEnableLogging):
+        * platform/mediastream/libwebrtc/LibWebRTCProvider.h:
+
</ins><span class="cx"> 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [GStreamer][WebRTC] Do not sync encoder on the clock
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediastreamRTCPeerConnectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp   2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp      2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -70,8 +70,10 @@
</span><span class="cx">     // Let's make it uncollectable until the pc is closed by JS or the page stops it.
</span><span class="cx">     if (!peerConnection->isClosed()) {
</span><span class="cx">         peerConnection->m_pendingActivity = peerConnection->makePendingActivity(peerConnection.get());
</span><del>-        if (auto* page = downcast<Document>(context).page())
</del><ins>+        if (auto* page = downcast<Document>(context).page()) {
</ins><span class="cx">             peerConnection->registerToController(page->rtcController());
</span><ins>+            page->libWebRTCProvider().setEnableLogging(!context.sessionID().isEphemeral());
+        }
</ins><span class="cx">     }
</span><span class="cx">     return peerConnection;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmediastreamlibwebrtcLibWebRTCProvidercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp        2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp   2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -120,20 +120,49 @@
</span><span class="cx">     void OnMessage(rtc::Message*);
</span><span class="cx"> };
</span><span class="cx"> 
</span><del>-static void initializePeerConnectionFactoryAndThreads(PeerConnectionFactoryAndThreads& factoryAndThreads)
</del><ins>+static void doReleaseLogging(rtc::LoggingSeverity severity, const char* message)
</ins><span class="cx"> {
</span><del>-    ASSERT(!factoryAndThreads.networkThread);
</del><ins>+    if (severity == rtc::LS_ERROR)
+        RELEASE_LOG_ERROR(WebRTC, "LibWebRTC error: %{public}s", message);
+    else
+        RELEASE_LOG(WebRTC, "LibWebRTC message: %{public}s", message);
+}
</ins><span class="cx"> 
</span><ins>+static void setLogging(rtc::LoggingSeverity level)
+{
+    rtc::LogMessage::SetLogOutput(level, (level == rtc::LS_NONE) ? nullptr : doReleaseLogging);
+}
+
+static rtc::LoggingSeverity computeLogLevel()
+{
</ins><span class="cx"> #if defined(NDEBUG)
</span><span class="cx"> #if !LOG_DISABLED || !RELEASE_LOG_DISABLED
</span><del>-    rtc::LogMessage::LogToDebug(LogWebRTC.state != WTFLogChannelOn ? rtc::LS_NONE : rtc::LS_INFO);
</del><ins>+    if (LogWebRTC.state != WTFLogChannelOn)
+        return rtc::LS_ERROR;
+
+    switch (LogWebRTC.level) {
+    case WTFLogLevelAlways:
+    case WTFLogLevelError:
+        return rtc::LS_ERROR;
+    case WTFLogLevelWarning:
+        return rtc::LS_WARNING;
+    case WTFLogLevelInfo:
+        return rtc::LS_INFO;
+    case WTFLogLevelDebug:
+        return rtc::LS_VERBOSE;
+    }
</ins><span class="cx"> #else
</span><del>-    rtc::LogMessage::LogToDebug(rtc::LS_NONE);
</del><ins>+    return rtc::LS_NONE;
</ins><span class="cx"> #endif
</span><span class="cx"> #else
</span><del>-    rtc::LogMessage::LogToDebug(LogWebRTC.state != WTFLogChannelOn ? rtc::LS_WARNING : rtc::LS_INFO);
</del><ins>+    return (LogWebRTC.state != WTFLogChannelOn) ? rtc::LS_WARNING : rtc::LS_INFO;
</ins><span class="cx"> #endif
</span><ins>+}
</ins><span class="cx"> 
</span><ins>+static void initializePeerConnectionFactoryAndThreads(PeerConnectionFactoryAndThreads& factoryAndThreads)
+{
+    ASSERT(!factoryAndThreads.networkThread);
+
</ins><span class="cx">     factoryAndThreads.networkThread = factoryAndThreads.networkThreadWithSocketServer ? rtc::Thread::CreateWithSocketServer() : rtc::Thread::Create();
</span><span class="cx">     factoryAndThreads.networkThread->SetName("WebKitWebRTCNetwork", nullptr);
</span><span class="cx">     bool result = factoryAndThreads.networkThread->Start();
</span><span class="lines">@@ -194,6 +223,14 @@
</span><span class="cx">     threads.signalingThread->Post(RTC_FROM_HERE, &threads, 1, new ThreadMessageData(WTFMove(callback)));
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void LibWebRTCProvider::setEnableLogging(bool enableLogging)
+{
+    if (!m_enableLogging)
+        return;
+    m_enableLogging = enableLogging;
+    setLogging(enableLogging ? computeLogLevel() : rtc::LS_NONE);
+}
+
</ins><span class="cx"> webrtc::PeerConnectionFactoryInterface* LibWebRTCProvider::factory()
</span><span class="cx"> {
</span><span class="cx">     if (m_factory)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmediastreamlibwebrtcLibWebRTCProviderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h (242885 => 242886)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h  2019-03-13 17:11:27 UTC (rev 242885)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h     2019-03-13 17:14:18 UTC (rev 242886)
</span><span class="lines">@@ -115,6 +115,8 @@
</span><span class="cx"> 
</span><span class="cx">     void clearFactory() { m_factory = nullptr; }
</span><span class="cx"> 
</span><ins>+    void setEnableLogging(bool);
+
</ins><span class="cx"> protected:
</span><span class="cx">     LibWebRTCProvider() = default;
</span><span class="cx"> 
</span><span class="lines">@@ -131,6 +133,7 @@
</span><span class="cx">     rtc::scoped_refptr<webrtc::PeerConnectionFactoryInterface> m_factory;
</span><span class="cx">     bool m_disableNonLocalhostConnections { false };
</span><span class="cx">     bool m_supportsVP8 { false };
</span><ins>+    bool m_enableLogging { true };
</ins><span class="cx"> #endif
</span><span class="cx"> };
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>