<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[242884] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/242884">242884</a></dd>
<dt>Author</dt> <dd>aakash_jain@apple.com</dd>
<dt>Date</dt> <dd>2019-03-13 10:03:42 -0700 (Wed, 13 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>[ews-app] Use Buildbot result code variables
https://bugs.webkit.org/show_bug.cgi?id=195668

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/ews-app/ews/common/buildbot.py:
(Buildbot): Added Buildbot result code variables.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Used Buildbot result code variables.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsBuildSlaveSupportewsappewscommonbuildbotpy">trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py</a></li>
<li><a href="#trunkToolsBuildSlaveSupportewsappewsviewsstatusbubblepy">trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsBuildSlaveSupportewsappewscommonbuildbotpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py (242883 => 242884)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py     2019-03-13 16:08:15 UTC (rev 242883)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py        2019-03-13 17:03:42 UTC (rev 242884)
</span><span class="lines">@@ -20,6 +20,8 @@
</span><span class="cx"> # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
</span><span class="cx"> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> 
</span><ins>+from future.utils import lrange
+
</ins><span class="cx"> import logging
</span><span class="cx"> import os
</span><span class="cx"> import re
</span><span class="lines">@@ -32,6 +34,10 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> class Buildbot():
</span><ins>+    # Buildbot status codes referenced from https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/results.py
+    ALL_RESULTS = lrange(7)
+    SUCCESS, WARNINGS, FAILURE, SKIPPED, EXCEPTION, RETRY, CANCELLED = ALL_RESULTS
+
</ins><span class="cx">     @classmethod
</span><span class="cx">     def send_patch_to_buildbot(cls, patch_path, properties=[]):
</span><span class="cx">         command = ['buildbot', 'try',
</span></span></pre></div>
<a id="trunkToolsBuildSlaveSupportewsappewsviewsstatusbubblepy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (242883 => 242884)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py  2019-03-13 16:08:15 UTC (rev 242883)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py     2019-03-13 17:03:42 UTC (rev 242884)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx"> from django.shortcuts import render
</span><span class="cx"> from django.views import View
</span><span class="cx"> from django.views.decorators.clickjacking import xframe_options_exempt
</span><ins>+from ews.common.buildbot import Buildbot
</ins><span class="cx"> from ews.models.patch import Patch
</span><span class="cx"> import ews.config as config
</span><span class="cx"> 
</span><span class="lines">@@ -57,17 +58,17 @@
</span><span class="cx">         bubble["details_message"] = '{}\n{}'.format(builder_full_name, build.state_string)
</span><span class="cx">         if build.result is None:
</span><span class="cx">             bubble["state"] = "started"
</span><del>-        elif build.result == 0:  # SUCCESS
</del><ins>+        elif build.result == Buildbot.SUCCESS:
</ins><span class="cx">             bubble["state"] = "pass"
</span><del>-        elif build.result == 1:  # WARNINGS
</del><ins>+        elif build.result == Buildbot.WARNINGS:
</ins><span class="cx">             bubble["state"] = "pass"
</span><del>-        elif build.result == 2:  # FAILURE
</del><ins>+        elif build.result == Buildbot.FAILURE:
</ins><span class="cx">             bubble["state"] = "fail"
</span><del>-        elif build.result == 3:  # SKIPPED
</del><ins>+        elif build.result == Buildbot.SKIPPED:
</ins><span class="cx">             bubble["state"] = "none"
</span><del>-        elif build.result == 4:  # EXCEPTION
</del><ins>+        elif build.result == Buildbot.EXCEPTION:
</ins><span class="cx">             bubble["state"] = "error"
</span><del>-        elif build.result == 5:  # RETRY
</del><ins>+        elif build.result == Buildbot.RETRY:
</ins><span class="cx">             bubble["state"] = "provisional-fail"
</span><span class="cx">         else:
</span><span class="cx">             bubble["state"] = "fail"
</span><span class="lines">@@ -85,7 +86,7 @@
</span><span class="cx">         return [build for build in patch.build_set.all() if build.builder_display_name == queue]
</span><span class="cx"> 
</span><span class="cx">     def _should_show_bubble_for_build(self, build):
</span><del>-        if build and build.result == 3 and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string):
</del><ins>+        if build and build.result == Buildbot.SKIPPED and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string):
</ins><span class="cx">             return False
</span><span class="cx">         return True
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (242883 => 242884)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2019-03-13 16:08:15 UTC (rev 242883)
+++ trunk/Tools/ChangeLog       2019-03-13 17:03:42 UTC (rev 242884)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2019-03-13  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Use Buildbot result code variables
+        https://bugs.webkit.org/show_bug.cgi?id=195668
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
+        (Buildbot): Added Buildbot result code variables.
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble): Used Buildbot result code variables.
+
</ins><span class="cx"> 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [Flatpak] Expand submodule recursively
</span></span></pre>
</div>
</div>

</body>
</html>