<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[242777] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/242777">242777</a></dd>
<dt>Author</dt> <dd>ryanhaddad@apple.com</dd>
<dt>Date</dt> <dd>2019-03-11 22:50:21 -0700 (Mon, 11 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/242763">r242763</a>.

Causes layout test crashes on iOS simulator

Reverted changeset:

"[Synthetic Click] Dispatch mouseout soon after mouseup"
https://bugs.webkit.org/show_bug.cgi?id=195575
https://trac.webkit.org/changeset/242763</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfasteventstouchioscontentobservationvisibilitychangehappenswhileinmousemovedhtml">trunk/LayoutTests/fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageEventHandlercpp">trunk/Source/WebCore/page/EventHandler.cpp</a></li>
<li><a href="#trunkSourceWebCorepageEventHandlerh">trunk/Source/WebCore/page/EventHandler.h</a></li>
<li><a href="#trunkSourceWebCorepageiosEventHandlerIOSmm">trunk/Source/WebCore/page/ios/EventHandlerIOS.mm</a></li>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitWebProcessWebPageiosWebPageIOSmm">trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (242776 => 242777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-03-12 05:27:44 UTC (rev 242776)
+++ trunk/LayoutTests/ChangeLog 2019-03-12 05:50:21 UTC (rev 242777)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
</span><span class="cx"> 
</span><ins>+        Unreviewed, rolling out r242763.
+
+        Causes layout test crashes on iOS simulator
+
+        Reverted changeset:
+
+        "[Synthetic Click] Dispatch mouseout soon after mouseup"
+        https://bugs.webkit.org/show_bug.cgi?id=195575
+        https://trac.webkit.org/changeset/242763
+
+2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
+
</ins><span class="cx">         Unreviewed test gardening, rebaseline tests after r242757.
</span><span class="cx"> 
</span><span class="cx">         * http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventstouchioscontentobservationvisibilitychangehappenswhileinmousemovedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html (242776 => 242777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html   2019-03-12 05:27:44 UTC (rev 242776)
+++ trunk/LayoutTests/fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html      2019-03-12 05:50:21 UTC (rev 242777)
</span><span class="lines">@@ -45,11 +45,7 @@
</span><span class="cx">         testRunner.notifyDone();
</span><span class="cx"> }, false);
</span><span class="cx"> 
</span><del>-tapthis.addEventListener("mouseout", function( event ) {
-    result.innerHTML = result.innerHTML + " mouseout should NOT be triggered ";
-}, false);
-
-becomesVisible.addEventListener("click", function( event ) {
</del><ins>+becomesVisible.addEventListener("click", function( event ) {   
</ins><span class="cx">     result.innerHTML = "clicked hidden";
</span><span class="cx"> }, false);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (242776 => 242777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2019-03-12 05:27:44 UTC (rev 242776)
+++ trunk/Source/WebCore/ChangeLog      2019-03-12 05:50:21 UTC (rev 242777)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r242763.
+
+        Causes layout test crashes on iOS simulator
+
+        Reverted changeset:
+
+        "[Synthetic Click] Dispatch mouseout soon after mouseup"
+        https://bugs.webkit.org/show_bug.cgi?id=195575
+        https://trac.webkit.org/changeset/242763
+
</ins><span class="cx"> 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
</span><span class="cx"> 
</span><span class="cx">         Add Optional to Forward.h.
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventHandlercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventHandler.cpp (242776 => 242777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventHandler.cpp       2019-03-12 05:27:44 UTC (rev 242776)
+++ trunk/Source/WebCore/page/EventHandler.cpp  2019-03-12 05:50:21 UTC (rev 242777)
</span><span class="lines">@@ -1978,7 +1978,7 @@
</span><span class="cx"> #endif
</span><span class="cx">         if (onlyUpdateScrollbars) {
</span><span class="cx">             if (shouldSendMouseEventsToInactiveWindows())
</span><del>-                updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, FireMouseOverOut::Yes);
</del><ins>+                updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, true);
</ins><span class="cx"> 
</span><span class="cx">             return true;
</span><span class="cx">         }
</span><span class="lines">@@ -1993,7 +1993,7 @@
</span><span class="cx"> 
</span><span class="cx">     if (newSubframe) {
</span><span class="cx">         // Update over/out state before passing the event to the subframe.
</span><del>-        updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, FireMouseOverOut::Yes);
</del><ins>+        updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, true);
</ins><span class="cx">         
</span><span class="cx">         // Event dispatch in updateMouseEventTargetNode may have caused the subframe of the target
</span><span class="cx">         // node to be detached from its FrameView, in which case the event should not be passed.
</span><span class="lines">@@ -2476,7 +2476,7 @@
</span><span class="cx">     return false;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void EventHandler::updateMouseEventTargetNode(Node* targetNode, const PlatformMouseEvent& platformMouseEvent, FireMouseOverOut fireMouseOverOut)
</del><ins>+void EventHandler::updateMouseEventTargetNode(Node* targetNode, const PlatformMouseEvent& platformMouseEvent, bool fireMouseOverOut)
</ins><span class="cx"> {
</span><span class="cx">     Ref<Frame> protectedFrame(m_frame);
</span><span class="cx">     Element* targetElement = nullptr;
</span><span class="lines">@@ -2494,7 +2494,7 @@
</span><span class="cx">     m_elementUnderMouse = targetElement;
</span><span class="cx"> 
</span><span class="cx">     // Fire mouseout/mouseover if the mouse has shifted to a different node.
</span><del>-    if (fireMouseOverOut == FireMouseOverOut::Yes) {
</del><ins>+    if (fireMouseOverOut) {
</ins><span class="cx">         auto scrollableAreaForLastNode = enclosingScrollableArea(m_lastElementUnderMouse.get());
</span><span class="cx">         auto scrollableAreaForNodeUnderMouse = enclosingScrollableArea(m_elementUnderMouse.get());
</span><span class="cx">         Page* page = m_frame.page();
</span><span class="lines">@@ -2588,7 +2588,7 @@
</span><span class="cx">     if (auto* view = m_frame.view())
</span><span class="cx">         view->disableLayerFlushThrottlingTemporarilyForInteraction();
</span><span class="cx"> 
</span><del>-    updateMouseEventTargetNode(targetNode, platformMouseEvent, setUnder ? FireMouseOverOut::Yes : FireMouseOverOut::No);
</del><ins>+    updateMouseEventTargetNode(targetNode, platformMouseEvent, setUnder);
</ins><span class="cx"> 
</span><span class="cx">     if (m_elementUnderMouse && !m_elementUnderMouse->dispatchMouseEvent(platformMouseEvent, eventType, clickCount))
</span><span class="cx">         return false;
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventHandlerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventHandler.h (242776 => 242777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventHandler.h 2019-03-12 05:27:44 UTC (rev 242776)
+++ trunk/Source/WebCore/page/EventHandler.h    2019-03-12 05:50:21 UTC (rev 242777)
</span><span class="lines">@@ -241,7 +241,6 @@
</span><span class="cx"> 
</span><span class="cx"> #if PLATFORM(IOS_FAMILY)
</span><span class="cx">     void defaultTouchEventHandler(Node&, TouchEvent&);
</span><del>-    WEBCORE_EXPORT void dispatchSyntheticMouseOut(const PlatformMouseEvent&);
</del><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(CONTEXT_MENUS)
</span><span class="lines">@@ -405,9 +404,9 @@
</span><span class="cx"> 
</span><span class="cx">     Node* nodeUnderMouse() const;
</span><span class="cx">     
</span><del>-    enum class FireMouseOverOut { No, Yes };
-    void updateMouseEventTargetNode(Node*, const PlatformMouseEvent&, FireMouseOverOut);
-
</del><ins>+    void updateMouseEventTargetNode(Node*, const PlatformMouseEvent&, bool fireMouseOverOut);
+    void fireMouseOverOut(bool fireMouseOver = true, bool fireMouseOut = true, bool updateLastNodeUnderMouse = true);
+    
</ins><span class="cx">     MouseEventWithHitTestResults prepareMouseEvent(const HitTestRequest&, const PlatformMouseEvent&);
</span><span class="cx"> 
</span><span class="cx">     bool dispatchMouseEvent(const AtomicString& eventType, Node* target, bool cancelable, int clickCount, const PlatformMouseEvent&, bool setUnder);
</span></span></pre></div>
<a id="trunkSourceWebCorepageiosEventHandlerIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/ios/EventHandlerIOS.mm (242776 => 242777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/ios/EventHandlerIOS.mm 2019-03-12 05:27:44 UTC (rev 242776)
+++ trunk/Source/WebCore/page/ios/EventHandlerIOS.mm    2019-03-12 05:50:21 UTC (rev 242777)
</span><span class="lines">@@ -515,11 +515,6 @@
</span><span class="cx">     return false;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void EventHandler::dispatchSyntheticMouseOut(const PlatformMouseEvent& platformMouseEvent)
-{
-    updateMouseEventTargetNode(nullptr, platformMouseEvent, FireMouseOverOut::Yes);
-}
-
</del><span class="cx"> bool EventHandler::passMousePressEventToSubframe(MouseEventWithHitTestResults& mev, Frame* subframe)
</span><span class="cx"> {
</span><span class="cx">     // WebKit1 code path.
</span></span></pre></div>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (242776 => 242777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2019-03-12 05:27:44 UTC (rev 242776)
+++ trunk/Source/WebKit/ChangeLog       2019-03-12 05:50:21 UTC (rev 242777)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r242763.
+
+        Causes layout test crashes on iOS simulator
+
+        Reverted changeset:
+
+        "[Synthetic Click] Dispatch mouseout soon after mouseup"
+        https://bugs.webkit.org/show_bug.cgi?id=195575
+        https://trac.webkit.org/changeset/242763
+
</ins><span class="cx"> 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
</span><span class="cx"> 
</span><span class="cx">         Add Optional to Forward.h.
</span></span></pre></div>
<a id="trunkSourceWebKitWebProcessWebPageiosWebPageIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (242776 => 242777)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-03-12 05:27:44 UTC (rev 242776)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm    2019-03-12 05:50:21 UTC (rev 242777)
</span><span class="lines">@@ -640,10 +640,6 @@
</span><span class="cx">     if (newFocusedElement && newFocusedElement == oldFocusedElement)
</span><span class="cx">         elementDidRefocus(*newFocusedElement);
</span><span class="cx"> 
</span><del>-    nodeRespondingToClick.document().frame()->eventHandler().dispatchSyntheticMouseOut(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::NoType, 0, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap));
-    if (m_isClosed)
-        return;
-
</del><span class="cx">     if (!tapWasHandled || !nodeRespondingToClick.isElementNode())
</span><span class="cx">         send(Messages::WebPageProxy::DidNotHandleTapAsClick(roundedIntPoint(location)));
</span><span class="cx">     
</span></span></pre>
</div>
</div>

</body>
</html>