<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[242683] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/242683">242683</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2019-03-09 21:52:21 -0800 (Sat, 09 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Add a test for scrolling tree adjustment of fixed layers (<a href="http://trac.webkit.org/projects/webkit/changeset/242601">r242601</a>)
https://bugs.webkit.org/show_bug.cgi?id=195521

Reviewed by Sam Weinig.

This test sets the "unstable" scrolling state (as if the user is actively scrolling) and scrolls,
then changes style to trigger a scrolling tree commit with a changed offset for a fixed layer.
The test shows the wrong fixed layer position before <a href="http://trac.webkit.org/projects/webkit/changeset/242601">r242601</a>.

Helpers are added to UIHelper to do the scroll, and to wrap setTimeout in an async function.
Sadly we have to wait about 120ms for the scrollbars to fade out.

* resources/ui-helper.js:
(window.UIHelper.async.delayFor):
(window.UIHelper.async.immediateScrollTo):
(window.UIHelper.async.immediateUnstableScrollTo):
* scrollingcoordinator/ios/ui-scroll-fixed-expected.html: Added.
* scrollingcoordinator/ios/ui-scroll-fixed.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsresourcesuihelperjs">trunk/LayoutTests/resources/ui-helper.js</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsscrollingcoordinatoriosuiscrollfixedexpectedhtml">trunk/LayoutTests/scrollingcoordinator/ios/ui-scroll-fixed-expected.html</a></li>
<li><a href="#trunkLayoutTestsscrollingcoordinatoriosuiscrollfixedhtml">trunk/LayoutTests/scrollingcoordinator/ios/ui-scroll-fixed.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (242682 => 242683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2019-03-10 05:43:36 UTC (rev 242682)
+++ trunk/LayoutTests/ChangeLog 2019-03-10 05:52:21 UTC (rev 242683)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2019-03-09  Simon Fraser  <simon.fraser@apple.com>
+
+        Add a test for scrolling tree adjustment of fixed layers (r242601)
+        https://bugs.webkit.org/show_bug.cgi?id=195521
+
+        Reviewed by Sam Weinig.
+        
+        This test sets the "unstable" scrolling state (as if the user is actively scrolling) and scrolls,
+        then changes style to trigger a scrolling tree commit with a changed offset for a fixed layer.
+        The test shows the wrong fixed layer position before r242601.
+
+        Helpers are added to UIHelper to do the scroll, and to wrap setTimeout in an async function.
+        Sadly we have to wait about 120ms for the scrollbars to fade out.
+
+        * resources/ui-helper.js:
+        (window.UIHelper.async.delayFor):
+        (window.UIHelper.async.immediateScrollTo):
+        (window.UIHelper.async.immediateUnstableScrollTo):
+        * scrollingcoordinator/ios/ui-scroll-fixed-expected.html: Added.
+        * scrollingcoordinator/ios/ui-scroll-fixed.html: Added.
+
</ins><span class="cx"> 2019-03-09  Wenson Hsieh  <wenson_hsieh@apple.com>
</span><span class="cx"> 
</span><span class="cx">         REGRESSION (r242551): Sporadic hangs when tapping to change selection on iOS
</span></span></pre></div>
<a id="trunkLayoutTestsresourcesuihelperjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/resources/ui-helper.js (242682 => 242683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/resources/ui-helper.js 2019-03-10 05:43:36 UTC (rev 242682)
+++ trunk/LayoutTests/resources/ui-helper.js    2019-03-10 05:52:21 UTC (rev 242683)
</span><span class="lines">@@ -197,6 +197,38 @@
</span><span class="cx">         });
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    static async delayFor(ms)
+    {
+        return new Promise(resolve => setTimeout(resolve, ms));
+    }
+    
+    static async immediateScrollTo(x, y)
+    {
+        if (!this.isWebKit2()) {
+            window.scrollTo(x, y);
+            return Promise.resolve();
+        }
+
+        await new Promise(resolve => {
+            testRunner.runUIScript(`
+                uiController.immediateScrollToOffset(${x}, ${y});`, resolve);
+        });
+    }
+
+    static async immediateUnstableScrollTo(x, y)
+    {
+        if (!this.isWebKit2()) {
+            window.scrollTo(x, y);
+            return Promise.resolve();
+        }
+
+        await new Promise(resolve => {
+            testRunner.runUIScript(`
+                uiController.stableStateOverride = false;
+                uiController.immediateScrollToOffset(${x}, ${y});`, resolve);
+        });
+    }
+
</ins><span class="cx">     static ensureVisibleContentRectUpdate()
</span><span class="cx">     {
</span><span class="cx">         if (!this.isWebKit2())
</span></span></pre></div>
<a id="trunkLayoutTestsscrollingcoordinatoriosuiscrollfixedexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/scrollingcoordinator/ios/ui-scroll-fixed-expected.html (0 => 242683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/scrollingcoordinator/ios/ui-scroll-fixed-expected.html                         (rev 0)
+++ trunk/LayoutTests/scrollingcoordinator/ios/ui-scroll-fixed-expected.html    2019-03-10 05:52:21 UTC (rev 242683)
</span><span class="lines">@@ -0,0 +1,57 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
+
+<html>
+<head>
+    <meta name="viewport" content="initial-scale=1.0">
+    <style>
+        body {
+            height: 2000px;
+            margin: 0;
+        }
+
+        #fixed {
+            position: fixed;
+            top: 200px;
+            left: 20px;
+            height: 100px;
+            width: calc(100% - 40px);
+            background-color: blue;
+        }
+        
+        #container {
+            position: absolute;
+            z-index: 0;
+            top: 100px;
+            left: 0;
+            height: 400px;
+            width: 100%;
+            border: 2px solid black;
+            box-sizing: border-box;
+            overflow: hidden; /* Forces compositing on this layer */
+        }
+    </style>
+    <script src="../../resources/ui-helper.js"></script>
+    <script>
+        if (window.testRunner)
+            testRunner.waitUntilDone();
+
+        async function runTest()
+        {
+            if (!testRunner.runUIScript)
+                return
+
+            await UIHelper.delayFor(0);
+            await UIHelper.immediateUnstableScrollTo(0, 50);
+            await UIHelper.delayFor(120); // Wait for scrollbars to disappear.
+            testRunner.notifyDone();
+        }
+        
+        window.addEventListener('load', runTest, false);
+    </script>
+</head>
+<body>
+    <div id="container">
+        <div id="fixed"></div>
+    </div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsscrollingcoordinatoriosuiscrollfixedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/scrollingcoordinator/ios/ui-scroll-fixed.html (0 => 242683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/scrollingcoordinator/ios/ui-scroll-fixed.html                          (rev 0)
+++ trunk/LayoutTests/scrollingcoordinator/ios/ui-scroll-fixed.html     2019-03-10 05:52:21 UTC (rev 242683)
</span><span class="lines">@@ -0,0 +1,62 @@
</span><ins>+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
+
+<html>
+<head>
+    <meta name="viewport" content="initial-scale=1.0">
+    <style>
+        body {
+            height: 2000px;
+            margin: 0;
+        }
+
+        #fixed {
+            position: fixed;
+            top: 200px;
+            left: 20px;
+            height: 100px;
+            width: calc(100% - 40px);
+            background-color: blue;
+        }
+        
+        #container {
+            position: absolute;
+            z-index: 0;
+            top: 50px;
+            left: 0;
+            height: 400px;
+            width: 100%;
+            border: 2px solid black;
+            box-sizing: border-box;
+            overflow: hidden; /* Forces compositing on this layer */
+        }
+        
+        #container.changed {
+            top: 100px;
+        }
+    </style>
+    <script src="../../resources/ui-helper.js"></script>
+    <script>
+        if (window.testRunner)
+            testRunner.waitUntilDone();
+
+        async function runTest()
+        {
+            if (!testRunner.runUIScript)
+                return
+
+            await UIHelper.delayFor(0);
+            await UIHelper.immediateUnstableScrollTo(0, 50);
+            await UIHelper.delayFor((120)); // Wait for scrollbars to disappear.
+            document.getElementById('container').classList.add('changed');
+            testRunner.notifyDone();
+        }
+        
+        window.addEventListener('load', runTest, false);
+    </script>
+</head>
+<body>
+    <div id="container">
+        <div id="fixed"></div>
+    </div>
+</body>
+</html>
</ins></span></pre>
</div>
</div>

</body>
</html>