<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[242556] trunk/Source/WebInspectorUI</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/242556">242556</a></dd>
<dt>Author</dt> <dd>drousso@apple.com</dd>
<dt>Date</dt> <dd>2019-03-06 11:22:30 -0800 (Wed, 06 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: CSS Changes: only show changes for the given node
https://bugs.webkit.org/show_bug.cgi?id=194608
<rdar://problem/48050206>

Reviewed by Timothy Hatcher.

* UserInterface/Views/ChangesDetailsSidebarPanel.js:
(WI.ChangesDetailsSidebarPanel.prototype.inspect):
(WI.ChangesDetailsSidebarPanel.prototype.supportsDOMNode):
(WI.ChangesDetailsSidebarPanel.prototype.layout):
Make this panel a subclass of `WI.DOMDetailsSidebarPanel` so it has access to the selected
DOM node in the Elements tab.

* UserInterface/Base/Setting.js:
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
Create new general setting for controlling this change.

* Localizations/en.lproj/localizedStrings.js:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseSettingjs">trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsChangesDetailsSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsSettingsTabContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (242555 => 242556)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog    2019-03-06 19:20:53 UTC (rev 242555)
+++ trunk/Source/WebInspectorUI/ChangeLog       2019-03-06 19:22:30 UTC (rev 242556)
</span><span class="lines">@@ -1,5 +1,27 @@
</span><span class="cx"> 2019-03-06  Devin Rousso  <drousso@apple.com>
</span><span class="cx"> 
</span><ins>+        Web Inspector: CSS Changes: only show changes for the given node
+        https://bugs.webkit.org/show_bug.cgi?id=194608
+        <rdar://problem/48050206>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ChangesDetailsSidebarPanel.js:
+        (WI.ChangesDetailsSidebarPanel.prototype.inspect):
+        (WI.ChangesDetailsSidebarPanel.prototype.supportsDOMNode):
+        (WI.ChangesDetailsSidebarPanel.prototype.layout):
+        Make this panel a subclass of `WI.DOMDetailsSidebarPanel` so it has access to the selected
+        DOM node in the Elements tab.
+
+        * UserInterface/Base/Setting.js:
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createGeneralSettingsView):
+        Create new general setting for controlling this change.
+
+        * Localizations/en.lproj/localizedStrings.js:
+
+2019-03-06  Devin Rousso  <drousso@apple.com>
+
</ins><span class="cx">         Web Inspector: Canvas: color swatches aren't shown for valid inputs with leading/trailing whitespace
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=195298
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (242555 => 242556)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js   2019-03-06 19:20:53 UTC (rev 242555)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js      2019-03-06 19:22:30 UTC (rev 242556)
</span><span class="lines">@@ -176,6 +176,7 @@
</span><span class="cx"> localizedStrings["CSP Hash"] = "CSP Hash";
</span><span class="cx"> localizedStrings["CSS"] = "CSS";
</span><span class="cx"> localizedStrings["CSS Canvas"] = "CSS Canvas";
</span><ins>+localizedStrings["CSS Changes:"] = "CSS Changes:";
</ins><span class="cx"> localizedStrings["CSS canvas \u201C%s\u201D"] = "CSS canvas \u201C%s\u201D";
</span><span class="cx"> localizedStrings["Cached"] = "Cached";
</span><span class="cx"> localizedStrings["Call Frames Truncated"] = "Call Frames Truncated";
</span><span class="lines">@@ -915,6 +916,7 @@
</span><span class="cx"> localizedStrings["Show hidden tabs"] = "Show hidden tabs";
</span><span class="cx"> localizedStrings["Show messages logged to the Console"] = "Show messages logged to the Console";
</span><span class="cx"> localizedStrings["Show network information"] = "Show network information";
</span><ins>+localizedStrings["Show only for selected node"] = "Show only for selected node";
</ins><span class="cx"> localizedStrings["Show page load timing"] = "Show page load timing";
</span><span class="cx"> localizedStrings["Show page resources"] = "Show page resources";
</span><span class="cx"> localizedStrings["Show shadow DOM nodes"] = "Show shadow DOM nodes";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseSettingjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (242555 => 242556)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js        2019-03-06 19:20:53 UTC (rev 242555)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js   2019-03-06 19:22:30 UTC (rev 242556)
</span><span class="lines">@@ -127,6 +127,7 @@
</span><span class="cx"> WI.settings = {
</span><span class="cx">     canvasRecordingAutoCaptureEnabled: new WI.Setting("canvas-recording-auto-capture-enabled", false),
</span><span class="cx">     canvasRecordingAutoCaptureFrameCount: new WI.Setting("canvas-recording-auto-capture-frame-count", 1),
</span><ins>+    cssChangesPerNode: new WI.Setting("css-changes-per-node", false),
</ins><span class="cx">     clearLogOnNavigate: new WI.Setting("clear-log-on-navigate", true),
</span><span class="cx">     clearNetworkOnNavigate: new WI.Setting("clear-network-on-navigate", true),
</span><span class="cx">     cpuTimelineThreadDetailsExpanded: new WI.Setting("cpu-timeline-thread-details-expanded", false),
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsChangesDetailsSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js (242555 => 242556)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js    2019-03-06 19:20:53 UTC (rev 242555)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js       2019-03-06 19:22:30 UTC (rev 242556)
</span><span class="lines">@@ -23,7 +23,7 @@
</span><span class="cx">  * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">  */
</span><span class="cx"> 
</span><del>-WI.ChangesDetailsSidebarPanel = class ChangesDetailsSidebarPanel extends WI.DetailsSidebarPanel
</del><ins>+WI.ChangesDetailsSidebarPanel = class ChangesDetailsSidebarPanel extends WI.DOMDetailsSidebarPanel
</ins><span class="cx"> {
</span><span class="cx">     constructor()
</span><span class="cx">     {
</span><span class="lines">@@ -36,11 +36,20 @@
</span><span class="cx"> 
</span><span class="cx">     inspect(objects)
</span><span class="cx">     {
</span><ins>+        let inspectable = super.inspect(objects);
+
+        if (WI.settings.cssChangesPerNode.value)
+            return inspectable;
+
+        // Display Changes panel regardless of the selected DOM node.
</ins><span class="cx">         return true;
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     supportsDOMNode(nodeToInspect)
</span><span class="cx">     {
</span><ins>+        if (WI.settings.cssChangesPerNode.value)
+            return nodeToInspect.nodeType() === Node.ELEMENT_NODE;
+
</ins><span class="cx">         // Display Changes panel regardless of the selected DOM node.
</span><span class="cx">         return true;
</span><span class="cx">     }
</span><span class="lines">@@ -74,6 +83,14 @@
</span><span class="cx"> 
</span><span class="cx">         let cssRules = WI.cssManager.modifiedCSSRules;
</span><span class="cx"> 
</span><ins>+        if (WI.settings.cssChangesPerNode.value) {
+            if (this.domNode) {
+                let styles = WI.cssManager.stylesForNode(this.domNode);
+                cssRules = cssRules.filter((cssRule) => styles.matchedRules.some((matchedRule) => cssRule.isEqualTo(matchedRule)));
+            } else
+                cssRules = [];
+        }
+
</ins><span class="cx">         this.element.classList.toggle("empty", !cssRules.length);
</span><span class="cx">         if (!cssRules.length) {
</span><span class="cx">             this.element.textContent = WI.UIString("No CSS Changes");
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsSettingsTabContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (242555 => 242556)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js        2019-03-06 19:20:53 UTC (rev 242555)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js   2019-03-06 19:22:30 UTC (rev 242556)
</span><span class="lines">@@ -217,6 +217,10 @@
</span><span class="cx"> 
</span><span class="cx">         generalSettingsView.addSeparator();
</span><span class="cx"> 
</span><ins>+        generalSettingsView.addSetting(WI.UIString("CSS Changes:"), WI.settings.cssChangesPerNode, WI.UIString("Show only for selected node"));
+
+        generalSettingsView.addSeparator();
+
</ins><span class="cx">         const zoomLevels = [0.6, 0.8, 1, 1.2, 1.4, 1.6, 1.8, 2, 2.2, 2.4];
</span><span class="cx">         const zoomValues = zoomLevels.map((level) => [level, Number.percentageString(level, 0)]);
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>