<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[242473] releases/WebKitGTK/webkit-2.24</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/242473">242473</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2019-03-05 09:21:09 -0800 (Tue, 05 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/242109">r242109</a> - Fix warnings on ARM and MIPS
https://bugs.webkit.org/show_bug.cgi?id=195049

Reviewed by Mark Lam.

.:

Disable warnings for changes to the ABI with GCC 7.1.

* Source/cmake/WebKitCompilerFlags.cmake:

Source/JavaScriptCore:

Fix all warnings on ARM and MIPS.

* assembler/MacroAssemblerPrinter.cpp:
(JSC::Printer::printMemory):
* assembler/testmasm.cpp:
(JSC::testProbeModifiesStackValues):
* bytecode/InByIdStatus.cpp:
(JSC::InByIdStatus::computeFor):
* runtime/CachedTypes.cpp:
(JSC::VariableLengthObject::buffer const):
* runtime/JSBigInt.h:
* tools/JSDollarVM.cpp:
(JSC::codeBlockFromArg):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit224ChangeLog">releases/WebKitGTK/webkit-2.24/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceJavaScriptCoreChangeLog">releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceJavaScriptCoreassemblerMacroAssemblerPrintercpp">releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceJavaScriptCoreassemblertestmasmcpp">releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/assembler/testmasm.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceJavaScriptCorebytecodeInByIdStatuscpp">releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/bytecode/InByIdStatus.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceJavaScriptCoreruntimeCachedTypescpp">releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/runtime/CachedTypes.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceJavaScriptCoreruntimeJSBigInth">releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/runtime/JSBigInt.h</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceJavaScriptCoretoolsJSDollarVMcpp">releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/tools/JSDollarVM.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourcecmakeWebKitCompilerFlagscmake">releases/WebKitGTK/webkit-2.24/Source/cmake/WebKitCompilerFlags.cmake</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit224ChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/ChangeLog (242472 => 242473)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/ChangeLog 2019-03-05 17:21:03 UTC (rev 242472)
+++ releases/WebKitGTK/webkit-2.24/ChangeLog    2019-03-05 17:21:09 UTC (rev 242473)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2019-02-26  Dominik Infuehr  <dinfuehr@igalia.com>
+
+        Fix warnings on ARM and MIPS
+        https://bugs.webkit.org/show_bug.cgi?id=195049
+
+        Reviewed by Mark Lam.
+
+        Disable warnings for changes to the ABI with GCC 7.1.
+
+        * Source/cmake/WebKitCompilerFlags.cmake:
+
</ins><span class="cx"> 2019-02-25  Miguel Gomez  <magomez@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [WPE] Add support for holepunch using an external video player
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/ChangeLog (242472 => 242473)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/ChangeLog   2019-03-05 17:21:03 UTC (rev 242472)
+++ releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/ChangeLog      2019-03-05 17:21:09 UTC (rev 242473)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2019-02-26  Dominik Infuehr  <dinfuehr@igalia.com>
+
+        Fix warnings on ARM and MIPS
+        https://bugs.webkit.org/show_bug.cgi?id=195049
+
+        Reviewed by Mark Lam.
+
+        Fix all warnings on ARM and MIPS.
+
+        * assembler/MacroAssemblerPrinter.cpp:
+        (JSC::Printer::printMemory):
+        * assembler/testmasm.cpp:
+        (JSC::testProbeModifiesStackValues):
+        * bytecode/InByIdStatus.cpp:
+        (JSC::InByIdStatus::computeFor):
+        * runtime/CachedTypes.cpp:
+        (JSC::VariableLengthObject::buffer const):
+        * runtime/JSBigInt.h:
+        * tools/JSDollarVM.cpp:
+        (JSC::codeBlockFromArg):
+
</ins><span class="cx"> 2019-02-26  Mark Lam  <mark.lam@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Unpoison MacroAssemblerCodePtr, ClassInfo pointers, and a few other things.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceJavaScriptCoreassemblerMacroAssemblerPrintercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp (242472 => 242473)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp 2019-03-05 17:21:03 UTC (rev 242472)
+++ releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp    2019-03-05 17:21:09 UTC (rev 242473)
</span><span class="lines">@@ -138,17 +138,17 @@
</span><span class="cx">             return;
</span><span class="cx">         }
</span><span class="cx">         if (memory.numBytes == sizeof(int16_t)) {
</span><del>-            auto p = reinterpret_cast<int16_t*>(ptr);
</del><ins>+            auto p = bitwise_cast<int16_t*>(ptr);
</ins><span class="cx">             out.printf("%p:<0x%04x %d>", p, *p, *p);
</span><span class="cx">             return;
</span><span class="cx">         }
</span><span class="cx">         if (memory.numBytes == sizeof(int32_t)) {
</span><del>-            auto p = reinterpret_cast<int32_t*>(ptr);
</del><ins>+            auto p = bitwise_cast<int32_t*>(ptr);
</ins><span class="cx">             out.printf("%p:<0x%08x %d>", p, *p, *p);
</span><span class="cx">             return;
</span><span class="cx">         }
</span><span class="cx">         if (memory.numBytes == sizeof(int64_t)) {
</span><del>-            auto p = reinterpret_cast<int64_t*>(ptr);
</del><ins>+            auto p = bitwise_cast<int64_t*>(ptr);
</ins><span class="cx">             out.printf("%p:<0x%016" PRIx64 " %" PRId64 ">", p, *p, *p);
</span><span class="cx">             return;
</span><span class="cx">         }
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceJavaScriptCoreassemblertestmasmcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/assembler/testmasm.cpp (242472 => 242473)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/assembler/testmasm.cpp      2019-03-05 17:21:03 UTC (rev 242472)
+++ releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/assembler/testmasm.cpp 2019-03-05 17:21:09 UTC (rev 242473)
</span><span class="lines">@@ -246,6 +246,7 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> 
</span><ins>+#if CPU(X86) || CPU(X86_64) || CPU(ARM64)
</ins><span class="cx"> static Vector<float> floatOperands()
</span><span class="cx"> {
</span><span class="cx">     return Vector<float> {
</span><span class="lines">@@ -263,6 +264,7 @@
</span><span class="cx">         -std::numeric_limits<float>::infinity(),
</span><span class="cx">     };
</span><span class="cx"> }
</span><ins>+#endif
</ins><span class="cx"> 
</span><span class="cx"> static Vector<int32_t> int32Operands()
</span><span class="cx"> {
</span><span class="lines">@@ -779,7 +781,9 @@
</span><span class="cx">     CPUState originalState;
</span><span class="cx">     void* originalSP { nullptr };
</span><span class="cx">     void* newSP { nullptr };
</span><ins>+#if !CPU(MIPS)
</ins><span class="cx">     uintptr_t modifiedFlags { 0 };
</span><ins>+#endif
</ins><span class="cx">     size_t numberOfExtraEntriesToWrite { 10 }; // ARM64 requires that this be 2 word aligned.
</span><span class="cx"> 
</span><span class="cx"> #if CPU(X86) || CPU(X86_64)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceJavaScriptCorebytecodeInByIdStatuscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/bytecode/InByIdStatus.cpp (242472 => 242473)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/bytecode/InByIdStatus.cpp   2019-03-05 17:21:03 UTC (rev 242472)
+++ releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/bytecode/InByIdStatus.cpp      2019-03-05 17:21:09 UTC (rev 242473)
</span><span class="lines">@@ -58,6 +58,7 @@
</span><span class="cx">     UNUSED_PARAM(map);
</span><span class="cx">     UNUSED_PARAM(bytecodeIndex);
</span><span class="cx">     UNUSED_PARAM(uid);
</span><ins>+    UNUSED_PARAM(didExit);
</ins><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx">     return result;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceJavaScriptCoreruntimeCachedTypescpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/runtime/CachedTypes.cpp (242472 => 242473)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/runtime/CachedTypes.cpp     2019-03-05 17:21:03 UTC (rev 242472)
+++ releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/runtime/CachedTypes.cpp        2019-03-05 17:21:09 UTC (rev 242473)
</span><span class="lines">@@ -340,7 +340,7 @@
</span><span class="cx">     template<typename T>
</span><span class="cx">     const T* buffer() const
</span><span class="cx">     {
</span><del>-        return reinterpret_cast<const T*>(buffer());
</del><ins>+        return bitwise_cast<const T*>(buffer());
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     uint8_t* allocate(Encoder& encoder, size_t size)
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceJavaScriptCoreruntimeJSBigInth"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/runtime/JSBigInt.h (242472 => 242473)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/runtime/JSBigInt.h  2019-03-05 17:21:03 UTC (rev 242472)
+++ releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/runtime/JSBigInt.h     2019-03-05 17:21:09 UTC (rev 242473)
</span><span class="lines">@@ -236,7 +236,7 @@
</span><span class="cx"> 
</span><span class="cx">     inline Digit* dataStorage()
</span><span class="cx">     {
</span><del>-        return reinterpret_cast<Digit*>(reinterpret_cast<char*>(this) + offsetOfData());
</del><ins>+        return bitwise_cast<Digit*>(reinterpret_cast<char*>(this) + offsetOfData());
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     Digit digit(unsigned);
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceJavaScriptCoretoolsJSDollarVMcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/tools/JSDollarVM.cpp (242472 => 242473)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/tools/JSDollarVM.cpp        2019-03-05 17:21:03 UTC (rev 242472)
+++ releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore/tools/JSDollarVM.cpp   2019-03-05 17:21:09 UTC (rev 242473)
</span><span class="lines">@@ -1461,7 +1461,7 @@
</span><span class="cx">             else
</span><span class="cx">                 candidateCodeBlock = func->jsExecutable()->eitherCodeBlock();
</span><span class="cx">         } else
</span><del>-            candidateCodeBlock = reinterpret_cast<CodeBlock*>(value.asCell());
</del><ins>+            candidateCodeBlock = static_cast<CodeBlock*>(value.asCell());
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     if (candidateCodeBlock && VMInspector::isValidCodeBlock(exec, candidateCodeBlock))
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourcecmakeWebKitCompilerFlagscmake"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/cmake/WebKitCompilerFlags.cmake (242472 => 242473)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/cmake/WebKitCompilerFlags.cmake    2019-03-05 17:21:03 UTC (rev 242472)
+++ releases/WebKitGTK/webkit-2.24/Source/cmake/WebKitCompilerFlags.cmake       2019-03-05 17:21:09 UTC (rev 242473)
</span><span class="lines">@@ -131,7 +131,8 @@
</span><span class="cx">     WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Qunused-arguments
</span><span class="cx">                                          -Wno-maybe-uninitialized
</span><span class="cx">                                          -Wno-noexcept-type
</span><del>-                                         -Wno-parentheses-equality)
</del><ins>+                                         -Wno-parentheses-equality
+                                         -Wno-psabi)
</ins><span class="cx"> 
</span><span class="cx">     # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80947
</span><span class="cx">     if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "8.0" AND NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
</span></span></pre>
</div>
</div>

</body>
</html>