<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[242454] releases/WebKitGTK/webkit-2.24</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/242454">242454</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2019-03-05 04:41:34 -0800 (Tue, 05 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/242043">r242043</a> - IndexedDB: IDBDatabase and IDBTransaction are leaked in layout tests
https://bugs.webkit.org/show_bug.cgi?id=194709

Reviewed by Geoffrey Garen.

Source/WebCore:

When connection to IDB server is closed, IDBTransaction would abort without notifying IDBDatabase, so
IDBDatabase didn't clear its reference to IDBTransaction which created a reference cycle.

Also IDBTransaction didn't clear its reference to IDBRequest in this case and it led to another reference cycle
between IDBOpenDBRequest and IDBTransaction.

Test: storage/indexeddb/IDBObject-leak.html

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::connectionToServerLost):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::~IDBTransaction):
(WebCore::IDBTransaction::connectionClosedFromServer):
* Modules/indexeddb/IDBTransaction.h:
* testing/Internals.cpp:
(WebCore::Internals::numberOfIDBTransactions const):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* TestExpectations:
* platform/wk2/TestExpectations:
* storage/indexeddb/IDBObject-leak-expected.txt: Added.
* storage/indexeddb/IDBObject-leak.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit224LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit224LayoutTestsTestExpectations">releases/WebKitGTK/webkit-2.24/LayoutTests/TestExpectations</a></li>
<li><a href="#releasesWebKitGTKwebkit224LayoutTestsplatformwk2TestExpectations">releases/WebKitGTK/webkit-2.24/LayoutTests/platform/wk2/TestExpectations</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceWebCoreModulesindexeddbIDBDatabasecpp">releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceWebCoreModulesindexeddbIDBTransactioncpp">releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceWebCoreModulesindexeddbIDBTransactionh">releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBTransaction.h</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceWebCoretestingInternalscpp">releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceWebCoretestingInternalsh">releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.h</a></li>
<li><a href="#releasesWebKitGTKwebkit224SourceWebCoretestingInternalsidl">releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.idl</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit224LayoutTestsstorageindexeddbIDBObjectleakexpectedtxt">releases/WebKitGTK/webkit-2.24/LayoutTests/storage/indexeddb/IDBObject-leak-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit224LayoutTestsstorageindexeddbIDBObjectleakhtml">releases/WebKitGTK/webkit-2.24/LayoutTests/storage/indexeddb/IDBObject-leak.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit224LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog     2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog        2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2019-02-25  Sihui Liu  <sihui_liu@apple.com>
+
+        IndexedDB: IDBDatabase and IDBTransaction are leaked in layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=194709
+
+        Reviewed by Geoffrey Garen.
+
+        * TestExpectations:
+        * platform/wk2/TestExpectations:
+        * storage/indexeddb/IDBObject-leak-expected.txt: Added.
+        * storage/indexeddb/IDBObject-leak.html: Added.
+
</ins><span class="cx"> 2019-02-22  Rob Buis  <rbuis@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         Fix unitless usage of mathsize
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224LayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/LayoutTests/TestExpectations (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/LayoutTests/TestExpectations      2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/TestExpectations 2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -129,6 +129,7 @@
</span><span class="cx"> http/tests/navigation/process-swap-window-open.html [ Skip ]
</span><span class="cx"> http/tests/navigation/useragent-reload.php [ Skip ]
</span><span class="cx"> storage/indexeddb/modern/opendatabase-after-storage-crash.html [ Skip ]
</span><ins>+storage/indexeddb/IDBObject-leak.html [ Skip ]
</ins><span class="cx"> fast/forms/call-text-did-change-in-text-field-when-typing.html [ Skip ]
</span><span class="cx"> 
</span><span class="cx"> # Only Mac and iOS have an implementation of UIScriptController::doAsyncTask().
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224LayoutTestsplatformwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/LayoutTests/platform/wk2/TestExpectations (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/LayoutTests/platform/wk2/TestExpectations 2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/platform/wk2/TestExpectations    2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -746,6 +746,7 @@
</span><span class="cx"> 
</span><span class="cx"> http/tests/navigation/useragent-reload.php [ Pass ]
</span><span class="cx"> storage/indexeddb/modern/opendatabase-after-storage-crash.html [ Pass ]
</span><ins>+storage/indexeddb/IDBObject-leak.html [ Pass ]
</ins><span class="cx"> 
</span><span class="cx"> fast/forms/call-text-did-change-in-text-field-when-typing.html [ Pass ]
</span><span class="cx"> 
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224LayoutTestsstorageindexeddbIDBObjectleakexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.24/LayoutTests/storage/indexeddb/IDBObject-leak-expected.txt (0 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/LayoutTests/storage/indexeddb/IDBObject-leak-expected.txt                         (rev 0)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/storage/indexeddb/IDBObject-leak-expected.txt    2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+This test verifies that IDBTransaction objects are freed.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS internals.numberOfIDBTransactions() is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit224LayoutTestsstorageindexeddbIDBObjectleakhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.24/LayoutTests/storage/indexeddb/IDBObject-leak.html (0 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/LayoutTests/storage/indexeddb/IDBObject-leak.html                         (rev 0)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/storage/indexeddb/IDBObject-leak.html    2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+<!DOCTYPE html>
+<script src="../../resources/js-test.js"></script>
+<script src="resources/shared.js"></script>
+<script>
+description('This test verifies that IDBTransaction objects are freed.');
+
+jsTestIsAsync = true;
+
+function test() {
+    if (!window.internals || !internals.numberOfIDBTransactions) {
+        testFailed('This test requires access to the Internals object');
+        finishJSTest();
+        return;
+    }
+
+    if (sessionStorage.doneFirstLoad) {
+        gc();
+        shouldBeEqualToNumber("internals.numberOfIDBTransactions()", 0);
+        finishJSTest();
+        return;
+    }
+
+    var dbname = setDBNameFromPath() + Date();
+    var request =  window.indexedDB.open(dbname);
+    request.onupgradeneeded = function(evt) {
+        sessionStorage.doneFirstLoad = true;
+        if (!window.testRunner || !testRunner.terminateNetworkProcess) {
+            testFailed('This test requires access to the TestRunner object and terminateNetworkProcess() function');
+            finishJSTest();
+            return;
+        } 
+        testRunner.terminateNetworkProcess();
+        setTimeout((()=> {
+            location.reload();
+        }), 0);
+    }
+}
+
+test();
+</script>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog  2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog     2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -1,3 +1,30 @@
</span><ins>+2019-02-25  Sihui Liu  <sihui_liu@apple.com>
+
+        IndexedDB: IDBDatabase and IDBTransaction are leaked in layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=194709
+
+        Reviewed by Geoffrey Garen.
+
+        When connection to IDB server is closed, IDBTransaction would abort without notifying IDBDatabase, so 
+        IDBDatabase didn't clear its reference to IDBTransaction which created a reference cycle. 

+        Also IDBTransaction didn't clear its reference to IDBRequest in this case and it led to another reference cycle
+        between IDBOpenDBRequest and IDBTransaction.
+
+        Test: storage/indexeddb/IDBObject-leak.html
+
+        * Modules/indexeddb/IDBDatabase.cpp:
+        (WebCore::IDBDatabase::connectionToServerLost):
+        * Modules/indexeddb/IDBTransaction.cpp:
+        (WebCore::IDBTransaction::IDBTransaction):
+        (WebCore::IDBTransaction::~IDBTransaction):
+        (WebCore::IDBTransaction::connectionClosedFromServer):
+        * Modules/indexeddb/IDBTransaction.h:
+        * testing/Internals.cpp:
+        (WebCore::Internals::numberOfIDBTransactions const):
+        * testing/Internals.h:
+        * testing/Internals.idl:
+
</ins><span class="cx"> 2019-02-25  Charlie Turner  <cturner@igalia.com>
</span><span class="cx"> 
</span><span class="cx">         [EME][GStreamer] Replace caps field loop with gst_structure_remove_fields
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceWebCoreModulesindexeddbIDBDatabasecpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp  2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp     2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -264,7 +264,8 @@
</span><span class="cx">     m_closePending = true;
</span><span class="cx">     m_closedInServer = true;
</span><span class="cx"> 
</span><del>-    for (auto& transaction : m_activeTransactions.values())
</del><ins>+    auto transactions = copyToVector(m_activeTransactions.values());
+    for (auto& transaction : transactions)
</ins><span class="cx">         transaction->connectionClosedFromServer(error);
</span><span class="cx"> 
</span><span class="cx">     auto errorEvent = Event::create(m_eventNames.errorEvent, Event::CanBubble::Yes, Event::IsCancelable::No);
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceWebCoreModulesindexeddbIDBTransactioncpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp       2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp  2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -59,6 +59,8 @@
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> using namespace JSC;
</span><span class="cx"> 
</span><ins>+std::atomic<unsigned> IDBTransaction::numberOfIDBTransactions { 0 };
+
</ins><span class="cx"> Ref<IDBTransaction> IDBTransaction::create(IDBDatabase& database, const IDBTransactionInfo& info)
</span><span class="cx"> {
</span><span class="cx">     return adoptRef(*new IDBTransaction(database, info, nullptr));
</span><span class="lines">@@ -82,6 +84,8 @@
</span><span class="cx">     LOG(IndexedDB, "IDBTransaction::IDBTransaction - %s", m_info.loggingString().utf8().data());
</span><span class="cx">     ASSERT(&m_database->originThread() == &Thread::current());
</span><span class="cx"> 
</span><ins>+    ++numberOfIDBTransactions;
+
</ins><span class="cx">     if (m_info.mode() == IDBTransactionMode::Versionchange) {
</span><span class="cx">         ASSERT(m_openDBRequest);
</span><span class="cx">         m_openDBRequest->setVersionChangeTransaction(*this);
</span><span class="lines">@@ -105,6 +109,7 @@
</span><span class="cx"> 
</span><span class="cx"> IDBTransaction::~IDBTransaction()
</span><span class="cx"> {
</span><ins>+    --numberOfIDBTransactions;
</ins><span class="cx">     ASSERT(&m_database->originThread() == &Thread::current());
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -1434,7 +1439,8 @@
</span><span class="cx"> {
</span><span class="cx">     LOG(IndexedDB, "IDBTransaction::connectionClosedFromServer - %s", error.message().utf8().data());
</span><span class="cx"> 
</span><del>-    m_state = IndexedDB::TransactionState::Aborting;
</del><ins>+    m_database->willAbortTransaction(*this);
+    transitionedToFinishing(IndexedDB::TransactionState::Aborting);
</ins><span class="cx"> 
</span><span class="cx">     abortInProgressOperations(error);
</span><span class="cx"> 
</span><span class="lines">@@ -1445,6 +1451,7 @@
</span><span class="cx">         ASSERT(m_transactionOperationsInProgressQueue.first() == operation.get());
</span><span class="cx">         operation->doComplete(IDBResultData::error(operation->identifier(), error));
</span><span class="cx">     }
</span><ins>+    m_currentlyCompletingRequest = nullptr;
</ins><span class="cx"> 
</span><span class="cx">     connectionProxy().forgetActiveOperations(operations);
</span><span class="cx"> 
</span><span class="lines">@@ -1454,6 +1461,7 @@
</span><span class="cx"> 
</span><span class="cx">     m_idbError = error;
</span><span class="cx">     m_domError = error.toDOMException();
</span><ins>+    m_database->didAbortTransaction(*this);
</ins><span class="cx">     fireOnAbort();
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceWebCoreModulesindexeddbIDBTransactionh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBTransaction.h (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBTransaction.h 2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/IDBTransaction.h    2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -152,6 +152,8 @@
</span><span class="cx"> 
</span><span class="cx">     void visitReferencedObjectStores(JSC::SlotVisitor&) const;
</span><span class="cx"> 
</span><ins>+    WEBCORE_EXPORT static std::atomic<unsigned> numberOfIDBTransactions;
+
</ins><span class="cx"> private:
</span><span class="cx">     IDBTransaction(IDBDatabase&, const IDBTransactionInfo&, IDBOpenDBRequest*);
</span><span class="cx"> 
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceWebCoretestingInternalscpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.cpp (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.cpp      2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.cpp 2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -93,6 +93,8 @@
</span><span class="cx"> #include "HistoryController.h"
</span><span class="cx"> #include "HistoryItem.h"
</span><span class="cx"> #include "HitTestResult.h"
</span><ins>+#include "IDBRequest.h"
+#include "IDBTransaction.h"
</ins><span class="cx"> #include "InspectorClient.h"
</span><span class="cx"> #include "InspectorController.h"
</span><span class="cx"> #include "InspectorFrontendClientLocal.h"
</span><span class="lines">@@ -2383,6 +2385,11 @@
</span><span class="cx">     return document->page()->countFindMatches(text, parsedOptions.releaseReturnValue(), 1000);
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+unsigned Internals::numberOfIDBTransactions() const
+{
+    return IDBTransaction::numberOfIDBTransactions;
+}
+
</ins><span class="cx"> unsigned Internals::numberOfLiveNodes() const
</span><span class="cx"> {
</span><span class="cx">     unsigned nodeCount = 0;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceWebCoretestingInternalsh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.h (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.h        2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.h   2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -379,6 +379,8 @@
</span><span class="cx">     ExceptionOr<void> insertAuthorCSS(const String&) const;
</span><span class="cx">     ExceptionOr<void> insertUserCSS(const String&) const;
</span><span class="cx"> 
</span><ins>+    unsigned numberOfIDBTransactions() const;
+
</ins><span class="cx">     unsigned numberOfLiveNodes() const;
</span><span class="cx">     unsigned numberOfLiveDocuments() const;
</span><span class="cx">     unsigned referencingNodeCount(const Document&) const;
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit224SourceWebCoretestingInternalsidl"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.idl (242453 => 242454)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.idl      2019-03-05 12:41:26 UTC (rev 242453)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/testing/Internals.idl 2019-03-05 12:41:34 UTC (rev 242454)
</span><span class="lines">@@ -406,6 +406,8 @@
</span><span class="cx">     void beginSimulatedMemoryPressure();
</span><span class="cx">     void endSimulatedMemoryPressure();
</span><span class="cx"> 
</span><ins>+    unsigned long numberOfIDBTransactions();
+
</ins><span class="cx">     unsigned long numberOfLiveNodes();
</span><span class="cx">     unsigned long numberOfLiveDocuments();
</span><span class="cx">     unsigned long referencingNodeCount(Document document);
</span></span></pre>
</div>
</div>

</body>
</html>