<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[242382] trunk/Source/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/242382">242382</a></dd>
<dt>Author</dt> <dd>ysuzuki@apple.com</dd>
<dt>Date</dt> <dd>2019-03-04 13:20:14 -0800 (Mon, 04 Mar 2019)</dd>
</dl>

<h3>Log Message</h3>
<pre>[JSC] Make Reflect lazily-allocated by dropping @Reflect references from builtin JS
https://bugs.webkit.org/show_bug.cgi?id=195250

Reviewed by Saam Barati.

By removing @Reflect from builtin JS, we can make Reflect object allocation lazy.
We move @ownKeys function from @Reflect to @Object to remove @Reflect reference.

We also remove m_intlObject field from JSGlobalObject since we no longer use it.

* builtins/BuiltinNames.h:
* builtins/GlobalOperations.js:
(globalPrivate.copyDataProperties):
(globalPrivate.copyDataPropertiesNoExclusions):
* runtime/JSGlobalObject.cpp:
(JSC::createReflectProperty):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
(JSC::objectConstructorOwnKeys):
* runtime/ReflectObject.cpp:
(JSC::ReflectObject::finishCreation):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsBuiltinNamesh">trunk/Source/JavaScriptCore/builtins/BuiltinNames.h</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsGlobalOperationsjs">trunk/Source/JavaScriptCore/builtins/GlobalOperations.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjectcpp">trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjecth">trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjectFunctionscpp">trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSGlobalObjectFunctionsh">trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeReflectObjectcpp">trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (242381 => 242382)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2019-03-04 21:17:36 UTC (rev 242381)
+++ trunk/Source/JavaScriptCore/ChangeLog       2019-03-04 21:20:14 UTC (rev 242382)
</span><span class="lines">@@ -1,5 +1,32 @@
</span><span class="cx"> 2019-03-04  Yusuke Suzuki  <ysuzuki@apple.com>
</span><span class="cx"> 
</span><ins>+        [JSC] Make Reflect lazily-allocated by dropping @Reflect references from builtin JS
+        https://bugs.webkit.org/show_bug.cgi?id=195250
+
+        Reviewed by Saam Barati.
+
+        By removing @Reflect from builtin JS, we can make Reflect object allocation lazy.
+        We move @ownKeys function from @Reflect to @Object to remove @Reflect reference.
+
+        We also remove m_intlObject field from JSGlobalObject since we no longer use it.
+
+        * builtins/BuiltinNames.h:
+        * builtins/GlobalOperations.js:
+        (globalPrivate.copyDataProperties):
+        (globalPrivate.copyDataPropertiesNoExclusions):
+        * runtime/JSGlobalObject.cpp:
+        (JSC::createReflectProperty):
+        (JSC::JSGlobalObject::init):
+        (JSC::JSGlobalObject::visitChildren):
+        * runtime/JSGlobalObject.h:
+        * runtime/ObjectConstructor.cpp:
+        (JSC::ObjectConstructor::finishCreation):
+        (JSC::objectConstructorOwnKeys):
+        * runtime/ReflectObject.cpp:
+        (JSC::ReflectObject::finishCreation):
+
+2019-03-04  Yusuke Suzuki  <ysuzuki@apple.com>
+
</ins><span class="cx">         [JSC] Offer @makeTypeError instead of exposing @TypeError
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=193858
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsBuiltinNamesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/BuiltinNames.h (242381 => 242382)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/BuiltinNames.h      2019-03-04 21:17:36 UTC (rev 242381)
+++ trunk/Source/JavaScriptCore/builtins/BuiltinNames.h 2019-03-04 21:20:14 UTC (rev 242382)
</span><span class="lines">@@ -64,13 +64,11 @@
</span><span class="cx">     macro(ArrayBuffer) \
</span><span class="cx">     macro(RegExp) \
</span><span class="cx">     macro(Promise) \
</span><del>-    macro(Reflect) \
</del><span class="cx">     macro(InternalPromise) \
</span><span class="cx">     macro(trunc) \
</span><span class="cx">     macro(create) \
</span><span class="cx">     macro(defineProperty) \
</span><span class="cx">     macro(getPrototypeOf) \
</span><del>-    macro(getOwnPropertyDescriptor) \
</del><span class="cx">     macro(getOwnPropertyNames) \
</span><span class="cx">     macro(ownKeys) \
</span><span class="cx">     macro(Set) \
</span><span class="lines">@@ -81,7 +79,6 @@
</span><span class="cx">     macro(BuiltinLog) \
</span><span class="cx">     macro(BuiltinDescribe) \
</span><span class="cx">     macro(homeObject) \
</span><del>-    macro(templateRegistryKey) \
</del><span class="cx">     macro(enqueueJob) \
</span><span class="cx">     macro(hostPromiseRejectionTracker) \
</span><span class="cx">     macro(promiseIsHandled) \
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsGlobalOperationsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/GlobalOperations.js (242381 => 242382)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/GlobalOperations.js 2019-03-04 21:17:36 UTC (rev 242381)
+++ trunk/Source/JavaScriptCore/builtins/GlobalOperations.js    2019-03-04 21:20:14 UTC (rev 242382)
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx">         return target;
</span><span class="cx"> 
</span><span class="cx">     let from = @toObject(source);
</span><del>-    let keys = @Reflect.@ownKeys(from); 
</del><ins>+    let keys = @ownKeys(from);
</ins><span class="cx">     let keysLength = keys.length;
</span><span class="cx">     for (let i = 0; i < keysLength; i++) {
</span><span class="cx">         let nextKey = keys[i];
</span><span class="lines">@@ -123,7 +123,7 @@
</span><span class="cx">         return target;
</span><span class="cx"> 
</span><span class="cx">     let from = @toObject(source);
</span><del>-    let keys = @Reflect.@ownKeys(from); 
</del><ins>+    let keys = @ownKeys(from);
</ins><span class="cx">     let keysLength = keys.length;
</span><span class="cx">     for (let i = 0; i < keysLength; i++) {
</span><span class="cx">         let nextKey = keys[i];
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp (242381 => 242382)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp   2019-03-04 21:17:36 UTC (rev 242381)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp      2019-03-04 21:20:14 UTC (rev 242382)
</span><span class="lines">@@ -222,6 +222,12 @@
</span><span class="cx">     return MathObject::create(vm, global, MathObject::createStructure(vm, global, global->objectPrototype()));
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+static JSValue createReflectProperty(VM& vm, JSObject* object)
+{
+    JSGlobalObject* global = jsCast<JSGlobalObject*>(object);
+    return ReflectObject::create(vm, global, ReflectObject::createStructure(vm, global, global->objectPrototype()));
+}
+
</ins><span class="cx"> static JSValue createConsoleProperty(VM& vm, JSObject* object)
</span><span class="cx"> {
</span><span class="cx">     JSGlobalObject* global = jsCast<JSGlobalObject*>(object);
</span><span class="lines">@@ -321,6 +327,7 @@
</span><span class="cx">   TypeError             JSGlobalObject::m_typeErrorStructure         DontEnum|ClassStructure
</span><span class="cx">   URIError              JSGlobalObject::m_URIErrorStructure          DontEnum|ClassStructure
</span><span class="cx">   Proxy                 createProxyProperty                          DontEnum|PropertyCallback
</span><ins>+  Reflect               createReflectProperty                        DontEnum|PropertyCallback
</ins><span class="cx">   JSON                  createJSONProperty                           DontEnum|PropertyCallback
</span><span class="cx">   Math                  createMathProperty                           DontEnum|PropertyCallback
</span><span class="cx">   console               createConsoleProperty                        DontEnum|PropertyCallback
</span><span class="lines">@@ -833,10 +840,7 @@
</span><span class="cx"> 
</span><span class="cx">     IntlObject* intl = IntlObject::create(vm, IntlObject::createStructure(vm, this, m_objectPrototype.get()));
</span><span class="cx">     putDirectWithoutTransition(vm, vm.propertyNames->Intl, intl, static_cast<unsigned>(PropertyAttribute::DontEnum));
</span><del>-    m_intlObject.set(vm, this, intl);
</del><span class="cx"> #endif // ENABLE(INTL)
</span><del>-    ReflectObject* reflectObject = ReflectObject::create(vm, this, ReflectObject::createStructure(vm, this, m_objectPrototype.get()));
-    putDirectWithoutTransition(vm, vm.propertyNames->Reflect, reflectObject, static_cast<unsigned>(PropertyAttribute::DontEnum));
</del><span class="cx"> 
</span><span class="cx">     m_moduleLoader.initLater(
</span><span class="cx">         [] (const Initializer<JSModuleLoader>& init) {
</span><span class="lines">@@ -853,6 +857,7 @@
</span><span class="cx">     JSFunction* privateFuncTrunc = JSFunction::create(vm, this, 0, String(), mathProtoFuncTrunc, TruncIntrinsic);
</span><span class="cx"> 
</span><span class="cx">     JSFunction* privateFuncPropertyIsEnumerable = JSFunction::create(vm, this, 0, String(), globalFuncPropertyIsEnumerable);
</span><ins>+    JSFunction* privateFuncOwnKeys = JSFunction::create(vm, this, 0, String(), globalFuncOwnKeys);
</ins><span class="cx">     JSFunction* privateFuncImportModule = JSFunction::create(vm, this, 0, String(), globalFuncImportModule);
</span><span class="cx">     JSFunction* privateFuncMakeTypeError = JSFunction::create(vm, this, 0, String(), globalFuncMakeTypeError);
</span><span class="cx">     JSFunction* privateFuncTypedArrayLength = JSFunction::create(vm, this, 0, String(), typedArrayViewPrivateFuncLength);
</span><span class="lines">@@ -924,6 +929,7 @@
</span><span class="cx">         GlobalPropertyInfo(vm.propertyNames->Infinity, jsNumber(std::numeric_limits<double>::infinity()), PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><span class="cx">         GlobalPropertyInfo(vm.propertyNames->undefinedKeyword, jsUndefined(), PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><span class="cx">         GlobalPropertyInfo(vm.propertyNames->builtinNames().propertyIsEnumerablePrivateName(), privateFuncPropertyIsEnumerable, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><ins>+        GlobalPropertyInfo(vm.propertyNames->builtinNames().ownKeysPrivateName(), privateFuncOwnKeys, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</ins><span class="cx">         GlobalPropertyInfo(vm.propertyNames->builtinNames().importModulePrivateName(), privateFuncImportModule, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><span class="cx">         GlobalPropertyInfo(vm.propertyNames->builtinNames().enqueueJobPrivateName(), JSFunction::create(vm, this, 0, String(), enqueueJob), PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><span class="cx">         GlobalPropertyInfo(vm.propertyNames->builtinNames().makeTypeErrorPrivateName(), privateFuncMakeTypeError, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><span class="lines">@@ -940,7 +946,6 @@
</span><span class="cx">         GlobalPropertyInfo(vm.propertyNames->builtinNames().RegExpPrivateName(), regExpConstructor, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><span class="cx">         GlobalPropertyInfo(vm.propertyNames->builtinNames().truncPrivateName(), privateFuncTrunc, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><span class="cx">         GlobalPropertyInfo(vm.propertyNames->builtinNames().PromisePrivateName(), promiseConstructor, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><del>-        GlobalPropertyInfo(vm.propertyNames->builtinNames().ReflectPrivateName(), reflectObject, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</del><span class="cx">         GlobalPropertyInfo(vm.propertyNames->builtinNames().InternalPromisePrivateName(), internalPromiseConstructor, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><span class="cx"> 
</span><span class="cx">         GlobalPropertyInfo(vm.propertyNames->builtinNames().repeatCharacterPrivateName(), JSFunction::create(vm, this, 2, String(), stringProtoFuncRepeatCharacter), PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly),
</span><span class="lines">@@ -1596,7 +1601,6 @@
</span><span class="cx">     visitor.append(thisObject->m_promiseConstructor);
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(INTL)
</span><del>-    visitor.append(thisObject->m_intlObject);
</del><span class="cx">     visitor.append(thisObject->m_defaultCollator);
</span><span class="cx">     thisObject->m_collatorStructure.visit(visitor);
</span><span class="cx">     thisObject->m_numberFormatStructure.visit(visitor);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h (242381 => 242382)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h     2019-03-04 21:17:36 UTC (rev 242381)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h        2019-03-04 21:20:14 UTC (rev 242382)
</span><span class="lines">@@ -274,7 +274,6 @@
</span><span class="cx">     WriteBarrier<JSInternalPromiseConstructor> m_internalPromiseConstructor;
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(INTL)
</span><del>-    WriteBarrier<IntlObject> m_intlObject;
</del><span class="cx">     WriteBarrier<IntlCollator> m_defaultCollator;
</span><span class="cx">     LazyProperty<JSGlobalObject, Structure> m_collatorStructure;
</span><span class="cx">     LazyProperty<JSGlobalObject, Structure> m_numberFormatStructure;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjectFunctionscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp (242381 => 242382)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp  2019-03-04 21:17:36 UTC (rev 242381)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp     2019-03-04 21:20:14 UTC (rev 242382)
</span><span class="lines">@@ -839,6 +839,15 @@
</span><span class="cx">     return JSValue::encode(jsBoolean(enumerable));
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+EncodedJSValue JSC_HOST_CALL globalFuncOwnKeys(ExecState* exec)
+{
+    VM& vm = exec->vm();
+    auto scope = DECLARE_THROW_SCOPE(vm);
+    JSObject* object = exec->argument(0).toObject(exec);
+    RETURN_IF_EXCEPTION(scope, encodedJSValue());
+    RELEASE_AND_RETURN(scope, JSValue::encode(ownPropertyKeys(exec, object, PropertyNameMode::StringsAndSymbols, DontEnumPropertiesMode::Include)));
+}
+
</ins><span class="cx"> #if ENABLE(INTL)
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL globalFuncDateTimeFormat(ExecState* exec)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSGlobalObjectFunctionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h (242381 => 242382)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h    2019-03-04 21:17:36 UTC (rev 242381)
+++ trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h       2019-03-04 21:20:14 UTC (rev 242382)
</span><span class="lines">@@ -56,6 +56,7 @@
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL globalFuncBuiltinDescribe(ExecState*);
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL globalFuncImportModule(ExecState*);
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL globalFuncPropertyIsEnumerable(ExecState*);
</span><ins>+EncodedJSValue JSC_HOST_CALL globalFuncOwnKeys(ExecState*);
</ins><span class="cx"> EncodedJSValue JSC_HOST_CALL globalFuncDateTimeFormat(ExecState*);
</span><span class="cx"> 
</span><span class="cx"> double jsToNumber(StringView);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeReflectObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp (242381 => 242382)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp    2019-03-04 21:17:36 UTC (rev 242381)
+++ trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp       2019-03-04 21:20:14 UTC (rev 242382)
</span><span class="lines">@@ -78,13 +78,10 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void ReflectObject::finishCreation(VM& vm, JSGlobalObject* globalObject)
</del><ins>+void ReflectObject::finishCreation(VM& vm, JSGlobalObject*)
</ins><span class="cx"> {
</span><span class="cx">     Base::finishCreation(vm);
</span><span class="cx">     ASSERT(inherits(vm, info()));
</span><del>-
-    JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->builtinNames().ownKeysPrivateName(), reflectObjectOwnKeys, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly, 1);
-    JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->builtinNames().getOwnPropertyDescriptorPrivateName(), reflectObjectGetOwnPropertyDescriptor, PropertyAttribute::DontEnum | PropertyAttribute::DontDelete | PropertyAttribute::ReadOnly, 2);
</del><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> // ------------------------------ Functions --------------------------------
</span></span></pre>
</div>
</div>

</body>
</html>