<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[238169] trunk/Source/WebInspectorUI</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/238169">238169</a></dd>
<dt>Author</dt> <dd>drousso@apple.com</dd>
<dt>Date</dt> <dd>2018-11-14 04:01:31 -0800 (Wed, 14 Nov 2018)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: Canvas: don't start with auto-capture enabled
https://bugs.webkit.org/show_bug.cgi?id=191553

Reviewed by Matt Baker.

* UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount):
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize):
(WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureInput):
* UserInterface/Views/CanvasOverviewContentView.css:
(.navigation-bar > .item.canvas-recording-auto-capture > label > input):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCanvasOverviewContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCanvasOverviewContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (238168 => 238169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog    2018-11-14 09:26:23 UTC (rev 238168)
+++ trunk/Source/WebInspectorUI/ChangeLog       2018-11-14 12:01:31 UTC (rev 238169)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2018-11-14  Devin Rousso  <drousso@apple.com>
</span><span class="cx"> 
</span><ins>+        Web Inspector: Canvas: don't start with auto-capture enabled
+        https://bugs.webkit.org/show_bug.cgi?id=191553
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/CanvasOverviewContentView.js:
+        (WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount):
+        (WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize):
+        (WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureInput):
+        * UserInterface/Views/CanvasOverviewContentView.css:
+        (.navigation-bar > .item.canvas-recording-auto-capture > label > input):
+
+2018-11-14  Devin Rousso  <drousso@apple.com>
+
</ins><span class="cx">         Web Inspector: Network Graphs are missing minimum sizes, might have no graph at all
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=191208
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsCanvasOverviewContentViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css (238168 => 238169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css    2018-11-14 09:26:23 UTC (rev 238168)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css       2018-11-14 12:01:31 UTC (rev 238169)
</span><span class="lines">@@ -181,8 +181,10 @@
</span><span class="cx"> .navigation-bar > .item.canvas-recording-auto-capture > label > input {
</span><span class="cx">     width: 1.5em;
</span><span class="cx">     min-width: 1.5em;
</span><del>-    margin: 0 4px;
</del><ins>+    margin: 0 var(--recording-auto-capture-input-margin); 
</ins><span class="cx">     text-align: center;
</span><ins>+
+    --recording-auto-capture-input-margin: 4px; /* Keep this in sync with `recordingAutoCaptureInputMargin`. */
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> .navigation-bar > .item.canvas-recording-auto-capture > label > input::-webkit-inner-spin-button {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsCanvasOverviewContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js (238168 => 238169)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js     2018-11-14 09:26:23 UTC (rev 238168)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js        2018-11-14 12:01:31 UTC (rev 238169)
</span><span class="lines">@@ -202,8 +202,11 @@
</span><span class="cx">         let frameCount = parseInt(this._recordingAutoCaptureFrameCountInputElement.value);
</span><span class="cx">         console.assert(!isNaN(frameCount) && frameCount >= 0);
</span><span class="cx"> 
</span><del>-        let enabled = frameCount && !!this._recordingAutoCaptureNavigationItem.checked;
</del><ins>+        if (this._recordingAutoCaptureNavigationItem.checked)
+            frameCount = Math.max(1, frameCount);
</ins><span class="cx"> 
</span><ins>+        let enabled = frameCount > 0 && !!this._recordingAutoCaptureNavigationItem.checked;
+
</ins><span class="cx">         WI.canvasManager.setRecordingAutoCaptureFrameCount(enabled, frameCount);
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="lines">@@ -221,17 +224,21 @@
</span><span class="cx">                 this._recordingAutoCaptureFrameCountInputElement.__cachedFont = computedStyle.font;
</span><span class="cx">             }
</span><span class="cx"> 
</span><ins>+            const recordingAutoCaptureInputMargin = 8; // Keep this in sync with `--recording-auto-capture-input-margin`.
+
</ins><span class="cx">             context.font = this._recordingAutoCaptureFrameCountInputElement.__cachedFont;
</span><span class="cx">             let textMetrics = context.measureText(this._recordingAutoCaptureFrameCountInputElement.value);
</span><del>-            this._recordingAutoCaptureFrameCountInputElement.style.setProperty("width", (textMetrics.width + 8) + "px");
</del><ins>+            this._recordingAutoCaptureFrameCountInputElement.style.setProperty("width", (textMetrics.width + recordingAutoCaptureInputMargin) + "px");
</ins><span class="cx">         });
</span><span class="cx"> 
</span><del>-        this._recordingAutoCaptureNavigationItem.checked = !!frameCount;
</del><ins>+        return frameCount;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     _handleRecordingAutoCaptureInput(event)
</span><span class="cx">     {
</span><del>-        this._updateRecordingAutoCaptureInputElementSize();
</del><ins>+        let frameCount = this._updateRecordingAutoCaptureInputElementSize();
+        this._recordingAutoCaptureNavigationItem.checked = !!frameCount;
+
</ins><span class="cx">         this._setRecordingAutoCaptureFrameCount();
</span><span class="cx">     }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>