<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[237380] trunk/Source/WebKit</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/237380">237380</a></dd>
<dt>Author</dt> <dd>csaavedra@igalia.com</dd>
<dt>Date</dt> <dd>2018-10-24 06:45:26 -0700 (Wed, 24 Oct 2018)</dd>
</dl>

<h3>Log Message</h3>
<pre>[WPE][GTK] Cleanups to the certificate decoder
https://bugs.webkit.org/show_bug.cgi?id=190867

Reviewed by Žan Doberšek.

* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<CertificateInfo>::decode):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitSharedsoupWebCoreArgumentCodersSoupcpp">trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (237379 => 237380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2018-10-24 10:20:34 UTC (rev 237379)
+++ trunk/Source/WebKit/ChangeLog       2018-10-24 13:45:26 UTC (rev 237380)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
</span><span class="cx"> 
</span><ins>+        [WPE][GTK] Cleanups to the certificate decoder
+        https://bugs.webkit.org/show_bug.cgi?id=190867
+
+        Reviewed by Žan Doberšek.
+
+        * Shared/soup/WebCoreArgumentCodersSoup.cpp:
+        (IPC::ArgumentCoder<CertificateInfo>::decode):
+
+2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
+
</ins><span class="cx">         [WPE][GTK] Cleanups to the certificate encoder
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=190865
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitSharedsoupWebCoreArgumentCodersSoupcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp (237379 => 237380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp    2018-10-24 10:20:34 UTC (rev 237379)
+++ trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp       2018-10-24 13:45:26 UTC (rev 237380)
</span><span class="lines">@@ -93,8 +93,7 @@
</span><span class="cx">     if (!chainLength)
</span><span class="cx">         return true;
</span><span class="cx"> 
</span><del>-    GTlsCertificate* issuer = nullptr;
-    GTlsBackend* backend = g_tls_backend_get_default();
</del><ins>+    GType certificateType = g_tls_backend_get_certificate_type(g_tls_backend_get_default());
</ins><span class="cx">     GRefPtr<GTlsCertificate> certificate;
</span><span class="cx">     for (uint32_t i = 0; i < chainLength; i++) {
</span><span class="cx">         IPC::DataReference certificateDataReference;
</span><span class="lines">@@ -101,14 +100,11 @@
</span><span class="cx">         if (!decoder.decodeVariableLengthByteArray(certificateDataReference))
</span><span class="cx">             return false;
</span><span class="cx"> 
</span><del>-        GByteArray* certificateData = g_byte_array_sized_new(certificateDataReference.size());
-        certificateData = g_byte_array_append(certificateData, certificateDataReference.data(), certificateDataReference.size());
-        GRefPtr<GByteArray> certificateBytes = adoptGRef(certificateData);
</del><ins>+        GRefPtr<GByteArray> certificateData = g_byte_array_sized_new(certificateDataReference.size());
+        certificateData = g_byte_array_append(certificateData.get(), certificateDataReference.data(), certificateDataReference.size());
</ins><span class="cx"> 
</span><span class="cx">         certificate = adoptGRef(G_TLS_CERTIFICATE(g_initable_new(
</span><del>-            g_tls_backend_get_certificate_type(backend), 0, 0, "certificate", certificateBytes.get(), "issuer", issuer, nullptr)));
-
-        issuer = certificate.get();
</del><ins>+            certificateType, nullptr, nullptr, "certificate", certificateData.get(), "issuer", certificate.get(), nullptr)));
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     uint32_t tlsErrors;
</span></span></pre>
</div>
</div>

</body>
</html>