<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[235652] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/235652">235652</a></dd>
<dt>Author</dt> <dd>emilio@crisal.io</dd>
<dt>Date</dt> <dd>2018-09-04 18:22:55 -0700 (Tue, 04 Sep 2018)</dd>
</dl>

<h3>Log Message</h3>
<pre>Remove PseudoElementUserAgentCustom.
https://bugs.webkit.org/show_bug.cgi?id=189089

Reviewed by Ryosuke Niwa.

Tests at https://github.com/web-platform-tests/wpt/pull/12743.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoElementType):
* css/CSSSelector.h:
(WebCore::CSSSelector::isCustomPseudoElement const):
* css/RuleSet.cpp:
(WebCore::RuleSet::addRule):
* css/parser/CSSParserSelector.h:
(WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSSelectorcpp">trunk/Source/WebCore/css/CSSSelector.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSSelectorh">trunk/Source/WebCore/css/CSSSelector.h</a></li>
<li><a href="#trunkSourceWebCorecssRuleSetcpp">trunk/Source/WebCore/css/RuleSet.cpp</a></li>
<li><a href="#trunkSourceWebCorecssparserCSSParserSelectorh">trunk/Source/WebCore/css/parser/CSSParserSelector.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (235651 => 235652)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/ChangeLog      2018-09-05 01:22:55 UTC (rev 235652)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2018-08-29  Emilio Cobos Ãlvarez  <emilio@crisal.io>
+
+        Remove PseudoElementUserAgentCustom.
+        https://bugs.webkit.org/show_bug.cgi?id=189089
+
+        Reviewed by Ryosuke Niwa.
+
+        Tests at https://github.com/web-platform-tests/wpt/pull/12743.
+
+        * css/CSSSelector.cpp:
+        (WebCore::CSSSelector::pseudoId):
+        (WebCore::CSSSelector::parsePseudoElementType):
+        * css/CSSSelector.h:
+        (WebCore::CSSSelector::isCustomPseudoElement const):
+        * css/RuleSet.cpp:
+        (WebCore::RuleSet::addRule):
+        * css/parser/CSSParserSelector.h:
+        (WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):
+
</ins><span class="cx"> 2018-09-04  Dean Jackson  <dino@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Post review Weinig fix-ups
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSSelectorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSSelector.cpp (235651 => 235652)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSSelector.cpp 2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/css/CSSSelector.cpp    2018-09-05 01:22:55 UTC (rev 235652)
</span><span class="lines">@@ -299,7 +299,6 @@
</span><span class="cx"> #endif
</span><span class="cx">     case PseudoElementSlotted:
</span><span class="cx">     case PseudoElementUnknown:
</span><del>-    case PseudoElementUserAgentCustom:
</del><span class="cx">     case PseudoElementWebKitCustom:
</span><span class="cx">     case PseudoElementWebKitCustomLegacyPrefixed:
</span><span class="cx">         return PseudoId::None;
</span><span class="lines">@@ -318,9 +317,6 @@
</span><span class="cx">     if (type == PseudoElementUnknown) {
</span><span class="cx">         if (name.startsWith("-webkit-"))
</span><span class="cx">             type = PseudoElementWebKitCustom;
</span><del>-
-        if (name.startsWith("x-"))
-            type = PseudoElementUserAgentCustom;
</del><span class="cx">     }
</span><span class="cx">     return type;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSSelectorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSSelector.h (235651 => 235652)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSSelector.h   2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/css/CSSSelector.h      2018-09-05 01:22:55 UTC (rev 235652)
</span><span class="lines">@@ -183,7 +183,6 @@
</span><span class="cx">             PseudoElementScrollbarTrackPiece,
</span><span class="cx">             PseudoElementSelection,
</span><span class="cx">             PseudoElementSlotted,
</span><del>-            PseudoElementUserAgentCustom,
</del><span class="cx">             PseudoElementWebKitCustom,
</span><span class="cx"> 
</span><span class="cx">             // WebKitCustom that appeared in an old prefixed form
</span><span class="lines">@@ -411,8 +410,7 @@
</span><span class="cx"> inline bool CSSSelector::isCustomPseudoElement() const
</span><span class="cx"> {
</span><span class="cx">     return match() == PseudoElement
</span><del>-        && (pseudoElementType() == PseudoElementUserAgentCustom
-            || pseudoElementType() == PseudoElementWebKitCustom
</del><ins>+        && (pseudoElementType() == PseudoElementWebKitCustom
</ins><span class="cx">             || pseudoElementType() == PseudoElementWebKitCustomLegacyPrefixed);
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorecssRuleSetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/RuleSet.cpp (235651 => 235652)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/RuleSet.cpp     2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/css/RuleSet.cpp        2018-09-05 01:22:55 UTC (rev 235652)
</span><span class="lines">@@ -242,7 +242,6 @@
</span><span class="cx">             break;
</span><span class="cx">         case CSSSelector::PseudoElement:
</span><span class="cx">             switch (selector->pseudoElementType()) {
</span><del>-            case CSSSelector::PseudoElementUserAgentCustom:
</del><span class="cx">             case CSSSelector::PseudoElementWebKitCustom:
</span><span class="cx">             case CSSSelector::PseudoElementWebKitCustomLegacyPrefixed:
</span><span class="cx">                 customPseudoElementSelector = selector;
</span></span></pre></div>
<a id="trunkSourceWebCorecssparserCSSParserSelectorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/parser/CSSParserSelector.h (235651 => 235652)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/parser/CSSParserSelector.h      2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/css/parser/CSSParserSelector.h 2018-09-05 01:22:55 UTC (rev 235652)
</span><span class="lines">@@ -117,7 +117,6 @@
</span><span class="cx"> {
</span><span class="cx">     return match() == CSSSelector::PseudoElement
</span><span class="cx">         && (pseudoElementType() == CSSSelector::PseudoElementWebKitCustom
</span><del>-            || pseudoElementType() == CSSSelector::PseudoElementUserAgentCustom
</del><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><span class="cx">             || pseudoElementType() == CSSSelector::PseudoElementCue
</span><span class="cx"> #endif
</span></span></pre>
</div>
</div>

</body>
</html>