<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[235148] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/235148">235148</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2018-08-21 16:59:03 -0700 (Tue, 21 Aug 2018)</dd>
</dl>

<h3>Log Message</h3>
<pre>Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
https://bugs.webkit.org/show_bug.cgi?id=188821

Reviewed by Simon Fraser.

Source/WebKit:

Add some more values to WKPageRenderingProgressEvents which were already supported by _WKRenderingProgressEvents and WKLayoutMilestones.

* UIProcess/API/C/WKPageRenderingProgressEvents.h:
* UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:
(pageRenderingProgressEvents):

Tools:

* TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKitChangeLog">trunk/Source/WebKit/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitUIProcessAPICWKPageRenderingProgressEventsh">trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h</a></li>
<li><a href="#trunkSourceWebKitUIProcessAPICWKPageRenderingProgressEventsInternalh">trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWebKitResizeReversePaginatedWebViewcpp">trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/ChangeLog (235147 => 235148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/ChangeLog    2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Source/WebKit/ChangeLog       2018-08-21 23:59:03 UTC (rev 235148)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2018-08-21  Alex Christensen  <achristensen@webkit.org>
</span><span class="cx"> 
</span><ins>+        Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
+        https://bugs.webkit.org/show_bug.cgi?id=188821
+
+        Reviewed by Simon Fraser.
+
+        Add some more values to WKPageRenderingProgressEvents which were already supported by _WKRenderingProgressEvents and WKLayoutMilestones.
+
+        * UIProcess/API/C/WKPageRenderingProgressEvents.h:
+        * UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:
+        (pageRenderingProgressEvents):
+
+2018-08-21  Alex Christensen  <achristensen@webkit.org>
+
</ins><span class="cx">         Fix API tests after r235139
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=188805
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessAPICWKPageRenderingProgressEventsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h (235147 => 235148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h      2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h 2018-08-21 23:59:03 UTC (rev 235148)
</span><span class="lines">@@ -36,7 +36,9 @@
</span><span class="cx">     WKPageRenderingProgressEventFirstLayout = 1 << 0,
</span><span class="cx">     WKPageRenderingProgressEventFirstVisuallyNonEmptyLayout = 1 << 1,
</span><span class="cx">     WKPageRenderingProgressEventFirstPaintWithSignificantArea = 1 << 2,
</span><del>-    WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold = 1 << 3
</del><ins>+    WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold = 1 << 3,
+    WKPageRenderingProgressEventFirstLayoutAfterSuppressedIncrementalRendering = 1 << 4,
+    WKPageRenderingProgressEventFirstPaintAfterSuppressedIncrementalRendering = 1 << 5,
</ins><span class="cx"> };
</span><span class="cx"> typedef uint32_t WKPageRenderingProgressEvents;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKitUIProcessAPICWKPageRenderingProgressEventsInternalh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h (235147 => 235148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h      2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h 2018-08-21 23:59:03 UTC (rev 235148)
</span><span class="lines">@@ -43,5 +43,11 @@
</span><span class="cx">     if (milestones & WebCore::ReachedSessionRestorationRenderTreeSizeThreshold)
</span><span class="cx">         events |= WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold;
</span><span class="cx">     
</span><ins>+    if (milestones & WebCore::DidFirstLayoutAfterSuppressedIncrementalRendering)
+        events |= WKPageRenderingProgressEventFirstLayoutAfterSuppressedIncrementalRendering;
+
+    if (milestones & WebCore::DidFirstPaintAfterSuppressedIncrementalRendering)
+        events |= WKPageRenderingProgressEventFirstPaintAfterSuppressedIncrementalRendering;
+
</ins><span class="cx">     return events;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (235147 => 235148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Tools/ChangeLog       2018-08-21 23:59:03 UTC (rev 235148)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2018-08-21  Alex Christensen  <achristensen@webkit.org>
+
+        Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
+        https://bugs.webkit.org/show_bug.cgi?id=188821
+
+        Reviewed by Simon Fraser.
+
+        * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
+        (TestWebKitAPI::didLayout):
+        (TestWebKitAPI::TEST):
+
</ins><span class="cx"> 2018-08-21  Myles C. Maxfield  <mmaxfield@apple.com>
</span><span class="cx"> 
</span><span class="cx">         [WHLSL] Call expressions shouldn't have type arguments
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWebKitResizeReversePaginatedWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp (235147 => 235148)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp 2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp    2018-08-21 23:59:03 UTC (rev 235148)
</span><span class="lines">@@ -44,7 +44,7 @@
</span><span class="cx"> static const unsigned pageGap = 100;
</span><span class="cx"> static const unsigned expectedPageCount = 20;
</span><span class="cx"> 
</span><del>-static void didLayout(WKPageRef page, WKLayoutMilestones milestones, WKTypeRef, const void* clientInfo)
</del><ins>+static void didLayout(WKPageRef page, WKPageRenderingProgressEvents milestones, WKTypeRef, const void* clientInfo)
</ins><span class="cx"> {
</span><span class="cx">     if (milestones & kWKDidFirstLayoutAfterSuppressedIncrementalRendering) {
</span><span class="cx">         PlatformWebView* webView = (PlatformWebView*)clientInfo;
</span><span class="lines">@@ -64,14 +64,14 @@
</span><span class="cx">     WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());
</span><span class="cx">     PlatformWebView webView(context.get());
</span><span class="cx"> 
</span><del>-    WKPageLoaderClientV3 loaderClient;
</del><ins>+    WKPageNavigationClientV3 loaderClient;
</ins><span class="cx">     memset(&loaderClient, 0, sizeof(loaderClient));
</span><span class="cx"> 
</span><span class="cx">     loaderClient.base.version = 3;
</span><span class="cx">     loaderClient.base.clientInfo = &webView;
</span><del>-    loaderClient.didLayout = didLayout;
</del><ins>+    loaderClient.renderingProgressDidChange = didLayout;
</ins><span class="cx"> 
</span><del>-    WKPageSetPageLoaderClient(webView.page(), &loaderClient.base);
</del><ins>+    WKPageSetPageNavigationClient(webView.page(), &loaderClient.base);
</ins><span class="cx"> 
</span><span class="cx">     WKPageListenForLayoutMilestones(webView.page(), kWKDidFirstLayoutAfterSuppressedIncrementalRendering);
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>