<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[234854] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/234854">234854</a></dd>
<dt>Author</dt> <dd>yusukesuzuki@slowstart.org</dd>
<dt>Date</dt> <dd>2018-08-14 10:45:09 -0700 (Tue, 14 Aug 2018)</dd>
</dl>

<h3>Log Message</h3>
<pre>Unreviewed, follow-up patch for comments
https://bugs.webkit.org/show_bug.cgi?id=188265

* bindings/js/JSExecState.cpp:
(WebCore::JSExecState::didLeaveScriptContext):
Do nothing if `context` is nullptr. It is OK since we do not need to drain microtasks / rejected
promise events after ScriptExecutionContext is gone.

* dom/Microtasks.cpp:
(WebCore::MicrotaskQueue::contextQueue):
Drop unnecessary assertion since it is subsumed by downcast<>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSExecStatecpp">trunk/Source/WebCore/bindings/js/JSExecState.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMicrotaskscpp">trunk/Source/WebCore/dom/Microtasks.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (234853 => 234854)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2018-08-14 17:23:50 UTC (rev 234853)
+++ trunk/Source/WebCore/ChangeLog      2018-08-14 17:45:09 UTC (rev 234854)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2018-08-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
+
+        Unreviewed, follow-up patch for comments
+        https://bugs.webkit.org/show_bug.cgi?id=188265
+
+        * bindings/js/JSExecState.cpp:
+        (WebCore::JSExecState::didLeaveScriptContext):
+        Do nothing if `context` is nullptr. It is OK since we do not need to drain microtasks / rejected
+        promise events after ScriptExecutionContext is gone.
+
+        * dom/Microtasks.cpp:
+        (WebCore::MicrotaskQueue::contextQueue):
+        Drop unnecessary assertion since it is subsumed by downcast<>.
+
</ins><span class="cx"> 2018-08-14  Ali Juma  <ajuma@chromium.org>
</span><span class="cx"> 
</span><span class="cx">         Follow-up: [IntersectionObserver] Implement rootMargin parsing
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSExecStatecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSExecState.cpp (234853 => 234854)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSExecState.cpp 2018-08-14 17:23:50 UTC (rev 234853)
+++ trunk/Source/WebCore/bindings/js/JSExecState.cpp    2018-08-14 17:45:09 UTC (rev 234854)
</span><span class="lines">@@ -37,6 +37,8 @@
</span><span class="cx"> void JSExecState::didLeaveScriptContext(JSC::ExecState* exec)
</span><span class="cx"> {
</span><span class="cx">     ScriptExecutionContext* context = scriptExecutionContextFromExecState(exec);
</span><ins>+    if (!context)
+        return;
</ins><span class="cx">     MicrotaskQueue::contextQueue(*context).performMicrotaskCheckpoint();
</span><span class="cx">     context->ensureRejectedPromiseTracker().processQueueSoon();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomMicrotaskscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Microtasks.cpp (234853 => 234854)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Microtasks.cpp  2018-08-14 17:23:50 UTC (rev 234853)
+++ trunk/Source/WebCore/dom/Microtasks.cpp     2018-08-14 17:45:09 UTC (rev 234854)
</span><span class="lines">@@ -55,7 +55,6 @@
</span><span class="cx">     // WorkerGlobalScope.
</span><span class="cx">     if (isMainThread())
</span><span class="cx">         return mainThreadQueue();
</span><del>-    ASSERT(context.isWorkerGlobalScope());
</del><span class="cx">     return downcast<WorkerGlobalScope>(context).microtaskQueue();
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>