<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[230856] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/230856">230856</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2018-04-20 14:10:56 -0700 (Fri, 20 Apr 2018)</dd>
</dl>

<h3>Log Message</h3>
<pre>Remove code for compilers that did not support NSDMI for aggregates
https://bugs.webkit.org/show_bug.cgi?id=184599

Reviewed by Per Arne Vollan.

Remove workaround for earlier Visual Studio versions that did not support non-static data
member initializers (NSDMI) for aggregates. We have since updated all the build.webkit.org
and EWS bots to a newer version that supports this feature.

Source/bmalloc:

* bmalloc/BPlatform.h:
* bmalloc/List.h:
(bmalloc::ListNode::ListNode): Deleted.
(bmalloc::List::iterator::iterator): Deleted.

Source/JavaScriptCore:

* domjit/DOMJITEffect.h:
(JSC::DOMJIT::Effect::Effect): Deleted.
* runtime/HasOwnPropertyCache.h:
(JSC::HasOwnPropertyCache::Entry::Entry): Deleted.
* wasm/WasmFormat.h:
(JSC::Wasm::WasmToWasmImportableFunction::WasmToWasmImportableFunction): Deleted.

Source/WebCore:

* Modules/cache/CacheQueryOptions.h:
(WebCore::CacheQueryOptions::CacheQueryOptions): Deleted.
* dom/Node.h:
(WebCore::Node::InsertionType::InsertionType): Deleted.
(WebCore::Node::RemovalType::RemovalType): Deleted.
* html/canvas/CanvasStyle.h:
(WebCore::CanvasStyle::CMYKAColor::CMYKAColor): Deleted.
* page/EventHandler.h:
(WebCore::EventHandler::DragTargetResponse::DragTargetResponse): Deleted.
* page/animation/CSSAnimationController.h:
(WebCore::AnimationUpdate::AnimationUpdate): Deleted.
* platform/graphics/FontSelectionAlgorithm.h:
(WebCore::FontSelectionRequest::tied const):
(WebCore::FontSelectionRequest::FontSelectionRequest): Deleted.
(WebCore::FontSelectionCapabilities::FontSelectionCapabilities): Deleted.
* platform/mediastream/IceCandidate.h:
(WebCore::IceCandidate::IceCandidate): Deleted.
* platform/text/StringWithDirection.h:
(WebCore::StringWithDirection::StringWithDirection): Deleted.
* rendering/MarkedText.h:
(WebCore::MarkedText::MarkedText): Deleted.
* style/StyleUpdate.h:
(WebCore::Style::ElementUpdate::ElementUpdate): Deleted.
(WebCore::Style::ElementUpdates::ElementUpdates): Deleted.
(WebCore::Style::TextUpdate::TextUpdate): Deleted.

Source/WTF:

* wtf/Compiler.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoredomjitDOMJITEffecth">trunk/Source/JavaScriptCore/domjit/DOMJITEffect.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeHasOwnPropertyCacheh">trunk/Source/JavaScriptCore/runtime/HasOwnPropertyCache.h</a></li>
<li><a href="#trunkSourceJavaScriptCorewasmWasmFormath">trunk/Source/JavaScriptCore/wasm/WasmFormat.h</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfCompilerh">trunk/Source/WTF/wtf/Compiler.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulescacheCacheQueryOptionsh">trunk/Source/WebCore/Modules/cache/CacheQueryOptions.h</a></li>
<li><a href="#trunkSourceWebCoredomNodeh">trunk/Source/WebCore/dom/Node.h</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasCanvasStyleh">trunk/Source/WebCore/html/canvas/CanvasStyle.h</a></li>
<li><a href="#trunkSourceWebCorepageEventHandlerh">trunk/Source/WebCore/page/EventHandler.h</a></li>
<li><a href="#trunkSourceWebCorepageanimationCSSAnimationControllerh">trunk/Source/WebCore/page/animation/CSSAnimationController.h</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsFontSelectionAlgorithmh">trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h</a></li>
<li><a href="#trunkSourceWebCoreplatformmediastreamIceCandidateh">trunk/Source/WebCore/platform/mediastream/IceCandidate.h</a></li>
<li><a href="#trunkSourceWebCoreplatformtextStringWithDirectionh">trunk/Source/WebCore/platform/text/StringWithDirection.h</a></li>
<li><a href="#trunkSourceWebCorerenderingMarkedTexth">trunk/Source/WebCore/rendering/MarkedText.h</a></li>
<li><a href="#trunkSourceWebCorestyleStyleUpdateh">trunk/Source/WebCore/style/StyleUpdate.h</a></li>
<li><a href="#trunkSourcebmallocChangeLog">trunk/Source/bmalloc/ChangeLog</a></li>
<li><a href="#trunkSourcebmallocbmallocBPlatformh">trunk/Source/bmalloc/bmalloc/BPlatform.h</a></li>
<li><a href="#trunkSourcebmallocbmallocListh">trunk/Source/bmalloc/bmalloc/List.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/JavaScriptCore/ChangeLog       2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2018-04-20  Daniel Bates  <dabates@apple.com>
+
+        Remove code for compilers that did not support NSDMI for aggregates
+        https://bugs.webkit.org/show_bug.cgi?id=184599
+
+        Reviewed by Per Arne Vollan.
+
+        Remove workaround for earlier Visual Studio versions that did not support non-static data
+        member initializers (NSDMI) for aggregates. We have since updated all the build.webkit.org
+        and EWS bots to a newer version that supports this feature.
+
+        * domjit/DOMJITEffect.h:
+        (JSC::DOMJIT::Effect::Effect): Deleted.
+        * runtime/HasOwnPropertyCache.h:
+        (JSC::HasOwnPropertyCache::Entry::Entry): Deleted.
+        * wasm/WasmFormat.h:
+        (JSC::Wasm::WasmToWasmImportableFunction::WasmToWasmImportableFunction): Deleted.
+
</ins><span class="cx"> 2018-04-20  Mark Lam  <mark.lam@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Build fix for internal builds after r230826.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoredomjitDOMJITEffecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/domjit/DOMJITEffect.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/domjit/DOMJITEffect.h        2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/JavaScriptCore/domjit/DOMJITEffect.h   2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -30,20 +30,6 @@
</span><span class="cx"> namespace JSC { namespace DOMJIT {
</span><span class="cx"> 
</span><span class="cx"> struct Effect {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    constexpr Effect() = default;
-    constexpr Effect(HeapRange reads, HeapRange writes)
-        : reads { reads }
-        , writes { writes }
-    {
-    }
-    constexpr Effect(HeapRange reads, HeapRange writes, HeapRange def)
-        : reads { reads }
-        , writes { writes }
-        , def { def }
-    {
-    }
-#endif
</del><span class="cx"> 
</span><span class="cx">     constexpr static Effect forWrite(HeapRange writeRange)
</span><span class="cx">     {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeHasOwnPropertyCacheh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/HasOwnPropertyCache.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/HasOwnPropertyCache.h        2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/JavaScriptCore/runtime/HasOwnPropertyCache.h   2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -42,18 +42,6 @@
</span><span class="cx">         static ptrdiff_t offsetOfImpl() { return OBJECT_OFFSETOF(Entry, impl); }
</span><span class="cx">         static ptrdiff_t offsetOfResult() { return OBJECT_OFFSETOF(Entry, result); }
</span><span class="cx"> 
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-        Entry() = default;
-        Entry(RefPtr<UniquedStringImpl>&& impl, StructureID structureID, bool result)
-            : impl { WTFMove(impl) }
-            , structureID { structureID }
-            , result { result }
-        {
-        }
-
-        Entry& operator=(Entry&& other) = default;
-#endif
-
</del><span class="cx">         RefPtr<UniquedStringImpl> impl;
</span><span class="cx">         StructureID structureID { 0 };
</span><span class="cx">         bool result { false };
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorewasmWasmFormath"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/wasm/WasmFormat.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/wasm/WasmFormat.h    2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/JavaScriptCore/wasm/WasmFormat.h       2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -275,15 +275,6 @@
</span><span class="cx"> // meant as fast lookup tables for these opcodes and do not own code.
</span><span class="cx"> struct WasmToWasmImportableFunction {
</span><span class="cx">     using LoadLocation = MacroAssemblerCodePtr<WasmEntryPtrTag>*;
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    WasmToWasmImportableFunction() = default;
-    WasmToWasmImportableFunction(SignatureIndex signatureIndex, LoadLocation entrypointLoadLocation)
-        : signatureIndex { signatureIndex }
-        , entrypointLoadLocation { entrypointLoadLocation }
-    {
-    }
-#endif
-
</del><span class="cx">     static ptrdiff_t offsetOfEntrypointLoadLocation() { return OBJECT_OFFSETOF(WasmToWasmImportableFunction, entrypointLoadLocation); }
</span><span class="cx"> 
</span><span class="cx">     // FIXME: Pack signature index and code pointer into one 64-bit value. See <https://bugs.webkit.org/show_bug.cgi?id=165511>.
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog       2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WTF/ChangeLog  2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2018-04-20  Daniel Bates  <dabates@apple.com>
+
+        Remove code for compilers that did not support NSDMI for aggregates
+        https://bugs.webkit.org/show_bug.cgi?id=184599
+
+        Reviewed by Per Arne Vollan.
+
+        Remove workaround for earlier Visual Studio versions that did not support non-static data
+        member initializers (NSDMI) for aggregates. We have since updated all the build.webkit.org
+        and EWS bots to a newer version that supports this feature.
+
+        * wtf/Compiler.h:
+
</ins><span class="cx"> 2018-04-19  David Kilzer  <ddkilzer@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Enable Objective-C weak references
</span></span></pre></div>
<a id="trunkSourceWTFwtfCompilerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Compiler.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Compiler.h  2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WTF/wtf/Compiler.h     2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -145,12 +145,8 @@
</span><span class="cx"> #define WTF_COMPILER_SUPPORTS_EABI 1
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-/* Non-static data member initializer (NSDMI) for aggregates */
</del><ins>+/* ASAN_ENABLED and SUPPRESS_ASAN */
</ins><span class="cx"> 
</span><del>-#if defined(__cpp_aggregate_nsdmi) && __cpp_aggregate_nsdmi >= 201304
-#define WTF_COMPILER_SUPPORTS_NSDMI_FOR_AGGREGATES 1
-#endif
-
</del><span class="cx"> #define ASAN_ENABLED COMPILER_HAS_CLANG_FEATURE(address_sanitizer)
</span><span class="cx"> 
</span><span class="cx"> #if ASAN_ENABLED
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/ChangeLog      2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -1,3 +1,40 @@
</span><ins>+2018-04-20  Daniel Bates  <dabates@apple.com>
+
+        Remove code for compilers that did not support NSDMI for aggregates
+        https://bugs.webkit.org/show_bug.cgi?id=184599
+
+        Reviewed by Per Arne Vollan.
+
+        Remove workaround for earlier Visual Studio versions that did not support non-static data
+        member initializers (NSDMI) for aggregates. We have since updated all the build.webkit.org
+        and EWS bots to a newer version that supports this feature.
+
+        * Modules/cache/CacheQueryOptions.h:
+        (WebCore::CacheQueryOptions::CacheQueryOptions): Deleted.
+        * dom/Node.h:
+        (WebCore::Node::InsertionType::InsertionType): Deleted.
+        (WebCore::Node::RemovalType::RemovalType): Deleted.
+        * html/canvas/CanvasStyle.h:
+        (WebCore::CanvasStyle::CMYKAColor::CMYKAColor): Deleted.
+        * page/EventHandler.h:
+        (WebCore::EventHandler::DragTargetResponse::DragTargetResponse): Deleted.
+        * page/animation/CSSAnimationController.h:
+        (WebCore::AnimationUpdate::AnimationUpdate): Deleted.
+        * platform/graphics/FontSelectionAlgorithm.h:
+        (WebCore::FontSelectionRequest::tied const):
+        (WebCore::FontSelectionRequest::FontSelectionRequest): Deleted.
+        (WebCore::FontSelectionCapabilities::FontSelectionCapabilities): Deleted.
+        * platform/mediastream/IceCandidate.h:
+        (WebCore::IceCandidate::IceCandidate): Deleted.
+        * platform/text/StringWithDirection.h:
+        (WebCore::StringWithDirection::StringWithDirection): Deleted.
+        * rendering/MarkedText.h:
+        (WebCore::MarkedText::MarkedText): Deleted.
+        * style/StyleUpdate.h:
+        (WebCore::Style::ElementUpdate::ElementUpdate): Deleted.
+        (WebCore::Style::ElementUpdates::ElementUpdates): Deleted.
+        (WebCore::Style::TextUpdate::TextUpdate): Deleted.
+
</ins><span class="cx"> 2018-04-20  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
</span></span></pre></div>
<a id="trunkSourceWebCoreModulescacheCacheQueryOptionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/cache/CacheQueryOptions.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/cache/CacheQueryOptions.h   2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/Modules/cache/CacheQueryOptions.h      2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -30,16 +30,6 @@
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><span class="cx"> struct CacheQueryOptions {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    CacheQueryOptions() = default;
-    CacheQueryOptions(bool ignoreSearch, bool ignoreMethod, bool ignoreVary, String&& cacheName)
-        : ignoreSearch { ignoreSearch }
-        , ignoreMethod { ignoreMethod }
-        , ignoreVary { ignoreVary }
-        , cacheName { WTFMove(cacheName) }
-    {
-    }
-#endif
</del><span class="cx">     CacheQueryOptions isolatedCopy() const { return { ignoreSearch, ignoreMethod, ignoreVary, cacheName.isolatedCopy() }; }
</span><span class="cx"> 
</span><span class="cx">     bool ignoreSearch { false };
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.h  2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/dom/Node.h     2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -440,12 +440,6 @@
</span><span class="cx">     };
</span><span class="cx"> 
</span><span class="cx">     struct InsertionType {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-        InsertionType(bool connectedToDocument, bool treeScopeChanged)
-            : connectedToDocument(connectedToDocument)
-            , treeScopeChanged(treeScopeChanged)
-        { }
-#endif
</del><span class="cx">         bool connectedToDocument { false };
</span><span class="cx">         bool treeScopeChanged { false };
</span><span class="cx">     };
</span><span class="lines">@@ -455,12 +449,6 @@
</span><span class="cx">     virtual void didFinishInsertingNode() { }
</span><span class="cx"> 
</span><span class="cx">     struct RemovalType {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-        RemovalType(bool disconnectedFromDocument, bool treeScopeChanged)
-            : disconnectedFromDocument(disconnectedFromDocument)
-            , treeScopeChanged(treeScopeChanged)
-        { }
-#endif
</del><span class="cx">         bool disconnectedFromDocument { false };
</span><span class="cx">         bool treeScopeChanged { false };
</span><span class="cx">     };
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasCanvasStyleh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/CanvasStyle.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/CanvasStyle.h   2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/html/canvas/CanvasStyle.h      2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -70,14 +70,6 @@
</span><span class="cx">     struct Invalid { };
</span><span class="cx"> 
</span><span class="cx">     struct CMYKAColor {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-        CMYKAColor() = default;
-        CMYKAColor(Color color, float cyan, float magenta, float yellow, float black, float alpha)
-            : color(color), c(cyan), m(magenta), y(yellow), k(black), a(alpha)
-        {
-        }
-#endif
-
</del><span class="cx">         Color color;
</span><span class="cx">         float c { 0 };
</span><span class="cx">         float m { 0 };
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventHandlerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventHandler.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventHandler.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/page/EventHandler.h    2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -158,14 +158,6 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(DRAG_SUPPORT)
</span><span class="cx">     struct DragTargetResponse {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-        DragTargetResponse() = default;
-        DragTargetResponse(bool accept, std::optional<DragOperation> operation)
-            : accept(accept)
-            , operation(operation)
-        {
-        }
-#endif
</del><span class="cx">         bool accept { false };
</span><span class="cx">         std::optional<DragOperation> operation;
</span><span class="cx">     };
</span></span></pre></div>
<a id="trunkSourceWebCorepageanimationCSSAnimationControllerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/animation/CSSAnimationController.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/animation/CSSAnimationController.h     2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/page/animation/CSSAnimationController.h        2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -43,13 +43,6 @@
</span><span class="cx"> class RenderElement;
</span><span class="cx"> 
</span><span class="cx"> struct AnimationUpdate {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    AnimationUpdate() = default;
-    AnimationUpdate(std::unique_ptr<RenderStyle> style, bool stateChanged)
-        : style(WTFMove(style))
-        , stateChanged(stateChanged)
-    { }
-#endif
</del><span class="cx">     std::unique_ptr<RenderStyle> style;
</span><span class="cx">     bool stateChanged { false };
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsFontSelectionAlgorithmh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h  2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h     2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -337,17 +337,6 @@
</span><span class="cx">     {
</span><span class="cx">         return WTF::tie(weight, width, slope);
</span><span class="cx">     }
</span><del>-
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    FontSelectionRequest() = default;
-
-    constexpr FontSelectionRequest(Value weight, Value width, Value slope)
-        : weight(weight)
-        , width(width)
-        , slope(slope)
-    {
-    }
-#endif
</del><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> constexpr bool operator==(const FontSelectionRequest& a, const FontSelectionRequest& b)
</span><span class="lines">@@ -385,17 +374,6 @@
</span><span class="cx">     Range weight { normalWeightValue() };
</span><span class="cx">     Range width { normalStretchValue() };
</span><span class="cx">     Range slope { normalItalicValue() };
</span><del>-
-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    FontSelectionCapabilities() = default;
-
-    constexpr FontSelectionCapabilities(Range weight, Range width, Range slope)
-        : weight(weight)
-        , width(width)
-        , slope(slope)
-    {
-    }
-#endif
</del><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> constexpr bool operator==(const FontSelectionCapabilities& a, const FontSelectionCapabilities& b)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmediastreamIceCandidateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mediastream/IceCandidate.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mediastream/IceCandidate.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/platform/mediastream/IceCandidate.h    2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -37,23 +37,6 @@
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><span class="cx"> struct IceCandidate {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    IceCandidate() = default;
-    IceCandidate(String&& type, String&& foundation, unsigned componentId, String&& transport, unsigned long priority, String&& address, unsigned port, String&& tcpType, String&& relatedAddress, unsigned relatedPort)
-        : type { WTFMove(type) }
-        , foundation { WTFMove(foundation) }
-        , componentId { componentId }
-        , transport { WTFMove(transport) }
-        , priority { priority }
-        , address { WTFMove(address) }
-        , port { port }
-        , tcpType { WTFMove(tcpType) }
-        , relatedAddress { WTFMove(relatedAddress) }
-        , relatedPort { relatedPort }
-    {
-    }
-#endif
-
</del><span class="cx">     String type;
</span><span class="cx">     String foundation;
</span><span class="cx">     unsigned componentId { 0 };
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextStringWithDirectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/StringWithDirection.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/StringWithDirection.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/platform/text/StringWithDirection.h    2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -46,14 +46,6 @@
</span><span class="cx"> // to the string.
</span><span class="cx"> 
</span><span class="cx"> struct StringWithDirection {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    StringWithDirection() = default;
-    StringWithDirection(String string, TextDirection direction)
-        : string { WTFMove(string) }
-        , direction { direction }
-    {
-    }
-#endif
</del><span class="cx">     String string;
</span><span class="cx">     TextDirection direction { LTR };
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingMarkedTexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/MarkedText.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/MarkedText.h      2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/rendering/MarkedText.h 2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -47,16 +47,6 @@
</span><span class="cx">         Selection,
</span><span class="cx">         DraggedContent,
</span><span class="cx">     };
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    MarkedText() = default;
-    MarkedText(unsigned startOffset, unsigned endOffset, Type type, const RenderedDocumentMarker* marker = nullptr)
-        : startOffset { startOffset }
-        , endOffset { endOffset }
-        , type { type }
-        , marker { marker }
-    {
-    }
-#endif
</del><span class="cx">     unsigned startOffset;
</span><span class="cx">     unsigned endOffset;
</span><span class="cx">     Type type;
</span></span></pre></div>
<a id="trunkSourceWebCorestyleStyleUpdateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/style/StyleUpdate.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/style/StyleUpdate.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/WebCore/style/StyleUpdate.h    2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -43,15 +43,6 @@
</span><span class="cx"> namespace Style {
</span><span class="cx"> 
</span><span class="cx"> struct ElementUpdate {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    ElementUpdate() = default;
-    ElementUpdate(std::unique_ptr<RenderStyle> style, Change change, bool recompositeLayer)
-        : style { WTFMove(style) }
-        , change { change }
-        , recompositeLayer { recompositeLayer }
-    {
-    }
-#endif
</del><span class="cx">     std::unique_ptr<RenderStyle> style;
</span><span class="cx">     Change change { NoChange };
</span><span class="cx">     bool recompositeLayer { false };
</span><span class="lines">@@ -60,16 +51,6 @@
</span><span class="cx"> enum class DescendantsToResolve { None, ChildrenWithExplicitInherit, Children, All };
</span><span class="cx"> 
</span><span class="cx"> struct ElementUpdates {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    ElementUpdates() = default;
-    ElementUpdates(ElementUpdate update, DescendantsToResolve descendantsToResolve, std::optional<ElementUpdate> beforePseudoElementUpdate, std::optional<ElementUpdate> afterPseudoElementUpdate)
-        : update { WTFMove(update) }
-        , descendantsToResolve(descendantsToResolve)
-        , beforePseudoElementUpdate { WTFMove(beforePseudoElementUpdate) }
-        , afterPseudoElementUpdate { WTFMove(afterPseudoElementUpdate) }
-    {
-    }
-#endif
</del><span class="cx">     ElementUpdate update;
</span><span class="cx">     DescendantsToResolve descendantsToResolve { DescendantsToResolve::None };
</span><span class="cx">     std::optional<ElementUpdate> beforePseudoElementUpdate;
</span><span class="lines">@@ -77,16 +58,6 @@
</span><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> struct TextUpdate {
</span><del>-#if !COMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    TextUpdate() = default;
-    TextUpdate(unsigned offset, unsigned length, std::optional<std::unique_ptr<RenderStyle>> inheritedDisplayContentsStyle)
-        : offset { offset }
-        , length { length }
-        , inheritedDisplayContentsStyle { WTFMove(inheritedDisplayContentsStyle) }
-    {
-    }
-#endif
-
</del><span class="cx">     unsigned offset { 0 };
</span><span class="cx">     unsigned length { std::numeric_limits<unsigned>::max() };
</span><span class="cx">     std::optional<std::unique_ptr<RenderStyle>> inheritedDisplayContentsStyle;
</span></span></pre></div>
<a id="trunkSourcebmallocChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/ChangeLog (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/ChangeLog   2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/bmalloc/ChangeLog      2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2018-04-20  Daniel Bates  <dabates@apple.com>
+
+        Remove code for compilers that did not support NSDMI for aggregates
+        https://bugs.webkit.org/show_bug.cgi?id=184599
+
+        Reviewed by Per Arne Vollan.
+
+        Remove workaround for earlier Visual Studio versions that did not support non-static data
+        member initializers (NSDMI) for aggregates. We have since updated all the build.webkit.org
+        and EWS bots to a newer version that supports this feature.
+
+        * bmalloc/BPlatform.h:
+        * bmalloc/List.h:
+        (bmalloc::ListNode::ListNode): Deleted.
+        (bmalloc::List::iterator::iterator): Deleted.
+
</ins><span class="cx"> 2018-04-19  David Kilzer  <ddkilzer@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Enable Objective-C weak references
</span></span></pre></div>
<a id="trunkSourcebmallocbmallocBPlatformh"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/bmalloc/BPlatform.h 2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/bmalloc/bmalloc/BPlatform.h    2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -81,11 +81,6 @@
</span><span class="cx"> /* BCOMPILER_SUPPORTS() - check for a compiler feature */
</span><span class="cx"> #define BCOMPILER_SUPPORTS(FEATURE) (defined BCOMPILER_SUPPORTS_##FEATURE && BCOMPILER_SUPPORTS_##FEATURE)
</span><span class="cx"> 
</span><del>-/* BCOMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES) - compiler supports non-static data member initializers for aggregates */
-#if defined(__cpp_aggregate_nsdmi) && __cpp_aggregate_nsdmi >= 201304
-#define BCOMPILER_SUPPORTS_NSDMI_FOR_AGGREGATES 1
-#endif
-
</del><span class="cx"> /* ==== Platform adaptation macros: these describe properties of the target environment. ==== */
</span><span class="cx"> 
</span><span class="cx"> /* BCPU() - the target CPU architecture */
</span></span></pre></div>
<a id="trunkSourcebmallocbmallocListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/bmalloc/bmalloc/List.h (230855 => 230856)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/bmalloc/bmalloc/List.h      2018-04-20 21:02:55 UTC (rev 230855)
+++ trunk/Source/bmalloc/bmalloc/List.h 2018-04-20 21:10:56 UTC (rev 230856)
</span><span class="lines">@@ -30,15 +30,6 @@
</span><span class="cx"> 
</span><span class="cx"> template<typename T>
</span><span class="cx"> struct ListNode {
</span><del>-#if !BCOMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-    ListNode() = default;
-    ListNode(ListNode<T>* prev, ListNode<T>* next)
-        : prev { prev }
-        , next { next }
-    {
-    }
-#endif
-
</del><span class="cx">     ListNode<T>* prev { nullptr };
</span><span class="cx">     ListNode<T>* next { nullptr };
</span><span class="cx"> };
</span><span class="lines">@@ -48,14 +39,6 @@
</span><span class="cx">     static_assert(std::is_trivially_destructible<T>::value, "List must have a trivial destructor.");
</span><span class="cx"> 
</span><span class="cx">     struct iterator {
</span><del>-#if !BCOMPILER_SUPPORTS(NSDMI_FOR_AGGREGATES)
-        iterator() = default;
-        iterator(ListNode<T>* node)
-            : m_node(node)
-        {
-        }
-#endif
-
</del><span class="cx">         T* operator*() { return static_cast<T*>(m_node); }
</span><span class="cx">         T* operator->() { return static_cast<T*>(m_node); }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>