<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[230742] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/230742">230742</a></dd>
<dt>Author</dt> <dd>jbedard@apple.com</dd>
<dt>Date</dt> <dd>2018-04-17 17:42:32 -0700 (Tue, 17 Apr 2018)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fix hasher tests for system with 32 bit longs
https://bugs.webkit.org/show_bug.cgi?id=184708
<rdar://problem/39459977>

Reviewed by Mark Lam.

Some systems have 32 bit longs. The Hasher WTF tests should handle this case.

* TestWebKitAPI/Tests/WTF/Hasher.cpp:
(TestWebKitAPI::TEST):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFHashercpp">trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (230741 => 230742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog    2018-04-18 00:05:07 UTC (rev 230741)
+++ trunk/Tools/ChangeLog       2018-04-18 00:42:32 UTC (rev 230742)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2018-04-17  Jonathan Bedard  <jbedard@apple.com>
+
+        Fix hasher tests for system with 32 bit longs
+        https://bugs.webkit.org/show_bug.cgi?id=184708
+        <rdar://problem/39459977>
+
+        Reviewed by Mark Lam.
+
+        Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
+
+        * TestWebKitAPI/Tests/WTF/Hasher.cpp:
+        (TestWebKitAPI::TEST):
+
</ins><span class="cx"> 2018-04-17  Commit Queue  <commit-queue@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Unreviewed, rolling out r230697, r230720, and r230724.
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFHashercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp (230741 => 230742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp   2018-04-18 00:05:07 UTC (rev 230741)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Hasher.cpp      2018-04-18 00:42:32 UTC (rev 230742)
</span><span class="lines">@@ -56,8 +56,8 @@
</span><span class="cx">     EXPECT_EQ(zero32BitHash, computeHash(0));
</span><span class="cx"> 
</span><span class="cx">     EXPECT_EQ(zero64BitHash, computeHash(0ULL));
</span><del>-    EXPECT_EQ(zero64BitHash, computeHash(0L));
-    EXPECT_EQ(zero64BitHash, computeHash(0UL));
</del><ins>+    EXPECT_EQ(sizeof(long) == sizeof(int32_t) ? zero32BitHash : zero64BitHash, computeHash(0L));
+    EXPECT_EQ(sizeof(unsigned long) == sizeof(uint32_t) ? zero32BitHash : zero64BitHash, computeHash(0UL));
</ins><span class="cx">     EXPECT_EQ(zero64BitHash, computeHash(0LL));
</span><span class="cx"> 
</span><span class="cx">     EXPECT_EQ(one32BitHash, computeHash(1U));
</span><span class="lines">@@ -70,8 +70,8 @@
</span><span class="cx">     EXPECT_EQ(one32BitHash, computeHash(1));
</span><span class="cx"> 
</span><span class="cx">     EXPECT_EQ(one64BitHash, computeHash(1ULL));
</span><del>-    EXPECT_EQ(one64BitHash, computeHash(1L));
-    EXPECT_EQ(one64BitHash, computeHash(1UL));
</del><ins>+    EXPECT_EQ(sizeof(long) == sizeof(int32_t) ? one32BitHash : one64BitHash, computeHash(1L));
+    EXPECT_EQ(sizeof(unsigned long) == sizeof(uint32_t) ? one32BitHash : one64BitHash, computeHash(1UL));
</ins><span class="cx">     EXPECT_EQ(one64BitHash, computeHash(1LL));
</span><span class="cx"> 
</span><span class="cx">     EXPECT_EQ(1772381661U, computeHash(0x7FU));
</span><span class="lines">@@ -107,16 +107,16 @@
</span><span class="cx"> 
</span><span class="cx">     EXPECT_EQ(1264532604U, computeHash(0x8000000000000000ULL));
</span><span class="cx">     EXPECT_EQ(1264532604U, computeHash(std::numeric_limits<int64_t>::min()));
</span><del>-    EXPECT_EQ(1264532604U, computeHash(std::numeric_limits<long>::min()));
</del><ins>+    EXPECT_EQ(sizeof(long) == sizeof(int32_t) ? 2425683428U : 1264532604U, computeHash(std::numeric_limits<long>::min()));
</ins><span class="cx"> 
</span><span class="cx">     EXPECT_EQ(2961049834U, computeHash(0x7FFFFFFFFFFFFFFFULL));
</span><span class="cx">     EXPECT_EQ(2961049834U, computeHash(std::numeric_limits<int64_t>::max()));
</span><del>-    EXPECT_EQ(2961049834U, computeHash(std::numeric_limits<long>::max()));
</del><ins>+    EXPECT_EQ(sizeof(long) == sizeof(int32_t) ? 3430670328U : 2961049834U, computeHash(std::numeric_limits<long>::max()));
</ins><span class="cx"> 
</span><span class="cx">     EXPECT_EQ(1106332091U, computeHash(0xFFFFFFFFFFFFFFFFULL));
</span><span class="cx">     EXPECT_EQ(1106332091U, computeHash(std::numeric_limits<uint64_t>::max()));
</span><del>-    EXPECT_EQ(1106332091U, computeHash(std::numeric_limits<unsigned long>::max()));
-    EXPECT_EQ(1106332091U, computeHash(-1L));
</del><ins>+    EXPECT_EQ(sizeof(long) == sizeof(int32_t) ? 1955511435U : 1106332091U, computeHash(std::numeric_limits<unsigned long>::max()));
+    EXPECT_EQ(sizeof(long) == sizeof(int32_t) ? 1955511435U : 1106332091U, computeHash(-1L));
</ins><span class="cx">     EXPECT_EQ(1106332091U, computeHash(-1LL));
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>