<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[225895] trunk/Source/WebInspectorUI</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/225895">225895</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2017-12-13 23:45:29 -0800 (Wed, 13 Dec 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: Network Tab - Make text filter just a URL filter and update incrementally
https://bugs.webkit.org/show_bug.cgi?id=180796

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-12-13
Reviewed by Brian Burg.

Revert the Network Tab's text filter back to being just a URL filter with the
normal behaviors of our other text filters that update as you type (incremental).
This also renames the "text filter" to "url filter" everywhere in the ContentView
for clarity. A follow-up change will make the url filter be case-insensitive
to fully match the filter bars in other tabs.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get filterNavigationItems):
(WI.NetworkTableContentView.prototype._checkURLFilterAgainstFinishedResource):
(WI.NetworkTableContentView.prototype._updateURLFilterActiveIndicator):
(WI.NetworkTableContentView.prototype._resourceLoadingDidFinish):
(WI.NetworkTableContentView.prototype._resourceLoadingDidFail):
(WI.NetworkTableContentView.prototype._hasURLFilter):
(WI.NetworkTableContentView.prototype._hasActiveFilter):
(WI.NetworkTableContentView.prototype._passURLFilter):
(WI.NetworkTableContentView.prototype._passFilter):
(WI.NetworkTableContentView.prototype._updateFilteredEntries):
(WI.NetworkTableContentView.prototype._resetFilters):
(WI.NetworkTableContentView.prototype._urlFilterDidChange):
(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFinishedResource): Deleted.
(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFailedResource): Deleted.
(WI.NetworkTableContentView.prototype._updateTextFilterActiveIndicator): Deleted.
(WI.NetworkTableContentView.prototype._hasTextFilter): Deleted.
(WI.NetworkTableContentView.prototype._passTextFilter): Deleted.
(WI.NetworkTableContentView.prototype._textFilterDidChange): Deleted.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNetworkTableContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (225894 => 225895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog    2017-12-14 07:00:57 UTC (rev 225894)
+++ trunk/Source/WebInspectorUI/ChangeLog       2017-12-14 07:45:29 UTC (rev 225895)
</span><span class="lines">@@ -1,5 +1,40 @@
</span><span class="cx"> 2017-12-13  Joseph Pecoraro  <pecoraro@apple.com>
</span><span class="cx"> 
</span><ins>+        Web Inspector: Network Tab - Make text filter just a URL filter and update incrementally
+        https://bugs.webkit.org/show_bug.cgi?id=180796
+
+        Reviewed by Brian Burg.
+
+        Revert the Network Tab's text filter back to being just a URL filter with the
+        normal behaviors of our other text filters that update as you type (incremental).
+        This also renames the "text filter" to "url filter" everywhere in the ContentView
+        for clarity. A follow-up change will make the url filter be case-insensitive
+        to fully match the filter bars in other tabs.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/NetworkTableContentView.js:
+        (WI.NetworkTableContentView):
+        (WI.NetworkTableContentView.prototype.get filterNavigationItems):
+        (WI.NetworkTableContentView.prototype._checkURLFilterAgainstFinishedResource):
+        (WI.NetworkTableContentView.prototype._updateURLFilterActiveIndicator):
+        (WI.NetworkTableContentView.prototype._resourceLoadingDidFinish):
+        (WI.NetworkTableContentView.prototype._resourceLoadingDidFail):
+        (WI.NetworkTableContentView.prototype._hasURLFilter):
+        (WI.NetworkTableContentView.prototype._hasActiveFilter):
+        (WI.NetworkTableContentView.prototype._passURLFilter):
+        (WI.NetworkTableContentView.prototype._passFilter):
+        (WI.NetworkTableContentView.prototype._updateFilteredEntries):
+        (WI.NetworkTableContentView.prototype._resetFilters):
+        (WI.NetworkTableContentView.prototype._urlFilterDidChange):
+        (WI.NetworkTableContentView.prototype._checkTextFilterAgainstFinishedResource): Deleted.
+        (WI.NetworkTableContentView.prototype._checkTextFilterAgainstFailedResource): Deleted.
+        (WI.NetworkTableContentView.prototype._updateTextFilterActiveIndicator): Deleted.
+        (WI.NetworkTableContentView.prototype._hasTextFilter): Deleted.
+        (WI.NetworkTableContentView.prototype._passTextFilter): Deleted.
+        (WI.NetworkTableContentView.prototype._textFilterDidChange): Deleted.
+
+2017-12-13  Joseph Pecoraro  <pecoraro@apple.com>
+
</ins><span class="cx">         REGRESSION: Web Inspector: Opening inspector crashes page if there are empty resources
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=180787
</span><span class="cx">         <rdar://problem/35934838>
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (225894 => 225895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js   2017-12-14 07:00:57 UTC (rev 225894)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js      2017-12-14 07:45:29 UTC (rev 225895)
</span><span class="lines">@@ -414,7 +414,7 @@
</span><span class="cx"> localizedStrings["Fill"] = "Fill";
</span><span class="cx"> localizedStrings["Fill Mode"] = "Fill Mode";
</span><span class="cx"> localizedStrings["Filter"] = "Filter";
</span><del>-localizedStrings["Filter Full URL and Text"] = "Filter Full URL and Text";
</del><ins>+localizedStrings["Filter Full URL"] = "Filter Full URL";
</ins><span class="cx"> localizedStrings["Flexbox"] = "Flexbox";
</span><span class="cx"> localizedStrings["Float"] = "Float";
</span><span class="cx"> localizedStrings["Float and Clear"] = "Float and Clear";
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNetworkTableContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (225894 => 225895)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js       2017-12-14 07:00:57 UTC (rev 225894)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js  2017-12-14 07:45:29 UTC (rev 225895)
</span><span class="lines">@@ -82,17 +82,15 @@
</span><span class="cx">         this._typeFilterScopeBar = new WI.ScopeBar("network-type-filter-scope-bar", typeFilterScopeBarItems, typeFilterScopeBarItems[0]);
</span><span class="cx">         this._typeFilterScopeBar.addEventListener(WI.ScopeBar.Event.SelectionChanged, this._typeFilterScopeBarSelectionChanged, this);
</span><span class="cx"> 
</span><del>-        this._textFilterSearchId = 0;
-        this._textFilterSearchText = null;
-        this._textFilterIsActive = false;
</del><ins>+        this._urlFilterSearchText = null;
+        this._urlFilterIsActive = false;
</ins><span class="cx"> 
</span><del>-        this._textFilterNavigationItem = new WI.FilterBarNavigationItem;
-        this._textFilterNavigationItem.filterBar.incremental = false;
-        this._textFilterNavigationItem.filterBar.addEventListener(WI.FilterBar.Event.FilterDidChange, this._textFilterDidChange, this);
-        this._textFilterNavigationItem.filterBar.placeholder = WI.UIString("Filter Full URL and Text");
</del><ins>+        this._urlFilterNavigationItem = new WI.FilterBarNavigationItem;
+        this._urlFilterNavigationItem.filterBar.addEventListener(WI.FilterBar.Event.FilterDidChange, this._urlFilterDidChange, this);
+        this._urlFilterNavigationItem.filterBar.placeholder = WI.UIString("Filter Full URL");
</ins><span class="cx"> 
</span><span class="cx">         this._activeTypeFilters = this._generateTypeFilter();
</span><del>-        this._activeTextFilterResources = new Set;
</del><ins>+        this._activeURLFilterResources = new Set;
</ins><span class="cx"> 
</span><span class="cx">         this._emptyFilterResultsMessageElement = null;
</span><span class="cx"> 
</span><span class="lines">@@ -201,11 +199,7 @@
</span><span class="cx"> 
</span><span class="cx">     get filterNavigationItems()
</span><span class="cx">     {
</span><del>-        let items = [];
-        if (window.PageAgent)
-            items.push(this._textFilterNavigationItem);
-        items.push(this._typeFilterScopeBar);
-        return items;
</del><ins>+        return [this._urlFilterNavigationItem, this._typeFilterScopeBar];
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     get supportsSave()
</span><span class="lines">@@ -910,41 +904,11 @@
</span><span class="cx">         this.needsLayout();
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    _checkTextFilterAgainstFinishedResource(resource)
</del><ins>+    _checkURLFilterAgainstFinishedResource(resource)
</ins><span class="cx">     {
</span><del>-        let frame = resource.parentFrame;
-        if (!frame)
-            return;
-
-        let searchQuery = this._textFilterSearchText;
-        if (resource.url.includes(searchQuery)) {
-            this._activeTextFilterResources.add(resource);
-            return;
-        }
-
-        let searchId = this._textFilterSearchId;
-
-        const isCaseSensitive = true;
-        const isRegex = false;
-        PageAgent.searchInResource(frame.id, resource.url, searchQuery, isCaseSensitive, isRegex, resource.requestIdentifier, (error, searchResults) => {
-            if (searchId !== this._textFilterSearchId)
-                return;
-
-            if (error || !searchResults || !searchResults.length)
-                return;
-
-            this._activeTextFilterResources.add(resource);
-
-            this._pendingFilter = true;
-            this.needsLayout();
-        });
-    }
-
-    _checkTextFilterAgainstFailedResource(resource)
-    {
-        let searchQuery = this._textFilterSearchText;
</del><ins>+        let searchQuery = this._urlFilterSearchText;
</ins><span class="cx">         if (resource.url.includes(searchQuery))
</span><del>-            this._activeTextFilterResources.add(resource);
</del><ins>+            this._activeURLFilterResources.add(resource);
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     _rowIndexForResource(resource)
</span><span class="lines">@@ -1026,9 +990,9 @@
</span><span class="cx">         this._table.scrollContainer.style.width = this._nameColumn.width + "px";
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    _updateTextFilterActiveIndicator()
</del><ins>+    _updateURLFilterActiveIndicator()
</ins><span class="cx">     {
</span><del>-        this._textFilterNavigationItem.filterBar.indicatingActive = this._hasTextFilter();
</del><ins>+        this._urlFilterNavigationItem.filterBar.indicatingActive = this._hasURLFilter();
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     _updateEmptyFilterResultsMessage()
</span><span class="lines">@@ -1112,8 +1076,8 @@
</span><span class="cx">         if (resource.timingData.responseEnd > this._waterfallEndTime)
</span><span class="cx">             this._waterfallEndTime = resource.timingData.responseEnd;
</span><span class="cx"> 
</span><del>-        if (this._hasTextFilter())
-            this._checkTextFilterAgainstFinishedResource(resource);
</del><ins>+        if (this._hasURLFilter())
+            this._checkURLFilterAgainstFinishedResource(resource);
</ins><span class="cx"> 
</span><span class="cx">         this.needsLayout();
</span><span class="cx">     }
</span><span class="lines">@@ -1128,8 +1092,8 @@
</span><span class="cx">         if (resource.timingData.responseEnd > this._waterfallEndTime)
</span><span class="cx">             this._waterfallEndTime = resource.timingData.responseEnd;
</span><span class="cx"> 
</span><del>-        if (this._hasTextFilter())
-            this._checkTextFilterAgainstFailedResource(resource);
</del><ins>+        if (this._hasURLFilter())
+            this._checkURLFilterAgainstFinishedResource(resource);
</ins><span class="cx"> 
</span><span class="cx">         this.needsLayout();
</span><span class="cx">     }
</span><span class="lines">@@ -1245,15 +1209,15 @@
</span><span class="cx">         return !!this._activeTypeFilters;
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    _hasTextFilter()
</del><ins>+    _hasURLFilter()
</ins><span class="cx">     {
</span><del>-        return this._textFilterIsActive;
</del><ins>+        return this._urlFilterIsActive;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     _hasActiveFilter()
</span><span class="cx">     {
</span><span class="cx">         return this._hasTypeFilter()
</span><del>-            || this._hasTextFilter();
</del><ins>+            || this._hasURLFilter();
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     _passTypeFilter(entry)
</span><span class="lines">@@ -1263,17 +1227,17 @@
</span><span class="cx">         return this._activeTypeFilters.some((checker) => checker(entry.resource.type));
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    _passTextFilter(entry)
</del><ins>+    _passURLFilter(entry)
</ins><span class="cx">     {
</span><del>-        if (!this._hasTextFilter())
</del><ins>+        if (!this._hasURLFilter())
</ins><span class="cx">             return true;
</span><del>-        return this._activeTextFilterResources.has(entry.resource);
</del><ins>+        return this._activeURLFilterResources.has(entry.resource);
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     _passFilter(entry)
</span><span class="cx">     {
</span><span class="cx">         return this._passTypeFilter(entry)
</span><del>-            && this._passTextFilter(entry);
</del><ins>+            && this._passURLFilter(entry);
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     _updateSortAndFilteredEntries()
</span><span class="lines">@@ -1291,7 +1255,7 @@
</span><span class="cx"> 
</span><span class="cx">         this._restoreSelectedRow();
</span><span class="cx"> 
</span><del>-        this._updateTextFilterActiveIndicator();
</del><ins>+        this._updateURLFilterActiveIndicator();
</ins><span class="cx">         this._updateEmptyFilterResultsMessage();
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="lines">@@ -1308,14 +1272,12 @@
</span><span class="cx">     {
</span><span class="cx">         console.assert(this._hasActiveFilter());
</span><span class="cx"> 
</span><del>-        // Clear text filter.
-        this._textFilterSearchId++;
-        this._textFilterNavigationItem.filterBar.indicatingProgress = false;
-        this._textFilterSearchText = null;
-        this._textFilterIsActive = false;
-        this._activeTextFilterResources.clear();
-        this._textFilterNavigationItem.filterBar.clear();
-        console.assert(!this._hasTextFilter());
</del><ins>+        // Clear url filter.
+        this._urlFilterSearchText = null;
+        this._urlFilterIsActive = false;
+        this._activeURLFilterResources.clear();
+        this._urlFilterNavigationItem.filterBar.clear();
+        console.assert(!this._hasURLFilter());
</ins><span class="cx"> 
</span><span class="cx">         // Clear type filter.
</span><span class="cx">         this._typeFilterScopeBar.resetToDefault();
</span><span class="lines">@@ -1361,23 +1323,20 @@
</span><span class="cx">         this._table.reloadData();
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    _textFilterDidChange(event)
</del><ins>+    _urlFilterDidChange(event)
</ins><span class="cx">     {
</span><del>-        let searchQuery = this._textFilterNavigationItem.filterBar.filters.text;
-        if (searchQuery === this._textFilterSearchText)
</del><ins>+        let searchQuery = this._urlFilterNavigationItem.filterBar.filters.text;
+        if (searchQuery === this._urlFilterSearchText)
</ins><span class="cx">             return;
</span><span class="cx"> 
</span><span class="cx">         // Even if the selected resource would still be visible, lets close the detail view if a filter changes.
</span><span class="cx">         this._hideResourceDetailView();
</span><span class="cx"> 
</span><del>-        let searchId = ++this._textFilterSearchId;
-
</del><span class="cx">         // Search cleared.
</span><span class="cx">         if (!searchQuery) {
</span><del>-            this._textFilterNavigationItem.filterBar.indicatingProgress = false;
-            this._textFilterSearchText = null;
-            this._textFilterIsActive = false;
-            this._activeTextFilterResources.clear();
</del><ins>+            this._urlFilterSearchText = null;
+            this._urlFilterIsActive = false;
+            this._activeURLFilterResources.clear();
</ins><span class="cx"> 
</span><span class="cx">             this._updateFilteredEntries();
</span><span class="cx">             this._table.reloadData();
</span><span class="lines">@@ -1384,64 +1343,18 @@
</span><span class="cx">             return;
</span><span class="cx">         }
</span><span class="cx"> 
</span><del>-        this._textFilterSearchText = searchQuery;
-        this._textFilterNavigationItem.filterBar.indicatingProgress = true;
</del><ins>+        this._urlFilterIsActive = true;
+        this._urlFilterSearchText = searchQuery;
+        this._activeURLFilterResources.clear();
</ins><span class="cx"> 
</span><del>-        // NetworkTable text filter currently searches:
-        //   - Resource URL
-        //   - Resource Text Content
-        // It does not search all the content in the table (like mimeType, headers, etc).
-        // For those we should provide more custom filters.
</del><ins>+        for (let entry of this._entries) {
+            let resource = entry.resource;
+            if (resource.url.includes(searchQuery))
+                this._activeURLFilterResources.add(resource);
+        }
</ins><span class="cx"> 
</span><del>-        const isCaseSensitive = true;
-        const isRegex = false;
-        PageAgent.searchInResources(searchQuery, isCaseSensitive, isRegex, (error, searchResults) => {
-            if (searchId !== this._textFilterSearchId)
-                return;
-
-            this._textFilterIsActive = true;
-            this._activeTextFilterResources.clear();
-            this._textFilterNavigationItem.filterBar.indicatingProgress = false;
-
-            // Add resources based on URL.
-            for (let entry of this._entries) {
-                let resource = entry.resource;
-                if (resource.url.includes(searchQuery))
-                    this._activeTextFilterResources.add(resource);
-            }
-
-            // Add resources based on content.
-            if (!error) {
-                for (let {url, frameId, requestId} of searchResults) {
-                    if (requestId) {
-                        let resource = WI.frameResourceManager.resourceForRequestIdentifier(requestId);
-                        if (resource) {
-                            this._activeTextFilterResources.add(resource);
-                            continue;
-                        }
-                    }
-
-                    if (frameId && url) {
-                        let frame = WI.frameResourceManager.frameForIdentifier(frameId);
-                        if (frame) {
-                            if (frame.mainResource.url === url) {
-                                this._activeTextFilterResources.add(frame.mainResource);
-                                continue;
-                            }
-                            let resource = frame.resourceForURL(url);
-                            if (resource) {
-                                this._activeTextFilterResources.add(resource);
-                                continue;
-                            }
-                        }
-                    }
-                }
-            }
-
-            // Apply.
-            this._updateFilteredEntries();
-            this._table.reloadData();
-        });
</del><ins>+        this._updateFilteredEntries();
+        this._table.reloadData();
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     _restoreSelectedRow()
</span></span></pre>
</div>
</div>

</body>
</html>