<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[225718] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/225718">225718</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2017-12-08 19:44:33 -0800 (Fri, 08 Dec 2017)</dd>
</dl>

<h3>Log Message</h3>
<pre>ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL
https://bugs.webkit.org/show_bug.cgi?id=180615

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

* web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
* web-platform-tests/workers/interfaces.worker-expected.txt:

Source/WebCore:

ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL, similarly to what we do for Window.
This allows a getter to be fallback to the global object as ThisValue when the cast of the ThisValue to the expected type fails.

No new tests, rebaselined existing test.

* workers/DedicatedWorkerGlobalScope.idl:
* workers/WorkerGlobalScope.idl:
* workers/service/ServiceWorkerGlobalScope.idl:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsimportedw3cChangeLog">trunk/LayoutTests/imported/w3c/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsserviceworkersserviceworkerinterfacesswhttpsexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt</a></li>
<li><a href="#trunkLayoutTestsimportedw3cwebplatformtestsworkersinterfacesworkerexpectedtxt">trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreworkersDedicatedWorkerGlobalScopeidl">trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerGlobalScopeidl">trunk/Source/WebCore/workers/WorkerGlobalScope.idl</a></li>
<li><a href="#trunkSourceWebCoreworkersserviceServiceWorkerGlobalScopeidl">trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsimportedw3cChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/ChangeLog (225717 => 225718)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-09 03:03:06 UTC (rev 225717)
+++ trunk/LayoutTests/imported/w3c/ChangeLog    2017-12-09 03:44:33 UTC (rev 225718)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2017-12-08  Chris Dumez  <cdumez@apple.com>
+
+        ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL
+        https://bugs.webkit.org/show_bug.cgi?id=180615
+
+        Reviewed by Brady Eidson.
+
+        Rebaseline WPT tests now that more checks are passing.
+
+        * web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
+        * web-platform-tests/workers/interfaces.worker-expected.txt:
+
</ins><span class="cx"> 2017-12-08  Youenn Fablet  <youenn@apple.com>
</span><span class="cx"> 
</span><span class="cx">         FetchResponse should keep unfiltered ResourceResponse so that it can be used in Service Worker
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsserviceworkersserviceworkerinterfacesswhttpsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt (225717 => 225718)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt        2017-12-09 03:03:06 UTC (rev 225717)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt   2017-12-09 03:44:33 UTC (rev 225718)
</span><span class="lines">@@ -14,14 +14,14 @@
</span><span class="cx"> PASS ServiceWorkerGlobalScope interface: internal [[SetPrototypeOf]] method of interface prototype object - setting to its original value via __proto__ should not throw 
</span><span class="cx"> PASS ServiceWorkerGlobalScope interface: internal [[SetPrototypeOf]] method of interface prototype object - setting to its original value via Reflect.setPrototypeOf should return true 
</span><span class="cx"> PASS ServiceWorkerGlobalScope interface: existence and properties of interface prototype object's "constructor" property 
</span><del>-FAIL ServiceWorkerGlobalScope interface: attribute clients The ServiceWorkerGlobalScope.clients getter can only be used on instances of ServiceWorkerGlobalScope
-FAIL ServiceWorkerGlobalScope interface: attribute registration The ServiceWorkerGlobalScope.registration getter can only be used on instances of ServiceWorkerGlobalScope
</del><ins>+PASS ServiceWorkerGlobalScope interface: attribute clients 
+PASS ServiceWorkerGlobalScope interface: attribute registration 
</ins><span class="cx"> PASS ServiceWorkerGlobalScope interface: operation skipWaiting() 
</span><del>-FAIL ServiceWorkerGlobalScope interface: attribute oninstall The ServiceWorkerGlobalScope.oninstall getter can only be used on instances of ServiceWorkerGlobalScope
-FAIL ServiceWorkerGlobalScope interface: attribute onactivate The ServiceWorkerGlobalScope.onactivate getter can only be used on instances of ServiceWorkerGlobalScope
-FAIL ServiceWorkerGlobalScope interface: attribute onfetch The ServiceWorkerGlobalScope.onfetch getter can only be used on instances of ServiceWorkerGlobalScope
-FAIL ServiceWorkerGlobalScope interface: attribute onmessage The ServiceWorkerGlobalScope.onmessage getter can only be used on instances of ServiceWorkerGlobalScope
-FAIL ServiceWorkerGlobalScope interface: attribute onmessageerror The ServiceWorkerGlobalScope.onmessageerror getter can only be used on instances of ServiceWorkerGlobalScope
</del><ins>+PASS ServiceWorkerGlobalScope interface: attribute oninstall 
+PASS ServiceWorkerGlobalScope interface: attribute onactivate 
+PASS ServiceWorkerGlobalScope interface: attribute onfetch 
+PASS ServiceWorkerGlobalScope interface: attribute onmessage 
+PASS ServiceWorkerGlobalScope interface: attribute onmessageerror 
</ins><span class="cx"> PASS ServiceWorkerGlobalScope interface: internal [[SetPrototypeOf]] method of global platform object - setting to a new value via Object.setPrototypeOf should throw a TypeError 
</span><span class="cx"> PASS ServiceWorkerGlobalScope interface: internal [[SetPrototypeOf]] method of global platform object - setting to a new value via __proto__ should throw a TypeError 
</span><span class="cx"> PASS ServiceWorkerGlobalScope interface: internal [[SetPrototypeOf]] method of global platform object - setting to a new value via Reflect.setPrototypeOf should return false 
</span></span></pre></div>
<a id="trunkLayoutTestsimportedw3cwebplatformtestsworkersinterfacesworkerexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker-expected.txt (225717 => 225718)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker-expected.txt 2017-12-09 03:03:06 UTC (rev 225717)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces.worker-expected.txt    2017-12-09 03:44:33 UTC (rev 225718)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx"> FAIL DedicatedWorkerGlobalScope interface: attribute name assert_own_property: The global object must have a property "name" expected property "name" missing
</span><span class="cx"> PASS DedicatedWorkerGlobalScope interface: operation postMessage(any, [object Object]) 
</span><span class="cx"> FAIL DedicatedWorkerGlobalScope interface: operation close() assert_own_property: global object missing non-static operation expected property "close" missing
</span><del>-FAIL DedicatedWorkerGlobalScope interface: attribute onmessage The DedicatedWorkerGlobalScope.onmessage getter can only be used on instances of DedicatedWorkerGlobalScope
</del><ins>+PASS DedicatedWorkerGlobalScope interface: attribute onmessage 
</ins><span class="cx"> FAIL DedicatedWorkerGlobalScope interface: attribute onmessageerror assert_own_property: The global object must have a property "onmessageerror" expected property "onmessageerror" missing
</span><span class="cx"> PASS DedicatedWorkerGlobalScope interface: internal [[SetPrototypeOf]] method of global platform object - setting to a new value via Object.setPrototypeOf should throw a TypeError 
</span><span class="cx"> PASS DedicatedWorkerGlobalScope interface: internal [[SetPrototypeOf]] method of global platform object - setting to a new value via __proto__ should throw a TypeError 
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (225717 => 225718)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2017-12-09 03:03:06 UTC (rev 225717)
+++ trunk/Source/WebCore/ChangeLog      2017-12-09 03:44:33 UTC (rev 225718)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2017-12-08  Chris Dumez  <cdumez@apple.com>
+
+        ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL
+        https://bugs.webkit.org/show_bug.cgi?id=180615
+
+        Reviewed by Brady Eidson.
+
+        ServiceWorkerGlobalScope is a global object and should be marked as [ImplicitThis] in the IDL, similarly to what we do for Window.
+        This allows a getter to be fallback to the global object as ThisValue when the cast of the ThisValue to the expected type fails.
+
+        No new tests, rebaselined existing test.
+
+        * workers/DedicatedWorkerGlobalScope.idl:
+        * workers/WorkerGlobalScope.idl:
+        * workers/service/ServiceWorkerGlobalScope.idl:
+
</ins><span class="cx"> 2017-12-08  Brady Eidson  <beidson@apple.com>
</span><span class="cx"> 
</span><span class="cx">         Delay some service worker operations until after the database import completes.
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersDedicatedWorkerGlobalScopeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl (225717 => 225718)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl      2017-12-09 03:03:06 UTC (rev 225717)
+++ trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl 2017-12-09 03:44:33 UTC (rev 225718)
</span><span class="lines">@@ -33,6 +33,7 @@
</span><span class="cx">     Exposed=DedicatedWorker,
</span><span class="cx">     Global=(Worker,DedicatedWorker),
</span><span class="cx">     JSGenerateToNativeObject,
</span><ins>+    ImplicitThis,
</ins><span class="cx">     IsImmutablePrototypeExoticObject,
</span><span class="cx">     IsImmutablePrototypeExoticObjectOnPrototype,
</span><span class="cx"> ] interface DedicatedWorkerGlobalScope : WorkerGlobalScope {
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerGlobalScopeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerGlobalScope.idl (225717 => 225718)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerGlobalScope.idl       2017-12-09 03:03:06 UTC (rev 225717)
+++ trunk/Source/WebCore/workers/WorkerGlobalScope.idl  2017-12-09 03:44:33 UTC (rev 225718)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx">     Exposed=Worker,
</span><span class="cx">     JSCustomMarkFunction,
</span><span class="cx">     JSLegacyParent=JSWorkerGlobalScopeBase,
</span><ins>+    ImplicitThis,
</ins><span class="cx">     IsImmutablePrototypeExoticObject,
</span><span class="cx">     IsImmutablePrototypeExoticObjectOnPrototype,
</span><span class="cx"> ] interface WorkerGlobalScope : EventTarget {
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersserviceServiceWorkerGlobalScopeidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl (225717 => 225718)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl        2017-12-09 03:03:06 UTC (rev 225717)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl   2017-12-09 03:44:33 UTC (rev 225718)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx">     Exposed=ServiceWorker,
</span><span class="cx">     Conditional=SERVICE_WORKER,
</span><span class="cx">     EnabledAtRuntime=ServiceWorker,
</span><ins>+    ImplicitThis,
</ins><span class="cx">     JSCustomMarkFunction,
</span><span class="cx">     IsImmutablePrototypeExoticObject,
</span><span class="cx">     IsImmutablePrototypeExoticObjectOnPrototype,
</span></span></pre>
</div>
</div>

</body>
</html>